[issue36521] Consider removing docstrings from co_consts in code objects

Serhiy Storchaka added the comment: If we are going to move docstring out of co_consts, I would make it a code object attribute rather than argument of MAKE_FUNCTION. It saves time on function creation. Most functions do not change docstring after creation. It is the same as code

[issue36521] Consider removing docstrings from co_consts in code objects

Inada Naoki added the comment: > If docstring is not in co_consts, all co_consts are empty tuple. The empty > tuple is nearly zero-cost because its a singleton. My wrong. Two setters will have `(None,)` tuple. But such tuple can be merged at compile time for now. And "common const" [1]

[issue36521] Consider removing docstrings from co_consts in code objects

Inada Naoki added the comment: > Why all the hating on docstrings? What have docstrings done wrong? Oh, I don't hate docstrings. I just want to move it from code object to function object. Remove docstring during unmarshal is your idea, not mine. My main motivation is reducing code size.

[issue36521] Consider removing docstrings from co_consts in code objects

Guido van Rossum added the comment: Why all the hating on docstrings? What have docstrings done wrong? I know there's the -OO flag that strips docstrings, but it doesn't work well and I think it was a mistake. -- ___ Python tracker

[issue34561] Replace list sorting merge_collapse()?

Tim Peters added the comment: The merge order was mentioned on python-dev today, and a quick web searched turned up a revision of Vincent Jugé's "Adaptive Shivers Sort: An Alternative Sorting Algorithm" paper I hadn't seen before: https://arxiv.org/pdf/1809.08411.pdf Its "length-adaptive

[issue45020] Freeze all modules imported during startup.

Change by Inada Naoki : -- nosy: +methane ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36521] Consider removing docstrings from co_consts in code objects

Inada Naoki added the comment: > This would actually make it harder to strip docstrings e.g. during > unmarshalling, since you don't know which constants refer to docstrings. We can not strip class docstring anyway. One idea to strip docstring during startup: Add new opcode only for storing

[issue36521] Consider removing docstrings from co_consts in code objects

Inada Naoki added the comment: > You'd just be moving the problem though -- the docstring would have be > included in the co_consts array of the surrounding code object instead of the > function object. As far as I know, surrounding code objects (e.g. global, class body) will be removed

[issue45020] Freeze all modules imported during startup.

Guido van Rossum added the comment: Gregor, thanks for sharing your experience! I guess freezing the entire stdlib instead of just a smattering of modules (like we do here) exacerbated the problems in your case. Builtin modules (such as sys or time) don't have a __file__ attribute either,

[issue45037] theme-change.py for tkinter lib

Zachary Ware added the comment: I agree with Serhiy and Terry that this is not the right place for this example and am closing the issue. -- nosy: +zach.ware resolution: -> rejected stage: -> resolved status: open -> closed ___ Python tracker

[issue45038] Bugs

Change by Zachary Ware : -- Removed message: https://bugs.python.org/msg400479 ___ Python tracker ___ ___ Python-bugs-list mailing

[issue45020] Freeze all modules imported during startup.

Gregory Szorc added the comment: Oh, PyOxidizer also ran into more general issues with the frozen importer in that it broke various importlib APIs. e.g. because the frozen importer only supports bytecode, you can't use .__loader__.get_source() to obtain the source of a module. This makes

[issue45020] Freeze all modules imported during startup.

Gregory Szorc added the comment: When I investigated freezing the standard library for PyOxidizer, I ran into a rash of problems. The frozen importer doesn't behave like PathFinder. It doesn't (didn't?) set some common module-level attributes that are documented by the importer

[issue39817] CRITICAL: TypeError: cannot pickle 'generator'

Irit Katriel added the comment: Thank you Andrei. -- nosy: +iritkatriel resolution: -> third party stage: -> resolved status: open -> closed ___ Python tracker ___

[issue45041] [sqlite3] simplify executescript()

New submission from Erlend E. Aasland : See also bpo-45040 Since sqlite3_finalize() will pass on any error message set by sqlite3_step(), we can greatly simplify SQLite C API usage and error handling in sqlite3.Cursor.executescript(), thus reducing the number of times we save/restore thread

[issue45041] [sqlite3] simplify executescript()

Change by Erlend E. Aasland : -- keywords: +patch pull_requests: +26466 stage: -> patch review pull_request: https://github.com/python/cpython/pull/28020 ___ Python tracker

[issue45037] theme-change.py for tkinter lib

Change by Terry J. Reedy : -- Removed message: https://bugs.python.org/msg400476 ___ Python tracker ___ ___ Python-bugs-list

[issue45037] theme-change.py for tkinter lib

Change by Terry J. Reedy : -- Removed message: https://bugs.python.org/msg400475 ___ Python tracker ___ ___ Python-bugs-list

[issue45037] theme-change.py for tkinter lib

Terry J. Reedy added the comment: Ayush, when responding by email, please delete the text you are responding to. After posting on the webpage, the quoted copy becomes redundant and noisy. -- I suspect that whatever tkinter demo existed previously was dropped because no one wanted

[issue35391] threading.RLock exception handling while waiting

Change by Antoine Pitrou : -- resolution: -> out of date stage: -> resolved status: open -> closed ___ Python tracker ___ ___

[issue35391] threading.RLock exception handling while waiting

Antoine Pitrou added the comment: RLock is implemented in C nowadays so this problem doesn't occur anymore: https://github.com/python/cpython/blob/main/Modules/_threadmodule.c#L436-L459 You can of course, however, import the pure Python RLock under the name "_PyRLock", which is still

[issue45024] Cannot extend collections ABCs with protocol

Anup Parikh added the comment: Yeah, you got the gist of what I meant, though, I guess that was a confusing example since there are apparently protocols for Iterable. But not for many of the other collection ABCs such as Sequence, e.g., the following doesn't work: from typing import

[issue45040] [sqlite3] optimise transaction control functions

Change by Erlend E. Aasland : -- keywords: +patch pull_requests: +26465 stage: -> patch review pull_request: https://github.com/python/cpython/pull/28019 ___ Python tracker

[issue24388] Python readline module crashes in history_get on FreeBSD with libedit

Change by Ned Deily : -- pull_requests: -26463 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue45040] [sqlite3] optimise transaction control functions

New submission from Erlend E. Aasland : pysqlite_connection_commit_impl(), pysqlite_connection_rollback_impl(), and begin_transaction() can be simplified: sqlite3_finalize() will pass on any error set by sqlite3_step(). This implies that we only need to check the return value of

[issue45036] turtle.onrelease() event doesn't get triggered sometimes

Terry J. Reedy added the comment: (turtle module has no relation to IDLE other than also using tkinter. The fact that turtledemo can be run from IDLE is incidental.) 3.10.0rc installed on Win 10. I first clicked randomly and never saw a missing 'release'. I noticed that the turtle

[issue24888] FileNotFoundException raised by subprocess.call

Change by Diana : -- keywords: +patch pull_requests: +26464 stage: -> patch review pull_request: https://github.com/python/cpython/pull/28018 ___ Python tracker ___

[issue24388] Python readline module crashes in history_get on FreeBSD with libedit

Change by Diana : -- nosy: +DonnaDia nosy_count: 3.0 -> 4.0 pull_requests: +26463 pull_request: https://github.com/python/cpython/pull/28018 ___ Python tracker ___

[issue36258] Incorrect docstring of the ssl module

Change by Irit Katriel : -- versions: +Python 3.10, Python 3.11, Python 3.9 -Python 2.7, Python 3.4, Python 3.5, Python 3.6, Python 3.7, Python 3.8 ___ Python tracker ___

[issue35391] threading.RLock exception handling while waiting

Irit Katriel added the comment: Have you reproduced the issue on 3.8? I am unable to reproduce this on main (on a Mac). Adding Antoine since I think he fixed a few issues in this area. -- nosy: +iritkatriel, pitrou ___ Python tracker

[issue38435] Start the deprecation cycle for subprocess preexec_fn

Gregory P. Smith added the comment: A worthwhile general suggestion on a new path forward for the mess of things between (v)fork+exec from Victor is over in https://bugs.python.org/issue42736#msg383869 TL;DR creating a subprocess.Preexec() recording object with specific interfaces for

[issue25130] Make tests more PyPy compatible

Serhiy Storchaka added the comment: New changeset 1046cd06b0e2f20b3be93de83d49b684956af98d by Serhiy Storchaka in branch '3.9': [3.9] bpo-25130: Make unit-test about restricting the maximum number of nested blocks cpython-only (GH-28002) (GH-28017)

[issue25130] Make tests more PyPy compatible

Serhiy Storchaka added the comment: New changeset 779b9aef4fb2750f57ce07f0efbc8ce8406e43ab by Miss Islington (bot) in branch '3.10': bpo-25130: Make unit-test about restricting the maximum number of nested blocks cpython-only (GH-28002) (GH-28016)

[issue45018] Pickling a range iterator with an index of over sizeof(int) stores an invalid index

Change by Łukasz Langa : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue44962] asyncio.create_task weakrefset race condition

Łukasz Langa added the comment: Thanks, Thomas! ✨  ✨ -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.11 -Python 3.7, Python 3.8 ___ Python tracker

[issue44962] asyncio.create_task weakrefset race condition

Łukasz Langa added the comment: New changeset 166ad706066a2aad84d0ae5b1594c88904fbb939 by Miss Islington (bot) in branch '3.9': bpo-44962: Fix a race in WeakKeyDict, WeakValueDict and WeakSet when two threads attempt to commit the last pending removal (GH-27921) (GH-28014)

[issue27334] [sqlite3] context manager leaves db locked if commit fails in __exit__

Erlend E. Aasland added the comment: Thanks Luca, for the report, reproducer, and initial patch, Berker for helpful suggestion, and Łukasz, Pablo, & Victor for reviewing and merging. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed

[issue25130] Make tests more PyPy compatible

Change by Serhiy Storchaka : -- pull_requests: +26462 pull_request: https://github.com/python/cpython/pull/28017 ___ Python tracker ___

[issue25130] Make tests more PyPy compatible

Change by miss-islington : -- nosy: +miss-islington nosy_count: 7.0 -> 8.0 pull_requests: +26461 pull_request: https://github.com/python/cpython/pull/28016 ___ Python tracker

[issue25130] Make tests more PyPy compatible

Serhiy Storchaka added the comment: New changeset eb263f9a356f5c5f21b8d5ce20bac92f31c40cad by Carl Friedrich Bolz-Tereick in branch 'main': bpo-25130: Make unit-test about restricting the maximum number of nested blocks cpython-only (GH-28002)

[issue25130] Make tests more PyPy compatible

Change by Carl Friedrich Bolz-Tereick : -- nosy: +Carl.Friedrich.Bolz nosy_count: 6.0 -> 7.0 pull_requests: +26460 pull_request: https://github.com/python/cpython/pull/28002 ___ Python tracker

[issue27334] [sqlite3] context manager leaves db locked if commit fails in __exit__

Pablo Galindo Salgado added the comment: New changeset 2a80893e5c023a73ccd32cc319f4f0404f548c00 by Erlend Egeberg Aasland in branch '3.10': [3.10] bpo-27334: roll back transaction if sqlite3 context manager fails to commit (GH-26202) (GH-27943)

[issue44962] asyncio.create_task weakrefset race condition

miss-islington added the comment: New changeset 8aa64cc45bff516a6db1f3a3c037cbcce9417fea by Miss Islington (bot) in branch '3.10': bpo-44962: Fix a race in WeakKeyDict, WeakValueDict and WeakSet when two threads attempt to commit the last pending removal (GH-27921)

[issue45018] Pickling a range iterator with an index of over sizeof(int) stores an invalid index

miss-islington added the comment: New changeset cd986e903176d28ed795f65ba14e6fcbf2a65e3d by Miss Islington (bot) in branch '3.10': bpo-45018: Fix rangeiter_reduce in rangeobject.c (GH-27938) https://github.com/python/cpython/commit/cd986e903176d28ed795f65ba14e6fcbf2a65e3d --

[issue44524] __name__ attribute in typing module

miss-islington added the comment: New changeset 81fa08c5ea2cf15254b951034b9d6c7358f96d79 by Miss Islington (bot) in branch '3.10': bpo-44524: Fix cryptic TypeError message when trying to subclass special forms in `typing` (GH-27710)

[issue45039] use ADDOP_LOAD_CONST consistently

Change by Irit Katriel : -- nosy: +Mark.Shannon, gvanrossum ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue45029] tkinter doc, hello world example - quit button clobbers method

Terry J. Reedy added the comment: For whatever reason, the 3.9 backport, PR-27911, was closed. In any case, we will not edit the code we have replaced. Lyndon, when responding by email, please delete the old text as it is redundant and noisy when your email is added to the web page.

[issue39817] CRITICAL: TypeError: cannot pickle 'generator'

Andrei Kulakov added the comment: This issue has been resolved and closed in Pelican tracker; so it can be closed here as well, as not a bug. -- nosy: +andrei.avk ___ Python tracker

[issue45039] use ADDOP_LOAD_CONST consistently

Change by Irit Katriel : -- keywords: +patch pull_requests: +26459 stage: -> patch review pull_request: https://github.com/python/cpython/pull/28015 ___ Python tracker ___

[issue45029] tkinter doc, hello world example - quit button clobbers method

Change by miss-islington : -- keywords: +patch nosy: +miss-islington nosy_count: 4.0 -> 5.0 pull_requests: +26458 stage: -> patch review pull_request: https://github.com/python/cpython/pull/27911 ___ Python tracker

[issue45039] use ADDOP_LOAD_CONST consistently

New submission from Irit Katriel : The compiler generally uses ADDOP_LOAD_CONST to emit a LOAD_CONST, but there are two places that use ADDOP_O(c, LOAD_CONST, Py_None, consts); This is currently equivalent to ADDOP_LOAD_CONST(c, Py_None); It should be replaced because we may soon change

[issue45037] theme-change.py for tkinter lib

Ayush Parikh added the comment: so can u review pr and make changes for me if required or guide me so that it can be merged ! On Sat, Aug 28, 2021 at 10:33 PM Serhiy Storchaka wrote: > > Serhiy Storchaka added the comment: > > I do not know. There are no issue numbers in changesets which

[issue44962] asyncio.create_task weakrefset race condition

Change by miss-islington : -- pull_requests: +26457 pull_request: https://github.com/python/cpython/pull/28014 ___ Python tracker ___

[issue44962] asyncio.create_task weakrefset race condition

Change by miss-islington : -- nosy: +miss-islington nosy_count: 5.0 -> 6.0 pull_requests: +26456 pull_request: https://github.com/python/cpython/pull/28013 ___ Python tracker

[issue44962] asyncio.create_task weakrefset race condition

Łukasz Langa added the comment: New changeset 206b21ed9f64fedff67bfea7cf73e423e3e32393 by Thomas Grainger in branch 'main': bpo-44962: Fix a race in WeakKeyDict, WeakValueDict and WeakSet when two threads attempt to commit the last pending removal (GH-27921)

[issue45037] theme-change.py for tkinter lib

Serhiy Storchaka added the comment: I do not know. There are no issue numbers in changesets which removed them. -- ___ Python tracker ___

[issue45037] theme-change.py for tkinter lib

E. Paine added the comment: > there were Tkinter demos in 2.7 (Demo/tkinter), but they were removed Why is this? Because people didn't want to change them all for the tkinter module names, or because they were deemed unnecessary? -- ___ Python

[issue45038] Bugs

Zachary Ware added the comment: If you don't describe them, we can't fix them ;) This looks rather like an accidental submission, so I'm going to go ahead and close it; if you do have a report you would like to submit, please edit the title and add a new comment and I'll be happy to reopen

[issue45038] Bugs

New submission from Jonathan Isaac : Jonathan Isaac Sent with Aqua Mail for Android https://www.mobisystems.com/aqua-mail -- messages: 400479 nosy: bonesisaac1982 priority: normal severity: normal status: open title: Bugs ___ Python tracker

[issue45036] turtle.onrelease() event doesn't get triggered sometimes

E. Paine added the comment: The issue is that the "release" function appears to be called before the "drag" function for the last coordinate. The fix is probably only lowering the pen when the mouse button is first clicked, as this is guaranteed to be called before "release". I ended up

[issue45037] theme-change.py for tkinter lib

Serhiy Storchaka added the comment: I do not think this should be included in the Tkinter library. As for demos, there were Tkinter demos in 2.7 (Demo/tkinter), but they were removed. -- ___ Python tracker

[issue45037] theme-change.py for tkinter lib

Change by E. Paine : -- components: -Parser nosy: -bonesisaac1982, lys.nikolaou, pablogsal type: crash -> enhancement versions: -Python 3.6 ___ Python tracker ___

[issue45037] theme-change.py for tkinter lib

Jonathan Isaac added the comment: Bugs -- components: +Parser nosy: +lys.nikolaou, pablogsal type: -> crash versions: +Python 3.11, Python 3.6 ___ Python tracker ___

[issue45037] theme-change.py for tkinter lib

Jonathan Isaac added the comment: Get the code! -- nosy: +bonesisaac1982 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue45037] theme-change.py for tkinter lib

Ayush Parikh added the comment: yes PR purpose is to show demo for themes change of tkinter window On Sat, Aug 28, 2021 at 8:03 PM E. Paine wrote: > > New submission from E. Paine : > > I'm slightly confused about the purpose of this PR. Is the intention to > create a demo, or this designed

[issue36521] Consider removing docstrings from co_consts in code objects

Guido van Rossum added the comment: > I'd like to remove docstring from code object at all. > func.__doc__ can be set by MAKE_FUNCTION or STORE_ATTR. You'd just be moving the problem though -- the docstring would have be included in the co_consts array of the surrounding code object instead

[issue45037] theme-change.py for tkinter lib

New submission from E. Paine : I'm slightly confused about the purpose of this PR. Is the intention to create a demo, or this designed to be used as an API? -- nosy: +epaine, serhiy.storchaka, terry.reedy ___ Python tracker

[issue45021] Race condition in thread.py

nullptr added the comment: Simplifying the reproducing example a bit more: from concurrent.futures import ProcessPoolExecutor, ThreadPoolExecutor from time import sleep def submit(pool): pool.submit(submit, pool) if __name__ == '__main__': pool = ThreadPoolExecutor(1)

[issue45037] theme-change.py for tkinter lib

Change by Ayush Parikh : -- components: Tkinter nosy: Ayushparikh-code priority: normal pull_requests: 26455 severity: normal status: open title: theme-change.py for tkinter lib ___ Python tracker

[issue45036] turtle.onrelease() event doesn't get triggered sometimes

New submission from Techn010 Je11y : (pls read with reference to attached code) I made a Paint-ish program with Turtle. As there isn't ondrag or onrelease for Screen, I created a turtle named bg so I could use ondrag and onrelease (see file attached ig) and eliminate the need for

[issue45020] Freeze all modules imported during startup.

Marc-Andre Lemburg added the comment: On 28.08.2021 06:06, Guido van Rossum wrote: > >> With that in place, it'd be great to pre-cache all the .py files >> automatically read in at startup. > > *All* the .py files? I think the binary bloat cause by deep-freezing the > entire stdlib would

[issue19027] undefined symbol: _PyParser_Grammar

Irit Katriel added the comment: We no longer have GRAMMAR_H or _PyParser_Grammar in the code. -- nosy: +iritkatriel resolution: -> out of date stage: needs patch -> resolved status: open -> closed ___ Python tracker

[issue20658] os.environ.clear() fails with empty keys (posix.unsetenv)

Irit Katriel added the comment: They keys are checked now, so I think this is resolved. (Tested on windows and Mac). >>> os.environ[''] = 'X' Traceback (most recent call last): File "", line 1, in File "/Users/iritkatriel/src/cpython/Lib/os.py", line 684, in __setitem__ putenv(key,

[issue36521] Consider removing docstrings from co_consts in code objects

Irit Katriel added the comment: > I'd like to remove docstring from code object at all. > func.__doc__ can be set by MAKE_FUNCTION or STORE_ATTR. I think that would require a change in the signature of PyFunction_New. -- ___ Python tracker

[issue45024] Cannot extend collections ABCs with protocol

Ken Jin added the comment: Thanks for the bug report Anup. I'm mildly confused by what you meant, so please help me here: I interpreted your request as wanting any type that implements `method` and `__iter__` to be considered a subtype of `IterableWithMethod`. But this already works at

[issue42272] Warning filter message/module documentation is misleading

Ananya Datta added the comment: No comments -- nosy: +ananyadatta88 Added file: https://bugs.python.org/file50238/D365 Finance cert learning path.pdf ___ Python tracker ___

[issue45035] sysconfig's posix_home scheme has different platlib value to distutils's unix_home

Change by Tzu-ping Chung : -- keywords: +patch pull_requests: +26454 stage: -> patch review pull_request: https://github.com/python/cpython/pull/28011 ___ Python tracker ___

[issue45035] sysconfig's posix_home scheme has different platlib value to distutils's unix_home

New submission from Tzu-ping Chung : This is similar to bpo-44860, but in the other direction: $ docker run -it --rm -h=p fedora:34 bash ... [root@p /]# yum install python3 -y ... [root@p /]# type python3 python3 is hashed (/usr/bin/python3) [root@p /]# python3 -V

[issue36521] Consider removing docstrings from co_consts in code objects

Inada Naoki added the comment: I'd like to remove docstring from code object at all. func.__doc__ can be set by MAKE_FUNCTION or STORE_ATTR. Pros are: * Code objects can be bit smaller than adding co_doc. * Many code objects don't have docstrings. (e.g. lambdas, somprehensions, and PEP