Aaron Hill added the comment:
I've upload a patch which should address the issue in both the lzma and bz2
modules.
--
keywords: +patch
nosy: +Aaron1011
Added file: http://bugs.python.org/file45730/fix-lzma-bz2-segfaults.patch
___
Python tracker <
Aaron Hill added the comment:
I've added a test case to exercise reset()
--
Added file:
http://bugs.python.org/file39934/fix-multibytecodec-segfault-with-test.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23247
Aaron Hill added the comment:
The patch didn't get attached for some reason. It's attached now.
--
Added file: http://bugs.python.org/file39933/fix-multibytecodec-segfault.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Aaron Hill added the comment:
The included patch fixes the issue, and modifies the existing unittest to
prevent a future regression.
The patch corrects an issue where the 'pending' struct field was NULL, but was
used as the input to multibytecodec_encode anyay
Aaron Hill added the comment:
This is also present in the latest Python 3.6.
I'm going to work on providing a patch for this, unless someone else already is
--
nosy: +Aaron1011
versions: +Python 3.6
___
Python tracker rep...@bugs.python.org
http
Aaron Hill added the comment:
I've fixed the formatting issues.
--
Added file:
http://bugs.python.org/file37510/mock-open-allow-binary-data-fix-formatting.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23004
Aaron Hill added the comment:
I've fixed the issues you pointed out.
Is there a better way than uploading a new patch file to make changes?
--
Added file:
http://bugs.python.org/file37458/mock-open-allow-binary-without-coerce-fixup.patch
___
Python
Aaron Hill added the comment:
Thanks, I've fixed that. Not sure why I thought decoding and re-encoding would
work with any binary data.
I've also updated one of the tests to use non-utf8-decodeable binary data, to
prevent a future regression.
--
Added file:
http://bugs.python.org
Aaron Hill added the comment:
I've created a new patch, which addresses the problem. Your example now
currently returns [b'foo\n', b'bar\n']
--
Added file:
http://bugs.python.org/file37440/mock-open-allow-binary-data-updated.patch
___
Python
Aaron Hill added the comment:
I've created a patch that fixes this, and added an accompanying unit test
(which fails without the change).
--
keywords: +patch
nosy: +Aaron1011
Added file: http://bugs.python.org/file37435/mock-open-allow-binary-data.patch
Aaron Hill added the comment:
Awesome! Thanks!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18216
___
___
Python-bugs-list mailing list
Aaron Hill added the comment:
Is there anything that needs to be changed?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18216
___
___
Python
Aaron Hill added the comment:
Does anyone have any thoughts about throwing a warning for an unexpected minor
revision?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18216
Aaron Hill added the comment:
Okay, then. I'll just leave it out.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18216
___
___
Python-bugs-list
Changes by Aaron Hill aa1ron...@gmail.com:
Added file: http://bugs.python.org/file36957/gettext-mo-fix-minor-version.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18216
Changes by Aaron Hill aa1ron...@gmail.com:
Removed file:
http://bugs.python.org/file36957/gettext-mo-fix-minor-version.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18216
Changes by Aaron Hill aa1ron...@gmail.com:
Added file: http://bugs.python.org/file36958/gettext-mo-fixup.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18216
Aaron Hill added the comment:
I've added a second patch, which properly distinguishes between major and minor
revisions, and updates the docs to account for the new behavior.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Aaron Hill added the comment:
In order to fix this, I think ParseResult needs to have two additional fields,
indicating with an empty prefix or query string are used.
Both ParseResult.fragment and ParseResult.query omit the leading '#' or '?'
from their value. This makes it impossible
Aaron Hill added the comment:
That sounds good. Should a warning be thrown for an unexpected minor revision?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18216
Changes by Aaron Hill aa1ron...@gmail.com:
--
keywords: +patch
nosy: +Aaron1011
Added file: http://bugs.python.org/file36828/gettext-mo-version.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18216
New submission from Aaron Hill:
The last sentence in the explanation of the TCP echo client currently reads:
At run_until_complete() exit, the loop is no more running, so there is no need
to stop the loop in case of an error.
The grammar should be improved to something like ...the loop
22 matches
Mail list logo
