Andrew Svetlov added the comment:
Answered in https://github.com/python/cpython/pull/15889
--
___
Python tracker
<https://bugs.python.org/issue36373>
___
___
Change by Andrew Svetlov :
--
pull_requests: +15530
pull_request: https://github.com/python/cpython/pull/15889
___
Python tracker
<https://bugs.python.org/issue36
Andrew Svetlov added the comment:
Better to avoid _asyncio_internal if not strictly necessary.
Currently, _asyncio_internal is used for protection of asyncio class direct
instantiation.
E.g. stream = asyncio.Stream() is forbidden, people should use factories like
stream = await
Andrew Svetlov added the comment:
Thanks for the report xtreak, I'll make a fix.
--
___
Python tracker
<https://bugs.python.org/issue36373>
___
___
Python-bug
Change by Andrew Svetlov :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Andrew Svetlov added the comment:
Done.
The only API from transport that users really need is get_extra_info() which is
exposed as a stream method already.
--
___
Python tracker
<https://bugs.python.org/issue38
Change by Andrew Svetlov :
--
keywords: +patch
pull_requests: +15415
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/15762
___
Python tracker
<https://bugs.python.org/issu
New submission from Andrew Svetlov :
As discussed in discussion
https://github.com/python/cpython/pull/14488#discussion_r322176319
Hide feed_eof(), feed_data(), set_exception() and set_transport() methods.
--
components: asyncio
messages: 351433
nosy: asvetlov, yselivanov
priority
Change by Andrew Svetlov :
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Andrew Svetlov added the comment:
Let's close the issue as "won't fix".
Third-party loop implementation *can* be reentrant but we don't want to
encourage people to use this pattern in stdlib.
--
resolution: -> wont fix
stage: patch review -> resolved
status
Andrew Svetlov added the comment:
This is a new feature (and not a blocker).
Shift to 3.9.
Nathaniel, the PR is outdated.
Have you an intention to land it or the issue can be closed by the lack of
interest?
--
nosy: +asvetlov
versions: +Python 3.9 -Python 3.8
Andrew Svetlov added the comment:
In asyncio code please use non-blocking code and await a future returned by
run_until_complete.
The following code doesn't leak:
import asyncio
import concurrent
import threading
def prepare_a_giant_list():
m = []
for i in range(1000*1000
Andrew Svetlov added the comment:
The solution produces subtle and error-prone code. It can live in third party
library but not good enough for stdlib I think.
--
___
Python tracker
<https://bugs.python.org/issue33
Change by Andrew Svetlov :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Andrew Svetlov added the comment:
New changeset 1c0600998681295735a18690fae184b0c9a4ca51 by Andrew Svetlov in
branch 'master':
bpo-34679: Restore instantiation Windows IOCP event loop from non-main thread
(#15492)
https://github.com/python/cpython/commit
Change by Andrew Svetlov :
--
pull_requests: +15183, 15184
pull_request: https://github.com/python/cpython/pull/15492
___
Python tracker
<https://bugs.python.org/issue34
Change by Andrew Svetlov :
--
pull_requests: +15183, 15184, 15185
pull_request: https://github.com/python/cpython/pull/15492
___
Python tracker
<https://bugs.python.org/issue34
Change by Andrew Svetlov :
--
pull_requests: +15183
pull_request: https://github.com/python/cpython/pull/15492
___
Python tracker
<https://bugs.python.org/issue34
Change by Andrew Svetlov :
--
pull_requests: -15179
___
Python tracker
<https://bugs.python.org/issue34769>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Andrew Svetlov :
--
keywords: +patch
pull_requests: +15180
pull_request: https://github.com/python/cpython/pull/15492
___
Python tracker
<https://bugs.python.org/issue34
Andrew Svetlov added the comment:
Kyle, thanks for the fix.
I have basically the same change in my PR but with test and news note.
--
___
Python tracker
<https://bugs.python.org/issue34
Andrew Svetlov added the comment:
The issue is related to Python 3.8 and master only. 3.6-3.7 are not affected
--
versions: +Python 3.9 -Python 3.6, Python 3.7
___
Python tracker
<https://bugs.python.org/issue34
Change by Andrew Svetlov :
--
pull_requests: +15179
pull_request: https://github.com/python/cpython/pull/15492
___
Python tracker
<https://bugs.python.org/issue34
Andrew Svetlov added the comment:
The behavior change is not backward compatible, we cannot apply it.
Also, please use github pull requests for proposing a patch:
https://devguide.python.org/pullrequest/
--
___
Python tracker
<ht
Andrew Svetlov added the comment:
There is no consensus yet, IMHO.
There is a lack of resources for the issue.
--
___
Python tracker
<https://bugs.python.org/issue17
Change by Andrew Svetlov :
--
assignee: -> asvetlov
___
Python tracker
<https://bugs.python.org/issue36732>
___
___
Python-bugs-list mailing list
Unsubscrib
Andrew Svetlov added the comment:
ResourceWarning?
I'll take a look
--
___
Python tracker
<https://bugs.python.org/issue36732>
___
___
Python-bugs-list mailin
Andrew Svetlov added the comment:
I still think that iscoroutinefunction should not be used for async/sync
decoration type autodetection.
A day ago stuck with a case when decorator used iscoroutinefunction() for
separation but returned a regular function wrapper that returns awaitable
Andrew Svetlov added the comment:
Hi. StreamReaderProtocol was leaked implementation detail, not a public
reusable class. The protocol has too many "gray zones" where its implementation
is not well defined or even wrong.
This situation prevents us from stream API improvements whi
Andrew Svetlov added the comment:
Thanks for the report.
--
assignee: -> asvetlov
___
Python tracker
<https://bugs.python.org/issue37573>
___
___
Python-
Change by Andrew Svetlov :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.8, Python 3.9
___
Python tracker
<https://bugs.python.or
Andrew Svetlov added the comment:
Good point.
For proactor event loop set_wakeup_fd() is used for Ctrl+C handling.
Skipping this call for non-main thread in proactor implementation makes sense.
--
assignee: -> asvetlov
___
Python tracker
<
Andrew Svetlov added the comment:
Thanks!
--
nosy: +asvetlov
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.7, Python 3.8, Python 3.9
___
Python tracker
<https://bugs.python.or
Andrew Svetlov added the comment:
It doesn't.
Loop is executed by asyncio.run() (recommended) or low-level
loop.run_until_complete() / loop.run_forever() calls.
Please note, this tracker is for working on Python itself, not for teaching
Python usage.
Please use other resources like forums
Andrew Svetlov added the comment:
Your code doesn't run the event loop, only creates it.
What do you expect?
--
___
Python tracker
<https://bugs.python.org/issue37
Andrew Svetlov added the comment:
Victor, backporting to 3.7 makes merge conflicts.
Do you think that I should backport manually?
--
___
Python tracker
<https://bugs.python.org/issue37
Andrew Svetlov added the comment:
Thanks!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.8
___
Python tracker
<https://bugs.python.or
Andrew Svetlov added the comment:
New changeset c2cda638d63b98f5cf9a8ef13e15aace2b7e3f0b by Andrew Svetlov
(Zackery Spytz) in branch 'master':
bpo-37199: Fix test failures when IPv6 is unavailable or disabled (#14480)
https://github.com/python/cpython/commit
Change by Andrew Svetlov :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.9 -Python 3.6, Python 3.7
___
Python tracker
<https://bugs.python.or
Andrew Svetlov added the comment:
New changeset 0d671c04c39b52e44597491b893eb0b6c86b3d45 by Andrew Svetlov in
branch 'master':
bpo-35621: Support running subprocesses in asyncio when loop is executed in
non-main thread (GH-14344)
https://github.com/python/cpython/commit
Andrew Svetlov added the comment:
Yes, sure
--
nosy: +asvetlov
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Andrew Svetlov :
--
pull_requests: +14211
pull_request: https://github.com/python/cpython/pull/14397
___
Python tracker
<https://bugs.python.org/issue36
Andrew Svetlov added the comment:
Is it ok to have
File
"/home/ajung/sandboxes/ugent-portaal-plone-4x/eggs/Products.CMFDynamicViewFTI-6.0.1-py3.7.egg/Products/CMFDynamicViewFTI/browserdefault.py",
line 76 in __call__
so many times?
Looks very
Andrew Svetlov added the comment:
I don't mind, sorry.
Feel free to make a pull request with the fix though.
--
___
Python tracker
<https://bugs.python.org/issue37
Andrew Svetlov added the comment:
Use asyncio transports or streams.
sock_recv() is a low-level API with a very limited audience.
wrapped ssl socket provides a synchronous interface only.
Perhaps we should raise an exception if SSLSocket is passed into asyncio
functions
Andrew Svetlov added the comment:
Adding a new state for "not running and not pending but something in between"
is useless, it can make .running() result a little more accurate but doesn't
improve the real functionality.
The easy "fix" is documentation updating to
Andrew Svetlov added the comment:
Got you.
iscoroutinefunction() is not reliable: it detects async functions only but
fails if we have a regular function that returns awaitable object.
I think AsyncContextDecorator is needed here to explicitly point that you want
to wrap async function
Andrew Svetlov added the comment:
Sorry, I still have no idea what is the code for PerfTimer class.
--
___
Python tracker
<https://bugs.python.org/issue37
Andrew Svetlov added the comment:
Yes, Stream doc should be a combination of StreamReader and StreamWriter with
small changes/additions.
StreamReader and StreamWriter should be kept in the doc.
Regarding docstrings: there is no strong requirement (we don't provide
docstrings for all asyncio
Andrew Svetlov added the comment:
I wonder why do you need it? What is your use case?
A code snippet can help a lot.
--
___
Python tracker
<https://bugs.python.org/issue37
Andrew Svetlov added the comment:
Thanks, Karthikeyan!
The only thing that needs to be documented is Stream class itself.
Would you finish this job, please?
--
___
Python tracker
<https://bugs.python.org/issue36
Andrew Svetlov added the comment:
New changeset 6793cce155f8875b10efd746cb0b34cb72263af7 by Andrew Svetlov
(Xtreak) in branch 'master':
bpo-36889: Document asyncio Stream and StreamServer (GH-14203)
https://github.com/python/cpython/commit/6793cce155f8875b10efd746cb0b34cb72263af7
Change by Andrew Svetlov :
--
pull_requests: +14164
pull_request: https://github.com/python/cpython/pull/14344
___
Python tracker
<https://bugs.python.org/issue35
Andrew Svetlov added the comment:
There is an interesting discussion:
https://stackoverflow.com/questions/14499593/can-the-infamous-error-netname-deleted-error-be-considered-an-error-at-all
"[WinError 64] The specified network name is no longer available" is raised on
pending
Change by Andrew Svetlov :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Andrew Svetlov added the comment:
I don't like to have not required parts like thread pool, time handlers, and
the exception handler executed in the auxiliary thread.
What's about an alternative proposal: embed into ProactorEventLoop not entire
SelectorEventLoop but selectors.SelectSelector
Andrew Svetlov added the comment:
I doubt if we should split a proactor loop into two objects in two threads.
I see no strong objections but have a feeling that we'll get other problems in
this way. asyncio is just not designed for this mode.
The proposal looks like a very dirty hack
Andrew Svetlov added the comment:
> Is it possible to implement add_reader/writer in ProactorEventLoop?
Sorry, no. There is no way IIUC.
Regarding a request for selecting event loop by a library.
1. You can call asyncio.set_event_loop_policy() already.
2. From my understand
Andrew Svetlov added the comment:
Agree with Caleb.
The more I think the more I doubt about the proposal.
Cancellation is for tasks, not for queues or locks.
When should I cancel a queue but cannot cancel a task?
--
___
Python tracker
<ht
Change by Andrew Svetlov :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Andrew Svetlov added the comment:
3.8 is in beta stage, public API is frozen
--
___
Python tracker
<https://bugs.python.org/issue37345>
___
___
Python-bug
Change by Andrew Svetlov :
--
versions: -Python 3.8
___
Python tracker
<https://bugs.python.org/issue37345>
___
___
Python-bugs-list mailing list
Unsubscribe:
Andrew Svetlov added the comment:
Sorry.
Please drop helper methods but keep IPPROTO_UDPLITE, UDPLITE_SEND_CSCOV,
UDPLITE_RECV_CSCOV constants.
--
___
Python tracker
<https://bugs.python.org/issue37
Andrew Svetlov added the comment:
We have no setsockopt() shortcut helpers.
socket.setblocking() uses fcntl() internally.
--
___
Python tracker
<https://bugs.python.org/issue37
Andrew Svetlov added the comment:
Adding new constants like socket.IPPROTO_UDPLITE is fine.
The question is: why we need a new function?
There is no set_send_checksum_coverage() on C level IIRC
--
nosy: +asvetlov
___
Python tracker
<ht
Andrew Svetlov added the comment:
Sounds like `.close()` is better name for described behavior.
--
___
Python tracker
<https://bugs.python.org/issue37
Andrew Svetlov added the comment:
> If a RuntimeWarning is warranted when a temporary variable is used, it's
> warranted when the value is used directly, without a temporary variable.
No, it's not. If "1/0" is present in never executed code block Python don't
raise
Change by Andrew Svetlov :
--
resolution: -> duplicate
stage: -> resolved
status: open -> closed
superseder: -> Don't log OSError exceptions in asyncio transports
___
Python tracker
<https://bugs.python
Andrew Svetlov added the comment:
I believe the issue is a duplicate for #37035 at least regarding traceback
logging.
It can be closed, OSError exceptions are not logged anymore.
--
___
Python tracker
<https://bugs.python.org/issue34
Andrew Svetlov added the comment:
No idea what to do.
SSL support is obviously broken.
Current code is too complex to maintain.
Yuri has a full reimplementation of ssl_proto.py in uvloop.
It *seem* to work and can be backported.
I'm sick now, can be ready to work back in a day or two
Andrew Svetlov added the comment:
The solution is called static analyzers and "type hints".
Mypy detects the absence of "await" pretty well.
In turn, CPython does the best in runtime mode for detecting not-awaited
awaitables when possible.
I think we should close the is
Andrew Svetlov added the comment:
>From my understanding yield inside __aiter__ is a forbidden construction. Even
>if parser allows it the statement doesn't make any sense.
I'm very interested to hear Yuri opinion.
--
___
Python tracker
Change by Andrew Svetlov :
--
nosy: -gvanrossum
___
Python tracker
<https://bugs.python.org/issue37294>
___
___
Python-bugs-list mailing list
Unsubscribe:
Andrew Svetlov added the comment:
The use case is weird.
I don't think we need to do something with the issue.
--
nosy: +gvanrossum
___
Python tracker
<https://bugs.python.org/issue37
Andrew Svetlov added the comment:
Ooops. Looks like a real problem, not test-only :(
--
___
Python tracker
<https://bugs.python.org/issue35998>
___
___
Pytho
Andrew Svetlov added the comment:
New changeset e5d67f1e31381d28b24f6e1c0f8388d9bf0bfc5f by Andrew Svetlov in
branch '3.7':
[3.7] bpo-37279: Fix asyncio sendfile support when extra data are sent in
fallback mode. (GH-14075). (GH-14103)
https://github.com/python/cpython/commit
Change by Andrew Svetlov :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Andrew Svetlov :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Andrew Svetlov :
--
pull_requests: +13957
pull_request: https://github.com/python/cpython/pull/14103
___
Python tracker
<https://bugs.python.org/issue37
Change by Andrew Svetlov :
--
pull_requests: +13956
pull_request: https://github.com/python/cpython/pull/14102
___
Python tracker
<https://bugs.python.org/issue37
Andrew Svetlov added the comment:
New changeset ef2152354f03a165c5e3adb53e2276934fabd50a by Andrew Svetlov in
branch 'master':
bpo-37279: Fix asyncio sendfile support when extra data are sent in fallback
mode. (GH-14075)
https://github.com/python/cpython/commit
Change by Andrew Svetlov :
--
resolution: -> third party
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Andrew Svetlov added the comment:
Thanks for the review, Victor!
I have had to fix it much earlier :(
--
___
Python tracker
<https://bugs.python.org/issue35
Andrew Svetlov added the comment:
Finally fixed
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Andrew Svetlov :
--
keywords: +patch
pull_requests: +13939
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/14080
___
Python tracker
<https://bugs.python.org/issu
Andrew Svetlov added the comment:
Duplicate of #35998
--
resolution: -> duplicate
stage: patch review -> resolved
status: open -> closed
superseder: -> test_asyncio: test_start_tls_server_1() TimeoutError on Fedora
29
___
Python tra
Change by Andrew Svetlov :
--
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue37202>
___
___
Python-bugs-list
Andrew Svetlov added the comment:
Welcome!
Thanks for the fix!
--
___
Python tracker
<https://bugs.python.org/issue37278>
___
___
Python-bugs-list mailin
Andrew Svetlov added the comment:
See bpo-32363
--
___
Python tracker
<https://bugs.python.org/issue37281>
___
___
Python-bugs-list mailing list
Unsubscribe:
Andrew Svetlov added the comment:
Maybe. Agree with your decision to close bpo-34520 as duplicate.
--
___
Python tracker
<https://bugs.python.org/issue37
Andrew Svetlov added the comment:
1. Task._fut_waiter is a private API, please avoid it
2. Task class is derived from Future, thus it HAS add_done_callback() method.
The other question is that from my experience if the application-level code
uses add_done_callback() the design is not perfect
Change by Andrew Svetlov :
--
keywords: +patch
pull_requests: +13934
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/14076
___
Python tracker
<https://bugs.python.org/issu
New submission from Andrew Svetlov :
We use thread pool executor for loop.sock_sendfile(), there is no reason to
call blocking code for loop.sendfile()
--
components: asyncio
messages: 345574
nosy: asvetlov, yselivanov
priority: normal
severity: normal
status: open
title: Use
Change by Andrew Svetlov :
--
keywords: +patch
pull_requests: +13933
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/14075
___
Python tracker
<https://bugs.python.org/issu
New submission from Andrew Svetlov :
My fault introduced in 3.7 in initial async sendfile implementation
--
components: asyncio
messages: 345571
nosy: asvetlov, yselivanov
priority: normal
severity: normal
status: open
title: asyncio sendfile sends extra data in the last chunk
Change by Andrew Svetlov :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.9
___
Python tracker
<https://bugs.python.or
New submission from Andrew Svetlov :
Subprocess starting can be a long blocking operation, see
https://github.com/python-trio/trio/issues/1109 for discussion
--
messages: 345472
nosy: asvetlov
priority: normal
severity: normal
status: open
title: spawn asyncio subprocesses in a thread
Andrew Svetlov added the comment:
Lukasz, please don't rush.
Applied PR makes asyncio more stable, not worse.
I see the only way to make it perfect: get rid of weak refs entirely.
Otherwise there is always a chance to catch GC run and set element deletion on
iteration over the set. Sorry
Andrew Svetlov added the comment:
Thank you!
Yuri, you might be interested too
--
___
Python tracker
<https://bugs.python.org/issue37226>
___
___
Python-bug
Change by Andrew Svetlov :
--
resolution: fixed ->
stage: resolved ->
status: closed -> open
___
Python tracker
<https://bugs.python.org/issue36607>
___
___
801 - 900 of 2515 matches
Mail list logo
