Anthony Sottile added the comment:
> Otherwise, why use the system libmpdec at all and not the version
shipped with Python?
the packages are faithful reproductions of upstream packages, deviating from
those introduces surprises for downstreams
> If I install into a venv, I also don
Anthony Sottile added the comment:
I package pythons for ubuntu:
https://github.com/deadsnakes/python3.9-nightly/actions/runs/151286686
https://github.com/deadsnakes/python3.10-nightly/actions/runs/151287821
--
___
Python tracker
<ht
Anthony Sottile added the comment:
reverting this patch passes all the tests, what's the motivation and why were
there no code reviews for this?
--
___
Python tracker
<https://bugs.python.org/issue40
Anthony Sottile added the comment:
especially this late in the beta period for 3.9 -- it would be unfortunate for
3.10 but it's an explicit break of feature freeze for 3.9
--
___
Python tracker
<https://bugs.python.org/issue40
Anthony Sottile added the comment:
this breaks builds for ubuntu, I'd suggest reverting this (especially because
it appears to build fine without this patch)
2020-06-29T08:52:56.8303672Z x86_64-linux-gnu-gcc -pthread -fPIC -Wdate-time
-D_FORTIFY_SOURCE=2 -Wno-unused-result -Wsign-compare
Anthony Sottile added the comment:
Looking into this, it appears to be due to the default value and not due to the
newline
I've stumbled upon two simplifications to the routines in inspect but not a fix
for this
1. https://github.com/python/cpython/pull/21100
2. https://github.com/python
Change by Anthony Sottile :
--
keywords: +patch
nosy: +Anthony Sottile
nosy_count: 3.0 -> 4.0
pull_requests: +20269
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/21066
___
Python tracker
<https://bugs.p
Change by Anthony Sottile :
--
pull_requests: +20265, 20266
pull_request: https://github.com/python/cpython/pull/21098
___
Python tracker
<https://bugs.python.org/issue31
Change by Anthony Sottile :
--
pull_requests: +20265
pull_request: https://github.com/python/cpython/pull/21098
___
Python tracker
<https://bugs.python.org/issue31
Change by Anthony Sottile :
--
pull_requests: +20265, 20266, 20267
pull_request: https://github.com/python/cpython/pull/21098
___
Python tracker
<https://bugs.python.org/issue31
Change by Anthony Sottile :
--
pull_requests: +20264
pull_request: https://github.com/python/cpython/pull/21097
___
Python tracker
<https://bugs.python.org/issue31
Anthony Sottile added the comment:
This appears to have broken pydoc of the select module, I've attached a patch
$ python3.8 -m pydoc select
Traceback (most recent call last):
File "/usr/lib/python3.8/inspect.py", line 2004, in wrap_value
value = eval(s, module_dict)
File
Change by Anthony Sottile :
--
nosy: +Anthony Sottile
nosy_count: 4.0 -> 5.0
pull_requests: +20235
pull_request: https://github.com/python/cpython/pull/21066
___
Python tracker
<https://bugs.python.org/issu
Anthony Sottile added the comment:
pre-commit uses this to do deterministic shuffling, please don't remove this
https://github.com/pre-commit/pre-commit/issues/1479
--
nosy: +Anthony Sottile
___
Python tracker
<https://bugs.python.org/issue40
Anthony Sottile added the comment:
There's current expectation in a lot of linters / code formatters that the
*lineno and *col_offset attributes will be missing if they are not attached to
the node
setting them to None is going to break a lot of those, if possible I'd suggest
going back
Anthony Sottile added the comment:
via
https://github.com/python/cpython/commit/b4d4aef8433da2657c8d80207686124d15d32054
--
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/i
Anthony Sottile added the comment:
@serhiy: this was pretty straightfowrard to fix as you suspected -- would you
be able to review it?
--
___
Python tracker
<https://bugs.python.org/issue40
Anthony Sottile added the comment:
fwiw virtualenv 20.x uses `.pth` now as well to fix some issues with
`venv`-based environments
--
___
Python tracker
<https://bugs.python.org/issue33
Anthony Sottile added the comment:
one way might be to give the groups "unique" names (perhaps hashing the input
string?) ((this is what I attempted to do in a little bit of code which tried
to "backport" (group)*+ and (group)++))
--
no
New submission from Anthony Sottile :
```console
$ ln -s 'import os; os.system("echo hi")' __main__.py
$ ls -al
total 8
drwxr-xr-x 2 asottile asottile 4096 May 5 15:55 .
drwxr-xr-x 3 asottile asottile 4096 May 5 14:50 ..
lrwxrwxrwx 1 asottile asottile 31 May 5 15:55 __main__.py
Change by Anthony Sottile :
--
keywords: +patch
pull_requests: +19225
pull_request: https://github.com/python/cpython/pull/19910
___
Python tracker
<https://bugs.python.org/issue40
New submission from Anthony Sottile :
just spent quite a bit of time debugging this, here's a minimal example:
```bash
# rm -rf a (if you want to reset)
cd /tmp
mkdir -p a/b
echo 'import os; os.chdir("..")' > a/b/c.py
cd a/b
python3 -m cProfile -o log.pstats c.py
ls -al
ls -al ..
New submission from Anthony Sottile :
unclear if this is intentional or not, I noticed this while seeing that
`ast.Subscript.slice` is no longer `Index` / `Slice` / `ExtSlice`
# python3.8
>>> isinstance(ast.Slice(), ast.slice)
True
# python3.9a6
>>> isinstance(ast.Slice()
Anthony Sottile added the comment:
cool, reported there as well!
--
___
Python tracker
<https://bugs.python.org/issue40335>
___
___
Python-bugs-list mailin
Anthony Sottile added the comment:
:waves: -- seeing a lot of failures in pyflakes' testsuite around SyntaxErrors
https://github.com/PyCQA/pyflakes/pull/532
(you can reproduce with `path/to/python -m unittest discover pyflakes` without
needing any dependencies installed)
--
nosy
Anthony Sottile added the comment:
pyflakes's testsuite has many failures under the new parser -- is the
expectation that those will be fixed by 3.9 final?
--
___
Python tracker
<https://bugs.python.org/issue40
Anthony Sottile added the comment:
I would really like to be able to trigger all warnings consistently and
statically without executing the code.
This is useful (for instance) for this simple script which validates the ast:
https://github.com/pre-commit/pre-commit-hooks/blob/master
Anthony Sottile added the comment:
This seems to have regressed again
$ ./python --version --version
Python 3.9.0a5+ (heads/master:503de7149d, Apr 24 2020, 13:34:49)
[GCC 7.5.0]
$ ./python t.py
File "/home/asottile/workspace/cpython/t.py&quo
New submission from Anthony Sottile :
compare the following:
```
if False: 'foo'(1)
```
$ python3.9
Python 3.9.0a5 (default, Mar 23 2020, 23:11:30)
[GCC 7.5.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>
Anthony Sottile added the comment:
The trailing newline was added in 1.5.1
78fc3634cbfd65a6be8abfd1b7fc7cbd0ccbfb39 -- back then `compile(...)` could not
take strings which did not end in newlines
now it can, so it is safe to remove -- I did the same triage on another PR
here: https
Anthony Sottile added the comment:
debian has its own implementation of find_modules which still returns a text
file for PY_SOURCE
changing the type of that io object is the "breaking change" and maybe
shouldn't be backported to python3.8 in a pat
Anthony Sottile added the comment:
actually I said that backwards in the previous message -- it was a text file
and now it's a binary file
--
___
Python tracker
<https://bugs.python.org/issue40
Change by Anthony Sottile :
--
pull_requests: +18965
pull_request: https://github.com/python/cpython/pull/19641
___
Python tracker
<https://bugs.python.org/issue40
Anthony Sottile added the comment:
The failure above is `fp` is now a text file but before it was a binary file.
this causes `fp.read()` + `b'\n'` to fail
I can send a patch -- I don't think the `b'\n'` is necessary any more (as far
as I can tell it used to be there for an old version
Anthony Sottile added the comment:
This is still failing, but now in a different way:
Traceback (most recent call last):
File "../debian/pymindeps.py", line 185, in
main(sys.argv[1:])
File "../debian/pymindeps.py", line 178, in main
mf.run_script(arg)
Change by Anthony Sottile :
--
nosy: +pablogsal
___
Python tracker
<https://bugs.python.org/issue40335>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Anthony Sottile :
this was noticed in pyflakes's testsuite:
https://github.com/PyCQA/pyflakes/pull/532#pullrequestreview-396059622
I've created a small script to reproduce the problem
```
import sys
SRC = b"""\
def foo():
'''
def bar():
Anthony Sottile added the comment:
(additionally, I'm not sure this should be backported to python3.8, especially
with changed behaviour)
--
___
Python tracker
<https://bugs.python.org/issue40
Anthony Sottile added the comment:
I'm admittedly a little unfamiliar with what it does as well -- I'm mostly
repackaging debian sources for deadsnakes. If I'm correct in my assumption, it
is attempting to find a minimal set of modules to package into
`python3-minimal` and ensure
Anthony Sottile added the comment:
This patch has broken debian's builds due to use of modulefinder -- notably the
type of `file_info` changed as a side-effect of this patch and is now causing:
../debian/pymindeps.py:29: DeprecationWarning: the imp module is deprecated in
favour
Anthony Sottile added the comment:
this is still broken even with the latest patch:
https://bugs.python.org/issue40266
--
nosy: +Anthony Sottile
___
Python tracker
<https://bugs.python.org/issue39
Anthony Sottile added the comment:
yes, it is still broken, now with fewer errors:
2020-04-13T15:06:34.7330649Z x86_64-linux-gnu-gcc -pthread -fPIC -Wdate-time
-D_FORTIFY_SOURCE=2 -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3
-Wall -g -fstack-protector -Wformat -Werror=format
New submission from Anthony Sottile :
Haven't yet bisected, but noticed this in the nightly builds I provide for
ubuntu deadsnakes https://github.com/deadsnakes/nightly -- I believe it to be
this patch so I've added to nosy: https://github.com/python/cpython/pull/19082
Both python3.8
Change by Anthony Sottile :
--
nosy: +Anthony Sottile
nosy_count: 6.0 -> 7.0
pull_requests: +18644
pull_request: https://github.com/python/cpython/pull/10021
___
Python tracker
<https://bugs.python.org/issu
Anthony Sottile added the comment:
you are right though, the effect is the same as just using mkdtemp
--
___
Python tracker
<https://bugs.python.org/issue25
Anthony Sottile added the comment:
the differences are api compatibility with context manager protocol and
equivalence with NamedTemporaryFile
NamedTemporaryFile(delete=False) is just `mkstemp` afaict and the api is there
--
___
Python tracker
Anthony Sottile added the comment:
Serhiy's comment provides workarounds but are still (imo) inferior to
supporting this.
I would really like for this api to match that of NamedTemporaryFile which has
the same `delete=...` option
--
___
Python
Anthony Sottile added the comment:
fwiw, astpretty's output looks like the black output:
https://github.com/asottile/astpretty
>>> astpretty.pprint(ast.parse('if x == y: y += 4').body[0])
If(
lineno=1,
col_offset=0,
test=Compare(
lineno=1,
col
Anthony Sottile added the comment:
oh! that's neat, yeah hadn't been following closely enough it seems, good to
hear that the readonly thing is fixed!
--
___
Python tracker
<https://bugs.python.org/issue25
Anthony Sottile added the comment:
one example is here:
https://github.com/pre-commit/pre-commit/blob/bb6f1efe63c168d9393d520bd60e16c991a57059/pre_commit/store.py#L137-L139
where I would want cleanup in the exceptional case
another (related but different) closed-source use case involves
Change by Anthony Sottile :
--
keywords: +patch
pull_requests: +18379
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/19030
___
Python tracker
<https://bugs.python.org/issu
Change by Anthony Sottile :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Anthony Sottile :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Anthony Sottile :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Anthony Sottile added the comment:
I would certainly like to see this, it would eliminate my last few hand rolled
temporary directory contexts
Mauro would you be interested in re-posting this patch as a PR to github? (or
allowing someone else to carry your patch forward?)
--
nosy
Anthony Sottile added the comment:
hit this today unfortunately -- I'm working with some pretty complex (and
nested) `typing.NamedTuple` objects and the lack of caching here results in
quite the slowdown (in my macro benchmarks it's the difference between a render
pass taking 180ms and 25ms
New submission from Anthony Sottile :
This is distilled from a larger example to be small/silly, however this caused
real problems
A script which was intended for python3.6 exactly was written as follows:
```
#!/usr/bin/env python3.6
...
```
when creating a virtualenv with `python3.6 -m
Anthony Sottile added the comment:
sure, it's the standard PATHEXT (basically a fresh vm from modern.ie) -- the
only reason I noticed this is I was reading the source:
https://github.com/python/cpython/blob/5bbac8cbdf140ebce446ea4e7db2b20a5d7b8402/Lib/shutil.py#L1367-L1373
C:\Users\IEUser
Anthony Sottile added the comment:
should I open a new issue for this, or is this an appropriate task to add to
this discussion
shutil.which also doesn't apply `PATHEXT` when the path contains a directory
separator
C:\Users\IEUser\astpretty>venv\Scripts\python --version
Python 3.7.5
Change by Anthony Sottile :
--
nosy: +Anthony Sottile
___
Python tracker
<https://bugs.python.org/issue39236>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Anthony Sottile :
--
keywords: +patch
pull_requests: +17264
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/17837
___
Python tracker
<https://bugs.python.org/issu
New submission from Anthony Sottile :
while fixing bpo-39215, I noticed that there seems to be a place here where
posonlyargs was missed:
https://github.com/python/cpython/blob/7dc72b8d4f2c9d1eed20f314fd6425eab66cbc89/Python/ast_opt.c#L617-L627
not sure if this is intentional or not -- happy
Change by Anthony Sottile :
--
keywords: +patch
pull_requests: +17254
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/17826
___
Python tracker
<https://bugs.python.org/issu
Anthony Sottile added the comment:
this triggers an assertion when run with debug enabled:
$ gdb ./python
GNU gdb (Ubuntu 8.1-0ubuntu3.2) 8.1.0.20180409-git
Copyright (C) 2018 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.h
Anthony Sottile added the comment:
Looks as though annotations are using `LOAD_NAME` when they should probably use
`LOAD_GLOBAL`?
```
$ diff -u <(python3.9 -m dis t2.py | sed
's/0x[a-f0-9]*/0xdeadbeef/g;s/t2\.py/FILENAME/g') <(python3.9 -m dis t3.py |
sed 's/0x[a-f0-9]*/0xdeadbeef/
New submission from Anthony Sottile :
def f():
def g(arg: int, /):
pass
f()
$ python3.9 t2.py
Traceback (most recent call last):
File "/home/asottile/workspace/t2.py", line 5, in
f()
File "/home/asottile/workspace/t2.py", line 2, in f
def g(arg:
Change by Anthony Sottile :
--
keywords: +patch
pull_requests: +17253
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/17825
___
Python tracker
<https://bugs.python.org/issu
New submission from Anthony Sottile :
(I've already got a patch for this, just making the necessary issue)
curses.window.inch is pretty useless for any non-ascii character
--
components: Extension Modules
messages: 359309
nosy: Anthony Sottile
priority: normal
severity: normal
status
Change by Anthony Sottile :
--
pull_requests: +17209
pull_request: https://github.com/python/cpython/pull/17776
___
Python tracker
<https://bugs.python.org/issue37
Change by Anthony Sottile :
--
nosy: +Anthony Sottile
___
Python tracker
<https://bugs.python.org/issue38883>
___
___
Python-bugs-list mailing list
Unsubscribe:
Anthony Sottile added the comment:
I think I'm missing what you're saying, apologies I'm probably confused :(
--
___
Python tracker
<https://bugs.python.org/issue38
Anthony Sottile added the comment:
function objects are immutable though
--
___
Python tracker
<https://bugs.python.org/issue38769>
___
___
Python-bugs-list m
Anthony Sottile added the comment:
:shrugs: it did go through a round of code review but was simply missed -- the
testing bit is fair
there are other such mutable objects in python which do define __hash__ = None
such as list and dict
New submission from Anthony Sottile :
We recently found a bug in one of our codebases that looked ~roughly like this:
class C:
...
def __hash__(self):
return hash((v for k, v in sorted(self.__dict__.items(
which resulted in a production bug
The *intention* was to hash
Anthony Sottile added the comment:
ah, I'll add those too -- I can do that in the current PR
--
___
Python tracker
<https://bugs.python.org/issue38312>
___
___
Anthony Sottile added the comment:
should we backport a documentation change for this? (the deprecatedremoved says
4.0 currently)
--
nosy: +Anthony Sottile
___
Python tracker
<https://bugs.python.org/issue37
Change by Anthony Sottile :
--
keywords: +patch
pull_requests: +16467
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/16938
___
Python tracker
<https://bugs.python.org/issu
Anthony Sottile added the comment:
Try with `sh`:
(it prompts for continuation, I pressed ^D to end it)
$ export F=$'\''
>
>
>
>
> sh: 8: Syntax error: Unterminated quoted string
dollar-sign strings are a `bash` extension, I don't think they're supported by
New submission from Anthony Sottile :
https://linux.die.net/man/3/set_escdelay
https://linux.die.net/man/3/set_tabsize
I'd like to help with this, but I don't even know where to start with
argumentclinic -- any points would be greatly appreciated
presumably I should also add getters
Anthony Sottile added the comment:
https://github.com/python/cpython/pull/6398/files#diff-fb54fd281a2569006594f7edc6ad90f9R744
hmm I assume _PyDict_GetItemId has different reference semantics?
--
___
Python tracker
<https://bugs.python.
Anthony Sottile added the comment:
oops! thanks for the quick fix, I'll double check where I copied this from
since it might have the same bug
--
___
Python tracker
<https://bugs.python.org/issue38
Change by Anthony Sottile :
--
pull_requests: +15320
pull_request: https://github.com/python/cpython/pull/15653
___
Python tracker
<https://bugs.python.org/issue36
Anthony Sottile added the comment:
neat, this looks like a similar api to astpretty:
https://github.com/asottile/astpretty
--
nosy: +Anthony Sottile
___
Python tracker
<https://bugs.python.org/issue37
Anthony Sottile added the comment:
I threw together a flake8 plugin which checks for these usage patterns:
https://github.com/asottile/flake8-2020
| Code | Description |
||-|
| YTT101
Change by Anthony Sottile :
--
nosy: +Anthony Sottile
versions: +Python 3.8, Python 3.9 -Python 3.5
___
Python tracker
<https://bugs.python.org/issue20
Change by Anthony Sottile :
--
keywords: +patch
pull_requests: +15028
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/15308
___
Python tracker
<https://bugs.python.org/issu
Anthony Sottile added the comment:
In case it helps someone else, `insstr` seems to not have this limitation
--
nosy: +Anthony Sottile
___
Python tracker
<https://bugs.python.org/issue8
Anthony Sottile added the comment:
That's actually a good point, I don't think this should land in python3.7 since
it changes outuput -- I'm removing that from the versions (though the bug does
affect every version I have access to)
--
versions: -Python 3.7
Change by Anthony Sottile :
--
keywords: +patch
pull_requests: +14930
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/15201
___
Python tracker
<https://bugs.python.org/issu
New submission from Anthony Sottile :
Here's an example
from difflib import ndiff
def main():
x = '\tx\t=\ty\n\t \t \t^'
y = '\tx\t=\ty\n\t \t \t^\n'
print('\n'.join(
line.rstrip('\n') for line in
ndiff(x.splitlines(True), y.splitlines(True)))
)
if __name__
Anthony Sottile added the comment:
seems unrelated and does the same on older versions of python:
```
$ python3.5 t.py
File "t.py", line 4
^
SyntaxError: EOF while scanning triple-quoted string literal
```
I'd suggest a new issue or findin
Change by Anthony Sottile :
--
pull_requests: +14769
pull_request: https://github.com/python/cpython/pull/15003
___
Python tracker
<https://bugs.python.org/issue37
Anthony Sottile added the comment:
sure! the only other case I could come up with involves multi-line strings and
invalid escape sequences + Werror
let me see if I can fold that in as well
--
___
Python tracker
<https://bugs.python.
Change by Anthony Sottile :
--
keywords: +patch
pull_requests: +14754
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/14986
___
Python tracker
<https://bugs.python.org/issu
New submission from Anthony Sottile :
For example:
curses.unget_wch(b'x')
TypeError: expect bytes or str of length 1, or int, got bytes
--
components: Extension Modules
messages: 348570
nosy: Anthony Sottile
priority: normal
severity: normal
status: open
title: Incorrect error
Change by Anthony Sottile :
--
nosy: +Anthony Sottile
___
Python tracker
<https://bugs.python.org/issue37636>
___
___
Python-bugs-list mailing list
Unsubscribe:
Anthony Sottile added the comment:
disregard, this appears to be due to debian's patching
--
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/i
New submission from Anthony Sottile :
In an effort to try and fix some of the ecosystem before python3.10 (or 4.0) is
a thing, I figured I'd set up a build where the version is bumped and see
what's broken.
If you're interested in reproducing my findings, I've included a build that's
New submission from Anthony Sottile :
In an effort to try and fix some of the ecosystem before python3.10 (or 4.0) is
a thing, I figured I'd set up a build where the version is bumped and see
what's broken.
If you're interested in reproducing my findings, I've included a build that's
Anthony Sottile added the comment:
yes, as was the original PR
--
___
Python tracker
<https://bugs.python.org/issue35605>
___
___
Python-bugs-list mailin
101 - 200 of 403 matches
Mail list logo
