[issue44934] Windows installer: Append Python to PATH instead of prepending it

2021-08-23 Thread Bastian Neuburger
Bastian Neuburger added the comment: Update: .NET 3.5 installation worked out fine via VS 2019 installer, I also added the VS2017 build tools as a precaution since the VM builds take some time. Afterwards build.bat still failed during wix steps, complaining about missing python.exe

[issue44934] Windows installer: Append Python to PATH instead of prepending it

2021-08-23 Thread Bastian Neuburger
Bastian Neuburger added the comment: Ah ok. Do you know if VS 2019 will do the job at all? I encountered a few (unrelated) projects on github that state they will only build with VS 2017. I will install .NET 3.5 via the VS 2019 installer (should do the trick, right?) and see how it turns

[issue44934] Windows installer: Append Python to PATH instead of prepending it

2021-08-23 Thread Bastian Neuburger
Bastian Neuburger added the comment: Attached is the full output of: - msbuild.exe -version - get_externals.bat - build.bat For the first few build tasks there are git related errors, which make sense since I ran the build from a downloaded zip release of the source instead of a git clone

[issue44934] Windows installer: Append Python to PATH instead of prepending it

2021-08-22 Thread Bastian Neuburger
Bastian Neuburger added the comment: Steve, I signed the CLA and created the PR, I don't know how long it takes until the info that the CLA is signed is propagated to bpo or github. Regarding failed builds: I will try to build again tomorrow when back at the office and can copy the errors

[issue44934] Windows installer: Append Python to PATH instead of prepending it

2021-08-22 Thread Bastian Neuburger
Change by Bastian Neuburger : -- keywords: +patch pull_requests: +26343 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/27889 ___ Python tracker <https://bugs.python.org/issu

[issue44934] Windows installer: Append Python to PATH instead of prepending it

2021-08-20 Thread Bastian Neuburger
Bastian Neuburger added the comment: Previous URL got "fixed" by roundup, hopefully this one works: https://github.com/python/cpython/compare/16b9be4861e007ad483611ba0479feb2b90ea783...bneuburg:issue44934 -- ___ Python track

[issue44934] Windows installer: Append Python to PATH instead of prepending it

2021-08-20 Thread Bastian Neuburger
Bastian Neuburger added the comment: Maybe this view better shows what I've actually done: https://github.com/python/cpython/compare/16b9be4861e007ad483611ba0479feb2b90ea783...bneuburg:issue44934?expand=1 -- ___ Python tracker <ht

[issue44934] Windows installer: Append Python to PATH instead of prepending it

2021-08-20 Thread Bastian Neuburger
Bastian Neuburger added the comment: Thanks for the rundown, after digging a little bit into the abyss that is the WIX toolset if you've never dealt with it before I already started going down that route. I pushed it to my fork of cpython: https://github.com/bneuburg/cpython/commits

[issue44934] Windows installer: Append Python to PATH instead of prepending it

2021-08-20 Thread Bastian Neuburger
Bastian Neuburger added the comment: Hi Steve, Of course there are various reasons for having multiple Python versions on a developer workstation but I would assume that the majority of Windows installer users simple want to run Python projects, at least this holds true for the majority

[issue44934] Windows installer: Append Python to PATH instead of prepending it

2021-08-17 Thread Bastian Neuburger
New submission from Bastian Neuburger : Hi there, in our organization Python 3.9 is installed on Windows with the PrependPath option; as expected the Install and Scripts directories are prepended to path. However if there are Python scripts with the same name as a system command (e.g