Change by Chris Angelico :
--
keywords: +patch
nosy: +Rosuav
nosy_count: 5.0 -> 6.0
pull_requests: +23797
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/25045
___
Python tracker
<https://bugs.python.org/i
Chris Angelico added the comment:
Can confirm. This changed in bpo-38038 and the fix isn't too difficult.
Adding 3.10 in case it's decided that this shouldn't be patched onto 3.9.
--
versions: +Python 3.10
___
Python tracker
<ht
Change by Chris Angelico :
--
keywords: +patch
nosy: +Rosuav
nosy_count: 3.0 -> 4.0
pull_requests: +23793
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/25045
___
Python tracker
<https://bugs.python.org/i
Chris Angelico added the comment:
That ducks the immediate issue, but I think the underlying issue would still be
worth solving. How hard would it be to fetch this via an encrypted connection?
It's still not 100% secure, but it would be resilient against some of these
sorts of issues
Chris Angelico added the comment:
Has this been ongoing, or is it something that started in the past day and a
half? I've had intermittent internet issues (and expect them to continue for
another half day or thereabouts), so it's possible that this is actually a
symptom of that.
If that's
Change by Chris Angelico :
--
pull_requests: +13196
___
Python tracker
<https://bugs.python.org/issue32893>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Chris Angelico :
--
pull_requests: +13077
___
Python tracker
<https://bugs.python.org/issue35224>
___
___
Python-bugs-list mailing list
Unsubscribe:
Chris Angelico added the comment:
BTW, sorry for sounding a bit snippy in my comment. Jonathan, in future, rather
than dropping someone an email, it'd be more normal to just ping the person on
the issue itself.
--
___
Python tracker
<ht
Chris Angelico added the comment:
Yes, the PEP says version 3.8. Why is this a problem? Sit tight, let the
implementation land. I don't understand why this needed me to get emailed
saying that the PEP has the wrong version number in it.
--
nosy: +Rosuav
Chris Angelico <ros...@gmail.com> added the comment:
(BTW, by "proposed" I mean that the change that I describe is in the PR.)
--
___
Python tracker <rep...@bugs.python.org>
<https://b
Chris Angelico <ros...@gmail.com> added the comment:
Actually, it's a bit more complicated than I thought. Current proposed
solution: Track the context of each conversion, thus allowing different errors
to be distinguished.
--
___
Python t
Chris Angelico <ros...@gmail.com> added the comment:
Hmm, I think I see what I broke there. It was part of the merge conflict
resolution - I moved the check into the function, which is actually incorrect.
It wasn't misleading like that in the original patch. Wi
Change by Chris Angelico <ros...@gmail.com>:
--
keywords: +patch
pull_requests: +5558
stage: -> patch review
___
Python tracker <rep...@bugs.python.org>
<https://bugs.pyt
New submission from Chris Angelico <ros...@gmail.com>:
When a non-literal is given to literal_eval, attempt to be more
helpful with the message, rather than calling it 'malformed'.
--
components: Library (Lib)
messages: 312423
nosy: Rosuav
priority: normal
pull_requests:
se
Chris Angelico <ros...@gmail.com> added the comment:
Thanks for handling that Terry. I take it the PR isn't needed now?
I would have done it, but I'm on the way to the US (literally posting this from
the airport), and hadn't gotten to looking at this in the in
Changes by Chris Angelico <ros...@gmail.com>:
--
nosy: +Rosuav
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29929>
___
__
Chris Angelico added the comment:
Also working for me. Thanks!
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue27322>
___
___
Pyth
Chris Angelico added the comment:
I'm not sure. The patch got backed out with little explanation, so presumably
it broke something somewhere, but I don't know what.
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
New submission from Chris Angelico:
Discussion on python-ideas led to a firm ruling by Guido that enum members are
functionally equivalent to constants, and should thus be named in upper-case.
This is contrary to the current documentation. Solution? Change the docs.
--
assignee: docs
Chris Angelico added the comment:
Huh. Yeah, that would work really nicely. Thanks Christian!
Does this count as a bugfix? I think we've missed 3.6 feature freeze.
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Chris Angelico added the comment:
Thanks Brett! Sounds like a plan.
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue27080>
___
___
Chris Angelico added the comment:
Just ran into the same issue, but in a slightly different way, and with
slightly different consequences. You can actually eliminate this failure by
manually running compileall on the affected directory:
sudo python3 -m compileall /usr/local/lib/python3.6/site
Chris Angelico added the comment:
Another couple of tests, per comments.
--
Added file: http://bugs.python.org/file44425/moar-tests.patch
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
New submission from Chris Angelico:
Having matplotlib installed globally causes test_site to fail, due to the .pth
file importing types. The point of the test is to monitor startup dependencies
(and thus time) for the core interpreter and standard library, not third-party
libraries, so having
Changes by Chris Angelico <ros...@gmail.com>:
--
keywords: +patch
Added file: http://bugs.python.org/file44158/no-site-packages-in-test.patch
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
Chris Angelico added the comment:
Hmm, strange. Comma formatting never seems to have had tests added. So I've
added a couple of simple tests of comma formatting at the same time as adding
underscore formatting tests. Also, test_long.py currently has a comment "#
octal" precedi
Chris Angelico added the comment:
Hmm, adding bin/oct/hex support didn't turn out that hard. Although it feels
like this code is getting hackish. Definitely needs code review!
--
Added file: http://bugs.python.org/file44153/underscores_all_bases.patch
Changes by Chris Angelico <ros...@gmail.com>:
--
nosy: +Rosuav
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue27080>
___
__
Chris Angelico added the comment:
Here's a first-cut patch. No docs, no tests, and applies only to decimal
formatting. It involves redefining the thousands_separators flag from being a
boolean to being a three-state flag (none, comma, or underscore), and (ab)uses
LT_*_LOCALE to carry
Changes by Chris Angelico <ros...@gmail.com>:
--
nosy: +Rosuav
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue27587>
___
__
Chris Angelico added the comment:
Cool cool! Then someone will need to notify the PVS-Studio people that we've
fixed the two bugs that are actually our bugs :)
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Chris Angelico added the comment:
Berker, I don't push code to CPython (I have the commitbit for PEP editing), so
do you want to push that?
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
New submission from Chris Angelico:
Originally reported (if you can call it "reported") here:
http://www.viva64.com/en/b/0414/
AFAICT, this is an easy and inconsequential fix.
--
files: uninitialized-pointer.patch
keywords: patch
messages: 270991
nosy: Rosuav
priority: norma
Chris Angelico added the comment:
Attached is a combined patch that has the new private function for
IsIdentifier, method 4's error handling change, and a bit of glue in the middle
to make use of it. The result is a passing test suite (bar test_site which was
already failing on my system
Chris Angelico added the comment:
Hmm, that'd be curious. The code to do that is actually pretty simple - see
attached patch - but actually using that to affect error messages is a bit
harder. Is it safe to mess with tok->start?
--
Added file:
http://bugs.python.org/file43818/wh
Chris Angelico added the comment:
BTW, here's how a session looks using method 4's change:
>>> varname = asdf“d“a”t”apoint
File "", line 1
varname = asdf“d“a”t”apoint
^
SyntaxError: invalid character in identifier
>>> varname = asdf“d“a”t”apoin
Changes by Chris Angelico <ros...@gmail.com>:
Added file: http://bugs.python.org/file43813/method3-change-all-errors.patch
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
Changes by Chris Angelico <ros...@gmail.com>:
Added file: http://bugs.python.org/file43812/method2-change-cur-and-inp.patch
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
Changes by Chris Angelico <ros...@gmail.com>:
Added file:
http://bugs.python.org/file43814/method4-change-all-errors-if-possible.patch
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
Chris Angelico added the comment:
Actually pinpointing the invalid character may be impractical, as there are two
boolean situations: either a UnicodeDecodeError (because you had an invalid
UTF-8 stream), or PyUnicode_IsIdentifier returns false. Either way, it applies
to the whole identifier
Chris Angelico added the comment:
The question was raised that there might be a problem with (UTF-8) bytes vs
characters, but that's definitely not it - pythonrun.c:1362 UTF-8-decodes the
line of source and then gets its character length to use as the new offset. So
I don't think
Changes by Chris Angelico <ros...@gmail.com>:
--
nosy: +Rosuav
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue27582>
___
__
Chris Angelico added the comment:
By "doesn't keep track of call chains", you mean that it can't handle
mutually-recursive functions, right?
Still useful.
--
nosy: +Rosuav
___
Python tracker <rep...@bugs.python.org>
<htt
Changes by Chris Angelico <ros...@gmail.com>:
--
nosy: +Rosuav
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue26805>
___
__
Chris Angelico added the comment:
Typo fixed in peps repo.
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue26763>
___
___
Pyth
Changes by Chris Angelico <ros...@gmail.com>:
--
nosy: +Rosuav
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue26763>
___
__
Chris Angelico added the comment:
The remaining difference that's actually of use, perhaps. But the decoration
itself happens before the name is bound. It's impossible to describe in Python
code; but it can be probed - you can monkeypatch a class using a decorator:
def monkeypatch(cls
Chris Angelico added the comment:
I may be a committer, but I don't push to cpython - just to the peps. But sure,
pretty little logo :)
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
New submission from Chris Angelico:
The official documentation declares an unambiguous equivalence which is not
true in some corner cases:
@deco
def f(x): pass
is not quite the same as
def f(x): pass
f = deco(f)
as the name is never bound to the undecorated function
Chris Angelico added the comment:
Sure - changing it to "roughly". I started with that wording, and then changed
to "broadly", for reasons which I now can't remember - so they can't have been
too important. Consistency wins.
--
Added file: http://bugs.pytho
Chris Angelico added the comment:
Sounds good to me. Replacement patch.
--
Added file: http://bugs.python.org/file42182/deco-docos.patch
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Chris Angelico added the comment:
Question: Is it worth having an explanation somewhere of exactly what *does*
happen? To what extent is it guaranteed by the language?
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Chris Angelico added the comment:
Opened https://github.com/python/asyncio/pull/322
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Chris Angelico added the comment:
Wording changed, and a simple test added. I'm currently seeing failures in
test_site, but that probably means I've messed something up on my system.
--
Added file: http://bugs.python.org/file41986/no_stop_iter.patch
Chris Angelico added the comment:
How about "StopException interacts badly with generators and cannot be raised
into a Future"?
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.py
Chris Angelico added the comment:
POC patch, no tests. Is TypeError right? Should it be ValueError, since the
notional type is "Exception"?
--
keywords: +patch
Added file: http://bugs.python.org/file41980/no_stop_iter.patch
___
Python tr
Chris Angelico added the comment:
Ultimately, it's the exact same thing that PEP 479 is meant to deal with -
raising StopIteration is functionally identical to returning. I don't use
asyncio enough to be certain, but I'm not aware of any good reason to inject a
StopIteration into it; maybe
Chris Angelico added the comment:
If someone made a new way of importing and had it raise ValueError on some
issue or other, I think there'd be complete consensus that that's the wrong
exception. Yes, this is incompatible with Python 2 - but there are a lot of
corner cases in the 3.3+ import
Chris Angelico added the comment:
LGTM. I'm currently seeing failures in test_ssl, but they weren't introduced by
this patch. I'll run with this patch and see if I run into any third party test
failures.
+1 on the change.
--
nosy: +Rosuav
Chris Angelico added the comment:
Whoops! Meant to include that as a second attachment. Now attached.
It's a quickly-thrown-together thing and not fully PEP 8 compliant.
--
Added file: http://bugs.python.org/file41346/nonascii.py
___
Python tracker
Chris Angelico added the comment:
There are non-ASCII dashes and apostrophes in .rst files; are they worth
cleaning up?
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Chris Angelico added the comment:
Oops, didn't see Victor's comment. (How do I get notified when someone posts a
patch review?) New patch uploaded which does this.
Note that Steven D'Aprano has expressed the opposite desire - that non-ASCII
text be kept, as it should be acceptable and its
Chris Angelico added the comment:
Misc/NEWS has a UTF-8 BOM. Otherwise, it and Misc/HISTORY look fine (all names
and other legit cases). Lib/idlelib/CREDITS.txt and Lib/idlelib/README.txt both
have non-UTF8 text in them. I don't understand what's with the first line of
.bzrignore, so I'm (pun
Chris Angelico added the comment:
Another version of detection script attached.
--
Added file: http://bugs.python.org/file41350/nonascii.py
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Chris Angelico added the comment:
As an alternative to checking only *.py, the second version uses the 'file'
command to recognize text files. Run from the cpython top-level directory
(rather than Lib/), it finds a large number of additional results, many of
which appear to have a UTF-8 BOM
Chris Angelico added the comment:
So Lib/idlelib/README.txt would decode wrongly in anything other than a Windows
codepage? Seems a good reason to asciify line 3.
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Chris Angelico added the comment:
Ah, got it. That definitely settles Idle's CREDITS.txt. Are there any locale
encodings where \x92 isn't an apostrophe?
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Chris Angelico added the comment:
The trouble with that example is that the semantics aren't the same. The
isinstance check will also be true for subclasses of int (for instance,
isinstance(True,int) is True), but the equality check will catch only exact
matches. And that's even before
New submission from Chris Angelico:
Discussion on python-list led to searching out unnecessary non-ASCII in the
stdlib. While there are places where non-ASCII text is good and worthwhile (eg
in comments identifying people such as Łukasz Langa, Peter Åstrand, Martin v.
Löwis, and Gerhard
Changes by Chris Angelico <ros...@gmail.com>:
--
nosy: +Rosuav
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue25446>
___
__
Chris Angelico added the comment:
Fair enough. Still needs someone to update the patch though.
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/
Chris Angelico added the comment:
Nudging this as a forgotten patch. Is anyone at all interested in this, or
should it be closed as not worth the hassle? The patch is ancient and doesn't
apply to 3.6.
Propose closing, to clean up the tracker. It can always be reopened if the
patch is updated
New submission from Chris Angelico:
See: https://mail.python.org/pipermail/python-list/2015-October/697818.html
Saying "In Python 2.2" is not helpful in the 3.x docs. Even in the 2.x docs,
it's pretty safe to assume by now that everyone's on 2.2+. (At very least,
"Since"
Chris Angelico added the comment:
Any other interest in this? It'd be nice to get this in trunk and start being
able to recommend it to people.
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Chris Angelico added the comment:
"bytes of binary data" seems redundant - how about just "byte string"?
Otherwise, sure.
--
nosy: +Rosuav
___
Python tracker <rep...@bugs.python.org>
<http
Chris Angelico added the comment:
3.6 doesn't have this check, so I would say that yes, this has indeed been
fixed. Issue can be closed fixed.
--
nosy: +Rosuav
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
New submission from Chris Angelico:
The grammar of the IMPORTANT NOTICE on the select module and the select.select
function wants a comma, I think. Patch attached.
--
assignee: docs@python
components: Documentation
files: add_comma.patch
keywords: patch
messages: 252750
nosy: Rosuav
Chris Angelico added the comment:
Patch applies cleanly to 3.6 and doesn't appear to add any new test failures
(3.6 currently has a couple). Needs its own test, though.
--
nosy: +Rosuav
versions: +Python 3.6 -Python 3.5
___
Python tracker <
Chris Angelico added the comment:
Has this been entirely superseded by Argument Clinic?
--
nosy: +Rosuav
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Chris Angelico added the comment:
+1 for anything that makes Python faster with provably no semantic changes.
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Chris Angelico added the comment:
Or at very least, can fallthrough be used in the switch block, so there aren't
7+6+5+4+3+2+1 copies of the same line?
-- Not a C performance expert --
--
___
Python tracker <rep...@bugs.python.org>
Chris Angelico added the comment:
This sounds like a feature enhancement, which means it (almost certainly) won't
be applied to Python 2.7. Does the same question come up in Python 3?
Also (FWIW) if you can confidently assume that all the keys are strings. then
type.lower() is better than
Chris Angelico added the comment:
ISTM this is a case where Python's core shouldn't be using assert. It's
possible for userland code to trigger an assertion failure, which means it
should be a regular if(..) raise. Patch attached.
@haypo, what do you mean by "fuzzing"? Is there some
Chris Angelico added the comment:
Oops, forgot to add a test. Using a variant of poc_getaddr.py to construct
something which fails on current CPython tip, and passes with the patch.
--
Added file: http://bugs.python.org/file40435/dont_assert_with_test.patch
Chris Angelico added the comment:
Ah. It's one of *those* bugs. Got it.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24707
___
___
Python-bugs
Chris Angelico added the comment:
The host is running Debian Jessie (newer than the Debian Wheezy of the VM).
Linux sikorsky 3.16.0-4-amd64 #1 SMP Debian 3.16.7-ckt9-3~deb8u1 (2015-04-24)
x86_64 GNU/Linux
What info are you after re hardware virtualization?
VirtualBox 4.3.28 r100309 manages
Chris Angelico added the comment:
Interestingly, the 2.7 docs have this correct already.
https://docs.python.org/2.7/reference/expressions.html#id23
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24610
New submission from Chris Angelico:
https://docs.python.org/3/reference/expressions.html#id18
The string \u0327\u0043 does not normalize to the same string as \u00C7, as
combining characters are supposed to _follow_ the base character. (Some
consoles may happen to display them the same way
Chris Angelico added the comment:
Another good option is read/write without the 'fd' suffix. Either works, I'd
prefer the shorter one but by a small margin.
--
nosy: +Rosuav
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24536
New submission from Chris Angelico:
Grammar/Grammar points to PEP 306, which points instead to the dev guide. The
exact link is not provided, but it'd be useful to skip the PEP altogether and
just link to https://docs.python.org/devguide/grammar.html in the file.
--
messages: 245180
Chris Angelico added the comment:
Weird. Tests ran fine on my machine too. Interestingly, that number is
0xdbdbdbdbdbdbdbda - does that mean anything? (It's negative
0x2424242424242426, for what that's worth.)
--
___
Python tracker rep
Chris Angelico added the comment:
Thanks everyone for all the help getting this to land! This is going to be a
part of my active python3 binary from now on :)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22906
Chris Angelico added the comment:
The comment was general because I honestly had no idea what was needed still.
All I knew was that the patch seemed to work for me, all tests passing
(including the new one). Thanks for uploading the new patch; it compiles
happily, and I'm running tests now
Chris Angelico added the comment:
You sure can! Take it, deploy it, run the test suite, and then start writing
real code that uses it. When you find a problem, that's what needs help! :)
--
___
Python tracker rep...@bugs.python.org
http
Chris Angelico added the comment:
Stinner, not sure what you mean by first part / second part. Is there a way for
me to withdraw the first two versions of the patch and just keep #37646?
--
___
Python tracker rep...@bugs.python.org
http
Chris Angelico added the comment:
Had a peek at the 2.7 branch in the web
(https://hg.python.org/cpython/file/4234b0dd2a54/Lib/test) and all the tests
appear to be testing the behaviour *with* the future directive, not bothering
to test the old behaviour. It makes sense - that way, when
Chris Angelico added the comment:
Got around to tracking down where this is actually being done. It's in
Objects/stringlib/codecs.h and it looks to be a hot area for optimization. I
don't want to fiddle with it without knowing a lot about the performance
implications (UTF-8 encode/decode
Chris Angelico added the comment:
Simple test case for the future directive. Needs expansion.
--
Added file: http://bugs.python.org/file39079/test_pep479.py
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22906
Chris Angelico added the comment:
Nice document. Is that actually how Python's decoder checks things? Does the
decoder have different definitions of valid continuation byte based on the
lead byte? If that's the case... well, ten out of ten for complying with the
spec, to be sure
New submission from Chris Angelico:
b\xed\xb4\x80.decode(utf-8)
Traceback (most recent call last):
File stdin, line 1, in module
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xed in position
0: invalid continuation byte
The actual problem here is that this byte sequence would decode
1 - 100 of 152 matches
Mail list logo
