Dustin J. Mitchell added the comment:
If the patch still applies cleanly, I have no issues with you or anyone opening
a PR. I picked this up several years ago at the PyCon sprints, and don't
remember a thing about it, nor have I touched any other bit of the CPython
source since then. So any
New submission from Dustin J. Mitchell:
Reproduction:
# main.py
import foo.bar
# foo/__init__.py
# (empty)
# foo/bar/__init__.py
import foo.bar.bing as bing
# foo/bar/bing.py
# (empty)
Result:
dustin@euclid ~/tmp $ python3.3 main.py
Traceback (most recent call last):
File main.py, line
Dustin J. Mitchell added the comment:
This seems to have stalled out after the PyCon sprints. Any chance the final
patch can be reviewed?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3353
Dustin J. Mitchell added the comment:
From my read of this bug, there are two distinct tasks mentioned:
1. make PyTokenizer_* part of the Python-level API
2. re-implement 'tokenize' in terms of that Python-level API
#1 is largely complete in Andrew's latest patch, but that will likely need
Dustin J. Mitchell added the comment:
New:
- rename token symbols in token.h with a PYTOK_ prefix
- include an example of using the PyTokenizer functions
- address minor review comments
--
Added file: http://bugs.python.org/file38999/issue3353-2.patch
Dustin J. Mitchell added the comment:
Here's an updated patch for #1:
Existing Patch:
- move tokenizer.h from Parser/ to Include/
- Add PyAPI_Func to export tokenizer functions
New:
- Removed unused, undefined PyTokenizer_RestoreEncoding
- Include PyTokenizer_State with limited ABI
Dustin J. Mitchell added the comment:
This fixes the four cases Nick referred to, although not in the functions
expected:
- str.encode no longer exists
- unicode.decode no longer exists
- encoders used by str.encode must return bytes (does not apply to
codecs.encode)
- decoders used
Dustin J. Mitchell [EMAIL PROTECTED] added the comment:
Thoughts on this patch?
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1187
___
___
Python-bugs-list
Dustin J. Mitchell [EMAIL PROTECTED] added the comment:
Hmm.. I see why you didn't write a unit test for this!
Attached is a patch with a unit test that tickles this behavior, along
with Andrew's fix.
Added file: http://bugs.python.org/file10338/1187-dustin.patch
Dustin J. Mitchell [EMAIL PROTECTED] added the comment:
Patch attached.
--
keywords: +patch
Added file: http://bugs.python.org/file10258/1625509.patch
_
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1625509
Dustin J. Mitchell [EMAIL PROTECTED] added the comment:
While it is a sensible fix for the signed/unsigned problem, David's patch
still fails regrtest on my system (amd64), after OOM-killing random other
processes :(
Andrew's suggestion makes a lot of sense here. Does it make sense
Dustin J. Mitchell [EMAIL PROTECTED] added the comment:
This test passes -- is this ready to commit?
I see a reduction from 1.9s to 1.5s for the test script in msg59715.
--
nosy: +djmitche
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1792
Dustin J. Mitchell [EMAIL PROTECTED] added the comment:
Improved fix; this passes test_file on my system.
--
keywords: +patch
Added file: http://bugs.python.org/file10266/1174606.patch
_
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1174606
Dustin J. Mitchell [EMAIL PROTECTED] added the comment:
I see that, on running your fix_fileno.py, nothing is output to
/tmp/stdout.test. I don't necessarily see the link to your fix. Could
you describe the problem and/or add comments to your patch to explain why
these checks are made
Dustin J. Mitchell [EMAIL PROTECTED] added the comment:
Ack, sorry. My 'vi' settings should now be correct.
Added file: http://bugs.python.org/file10274/1174606-3.patch
_
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1174606
15 matches
Mail list logo
