Gerhard Häring added the comment:
Isn't this issue at least partly about the statement parsing code in the sqlite
module?
I've fixed this upstream a while ago in
https://github.com/ghaering/pysqlite/commit/94eae5002967a51782f36ce9b7b81bba5b4379db
Could somebody perhaps bring
Gerhard Häring added the comment:
I'm -1 because I believe that ultimately, adapters and converters were a
mistake to add to pysqlite. That's why I deprecated them in pysqlite 2.8.0.
Do you know what would be the correct step to propose a deprecation in the
sqlite3 module of Python proper
Gerhard Häring added the comment:
I propose to also set the SQLite extended error code if this is implemented.
What's the reasoning behind offering a error code to name mapping? This seem
problematic to me. In case a newer SQLite version introduces a new error code,
this error code cannot
Gerhard Häring added the comment:
http://bugs.python.org/issue20463 is related.
--
assignee: - ghaering
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16885
Gerhard Häring added the comment:
This wiki page is out of date. It appears that SQlite is now threadsafe by
default: http://www.sqlite.org/threadsafe.html
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3783
Gerhard Häring added the comment:
Please note that after the mentioned commit, I restored backwards compatibility
with commit
https://github.com/ghaering/pysqlite/commit/796b3afe38cfdac5d7d5ec260826b0a596554631
Now the only difference is that the implicit commits *before* DDL statements
Gerhard Häring added the comment:
I'm +1 on deprecating the connection manager
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16958
Gerhard Häring added the comment:
apsw contains code that handles the issues with dumping SQLite databases very
well. I plan to integrate this code into pysqlite. We can then later port the
fix to the sqlite3 module.
See https://github.com/ghaering/pysqlite/issues/10 for the tasks and
https
Gerhard Häring added the comment:
There is no guarantee that all any column in a SQlite resultset always has the
same type. That's why I decided to err on the side of setting the type code to
undefined.
Closing as wontfix.
--
resolution: - wont fix
status: open - closed
Gerhard Häring added the comment:
It requires switch to the v2 open function of the SQLite C API. While we're at
it, we can also enable URI filenames.
--
assignee: - ghaering
nosy: +ghaering
versions: +Python 3.6 -Python 3.4
___
Python tracker rep
Gerhard Häring added the comment:
I'm -1 on adding timezone to the adapters.
--
assignee: - ghaering
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19065
Changes by Gerhard Häring g...@ghaering.de:
--
assignee: - ghaering
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16379
___
___
Python-bugs-list
Changes by Gerhard Häring g...@ghaering.de:
--
assignee: - ghaering
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21250
___
___
Python-bugs-list
Changes by Gerhard Häring g...@ghaering.de:
--
assignee: - ghaering
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16864
___
___
Python-bugs-list
Gerhard Häring added the comment:
The externally maintained version of the sqlite3 module has now been switched
to the v2 statement API. pysqlite is for Python 2.7 only. I'd suggest to
revisit this for Python 3.6 and then try to port most fixes from pysqlite to
the sqlite3 module
Changes by Gerhard Häring g...@ghaering.de:
--
assignee: - ghaering
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13299
___
___
Python-bugs-list
Changes by Gerhard Häring g...@ghaering.de:
--
assignee: - ghaering
nosy: +ghaering
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20587
Changes by Gerhard Häring g...@ghaering.de:
--
assignee: - ghaering
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10740
___
___
Python-bugs-list
Changes by Gerhard Häring g...@ghaering.de:
--
assignee: - ghaering
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20463
___
___
Python-bugs-list
Changes by Gerhard Häring g...@ghaering.de:
--
assignee: docs@python - ghaering
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11691
___
___
Python
Changes by Gerhard Häring g...@ghaering.de:
--
assignee: - ghaering
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9924
___
___
Python-bugs-list
Changes by Gerhard Häring g...@ghaering.de:
--
assignee: - ghaering
nosy: +ghaering
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20274
Changes by Gerhard Häring g...@ghaering.de:
--
assignee: - ghaering
nosy: +ghaering
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20562
Changes by Gerhard Häring g...@ghaering.de:
--
assignee: - ghaering
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16958
___
___
Python-bugs-list
Changes by Gerhard Häring g...@ghaering.de:
--
assignee: - ghaering
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21465
___
___
Python-bugs-list
Changes by Gerhard Häring g...@ghaering.de:
--
assignee: - ghaering
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13583
___
___
Python-bugs-list
Changes by Gerhard Häring g...@ghaering.de:
--
assignee: - ghaering
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21836
___
___
Python-bugs-list
Gerhard Häring added the comment:
ok, i will have to look into this
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9303
___
___
Python-bugs-list
Gerhard Häring added the comment:
The low-hanging fruit of executemany() reusing the prepared statement is of
course taken. Also, there is a statement cache that is being used transparently.
I am against exposing the statement directly via the API.
--
assignee: - ghaering
nosy
Gerhard Häring added the comment:
I have now committed a fix in the pysqlite project at github.
https://github.com/ghaering/pysqlite/commit/f67fa9c898a4713850e16934046f0fe2cba8c44c
I'll eventually merge it into the Python tree.
--
assignee: - ghaering
nosy: +ghaering
Gerhard Häring added the comment:
Reusing the apsw connection in the sqlite3 module was deprecated a long time
ago. It is simply not supported, even if there is still code left in the module
that supports this somewhat.
This code should then be removed.
This closing as wontfix
Gerhard Häring added the comment:
The sqlite3 module is not at fault here. If it does not work, then is is a
restriction of SQLite3 - at which places it accepts bind parameters.
This closing as not a bug.
--
assignee: - ghaering
resolution: - not a bug
status: open - closed
Gerhard Häring g...@ghaering.de added the comment:
SQLite's columns aren't typed, only SQLite values are. So it's entirely
possible for the same column to have different types, like the NULL type, the
INTEGER type and the TEXT type.
It's thus impossible to give meaningful type information
Gerhard Häring g...@ghaering.de added the comment:
Without SQLITE_OMIT_LOAD_EXTENSION, builds will break on Mac OS X 10.5 and 10.6
and maybe other platforms.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10020
Gerhard Häring g...@ghaering.de added the comment:
Fixed in r85208 by adding a note to the docs.
--
resolution: - fixed
status: open - pending
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10020
Gerhard Häring g...@ghaering.de added the comment:
Yes Mike. Avoiding unnecessary locks was exactly the reason for this behaviour.
I agree that for serializable transactions I'd need to make some changes.
--
___
Python tracker rep...@bugs.python.org
Changes by Gerhard Häring g...@ghaering.de:
--
assignee: - ghaering
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9750
___
___
Python-bugs-list
Gerhard Häring g...@ghaering.de added the comment:
Wow! That's great!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6683
___
___
Python-bugs
Gerhard Häring g...@ghaering.de added the comment:
Fixed in r83747.
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3854
Gerhard Häring g...@ghaering.de added the comment:
PEP 0249 says that the module's Warning class must be a subclass of
StandardError. So I reject your proposed change.
There are only two cases where pysqlite raises Warning, and these could be
changed to ProgrammerError anyway
Gerhard Häring g...@ghaering.de added the comment:
Fixed in r83742. I implemented this without a test case, because if we wait for
a test case for this, we can wait forever (would need a SMTP server
implementation in Python for the various auth methods
Gerhard Häring g...@ghaering.de added the comment:
There is too little value changing the paramstyle attribute. I think the
documentation clearly states that both parameter binding methods are supported.
--
resolution: - rejected
status: open - closed
Changes by Gerhard Häring g...@ghaering.de:
--
nosy: -ghaering
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4032
___
___
Python-bugs-list
Changes by Gerhard Häring g...@ghaering.de:
--
nosy: -ghaering
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue588756
___
___
Python-bugs-list
Gerhard Häring g...@ghaering.de added the comment:
Yes, the sqlite module uses the old API, and is written to work with older
SQLite releases and their respective bugs as well.
Using the new API will mean requiring newer SQLite releases.
If we do this, then this is the chance to remove all
Gerhard Häring g...@ghaering.de added the comment:
I see that the status of this issue keeps changing.
Now does anything in the sqlite3 module or the docs need to be changed?
Or what's left to close this?
--
___
Python tracker rep
Changes by Gerhard Häring g...@ghaering.de:
--
nosy: +ghaering
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5872
___
___
Python-bugs-list mailing
Gerhard Häring g...@ghaering.de added the comment:
I said qmark vs numeric. I. e. vs:
execute(UPDATE authors set name = :1, email = :2, comment = :3 WHERE id = :4,
(form.name, form.email, form.text, form.id))
The sqlite3 module will always support both paramstyles qmark and named, simply
Gerhard Häring g...@ghaering.de added the comment:
Thanks for bringing this up.
By changing this we would maybe be a little bit closer to PEP 0249. I don't get
why the PEP author thinks that 'qmark' is less clear than 'numeric', though. I
think they're equally clear.
The real reason why I
Changes by Gerhard Häring g...@ghaering.de:
--
nosy: +ghaering
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8145
___
___
Python-bugs-list mailing
Gerhard Häring g...@ghaering.de added the comment:
Applied in trunk. Thanks!
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7670
Gerhard Häring g...@ghaering.de added the comment:
Fixed in trunk now. Thanks!
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7478
Gerhard Häring g...@ghaering.de added the comment:
Now also fixed in 2.6 and 3.1 maintenance branches.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7670
Gerhard Häring g...@ghaering.de added the comment:
As requested per Barry, marking this as release blocker for 2.6.
--
keywords: +26backport
priority: - release blocker
stage: patch review - commit review
status: closed - open
___
Python tracker rep
Changes by Gerhard Häring g...@ghaering.de:
--
title: Strabge issue : cursor.commit() with sqlite - Strange issue :
cursor.commit() with sqlite
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7572
Gerhard Häring g...@ghaering.de added the comment:
You confuse two things here: cursors and connections.
Indeed closing a connection without calling commit() on it will do an
implicit rollback, i. e. any changes on the database will not be persisted.
Closing cursors, however does nothing
Gerhard Häring g...@ghaering.de added the comment:
Please change your test case so that it works with an in-memory database
:memory:. Then you'll also need to include a schema creation command
create table, which is missing here.
Please also state which behaviour you see and which one you
Gerhard Häring g...@ghaering.de added the comment:
The error code SQLITE_ERROR from SQLite is used for runtime errors.
These can either be caused by the programmer (table does not exist, SQL
contains errors) or they can be other problems like constraint
violations etc.
To differentiate these we
Gerhard Häring g...@ghaering.de added the comment:
Thanks!
I've integrated this into pysqlite
(http://code.google.com/p/pysqlite/source/detail?r=6455981b3283b26c147d949a9031a0d74ea7ffe8)
and will soon push updates to the version in Python core.
In my opinion this changes is not critical enough
Gerhard Häring g...@ghaering.de added the comment:
This has long been fixed. Even for 2.6maint the SQLite version currently
being fetched is 3.6.11.
--
resolution: - out of date
status: open - closed
___
Python tracker rep...@bugs.python.org
http
Changes by Gerhard Häring g...@ghaering.de:
--
assignee: - ghaering
nosy: +ghaering
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6683
Gerhard Häring g...@ghaering.de added the comment:
At the very start of the module's documentation it reads:
pysqlite was written by Gerhard Häring and provides a SQL interface
compliant with the DB-API 2.0 specification described by PEP 249.
Where PEP 249 is a link to the Database API 2.0
Changes by Gerhard Häring g...@ghaering.de:
--
assignee: - ghaering
nosy: +ghaering
priority: - low
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5033
Gerhard Häring g...@ghaering.de added the comment:
This is a known issue with SQLite. It's not as bad as it looks at first
sight, though.
http://www.sqlite.org/faq.html#q17
(17) I get hundreds of compiler warnings when I compile SQLite. Isn't
this a problem? Doesn't it indicate poor code
Gerhard Häring g...@ghaering.de added the comment:
I propose to either close this as wontfix. I don't know the switches for
the Microsoft compiler to disable the warnings myself.
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5134
Gerhard Häring [EMAIL PROTECTED] added the comment:
Thanks, committed in revision 66843.
--
status: open - closed
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue4068
New submission from Gerhard Häring [EMAIL PROTECTED]:
This is a backport of Georg Brandl's fix for issue #3312.
--
assignee: ghaering
files: 253_backport_fix_issue3312.diff
keywords: patch, patch
messages: 74454
nosy: ghaering
priority: normal
severity: normal
status: open
title
Gerhard Häring [EMAIL PROTECTED] added the comment:
Thanks a lot, Benjamin!
Committed revision 66550.
--
resolution: - fixed
status: open - closed
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3659
Gerhard Häring [EMAIL PROTECTED] added the comment:
Damn. I uploaded a patch to this issue a few days ago for review.
Apparently, it didn't work?! I'll recreate it again.
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3659
Gerhard Häring [EMAIL PROTECTED] added the comment:
Attached patch corrects the issue. Could you please review it?
--
status: open - pending
Added file: http://bugs.python.org/file11541/py3_sqlite3_str_subclass.dif
___
Python tracker [EMAIL PROTECTED
Changes by Gerhard Häring [EMAIL PROTECTED]:
--
keywords: +easy, needs review, patch
type: - behavior
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3659
Changes by Gerhard Häring [EMAIL PROTECTED]:
--
status: pending - open
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3659
___
___
Python-bugs-list
New submission from Gerhard Häring [EMAIL PROTECTED]:
I'd really like this change to get into Python 2.6. It's pretty trivial
(just releases the GIL when compiling SQLite statements), but improves
concurrency for SQLite. This means less database is locked errors for
our users.
Could somebody
Changes by Gerhard Häring [EMAIL PROTECTED]:
--
keywords: +needs review -patch
priority: - high
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3846
New submission from Gerhard Häring [EMAIL PROTECTED]:
Could one of you please give me a review for the trivial patch at
http://bugs.python.org/issue3846 It releases the GIL around
sqlite3_prepare calls to improve concurrency.
Many thanks
-- Gerhard
--
files: unnamed
messages: 73087
Gerhard Häring [EMAIL PROTECTED] added the comment:
Patch to Python 2.6 with Misc/NEWS entry if we want to close this now.
Added file: http://bugs.python.org/file11475/patch_sqlite3_global_symbols.dif
___
Python tracker [EMAIL PROTECTED]
http
Gerhard Häring [EMAIL PROTECTED] added the comment:
1. SQLite calling back
Good that you mention it. During sqlite3_prepare, SQLite can call the
authorizer_callback. Fortunately, it already acquires/releases the GIL
appropriately already.
2. Other thread closing connection, etc.
Connections
Gerhard Häring [EMAIL PROTECTED] added the comment:
I accidentally created this issue
--
resolution: - invalid
status: open - closed
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3847
Gerhard Häring [EMAIL PROTECTED] added the comment:
Interesting. I was smart enough to not document check_same_thread in the
sqlite3 incarnation of the module.
This has nothing to do with releasing/aquiring the GIL around
sqlite3_prepare, though. Adding the macros was just an oversight.
They're
Gerhard Häring [EMAIL PROTECTED] added the comment:
Just to be explicit: check_same_thread is unsupported and while it's
undocumented in sqlite3, the old pysqlite docs say that when you use it,
you have to make sure the connections/cursors are protected otherwise
(via your own mutexes
Gerhard Häring [EMAIL PROTECTED] added the comment:
Thanks, Martin.
Commited as r66414.
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3846
___
___
Python-bugs
Gerhard Häring [EMAIL PROTECTED] added the comment:
Committed in r66412.
--
status: open - closed
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3103
New submission from Gerhard Häring [EMAIL PROTECTED]:
According to http://www.sqlite.org/faq.html#q6 SQLite should be built
with SQLITE_THREADSAFE defined when the library is used in a
multithreaded context.
This doesn't mean that the connection objects can then be shared between
threads
New submission from Gerhard Häring [EMAIL PROTECTED]:
In Issue3846, Martin proposed [...] I encourage you to review the
entire issue, though, and document
somewhere what promises are made under what conditions. Then a later
review can validate that the promises are really kept.
Currently it's
Gerhard Häring [EMAIL PROTECTED] added the comment:
Issue3854 was created for documenting sqlite3 vs. threads.
--
status: open - closed
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3846
Gerhard Häring [EMAIL PROTECTED] added the comment:
I'll look into this.
--
assignee: - ghaering
nosy: +ghaering
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3659
Gerhard Häring [EMAIL PROTECTED] added the comment:
I like Skip's version better, because it's closer to the dbm
specification instead of trying to mimic bsddb (first, last, etc.).
I'd like to keep such things out.
I've made a few changes to the sandbox project which I will check in
later today
Gerhard Häring [EMAIL PROTECTED] added the comment:
One question about Josiah's _check_value(). SQLite is less crippled than
other simplistic databases and also supports integers, reals and blobs
in addition to strings.
Shouldn't we make this accessible to users? Or is compatibility with
other
Gerhard Häring [EMAIL PROTECTED] added the comment:
I'd like to guarantee that zip(db.keys(), db.values() == db.items().
Ok. If that isn't guaranteed elsewhere just drop it here?
FWIW that will also work without the ORDER BY, because you're getting
the rows back in the same ORDER. Something
Gerhard Häring [EMAIL PROTECTED] added the comment:
Skip Montanaro wrote:
Skip Montanaro [EMAIL PROTECTED] added the comment:
Gerhard FWIW that will also work without the ORDER BY, because you're
Gerhard getting the rows back in the same ORDER. Something cheaper
Gerhard would also
Gerhard Häring [EMAIL PROTECTED] added the comment:
I've fixed that in the externally maintained pysqlite. I suppose it's
too late to bring this into 2.6 or 3.0, right?
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3103
Gerhard Häring [EMAIL PROTECTED] added the comment:
Can we close this now? Did you try out a Python2.6 or Python 3.0 beta?
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2127
Gerhard Häring [EMAIL PROTECTED] added the comment:
I applied your second patch in r62701. Thanks again!
--
resolution: - accepted
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2152
Gerhard Häring [EMAIL PROTECTED] added the comment:
Implemented in r62702.
--
resolution: - accepted
status: open - closed
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2157
Gerhard Häring [EMAIL PROTECTED] added the comment:
The implementation in SVN should in the meatntime behave like you expect
now. Look for database_utf8 = PyUnicode_AsUTF8String(database); in
connection.c to see the implementation.
__
Tracker [EMAIL PROTECTED
Gerhard Häring [EMAIL PROTECTED] added the comment:
Glyph, do you know somebody with a Mac who could verify this patch?
Perhaps you have a Mac yourself? :-) I'd suggest to update the patch to
the latest SQLite version then while at it (3.5.8 currently).
--
assignee: ghaering - glyph
Changes by Gerhard Häring [EMAIL PROTECTED]:
--
nosy: +ghaering
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2277
__
___
Python-bugs-list mailing list
Unsubscribe
Gerhard Häring [EMAIL PROTECTED] added the comment:
Thanks for reporting this. It's fixed in r62183 in the 2.5 maintenance
branch.
--
resolution: - fixed
status: open - closed
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2515
Gerhard Häring [EMAIL PROTECTED] added the comment:
My problem is that I can't really test (better than #undefining
HAVE_LONG_LONG) this, because I have no platform to test on that doesn't
have long longs.
I'm not even sure SQLite *really* works when there is no 64-bit type.
I'll ask
Gerhard Häring [EMAIL PROTECTED] added the comment:
Thanks a lot! I will review and apply this after the next releases.
Don't want to rush things in now that the next alphas are so close. Btw.
I don't find forward-porting to py3k particularly easy. The diffs
between the 2.6 version and th 3.0
1 - 100 of 127 matches
Mail list logo