Giampaolo Rodola' added the comment:
Sorry, my fault. I got confused with os.sendfile() which returns 0 on EOF.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20951
Giampaolo Rodola' added the comment:
hg import http://bugs.python.org/file34522/devpoll3.patch; applies cleanly for
me. Not sure what else to do.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18931
Giampaolo Rodola' added the comment:
I successfully tested this on Solaris 11.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18931
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
assignee: - giampaolo.rodola
components: +Library (Lib)
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18931
Giampaolo Rodola' added the comment:
Regenerated without --git.
--
Added file: http://bugs.python.org/file34522/devpoll3.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18931
Giampaolo Rodola' added the comment:
Patch in attachment.
--
Added file: http://bugs.python.org/file34494/devpoll2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18931
Giampaolo Rodola' added the comment:
Sorry for not being able to rewrite the patch in time for 3.4.
I will provide an updated patch (I need to setup an Open Solaris box first
though).
The code for poll(), epoll() and /dev/poll will have many similarities, so I
think it makes sense to refactor
Giampaolo Rodola' added the comment:
OK, I will provide a patch soon.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18931
___
___
Python-bugs
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20246
___
___
Python
New submission from Giampaolo Rodola':
http://hg.python.org/cpython/file/29d9638bf449/Lib/subprocess.py#l1144
This was introduced in revision 6b627e121573 and is currently not documented.
I'm not sure whether this is a documentation issue or endtime should have
been _endtime instead
Giampaolo Rodola' added the comment:
Sorry: revision a161081e8f7c.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20572
___
___
Python-bugs-list
Giampaolo Rodola' added the comment:
I'd be for just getting rid of it for 3.4 now that we still can.
Being that this parameter is 1) not documented and 2) it's not even clear what
it does I think it's unlikely that there's people using it.
--
nosy: +georg.brandl, larry
priority
Giampaolo Rodola' added the comment:
Patch LGTM.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20555
___
___
Python-bugs-list mailing list
Giampaolo Rodola' added the comment:
The new asyncio module doesn't have this performance issue
On Unix, the default implementation sets an handler for SIGCHLD signal which
calls waitpid(pid, WNOHANG) on all processes to detect process exit. But it
has
also a faster implementation which
Giampaolo Rodola' added the comment:
Please find a better name for the type enum and document the new enums.
Why should new enums be documented and how are they useful?
IMO socket module adopted enum module only to provide a better representation
of AF_* and SOCK_* constants on repr(), which
Giampaolo Rodola' added the comment:
But as a user when are you gonna need to use AddressFamily container?
Before enum we didn't have something like:
AddressFamily = (AF_INET, AF_INET6, ...)
Basically because we didn't need it. Sorry if I'm missing something here
New submission from Giampaolo Rodola':
Python 2.7
import socket
socket.SocketType
class 'socket._socketobject'
s = socket.socket()
isinstance(s, socket.SocketType)
True
Python 3.4
socket.SocketType
enum 'SocketType'
s = socket.socket()
isinstance(s, socket.SocketType)
False
Giampaolo Rodola' added the comment:
Either way it's fine with me.
Regardless I think these tests have some value because all those os functions
are not currently tested so it might makes sense to apply Serhiy's suggestions
and port them to Python 3.4
Giampaolo Rodola' added the comment:
Attached patch includes tests. I took test_sax.py as an example.
--
Added file: http://bugs.python.org/file33633/issue18695-2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18695
Giampaolo Rodola' added the comment:
While I'm at it I'm going to fix also mkfifo(), mknod() and others. Hold on a
bit more.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18695
Giampaolo Rodola' added the comment:
Ok, patch in attachment fixes mkfifo(), mknod() and statvfs() and also includes
Unicode tests for all os module's path-related functions.
--
Added file: http://bugs.python.org/file33634/issue18695-3.patch
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14480
___
___
Python
Giampaolo Rodola' added the comment:
LGTM
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10388
___
___
Python-bugs-list mailing list
Unsubscribe
Giampaolo Rodola' added the comment:
You mean this should be made in 3.4 only?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10388
Giampaolo Rodola' added the comment:
I can agree with you that it's probably better to avoid changing existent
python versions to avoid breakage but I see no need to be that strict for newer
ones.
Current version should check errno but it doesn't. IMO that is clearly a bug.
Same goes
Giampaolo Rodola' added the comment:
Looking back at this: considering we may get errors != EACCESS I think we
better be as generic as possible as in:
--- a/Modules/spwdmodule.c
+++ b/Modules/spwdmodule.c
@@ -153,6 +153,8 @@
if ((d = PyList_New(0)) == NULL)
return NULL
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20166
___
___
Python
Giampaolo Rodola' added the comment:
I don't think this should be documented as personally I wouldn't expect this
use case to be working in the first place.
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19143
___
___
Python
New submission from Giampaolo Rodola':
On Windows 7:
v = sys.getwindowsversion()
v
sys.getwindowsversion(major=6, minor=1, build=7600, platform=2, service_pack='')
v.service_pack_major
0
v.service_pack_minor
0
v.suite_mask
254
Doc states:
For compatibility with prior versions, only
Giampaolo Rodola' added the comment:
Thanks for fixing. =)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20045
___
___
Python-bugs-list mailing
New submission from Giampaolo Rodola':
$ ./python -V
Python 3.4.0b1
$ ./python setup.py register --list-classifiers
running register
running check
Traceback (most recent call last):
File setup.py, line 2219, in module
main()
File setup.py, line 2214, in main
Tools/scripts/2to3, Tools
Giampaolo Rodola' added the comment:
Just received this report on psutil bug tracker:
https://code.google.com/p/psutil/issues/detail?id=455
It seems os.prlimit() is affected by the same problem:
import resource
resource.RLIM_INFINITY
-1
--
resolution: fixed -
status: closed - open
Giampaolo Rodola' added the comment:
s/os.prlimit/resource.prlimit
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16595
___
___
Python-bugs-list
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: -giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19940
___
___
Python
Giampaolo Rodola' added the comment:
I replied to your comments here:
http://bugs.python.org/review/19843/
Assuming the deadlock problem gets fixed would you consider this feature worthy
for inclusion?
--
___
Python tracker rep...@bugs.python.org
Giampaolo Rodola' added the comment:
In those protocols where client and server exchange a lot of commands and
responses in a single session, such as FTP, modify() is going to be called many
times.
I don't have actual numbers but I remember that using epoll.modify() was one of
those
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19842
___
___
Python
New submission from Giampaolo Rodola':
I recently implemented this in psutil and thought it would have been a nice
addition for subprocess module as well:
https://code.google.com/p/psutil/issues/detail?id=440
Patch in attachment introduces a new subprocess.wait_procs() utility function
which
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19822
___
___
Python
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: -giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19689
___
___
Python
Giampaolo Rodola' added the comment:
Same problem here. I'm currently uploading .exe files for psutil by hand.
Interestingly the problem occurs with certain versions of python only (2.4,
2.5, 2.7, 3.2).
--
nosy: +giampaolo.rodola
___
Python tracker
Giampaolo Rodola' added the comment:
I think I have already proposed something similar in past but I can't find any
reference on the tracker (so maybe I didn't after all).
BTW I have something like this [1] in a utils module I use across different
projects and I would definitively welcome
Giampaolo Rodola' added the comment:
Personally I see little value in creating a section in the doc which explains
how to port code from asyncore/chat to asyncio.
Current asyncore/chat doc has just a couple of code samples which do not
justify the effort, IMO.
I think a deprecation warning
Giampaolo Rodola' added the comment:
This module has been around for a long time and no users have reported
any issues with respect to event ordering. The logic is essentially
the same as is used in popular event loops like Tornado.
Please don't just make-up a new invariant
Giampaolo Rodola' added the comment:
You are right. I will try to provide patches for other Python versions
later next week.
On Sun, Oct 20, 2013 at 5:08 PM, Arfrever Frehtes Taifersar Arahesis
rep...@bugs.python.org wrote:
Arfrever Frehtes Taifersar Arahesis added the comment:
(3.1
Giampaolo Rodola' added the comment:
I think this is already fixed. Barry can we close this out?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16038
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: -giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18777
___
___
Python
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19291
___
___
Python
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19262
___
___
Python
Giampaolo Rodola' added the comment:
I don't have time to look into Serhiy's changes right now but here's a brief
summary:
- there's a (I think) *minor* downside in terms of backward compatibility
because scheduler._queue won't be updated after cancel() (basically this is the
reason why
Giampaolo Rodola' added the comment:
Sorry, I failed to notice there's a scheduler.queue property which exposes the
underlying _queue attribute so the patch should take that into account and
return the updated list.
--
___
Python tracker rep
Giampaolo Rodola' added the comment:
Patch in attachment applies cleanly with the current 3.4 code (last one wasn't)
and returns an updated list on scheduler.queue.
I rebased my work starting from my original patch (cancel.patch) not
Serhiy's because it wasn't clear to me *where* exactly
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15806
___
___
Python
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11344
___
___
Python
Giampaolo Rodola' added the comment:
I believe the problem is the set of next_retr_data attribute here:
def test_retrlines_too_long(self):
self.server.handler.next_retr_data = 'x' * self.client.maxline * 2
...because self.server.handler runs in a different thread (different than
Giampaolo Rodola' added the comment:
Barry can you paste the traceback caused by the race condition? What's not
clear to me is when (what line) it occurs.
One solution might be to send a NOOP command (self.client.sendcmd('noop')) in
order to synchronize client and server
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4080
___
___
Python-bugs
Giampaolo Rodola' added the comment:
Looks legitimate to me. I will come up with a separate patch for later Python
versions.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16038
New submission from Giampaolo Rodola':
This is a follow up of issue 16853.
I will try to see whether I can come up with a patch later today.
--
messages: 196989
nosy: christian.heimes, felipecruz, giampaolo.rodola, gvanrossum, haypo,
meador.inge, neologix, pitrou, python-dev
New submission from Giampaolo Rodola':
This is a follow up of issue 16853 (see comment
http://bugs.python.org/issue16853#msg196984).
--
messages: 196990
nosy: christian.heimes, felipecruz, giampaolo.rodola, gvanrossum, haypo,
meador.inge, neologix, pitrou, python-dev, rosslagerwall
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18923
___
___
Python
Giampaolo Rodola' added the comment:
It's likely that asyncore won't be able to take any practical advantage from
this integration.
To say one, epoll()/kqueue() pollers won't bring any speedup over
select()/poll() because of how asyncore.loop() function is implemented (see
http
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18934
___
___
Python
Giampaolo Rodola' added the comment:
Patch is in attachment.
--
keywords: +patch
Added file: http://bugs.python.org/file31618/devpoll.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18931
Giampaolo Rodola' added the comment:
I'm attaching a slightly different patch including new tests and which uses a
'maxline' class attribute (as opposed to a global var).
Christian if that's OK with you I will wait a while and then make a commit for
all Python versions.
--
Added file
Giampaolo Rodola' added the comment:
Is there anything left to do or can we close this issue?
Add support for select.devpoll on Solaris.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16853
Giampaolo Rodola' added the comment:
I have realized just now that at least epoll() and kqueue() selectors could
take advantage and define their own modify() method (there was even a TODO I
totally missed).
Anyway, from now on I'm gonna file separate issues
New submission from Giampaolo Rodola':
It was introduced in Python 2.6:
http://bugs.python.org/issue1657
Will commit a patch soon.
--
assignee: docs@python
components: Documentation
messages: 196953
nosy: docs@python, giampaolo.rodola
priority: normal
severity: normal
status: open
title
Giampaolo Rodola' added the comment:
I may be missing something here but isn't the whole point of EINTR to interrupt
a potentially long running syscall?
Why protract function return time as a consequence?
All the event loops I'm familiar with (twisted, tornado and asyncore) just
'return
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18885
___
___
Python
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18896
___
___
Python
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12304
___
___
Python
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18100
___
___
Python
Giampaolo Rodola' added the comment:
Follows a couple of minor concerns.
- What about Solaris' /dev/poll?
- I'm not sure why in case of EINTR you retry with a different timeout; can't
you just return []?
- this is probably because I'm paranoid about performances but given that
select
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18882
___
___
Python
Giampaolo Rodola' added the comment:
That should be pretty easy to add by someone who has access to a
Solaris box: I could use the buildbots, but it'd take a couple
iterations to get it right.
I can probably help with that.
--
___
Python tracker
Giampaolo Rodola' added the comment:
I'm playing with devpoll on Open Solaris and it seems it works exactly as
poll(). Basically a copy paste of PollSelector class with a different
self._poll attribute will suffice.
With dev/poll support you now have 3 classes (PollSelector, EpollSelector
New submission from Giampaolo Rodola':
From: https://code.google.com/p/psutil/issues/detail?id=416
# -*- coding: utf-8 -*-
from __future__ import unicode_literals
import os, errno
name = ƒőő
try:
os.mkdir(name)
except OSError as err:
if err.errno != errno.EEXIST:
raise
Giampaolo Rodola' added the comment:
I'm not sure that it's a good idea to invest time on fixing Unicode
issues in Python 2, especially in a minor version (Python 2.7.x).
I admit I sort of share the same doubts, but considering 2.7 a minor python
version, especially at this point, would
Giampaolo Rodola' added the comment:
From my original post which unfortunately was ignored :( :
http://mail.python.org/pipermail/python-ideas/2012-June/015323.html
...for completeness perhaps it also makes sense to expose Linux-specific RLIMIT
constants:
RLIMIT_MSGQUEUE
RLIMIT_NICE
Giampaolo Rodola' added the comment:
I cannot reproduce the issue on Ubuntu.
As for the second exception I think it's safe to just do:
- raise URLError('ftp error: %d' % reason) from reason
+ raise URLError('ftp error: %s' % reason) from reason
(will commit that later
Giampaolo Rodola' added the comment:
That's not safe as a misbehaving FTP server might not send a response code at
all (highly unlikely but still...).
Furthermore having the complete server response (response code + accompaining
message) is a lot more helpful
Giampaolo Rodola' added the comment:
I think raise URLError('ftp error: %s' % reason) from reason is just fine.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17933
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18264
___
___
Python
New submission from Giampaolo Rodola':
...as per my original proposal on python-ideas:
http://mail.python.org/pipermail/python-ideas/2013-June/021450.html
Patch is in attachment.
--
components: Library (Lib)
files: unittest.patch
keywords: needs review, patch
messages: 192430
nosy
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18095
___
___
Python
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18329
___
___
Python
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17343
___
___
Python
Giampaolo Rodola' added the comment:
LGTM now.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11959
___
___
Python-bugs-list mailing list
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13483
___
___
Python
Giampaolo Rodola' added the comment:
Changes to Doc/library/asyncore.rst should be reverted.
Also I would do:
- asynchat.async_chat.__init__(self, conn, map)
+ asynchat.async_chat.__init__(self, conn, map=map)
--
___
Python tracker rep
Giampaolo Rodola' added the comment:
patch plus self.producer_fifo.extendleft([data, first]) seems legit and I
verified pyftpdlib tests pass.
Last thing missing from the patch is a test case. Pierrick can you merge
test_initiate_send.py into Lib/test_asynchat.py and provide a new patch
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18123
___
___
Python
Giampaolo Rodola' added the comment:
I think we shouldn't expect asynchat to be thread safe in this regard.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17925
Giampaolo Rodola' added the comment:
After applying the patch I get these 2 failures on Linux:
==
FAIL: test_simple_producer (__main__.TestAsynchat
Giampaolo Rodola' added the comment:
Looking back at this I think that allowing a map argument to be passed to
SMTPChannel in order to allow running handlers in separate threads can be
reasonable after all.
I don't understand why create_socket() signature needs to be changed though
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
assignee: - giampaolo.rodola
resolution: - fixed
stage: - committed/rejected
status: open - closed
type: - enhancement
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17996
Giampaolo Rodola' added the comment:
Mmm I'm not sure how to do this properly.
Apparently it seems I can:
--- a/Lib/plat-freebsd8/regen
+++ b/Lib/plat-freebsd8/regen
@@ -1,3 +1,3 @@
#! /bin/sh
set -v
-python ../../Tools/scripts/h2py.py -i '(u_long)' /usr/include/netinet/in.h
+python
Giampaolo Rodola' added the comment:
Nevermind, it seems changing regen is not necessary. Patch is in attachment.
--
keywords: +patch
Added file: http://bugs.python.org/file30327/AF_LINK.patch
___
Python tracker rep...@bugs.python.org
http
501 - 600 of 1713 matches
Mail list logo
