Giampaolo Rodola' added the comment:
As for runcall() we haven't the ability to freely support kwargs *and* filename.
I see two possibilities.
Kill kwargs, as such:
+def runcall(func, *args, filename=None, sort=-1):
+Run func(*args) under profiler, optionally saving results in
+filename
Giampaolo Rodola' added the comment:
LineTooLong should be added to ftplib.all_errors.
4096 looks enough to me.
The longest lines I can think of occur when processing MLSD command which
produces an output of like this:
type=file;size=156;perm=r;modify=20071029155301;unique=801cd2; music.mp3
Giampaolo Rodola' added the comment:
ftplib.ftpcp? What is that? I do not understand what you're trying to test.
ftplib test suite is already pretty extended.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17055
Giampaolo Rodola' added the comment:
This discussion got very long and it's not clear (to me at least) what the
status of the patch is and whether it has been accepted for inclusion.
Maybe it makes sense to bring this up to python-dev mailing list instead of
keep stressing this thread
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17006
___
___
Python
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16038
___
___
Python
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16042
___
___
Python
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16039
___
___
Python
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16040
___
___
Python
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16041
___
___
Python
Giampaolo Rodola' added the comment:
asyncore simply does not support SSL.
That is tracked in issue 10084.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16976
Giampaolo Rodola' added the comment:
What do you mean? The intent was to use poll() instead of select() anywhere
available in order to avoid running out of fds.
The change didn't affect Windows because as of right now select() is the only
thing available
Giampaolo Rodola' added the comment:
Damn, you're right. I must have messed up something while porting the patch
from 3.2 all the way up to 3.4 as the merge produced some conflicts.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Giampaolo Rodola' added the comment:
3.3 and 3.4 branches should now be fixed.
2.7 and 3.2 still need to be fixed and the code from connections.py removed.
Sorry for the mess up.
--
assignee: giampaolo.rodola -
___
Python tracker rep
Giampaolo Rodola' added the comment:
Ok for asyncore/asynchat in 3.4 branch.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16871
___
___
Python
Giampaolo Rodola' added the comment:
@Guido: agreed.
there's no SELECT_ERR anymore [...] the error will be reported when the FD
will be read/written
I don't think this is a good idea, particularly during this early stage.
This assumption might be valid for select() but not for poll
Giampaolo Rodola' added the comment:
Inline comments:
http://bugs.python.org/review/16853/
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16853
Giampaolo Rodola' added the comment:
The actual error (which may be ECONNRESET, but also EBADF, ENOBUFS...) will
be raised
upon the next call to read()/write(), or can be retrieved through
getsockopt(SO_ERROR).
Mmmm... I would be tempted to think the same but the fact that both Tornado
Giampaolo Rodola' added the comment:
asyncore's __getattr__ horror was scheduled for removal a long ago (3.1 as per
issue8483).
We can safely remove it for 3.4 and fix the RuntimeError exception above for
all the earlier Python versions which are affected
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
assignee: - giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13103
Giampaolo Rodola' added the comment:
Previous issue should have been fixed by now.
Closing.
--
status: pending - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14807
Giampaolo Rodola' added the comment:
Is this currently being written from scratch? It shouldn't be IMO.
Instead I recommend using the existent Tornado or pyftpdlib IO loop as an
example:
https://github.com/facebook/tornado/tree/master/tornado/platform
https://github.com/facebook/tornado/blob
Giampaolo Rodola' added the comment:
My bad, sorry. It should be fixed now.
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10527
Giampaolo Rodola' added the comment:
I know. I proposed something like that here:
http://mail.python.org/pipermail/python-ideas/2012-May/015223.html.
In theory all the necessary pieces are already there. What's missing is an
agreement on what the API should look like, and that's the hard part
Giampaolo Rodola' added the comment:
Well, for now I'd say let's just check in this patch as-is.
I would be keen on considering this a bug and hence address the patch for
Python 2.7, 3.2, 3.3 and 3.4.
--
___
Python tracker rep...@bugs.python.org
Giampaolo Rodola' added the comment:
Does asyncore expose its implementation details?
I was talking about asynchat. What is supposed to change is
asynchat.async_chat.producer_fifo attribute which is currently a
collections.deque object
Giampaolo Rodola' added the comment:
BTW, the patch looks ok to me.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16787
___
___
Python-bugs
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
assignee: - giampaolo.rodola
resolution: - fixed
stage: patch review - commit review
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10527
Giampaolo Rodola' added the comment:
Updated patch including test fixes is in attachment.
--
Added file: http://bugs.python.org/file28501/issue10527-3.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10527
Giampaolo Rodola' added the comment:
IMO no. asyncore.dispatcher_with_send should not exist in the first place as it
basically is a castrated version of asynchat.async_chat with less capabilities.
I'd say it's there only for an historical reason.
Moving ac_*_buffer_size to asyncore.dispatcher
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16802
___
___
Python
Giampaolo Rodola' added the comment:
But even in asynchat, there's a lot of copying going on, length
computations performed twice in a row, etc.
What/where do you mean exactly?
I see little value in focusing efforts towards things such as
initiate_with_send which are not supposed to be used
Giampaolo Rodola' added the comment:
memoryview is also great to avoid copies when sending/receiving to a socket.
That's interesting. How exactly? Would producer_fifo have to change from a
deque() to a memoryview() object? In that case we might have to take backward
compatibility
Giampaolo Rodola' added the comment:
New patch in attachment.
It always uses poll() and maintains and internal fd/Connection map.
I get one failure due to the returned list being sorted differently than when
using select() though
Giampaolo Rodola' added the comment:
Patch looks fine to me.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16641
___
___
Python-bugs-list
Giampaolo Rodola' added the comment:
Patch looks fine to me.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16640
___
___
Python-bugs-list
Giampaolo Rodola' added the comment:
Sorry for chiming in so late.
The patch looks fine to me.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16165
Giampaolo Rodola' added the comment:
A couple of years ago I conducted similar tests and it turned out that 64k was
the best compromise:
http://code.google.com/p/pyftpdlib/issues/detail?id=94
Twisted uses 128k.
I'd be for using 64k and also change asynchat.async_chat.ac_*_buffer_size
Giampaolo Rodola' added the comment:
Why did you replace socket.error with OSError?
I think we should use socket.create_connection() as a guide line:
http://hg.python.org/cpython/file/45dfb657b430/Lib/socket.py#l401
A patch is in attachment.
--
Added file: http://bugs.python.org
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
assignee: - giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16646
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
resolution: - fixed
stage: commit review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16646
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16692
___
___
Python
Giampaolo Rodola' added the comment:
Ouch! My bad. Thanks.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16646
___
___
Python-bugs-list mailing
Giampaolo Rodola' added the comment:
I don't think it is worth complicating the API for this. There have
been zero requests for this functionality. Even the doc field of
property() is rarely used.
+1
--
nosy: +giampaolo.rodola
___
Python
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16507
___
___
Python
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16487
___
___
Python
New submission from Giampaolo Rodola':
http://www.webmproject.org/docs/container/#naming
--
components: Library (Lib)
files: webm.diff
keywords: patch
messages: 173843
nosy: giampaolo.rodola
priority: normal
severity: normal
status: open
title: mimetypes does not support webm type
Giampaolo Rodola' added the comment:
(patch in attachment)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16329
___
___
Python-bugs-list mailing
Giampaolo Rodola' added the comment:
I'd say we can't but I suppose the same problem might exist for other mime
types as well.
Given that we can't inspect file content the only choice we have is either
decide to not support a certain mime type or assume the most common scenario,
which in case
Giampaolo Rodola' added the comment:
Have you tried to see what happens in passive mode (use: ftps.set_pasv(True))?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16318
Giampaolo Rodola' added the comment:
This should do it:
diff --git a/Lib/test/test_asyncore.py b/Lib/test/test_asyncore.py
--- a/Lib/test/test_asyncore.py
+++ b/Lib/test/test_asyncore.py
@@ -484,8 +484,9 @@
return self.socket.getsockname()[:2]
def handle_accept(self
Giampaolo Rodola' added the comment:
Yes, now that I think of it that is how accept() is supposed to be used in 2.7
(back then I did also update doc examples in order to enforce this use case) so
this is a test suite issue.
--
___
Python tracker
Giampaolo Rodola' added the comment:
A preliminary patch is in attachment.
By default it uses select() but looks for ValueError (raised in case FD_SETSIZE
gets hit) and falls back on using poll().
This is the failure I get when running tests on Linux.
It is related to issue 3321 and I'm
Giampaolo Rodola' added the comment:
Using poll() by default is controversial for 2 reasons, I think:
#1 - a certain slowdown is likely to be introduced (I'll measure it)
#2 - current wait() implementation allows to specify a list of file descriptors
and/or Connections objects.
select() can
Giampaolo Rodola' added the comment:
Still not getting what you refer to when you talk about 512 fds problem.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10527
Giampaolo Rodola' added the comment:
+self.assertEqual(shutil.rmtree(os.path.join(tmpdir, tstfile),
+ ignore_errors=True), None)
I wouldn't use assertEqual as the return value is not meaningful.
--
nosy: +giampaolo.rodola
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
assignee: - giampaolo.rodola
resolution: - fixed
status: open - closed
versions: +Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16270
Giampaolo Rodola' added the comment:
Not necessarily. It just means the other one was a duplicate.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10527
Giampaolo Rodola' added the comment:
That is weird. accept() should never return None.
What about python 3.x?
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16274
Giampaolo Rodola' added the comment:
I notice there are some differences in sock_accept() (Modules/socketmodule.c)
between 2.7 and 3.2.
Maybe a bugfix which wasn't backported to 2.7.
--
___
Python tracker rep...@bugs.python.org
http
Giampaolo Rodola' added the comment:
If an issue is a duplicate of another one it gets closed as a duplicate, and
that's it basically.
This issue is still open and this is where the matter should be discussed.
--
nosy: +sbt
___
Python tracker rep
Giampaolo Rodola' added the comment:
Committed http://hg.python.org/cpython/rev/240fa6e93925 in order to have a
clearer look on what's going on.
Will get back on this later today, after the next bb failure.
--
___
Python tracker rep
Giampaolo Rodola' added the comment:
I guess this is about urllib, not ftplib.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16270
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16269
___
___
Python
Giampaolo Rodola' added the comment:
On one hand this seems reasonable to me, on the other hand I'm not sure.
select() other than being supported on all platforms has the advantage of being
simple and quick to use (you just call it once by passing a set of fds and then
you're done).
poll
Giampaolo Rodola' added the comment:
Do you mean at the C level?
No, Python of course.
poll(), unlike select(), does not have to scan an fd_set
(of 1024 bits?) so I would have expected it to be faster if anything.
That might be true in a continuous loop (e.g. a reactor).
Judging from
Giampaolo Rodola' added the comment:
Speaking of which, it seems this is a duplicate of issue 10527.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16269
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10527
___
___
Python
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
resolution: - duplicate
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16269
Giampaolo Rodola' added the comment:
It's not clear to me how you intend to provide this exactly.
To me it looks like a good candidate for a recipe, otherwise I don't see it as
a good fit for the stdlib.
--
nosy: +giampaolo.rodola
___
Python
Giampaolo Rodola' added the comment:
I can reproduce the issue on python 3.3.
To have a clearer understanding on what's going on use:
import urllib.request
import ftplib
ftplib.FTP.debugging = 4
url = ftp://ftp.fu-berlin.de/pub/misc/movies/database/ratings.list.gz;
with urllib.request.urlopen
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
title: ftplib hangs when closing connection - urllib hangs when closing
connection
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16270
Giampaolo Rodola' added the comment:
We could have a public module exposing IOCP as a nice API :-)
What about select module?
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16175
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
versions: +Python 3.4 -Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13451
Giampaolo Rodola' added the comment:
The proposal looks way too ambitious and vaguely defined to me to say the least.
Integrating any async framework into another one which uses a blocking
concurrency model is hard. If that async framework is asyncore is usually also
a bad idea
Giampaolo Rodola' added the comment:
Assigning to me but I won't be able to look into it for a while.
--
assignee: - giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15934
Giampaolo Rodola' added the comment:
+1 for Antoine's patch/approach: it's more usable and pythonic.
I think documentation should mention and link the existence of:
http://docs.python.org/library/multiprocessing.html#multiprocessing.cpu_count
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10399
___
___
Python
New submission from Giampaolo Rodola' g.rod...@gmail.com:
It seems a doc fix is the best way to go, in which case I leave this one to a
native English speaker:
http://mail.python.org/pipermail/python-dev/2012-June/120788.html
Alternatively a new 'strict' parameter has been proposed
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12971
___
___
Python
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15093
___
___
Python
Giampaolo Rodola' g.rod...@gmail.com added the comment:
I'm -0 about unifying the function signature and raise NotImplementedError
where an arg is not supported.
I'm -1 about os.sendfile(..., diskio=True, wait=True, sync=False).
In both cases users willing to use these 3 args are already
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1260171
___
___
Python
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1602
___
___
Python-bugs
Giampaolo Rodola' g.rod...@gmail.com added the comment:
Not sure whether a solution has already been proposed because the issue is very
long, but I just bumped into this on Windows and come up with this:
from __future__ import print_function
import sys
def safe_print(s):
try
Giampaolo Rodola' g.rod...@gmail.com added the comment:
Let's see how it goes now.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14807
Giampaolo Rodola' g.rod...@gmail.com added the comment:
You are right. I should have looked more carefully. =)
--
resolution: - invalid
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14820
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14807
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
assignee: - giampaolo.rodola
keywords: +easy -patch
stage: - committed/rejected
status: open - closed
type: - enhancement
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
assignee: - giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14807
Giampaolo Rodola' g.rod...@gmail.com added the comment:
Changing it in asyncore is fine.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11959
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14814
___
___
Python
Giampaolo Rodola' g.rod...@gmail.com added the comment:
Thanks. It should now be fixed.
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14807
New submission from Giampaolo Rodola' g.rod...@gmail.com:
Don't know the details but this condition looks wrong:
http://hg.python.org/cpython/file/cdcc816dea85/Lib/socket.py#l190
--
messages: 160777
nosy: giampaolo.rodola, janssen
priority: normal
severity: normal
status: open
title
New submission from Giampaolo Rodola' g.rod...@gmail.com:
As per:
http://mail.python.org/pipermail/python-ideas/2012-May/015104.html
Patch is in attachment.
--
components: Library (Lib)
files: filemode.patch
keywords: easy, patch
messages: 160621
nosy: giampaolo.rodola, terry.reedy
Giampaolo Rodola' g.rod...@gmail.com added the comment:
Updated patch in attachment.
--
Added file: http://bugs.python.org/file25585/filemode.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14807
New submission from Giampaolo Rodola' g.rod...@gmail.com:
As per:
http://mail.python.org/pipermail/python-ideas/2012-May/015112.html
--
files: stat-comments.patch
keywords: patch
messages: 160584
nosy: giampaolo.rodola, terry.reedy
priority: normal
severity: normal
status: open
title
Giampaolo Rodola' g.rod...@gmail.com added the comment:
Unfortunately unit tests overwrite the original smtpd.socket module object with
test.mock_socket [1] and the latter one doesn't expose socket.getaddrinfo().
[1] http://hg.python.org/cpython/file/d937b527b76e/Lib/test/test_smtpd.py#l54
Giampaolo Rodola' g.rod...@gmail.com added the comment:
Agreed. The only problem I see is that unit tests rely on a mock socket object
and should be rewritten by using an actual socket.
--
___
Python tracker rep...@bugs.python.org
http
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: -giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13903
___
___
Python
701 - 800 of 1713 matches
Mail list logo
