Giampaolo Rodola' g.rod...@gmail.com added the comment:
Sorry for commenting on a closed issue but I just bumped into a problem
requiring a total_minute() method I ended up implementing by doing some raw
math by hand.
Would it be a reasonable addition?
If so I'll open a separate issue
New submission from Giampaolo Rodola' g.rod...@gmail.com:
/opt/python3.2/lib/python3.2/site-packages/psutil/_pslinux.py:389:
ResourceWarning: unclosed file _io.FileIO name=7 mode='rb'
return [x for x in f.read().split('\x00') if x]
I get this while running tests.
The method in question
Giampaolo Rodola' g.rod...@gmail.com added the comment:
Indeed you were right.
Thanks.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13222
Giampaolo Rodola' g.rod...@gmail.com added the comment:
IMO, patch should only be applied to Python 3.2.
For 3.3 we finally have the chance to get rid of the dispatcher.__getattr__
aberration (see issue 8483) so I say let's just remove it and fix this issue as
a consequence
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: -giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13034
___
___
Python
Giampaolo Rodola' g.rod...@gmail.com added the comment:
Thanks. After all, I think that keeping atexit simple is the best solution
and a doc adjustement is just fine.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9788
Giampaolo Rodola' g.rod...@gmail.com added the comment:
IMHO, both methods should raise an exception (RuntimeError maybe) in case the
server is already started or stopped, at least in Python 3.3, while previous
python versions should silently pass.
It also makes sense to add a running
Giampaolo Rodola' g.rod...@gmail.com added the comment:
Patch in attachment (tests still missing).
--
Added file: http://bugs.python.org/file22755/socketserver.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12463
Giampaolo Rodola' g.rod...@gmail.com added the comment:
This patch is now available as a recipe for python 2.x:
http://code.activestate.com/recipes/577808-asyncore-scheduler/
--
versions: +Python 3.3 -Python 3.2
___
Python tracker rep
Giampaolo Rodola' g.rod...@gmail.com added the comment:
New patch including tests.
--
Added file: http://bugs.python.org/file22762/socketserver.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12463
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
versions: +Python 2.7, Python 3.1, Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12502
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
versions: -Python 3.1
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12502
___
___
Python-bugs
Giampaolo Rodola' g.rod...@gmail.com added the comment:
+1 on what Eric just said.
See issue 10882 and msg 126049
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3177
Giampaolo Rodola' g.rod...@gmail.com added the comment:
Sorry for delay. Yes, patch looks ok to me and some tests for AF_UNIX sockets
would definitively be welcome.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12502
Giampaolo Rodola' g.rod...@gmail.com added the comment:
I removed the percent usage from the returned namedtuple hence that comment is
no longer necessary.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12442
Giampaolo Rodola' g.rod...@gmail.com added the comment:
Thanks for the further fixes.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12442
Giampaolo Rodola' g.rod...@gmail.com added the comment:
Agreed.
New patch removes the percentage and fixes computations on posix as recommended
by Charles-François:
free = st.f_bavail * st.f_bsize
total = st.f_blocks * st.f_frsize
used = (total - st.f_bfree * st.f_bsize)
--
Added
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
resolution: - fixed
stage: patch review - commit review
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12442
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12460
___
___
Python
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12459
___
___
Python
Giampaolo Rodola' g.rod...@gmail.com added the comment:
New patch includes:
- Py_BEGIN/END_ALLOW_THREADS around GetDiskFreeSpaceEx() call
- use of assertGreaterEqual / assertLessEqual when testing the percentage usage
- use of hasattr(shutil, 'disk_usage') for skipping the test
- extended url
Giampaolo Rodola' g.rod...@gmail.com added the comment:
The culprit here is the dummy FTP test server which does not complete the SSL
shutdown procedure successfully.
I believe it's better if we remove the self.client.sendcmd('noop') line.
That's there in order to check that client and server
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12139
___
___
Python-bugs
New submission from Giampaolo Rodola' g.rod...@gmail.com:
Patch in attachment adds a new disk_usage() function to shutil module which
retrieves total, used and free disk space given a certain path plus the
percentage usage.
See original discussion on python-ideas ml:
http://mail.python.org
Giampaolo Rodola' g.rod...@gmail.com added the comment:
Typo. It's:
http://mail.python.org/pipermail/python-ideas/2011-June/010480.html
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12442
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12139
Giampaolo Rodola' g.rod...@gmail.com added the comment:
Hmm... Reopening. I'll look into this later.
--
resolution: fixed -
status: closed - pending
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12139
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9246
___
___
Python-bugs
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
assignee: giampaolo.rodola
nosy: giampaolo.rodola
priority: normal
severity: normal
status: open
title: inspect.getabsfile() is not documented
versions: Python 2.6, Python 2.7, Python 3.1, Python 3.2, Python 3.3
Giampaolo Rodola' g.rod...@gmail.com added the comment:
This whole thread is becoming quite confusing.
It would be better to open a separate issue for any bug or feature request
which is not related to exposing signalfd(2) and pthread_sigmask
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12303
___
___
Python
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12197
___
___
Python
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12187
___
___
Python
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8407
___
___
Python-bugs
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12191
___
___
Python
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12166
___
___
Python
Giampaolo Rodola' g.rod...@gmail.com added the comment:
Is this fixed?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11748
___
___
Python-bugs
New submission from Giampaolo Rodola' g.rod...@gmail.com:
In FTPS, CCC command can be used to switch back to a clear-text control
connection.
This can be useful to take advantage of firewalls that know how to handle NAT
with non-secure FTP without opening fixed ports.
Patch in attachment
Giampaolo Rodola' g.rod...@gmail.com added the comment:
voidcmd() expects a response code starting with 2 and automatically raises an
exception otherwise.
A server succesfully accepting the CCC command is supposed to first reply with
220 and then shutdown() the SSL layer.
Client is supposed
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10808
___
___
Python
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
resolution: - fixed
stage: needs patch - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12002
Giampaolo Rodola' g.rod...@gmail.com added the comment:
This is a nasty one and mainly it's the reason why there are no tests for
abort() method.
In FTP, ABOR command is supposed to be sent as OOB (out-of-band) urgent data
and the dummy FTP server we're using for the funcional tests must
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
assignee: - giampaolo.rodola
components: +Library (Lib)
resolution: - fixed
stage: - committed/rejected
status: open - closed
type: - feature request
___
Python tracker rep...@bugs.python.org
Giampaolo Rodola' g.rod...@gmail.com added the comment:
Which ones in particular? msg130474?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11072
Giampaolo Rodola' g.rod...@gmail.com added the comment:
In my view, aside from the documentation note they're all minor/styling-related
changes but feel free to provide a patch if you want to and I'll commit it.
--
___
Python tracker rep
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
assignee: - giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12002
Giampaolo Rodola' g.rod...@gmail.com added the comment:
Eric, any further comments about the patch?
Can we go on and commit it?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11072
Giampaolo Rodola' g.rod...@gmail.com added the comment:
The fact that you need to keep two separate maps makes me think that the
approach you have in mind might be wrong, as in - that's something you usually
don't want to do -.
The fact that asyncore uses a default socket map is surely
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
Removed message: http://bugs.python.org/msg134825
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11959
Giampaolo Rodola' g.rod...@gmail.com added the comment:
The fact that you need to keep two separate maps makes me think that the
approach you have in mind might be wrong, as in - that's something you usually
don't want to do -. The fact that asyncore uses a global socket map is surely
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
versions: +Python 3.3 -Python 3.0
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5115
Giampaolo Rodola' g.rod...@gmail.com added the comment:
What change are you proposing exactly?
Btw, overriding log_info() in such cases seems reasonable to me, without
changing anything in asyncore.
--
___
Python tracker rep...@bugs.python.org
http
Giampaolo Rodola' g.rod...@gmail.com added the comment:
asyncore is a minimalistic and generic framework; as such it should not
privilege a specific application such as mod_wsgi or make any other
assumption.
I'd say it's fine to let user decide what to do in its own subclass.
Furthermore
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11583
___
___
Python
Giampaolo Rodola' g.rod...@gmail.com added the comment:
@barry I have commit privileges, but no problem if you want to commit it.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11289
Giampaolo Rodola' g.rod...@gmail.com added the comment:
Go on, no prob.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11289
___
___
Python-bugs
Giampaolo Rodola' g.rod...@gmail.com added the comment:
Closing out as per msg128969.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11257
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
resolution: - wont fix
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11257
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
stage: - committed/rejected
type: - feature request
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11289
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11459
___
___
Python
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11453
___
___
Python
Giampaolo Rodola' g.rod...@gmail.com added the comment:
You should have the facts in MLSD_DATA be mixed case, to ensure
they're being lowercased correctly.
This is already tested by:
+# case sensitiveness
+set_data('Type=type;TyPe=perm;UNIQUE=unique; name\r\n
Giampaolo Rodola' g.rod...@gmail.com added the comment:
Thanks for the great review Eric.
Patch in attachment provides the following changes:
- return a generator object
- remove callback parameter
- each yielded entry is a (name, {...}) tuple
- fix for ; in file name
- fix for in file name
Giampaolo Rodola' g.rod...@gmail.com added the comment:
You're right about r/strip(), thanks (new patch in attachment).
In your test you're checking whether returned facts
contain every requested fact, this is not guaranteed by RFC.
Yes, but we're using a dummy FTP server returning static
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8594
___
___
Python-bugs
Giampaolo Rodola' g.rod...@gmail.com added the comment:
Committed in r68309.
--
status: pending - open
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8594
Giampaolo Rodola' g.rod...@gmail.com added the comment:
Ok, that wasn't r68309. =)
I'm not sure what revision number is now that we're using mercurial.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8594
Giampaolo Rodola' g.rod...@gmail.com added the comment:
Thanks. Committed in r88761.
--
status: pending - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8594
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11406
___
___
Python
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11397
___
___
Python
Giampaolo Rodola' g.rod...@gmail.com added the comment:
Fixed in r88722.
I did not catch EAGAIN in connect() as it makes hang some tests.
--
resolution: - fixed
status: open - closed
versions: -Python 2.6
___
Python tracker rep...@bugs.python.org
Giampaolo Rodola' g.rod...@gmail.com added the comment:
OSX failure is tracked in issue 11351.
Closing this out as fixed.
--
resolution: accepted - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Giampaolo Rodola' g.rod...@gmail.com added the comment:
issue11351-5.patch no longer applies cleanly and I don't have an OSX box to
test against at the moment.
Could you please update your patch? If you tell me it's gonna fix the test I'm
going to commit it assuming everything is fine
Giampaolo Rodola' g.rod...@gmail.com added the comment:
Can you write an actual patch which includes tests?
Also, I think the z.patch in attachment is targeted for python 2.x as it does
not apply cleanly against the current trunk.
--
___
Python
Giampaolo Rodola' g.rod...@gmail.com added the comment:
I'm at e79364a6bed8/[svn r88726].
issue11351-5.patch applies and the test is ok, at least in respect
to sendfile:
Sorry, I'm still not used to the whole svn/mercurial change.
I applied your patch in r88729.
Let's see how the buildbot
Giampaolo Rodola' g.rod...@gmail.com added the comment:
=)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11351
___
___
Python-bugs-list mailing
Giampaolo Rodola' g.rod...@gmail.com added the comment:
Committed in r88734.
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9795
Giampaolo Rodola' g.rod...@gmail.com added the comment:
By writing a test I mean adding a unittest-based test case in
Lib/test/test_asynchat.py which fails before fixing Lib/asynchat.py and
succeeds afterwards.
Now, I'm not even sure I properly understood your bug exactly.
I've never used
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
resolution: - fixed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11351
___
___
Python-bugs
Giampaolo Rodola' g.rod...@gmail.com added the comment:
Thanks.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11351
___
___
Python-bugs-list
Giampaolo Rodola' g.rod...@gmail.com added the comment:
Patch in attachment updates the previous one which no longer applies cleanly in
py 3.3.
The control connection address is used for *both* passive (PASV) and active
(PORT) connections, which is the same approach I used in pyftpdlib
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
assignee: - giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1661754
Giampaolo Rodola' g.rod...@gmail.com added the comment:
we do not want that the same (host, port) is used for
both control and data connections.
I meant *port*, not (host, port).
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org
Giampaolo Rodola' g.rod...@gmail.com added the comment:
Again, it's not clear to me what you are complaining about.
Please try to be more clear and/or provide a patch.
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http
Giampaolo Rodola' g.rod...@gmail.com added the comment:
Please try to provide a patch which fixes (as in makes the test pass) this
specific issue only. As for other changes such as the code restyling you can
open a separate ticket with another patch
Giampaolo Rodola' g.rod...@gmail.com added the comment:
Ok for EAGAIN.
I'm not completely sure about EPIPE on recv() as it is not listed here:
http://www.kernel.org/doc/man-pages/online/pages/man2/recv.2.html
...although I think it's ok to treat it as an alias for connection lost anyway
Giampaolo Rodola' g.rod...@gmail.com added the comment:
Committed in r88679.
--
versions: +Python 3.3 -Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8594
Giampaolo Rodola' g.rod...@gmail.com added the comment:
Committed in r88680.
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11348
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8594
Giampaolo Rodola' g.rod...@gmail.com added the comment:
Of course the test fails: a process can't have a nice value higher than a
certain limit, which I think can vary depending on the UNIX variant in use. The
fix is not to use nice -n20
Giampaolo Rodola' g.rod...@gmail.com added the comment:
(socket.error, EOFError) after quit() indicates that the socket is
disconnected, in which case we should not raise any error (or at least, this is
the approach we're using in ftplib) while all other NNTPError related errors
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +rosslagerwall
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11323
___
___
Python-bugs
Giampaolo Rodola' g.rod...@gmail.com added the comment:
Thanks.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11325
___
___
Python-bugs-list
Giampaolo Rodola' g.rod...@gmail.com added the comment:
Unless there's a way to automatically call close() when a dispatcher instance
is no longer referenced (and I can't think of anything to do that) I'd say we
better close this as rejected
Giampaolo Rodola' g.rod...@gmail.com added the comment:
What about Doc/whatsnew/3.3.rst?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4761
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11333
___
___
Python
Giampaolo Rodola' g.rod...@gmail.com added the comment:
Patch in attachment set source_address attribute and updates doc.
It still keeps using support.find_unused_port() which is also used in
test_socket.py though [1], so it shouldn't cause problems.
http://svn.python.org/view/python/trunk/Lib
Giampaolo Rodola' g.rod...@gmail.com added the comment:
Committed in r88580.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10882
___
___
Python
Giampaolo Rodola' g.rod...@gmail.com added the comment:
Fixed.
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11232
Giampaolo Rodola' g.rod...@gmail.com added the comment:
Can you provide a patch including a test case?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11259
901 - 1000 of 1713 matches
Mail list logo
