[issue36985] typing.ForwardRef is undocumented

Change by Ivan Levkivskyi : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue36985] typing.ForwardRef is undocumented

Change by Ivan Levkivskyi : -- pull_requests: +14058 pull_request: https://github.com/python/cpython/pull/14220 ___ Python tracker <https://bugs.python.org/issue36

[issue33416] Add endline and endcolumn to every AST node

Change by Ivan Levkivskyi : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue36985] typing.ForwardRef is undocumented

Change by Ivan Levkivskyi : -- keywords: +patch pull_requests: +14053 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14216 ___ Python tracker <https://bugs.python.org/issu

[issue33416] Add endline and endcolumn to every AST node

Change by Ivan Levkivskyi : -- pull_requests: +14052 pull_request: https://github.com/python/cpython/pull/14214 ___ Python tracker <https://bugs.python.org/issue33

[issue28869] __module__ attribute is not set correctly for a class created by direct metaclass call

Ivan Levkivskyi added the comment: > Perhaps adding some section like "Notes on pickling dynamically-defined > classes" in the `pickle` module would be more appropriate? I think just a note with few sentences would be enough. -- __

[issue35766] Merge typed_ast back into CPython

Ivan Levkivskyi added the comment: Typo: "mypy todo list" should be "my todo list" :-) -- ___ Python tracker <https://bugs.python.org/issue35766> ___ _

[issue35766] Merge typed_ast back into CPython

Ivan Levkivskyi added the comment: > Would it be possible to document the change somewhere? Most of these things are in the docs for ast module. But indeed none of static typing related features have been added to What's New. I have an item on mypy todo list to add four typing PEPs plus

[issue28869] __module__ attribute is not set correctly for a class created by direct metaclass call

Ivan Levkivskyi added the comment: I think we can proceed with option A, but only if doesn't cause visible slow-down for creating ABCs (which is already slower that normal classes). TBH, I don't want to document A as "official" recipe (maybe however mention the problem in t

[issue33758] Unexpected success of test_get_type_hints_modules_forwardref in test_typing

Ivan Levkivskyi added the comment: Likely, the unexpected success can be avoided with clearing generic caches in test___all__ (it just imports whatever it can find and likely also test/mod_generics_cache.py), but I am also fine with just skipping it for now. Will you have time to make a PR

[issue35814] Syntax quirk with variable annotations

Change by Ivan Levkivskyi : -- pull_requests: +13679 pull_request: https://github.com/python/cpython/pull/13794 ___ Python tracker <https://bugs.python.org/issue35

[issue33416] Add endline and endcolumn to every AST node

Ivan Levkivskyi added the comment: So what was the conclusion about PyCode_New()? Situation is quite similar here (except that these functions are used less often). Should we just document the changes in What's New? -- ___ Python tracker <ht

[issue31006] typing.NamedTuple should add annotations to its constructor (__new__) parameters.

Ivan Levkivskyi added the comment: Thanks! It looks like this was fixed in typing and then forward ported to CPython. -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker <https://bug

[issue35814] Syntax quirk with variable annotations

Change by Ivan Levkivskyi : -- pull_requests: +13638 pull_request: https://github.com/python/cpython/pull/13757 ___ Python tracker <https://bugs.python.org/issue35

[issue36984] typing docs "versionadded" is inaccurate for many attributes

Change by Ivan Levkivskyi : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue36985] typing.ForwardRef is undocumented

Ivan Levkivskyi added the comment: Guido, I remember you were against exposing `ForwardRef` as public at some point, but recently you approved https://github.com/python/cpython/pull/13456 that added it to `typing.__all__`. I don't have any particular opinion on this, but if you don't object

[issue29262] Provide a way to check for *real* typing.Union instances

Change by Ivan Levkivskyi : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.8 -Python 3.6 ___ Python tracker <https://bugs.python.or

[issue29262] Provide a way to check for *real* typing.Union instances

Ivan Levkivskyi added the comment: New changeset 4c23aff065fb28aba789a211937a2af974842110 by Ivan Levkivskyi in branch 'master': bpo-29262: Add get_origin() and get_args() introspection helpers to typing (GH-13685) https://github.com/python/cpython/commit

[issue29262] Provide a way to check for *real* typing.Union instances

Change by Ivan Levkivskyi : -- keywords: +patch pull_requests: +13573 stage: -> patch review pull_request: https://github.com/python/cpython/pull/13685 ___ Python tracker <https://bugs.python.org/issu

[issue37058] Implement PEP 544: add Protocol to typing

Change by Ivan Levkivskyi : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue37058] Implement PEP 544: add Protocol to typing

Ivan Levkivskyi added the comment: New changeset 74d7f76e2c953fbfdb7ce01b7319d91d471cc5ef by Ivan Levkivskyi in branch 'master': bpo-37058: PEP 544: Add Protocol to typing module (GH-13585) https://github.com/python/cpython/commit/74d7f76e2c953fbfdb7ce01b7319d91d471cc5ef

[issue37045] Implement PEP 591: add Final qualifier and @final decorator to typing

Change by Ivan Levkivskyi : -- pull_requests: +13495 pull_request: https://github.com/python/cpython/pull/13588 ___ Python tracker <https://bugs.python.org/issue37

[issue37058] Implement PEP 544: add Protocol to typing

Change by Ivan Levkivskyi : -- keywords: +patch pull_requests: +13492 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/13585 ___ Python tracker <https://bugs.python.org/issu

[issue37058] Implement PEP 544: add Protocol to typing

New submission from Ivan Levkivskyi : The implementation would be basically copying some code from `typing_extension` and fixing some important known issues (such as renaming @runtime to @runtime_checkable and allowing sub-protocols of builtin protocols). Also ideally we should get rid

[issue37056] test_tools is failing on several buildbots

Ivan Levkivskyi added the comment: Duplicate of https://bugs.python.org/issue37053 -- resolution: -> duplicate stage: -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue37053] Tools/parser/unparse.py does not handle u"bar" correctly

Ivan Levkivskyi added the comment: On the other hand, if this causes troubles, feel free to just replace u"bar" with "bar" in that test. It is not really important. -- nosy: +levkivskyi ___ Python tracker <https://bug

[issue37045] Implement PEP 591: add Final qualifier and @final decorator to typing

Change by Ivan Levkivskyi : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue37049] Implement PEP 589: add TypedDict to typing

Change by Ivan Levkivskyi : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue37046] Implement PEP 586: add Literal type constructor to typing

Change by Ivan Levkivskyi : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue37049] Implement PEP 589: add TypedDict to typing

Ivan Levkivskyi added the comment: New changeset 135c6a56e55d2f4f8718b3b9f03ce3c692b15f0f by Ivan Levkivskyi in branch 'master': bpo-37049: PEP 589: Add TypedDict to typing module (GH-13573) https://github.com/python/cpython/commit/135c6a56e55d2f4f8718b3b9f03ce3c692b15f0f

[issue37046] Implement PEP 586: add Literal type constructor to typing

Ivan Levkivskyi added the comment: New changeset b891c465bb7d38a597c5c2ad547d7b19194f4dad by Ivan Levkivskyi in branch 'master': bpo-37046: PEP 586: Add Literal to typing module (#13572) https://github.com/python/cpython/commit/b891c465bb7d38a597c5c2ad547d7b19194f4dad

[issue37045] Implement PEP 591: add Final qualifier and @final decorator to typing

Ivan Levkivskyi added the comment: New changeset f367242d10ef36db38133a39ab7627f63099cba4 by Ivan Levkivskyi in branch 'master': bpo-37045: PEP 591: Add final qualifiers to typing module (GH-13571) https://github.com/python/cpython/commit/f367242d10ef36db38133a39ab7627f63099cba4

[issue37049] Implement PEP 589: add TypedDict to typing

Change by Ivan Levkivskyi : -- keywords: +patch pull_requests: +13481 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/13573 ___ Python tracker <https://bugs.python.org/issu

[issue37049] Implement PEP 589: add TypedDict to typing

New submission from Ivan Levkivskyi : The actual implementation is performed by type checkers like mypy. We just need to add `TypedDict` to the `typing` module. -- assignee: levkivskyi components: Library (Lib) messages: 343506 nosy: gvanrossum, levkivskyi priority: normal severity

[issue37046] Implement PEP 586: add Literal type constructor to typing

Change by Ivan Levkivskyi : -- keywords: +patch pull_requests: +13480 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/13572 ___ Python tracker <https://bugs.python.org/issu

[issue37046] Implement PEP 586: add Literal type constructor to typing

New submission from Ivan Levkivskyi : The actual implementation is performed by type checkers like mypy. We just need to add `Literal` to the `typing` module. -- assignee: levkivskyi components: Library (Lib) messages: 343503 nosy: gvanrossum, levkivskyi, michael0x2a priority: normal

[issue37045] Implement PEP 591: add Final qualifier and @final decorator to typing

Change by Ivan Levkivskyi : -- keywords: +patch pull_requests: +13479 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/13571 ___ Python tracker <https://bugs.python.org/issu

[issue37045] Implement PEP 591: add Final qualifier and @final decorator to typing

New submission from Ivan Levkivskyi : The actual implementation is performed by type checkers like mypy. We just need to add the names to the `typing` module. -- assignee: levkivskyi components: Library (Lib) messages: 343501 nosy: gvanrossum, levkivskyi, msullivan priority: normal

[issue36985] typing.ForwardRef is undocumented

Change by Ivan Levkivskyi : ___ Python tracker <https://bugs.python.org/issue36985> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/o

[issue36878] ast.parse with type_comments=True should allow extra text after # type: ignore

Ivan Levkivskyi added the comment: New changeset 933e1509ec6efa8e6ab8c8c7ce02059ce2b6d9b9 by Ivan Levkivskyi (Michael J. Sullivan) in branch 'master': bpo-36878: Track extra text added to 'type: ignore' in the AST (GH-13479) https://github.com/python/cpython/commit

[issue36972] Add SupportsIndex

Change by Ivan Levkivskyi : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue36972] Add SupportsIndex

Ivan Levkivskyi added the comment: New changeset 4c7a46eb3c009c85ddf2eb315d94d804745187d4 by Ivan Levkivskyi (Paul Dagnelie) in branch 'master': bpo-36972: Add SupportsIndex (GH-13448) https://github.com/python/cpython/commit/4c7a46eb3c009c85ddf2eb315d94d804745187d4 -- nosy

[issue36881] isinstance raises TypeError for metaclass with metaclass=ABCMeta

Ivan Levkivskyi added the comment: I think this is related to how `__subclasscheck__` is implemented in `ABCMeta`. I just checked this also happens in Python 3.6 (i.e. it is not something specific to the C version introduced in Python 3.7

[issue35814] Syntax quirk with variable annotations

Ivan Levkivskyi added the comment: Is PEP the best place for such updates? Maybe we can add a `versionchanged` note in https://docs.python.org/3/reference/simple_stmts.html#annotated-assignment-statements instead? -- ___ Python tracker <ht

[issue36881] isinstance raises TypeError for metaclass with metaclass=ABCMeta

Change by Ivan Levkivskyi : -- nosy: +levkivskyi ___ Python tracker <https://bugs.python.org/issue36881> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36810] Recursive type annotations do not work in documentation tests

Ivan Levkivskyi added the comment: > I don't think there's an actionable bug here. OK, then taking into account there is a decent workaround, I am closing this. -- resolution: -> not a bug stage: -> resolved status: open -> closed __

[issue36878] ast.parse with type_comments=True should allow extra text after # type: ignore

Ivan Levkivskyi added the comment: New changeset d8320ecb86da8df7c13d8bf8582507f736aa2924 by Ivan Levkivskyi (Michael J. Sullivan) in branch 'master': bpo-36878: Allow extra text after `# type: ignore` comments (GH-13238) https://github.com/python/cpython/commit

[issue36878] ast.parse with type_comments=True should allow extra text after # type: ignore

Ivan Levkivskyi added the comment: I like the idea of separate smaller PRs, the first one looks good. -- ___ Python tracker <https://bugs.python.org/issue36

[issue36810] Recursive type annotations do not work in documentation tests

Change by Ivan Levkivskyi : -- nosy: +gvanrossum, lukasz.langa ___ Python tracker <https://bugs.python.org/issue36810> ___ ___ Python-bugs-list mailing list Unsub

[issue36810] Recursive type annotations do not work in documentation tests

Ivan Levkivskyi added the comment: I think this is related to doc tests being executed in a namespace where the class definition is not available. I am not sure what is the best way here, a workaround is to explicitly pass the namespace, for example this passes: import typing def f(clazz

[issue15987] Provide a way to compare AST nodes for equality recursively

Ivan Levkivskyi added the comment: Btw, I am +1 on this feature (preferably with an option to check line, column, end line, and end column). I always wanted this, but never had time to actually implement this. -- nosy: +levkivskyi ___ Python

[issue36817] Add = to f-strings for easier debugging.

Ivan Levkivskyi added the comment: +1 from me (as a big fan of print-debugging). -- nosy: +levkivskyi ___ Python tracker <https://bugs.python.org/issue36

[issue36679] duplicate method definition in Lib/test/test_genericclass.py

Change by Ivan Levkivskyi : -- status: closed -> open ___ Python tracker <https://bugs.python.org/issue36679> ___ ___ Python-bugs-list mailing list Unsubscrib

[issue36679] duplicate method definition in Lib/test/test_genericclass.py

Ivan Levkivskyi added the comment: New changeset d111490a1f63db2dcc3714157726dc6a5c0fa1cd by Ivan Levkivskyi in branch '3.7': [3.7] bpo-36679: Rename duplicate test_class_getitem function (GH-12892) (GH-12978) https://github.com/python/cpython/commit/d111490a1f63db2dcc3714157726dc6a5c0fa1cd

[issue36679] duplicate method definition in Lib/test/test_genericclass.py

Ivan Levkivskyi added the comment: OK, backported the fix to 3.7. -- stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/i

[issue36679] duplicate method definition in Lib/test/test_genericclass.py

Ivan Levkivskyi added the comment: Thanks for fixing this! -- nosy: +levkivskyi resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue36679] duplicate method definition in Lib/test/test_genericclass.py

Change by Ivan Levkivskyi : -- pull_requests: +12904 stage: resolved -> patch review ___ Python tracker <https://bugs.python.org/issue36679> ___ ___ Python-

[issue36679] duplicate method definition in Lib/test/test_genericclass.py

Ivan Levkivskyi added the comment: Oh, sorry, didn't notice the backport is missing! -- ___ Python tracker <https://bugs.python.org/issue36679> ___ ___ Pytho

[issue36643] Forward reference is not resolved by dataclasses.fields()

Change by Ivan Levkivskyi : -- nosy: +levkivskyi ___ Python tracker <https://bugs.python.org/issue36643> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36591] Should be a typing.UserNamedTuple

Ivan Levkivskyi added the comment: This is a duplicate of https://github.com/python/typing/issues/431 We can of course close the other issue and keep this one open, but the other one has much more discussion. So I am closing this one. -- resolution: -> duplicate stage: -> re

[issue36555] PEP484 @overload vs. str/bytes

Ivan Levkivskyi added the comment: Mypy already takes first overload for ambiguous arguments. This example is however genuinely unsafe from the static typing point of view. Please read the docs https://mypy.readthedocs.io/en/latest/more_types.html#type-checking-the-variants

[issue36517] typing.NamedTuple does not support mixins

Ivan Levkivskyi added the comment: Hm, it looks like we can support this. I however don't think the proposed "patch" is the right way to fix it, since this makes the implementation with and without a mixin quite different. Also I am not sure I will have time to work on this in t

[issue31369] re.RegexFlag is not included in __all__, makes type inference less useful

Ivan Levkivskyi added the comment: I am totally fine with making RegexFlag public (this may be indeed useful for static typing purposes). -- ___ Python tracker <https://bugs.python.org/issue31

[issue36495] Out-of-bounds array reads in Python/ast.c

Change by Ivan Levkivskyi : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue36466] Adding a way to strip annotations from compiled bytecode

Ivan Levkivskyi added the comment: +1 from me. There are two ways to enable this: * Add -OOO that would remove all three: asserts, docstrings, annotations * Add separate --O-asserts --O-docstrings --O-annotations (or similar) I think I like the second option more. @cary Please note that our

[issue36466] Adding a way to strip annotations from compiled bytecode

Change by Ivan Levkivskyi : -- nosy: +gvanrossum, levkivskyi ___ Python tracker <https://bugs.python.org/issue36466> ___ ___ Python-bugs-list mailing list Unsub

[issue36470] dataclasses.replace raises an exception if InitVar with default argument is not provided.

Change by Ivan Levkivskyi : -- nosy: +levkivskyi ___ Python tracker <https://bugs.python.org/issue36470> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36320] typing.NamedTuple to switch from OrderedDict to regular dict

Ivan Levkivskyi added the comment: Good idea! This should be easy to fix/update, this was initially discussed in https://github.com/python/typing/issues/339. -- ___ Python tracker <https://bugs.python.org/issue36

[issue36287] Make ast.dump() not output optional default fields

Ivan Levkivskyi added the comment: We can probably also skip `type_ignores` list if it is empty (which will be the case in 99% situations). -- nosy: +levkivskyi ___ Python tracker <https://bugs.python.org/issue36

[issue36042] Setting __init_subclass__ and __class_getitem__ methods are in runtime doesnt make them class method.

Ivan Levkivskyi added the comment: I totally agree with Serhiy -- ___ Python tracker <https://bugs.python.org/issue36042> ___ ___ Python-bugs-list mailin

[issue35992] Metaclasses interfere with __class_getitem__

Change by Ivan Levkivskyi : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue35992] Metaclasses interfere with __class_getitem__

Ivan Levkivskyi added the comment: New changeset ac28147e78c45a6217d348ce90ca5281d91f676f by Ivan Levkivskyi in branch 'master': bpo-35992: Use PySequence_GetItem only if sq_item is not NULL (GH-11857) https://github.com/python/cpython/commit/ac28147e78c45a6217d348ce90ca5281d91f676f

[issue36009] weakref.ReferenceType is not a valid typing type

Ivan Levkivskyi added the comment: This question appeared several times before, and the conclusion is that we are not going to do this. There are many cases in standard library that are generic in stubs (and by nature) but are not declared as such at runtime, so we simply can't provide

[issue35992] Metaclasses interfere with __class_getitem__

Ivan Levkivskyi added the comment: Yes, I think this is a bug. Created a PR with a possible simple fix. -- nosy: +gvanrossum ___ Python tracker <https://bugs.python.org/issue35

[issue35992] Metaclasses interfere with __class_getitem__

Change by Ivan Levkivskyi : -- keywords: +patch pull_requests: +11889 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue35992> ___ _

[issue35987] Mypy and Asyncio import cannot be skipped

Ivan Levkivskyi added the comment: This is not a Python issue, this should be reported on typeshed tracker (but likely a duplicate of the issue mentioned by Karthikeyan). -- resolution: -> third party stage: -> resolved status: open -&g

[issue35975] Put back the ability to parse files where async/await aren't keywords

Change by Ivan Levkivskyi : -- nosy: +levkivskyi ___ Python tracker <https://bugs.python.org/issue35975> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35878] ast.c: end_col_offset may be used uninitialized in this function

Change by Ivan Levkivskyi : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue35878] ast.c: end_col_offset may be used uninitialized in this function

Change by Ivan Levkivskyi : -- keywords: +patch, patch pull_requests: +11636, 11637 stage: -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue35878] ast.c: end_col_offset may be used uninitialized in this function

Change by Ivan Levkivskyi : -- keywords: +patch, patch, patch pull_requests: +11636, 11637, 11638 stage: -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue35878] ast.c: end_col_offset may be used uninitialized in this function

Change by Ivan Levkivskyi : -- keywords: +patch pull_requests: +11636 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue35878> ___ _

[issue35834] get_type_hints exposes an instance of ForwardRef (internal class) in its result, with `from __future__ import annotations` enabled

Ivan Levkivskyi added the comment: It looks like an opposite side of https://github.com/python/typing/issues/508 (I wanted to work on it, but never had time to, sorry). This question appeared couple times before, and I think there are pros and cons for both returning a ForwardRef

[issue35808] Let's retire pgen

Change by Ivan Levkivskyi : -- nosy: +levkivskyi ___ Python tracker <https://bugs.python.org/issue35808> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35814] Syntax quirk with variable annotations

Change by Ivan Levkivskyi : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.8 -Python 3.7 ___ Python tracker <https://bugs.python.or

[issue35814] Syntax quirk with variable annotations

Ivan Levkivskyi added the comment: New changeset 62c35a8a8ff5854ed470b1c16a7a14f3bb80368c by Ivan Levkivskyi in branch 'master': bpo-35814: Allow same r.h.s. in annotated assignments as in normal ones (GH-11667) https://github.com/python/cpython/commit

[issue33416] Add endline and endcolumn to every AST node

Ivan Levkivskyi added the comment: Re-opening to track renaming of potentially public PyNode_AddChild() and PyParser_AddToken(). -- nosy: +vstinner resolution: fixed -> stage: resolved -> patch review status: closed -> open ___ Pytho

[issue35814] Syntax quirk with variable annotations

Change by Ivan Levkivskyi : -- keywords: +patch, patch pull_requests: +11473, 11474 stage: -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue35814] Syntax quirk with variable annotations

Change by Ivan Levkivskyi : -- keywords: +patch, patch, patch pull_requests: +11473, 11474, 11475 stage: -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue35814] Syntax quirk with variable annotations

Change by Ivan Levkivskyi : -- keywords: +patch pull_requests: +11473 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue35814> ___ _

[issue35814] Syntax quirk with variable annotations

Ivan Levkivskyi added the comment: Good catch! I think it was just overlooked rather than a conscious decision (unlike the left hand side, that generated lots of debates) I will make a PR to allow everything that is allowed on r.h.s. of a normal assignment

[issue33416] Add endline and endcolumn to every AST node

Ivan Levkivskyi added the comment: Buildbots are green, this can be now closed. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue33416] Add endline and endcolumn to every AST node

Ivan Levkivskyi added the comment: New changeset 9932a22897ef9905161dac7476e6976370e13515 by Ivan Levkivskyi in branch 'master': bpo-33416: Add end positions to Python AST (GH-11605) https://github.com/python/cpython/commit/9932a22897ef9905161dac7476e6976370e13515

[issue35766] Merge typed_ast back into CPython

Change by Ivan Levkivskyi : -- nosy: +levkivskyi ___ Python tracker <https://bugs.python.org/issue35766> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33416] Add endline and endcolumn to every AST node

Change by Ivan Levkivskyi : -- keywords: +patch, patch, patch pull_requests: +11329, 11330, 11331 stage: -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue33416] Add endline and endcolumn to every AST node

Change by Ivan Levkivskyi : -- keywords: +patch pull_requests: +11329 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue33416> ___ _

[issue33416] Add endline and endcolumn to every AST node

Change by Ivan Levkivskyi : -- keywords: +patch, patch pull_requests: +11329, 11330 stage: -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue22616] Allow connecting AST nodes with corresponding source ranges

Ivan Levkivskyi added the comment: Closed as superseded by https://bugs.python.org/issue33416 -- superseder: -> Add endline and endcolumn to every AST node ___ Python tracker <https://bugs.python.org/issu

[issue22616] Allow connecting AST nodes with corresponding source ranges

Change by Ivan Levkivskyi : -- nosy: +levkivskyi stage: -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue22616> ___ ___

[issue33416] Add endline and endcolumn to every AST node

Ivan Levkivskyi added the comment: > I'm sure we will find use cases though I doubt that many compiler syntax > errors would benefit (since a syntax error means that we don't have a > completely matched grammar rule). This is mostly useful for code analysis tools and IDEs. &g

[issue33416] Add endline and endcolumn to every AST node

Ivan Levkivskyi added the comment: FYI, I started working on this. I will have PR ready end of next week. Serhiy, I don't think we should keep both this and issue22616 open. Which one would you prefer to close? -- ___ Python tracker <ht

<    1   2   3   4   5   6   7   >