Jacek Kołodziej added the comment:
That's completely fine for me. I'm attaching the patch that just adds test for
__all__, then. :)
--
Added file: http://bugs.python.org/file44393/configparser_all.v2.patch
___
Python tracker <rep...@bugs.python.
Jacek Kołodziej added the comment:
> I would lean toward ensuring the test fails if someone adds a new
> implementation detail without an underscore prefix. It is also good to be
> explicit that the ISTERMINAL() etc functions are special cases.
Original patch meets these requireme
Changes by Jacek Kołodziej <kolodzi...@gmail.com>:
Added file: http://bugs.python.org/file44373/tokenize_all.v2.patch
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
Jacek Kołodziej added the comment:
Łukasz, Martin - I'm not sure how to proceed here, of course both ways out are
reasonable. I'd be happy to provide (however small) patch for either one
(adding Error to __all__ or just adding test for __all__). :)
My inner librarian would of course either
Jacek Kołodziej added the comment:
Thank you, Martin. :)
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue27105>
___
___
Pyth
Jacek Kołodziej added the comment:
> * All names in black list are implementation details. Names in white list are
> stable and already repeated in docs.
Assumption here is that implementation details shouldn't "look" public - they
should have names starting with "_&q
Jacek Kołodziej added the comment:
In this case I'm proposing a small patch just for testing pydoc module's
__all__ list and left the decision to you, whether to apply it or not. :)
Test doesn't use test.support.check__all__ (see msg266312) - blacklist would be
huge and expected list, as you
Jacek Kołodziej added the comment:
Martin:
> Is there any advantage to having the test case in a separate MiscTestCase
> class, as opposed to the existing CgiTests class?
Other than "the first test [well, that I know of] for __all__ list was in
separate class called MiscTestCase s
Jacek Kołodziej added the comment:
Thank you, Martin. I'm uploading amended patch.
--
Added file: http://bugs.python.org/file42988/mimetypes_all.v2.patch
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Jacek Kołodziej added the comment:
I disagree:
* blacklist has 48 entries now, whitelist would have 72 ones
* whitelisting requires adding new public names to two places instead of one
* test.support.check__all__ currently don't support whitelisting, it would need
to be added
Jacek Kołodziej added the comment:
Well, but it is documented in public docs:
cgi.test()
Robust test CGI script, usable as main program. Writes minimal HTTP headers
and formats all information provided to the script in HTML form.
Should I remove it from __all__ and probably from
Jacek Kołodziej added the comment:
David, what do you mean by "new format"? Can you point me to some existing code?
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.py
Jacek Kołodziej added the comment:
Per Martin's request, I've created a few new issues for next batch of module's
__all__ list updates:
* cgi: #27105
* configparser: #27106
* mailbox: #27107
* mimetypes: #27108
* plistlib: #27109
* smtpd: #27110
* tokenize: #27112
I've also looked at pydoc
Changes by Jacek Kołodziej <kolodzi...@gmail.com>:
Removed file: http://bugs.python.org/file42972/smtpd_all.patch
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
New submission from Jacek Kołodziej:
That's a child issue of #23883, created to propose a patch fixing tokenize
module's __all__ list.
Changes in tests go farther: I've changed import from
from tokenize import ...
to
import tokenize
and adjusted all its usages accordingly
Changes by Jacek Kołodziej <kolodzi...@gmail.com>:
Added file: http://bugs.python.org/file42977/smtpd_all.patch
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
New submission from Jacek Kołodziej:
That's a child issue of #23883, created to propose a patch fixing smtpd
module's __all__ list.
--
components: Library (Lib)
files: smtpd_all.patch
keywords: patch
messages: 266270
nosy: Unit03
priority: normal
severity: normal
status: open
title
New submission from Jacek Kołodziej:
That's a child issue of #23883, created to propose a patch fixing plistlib
module's __all__ list.
--
components: Library (Lib)
files: plistlib_all.patch
keywords: patch
messages: 266269
nosy: Unit03
priority: normal
severity: normal
status: open
New submission from Jacek Kołodziej:
That's a child issue of #23883, created to propose a patch fixing mimetypes
module's __all__ list.
--
components: Library (Lib)
files: mimetypes_all.patch
keywords: patch
messages: 266268
nosy: Unit03
priority: normal
severity: normal
status: open
New submission from Jacek Kołodziej:
That's a child issue of #23883, created to propose a patch fixing mailbox
module's __all__ list.
--
components: Library (Lib)
files: mailbox_all.patch
keywords: patch
messages: 266267
nosy: Unit03
priority: normal
severity: normal
status: open
title
New submission from Jacek Kołodziej:
That's a child issue of #23883, created to propose a patch fixing configparser
module's __all__ list.
--
components: Library (Lib)
files: configparser_all.patch
keywords: patch
messages: 266266
nosy: Unit03
priority: normal
severity: normal
status
New submission from Jacek Kołodziej:
That's a child issue of #23883, created to propose a patch fixing cgi module's
__all__ list.
--
components: Library (Lib)
files: cgi_all.patch
keywords: patch
messages: 266265
nosy: Unit03
priority: normal
severity: normal
status: open
title: cgi
Jacek Kołodziej added the comment:
LCK: it's a trait of float point arithmetic in computing:
https://docs.python.org/3.5/tutorial/floatingpoint.html . It's not a bug.
--
nosy: +Unit03
___
Python tracker <rep...@bugs.python.org>
Jacek Kołodziej added the comment:
Martin, yay! :) And thank you for the documentation correction.
Milap, Joel, Mauro, are you still interested in working on patches for
calendar/tarfile/fileinput patches? I intend to finish them up if that's not
the case
Changes by Jacek Kołodziej <kolodzi...@gmail.com>:
Added file: http://bugs.python.org/file41012/Issue23883_all.v6.patch
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
Jacek Kołodziej added the comment:
Serhiy, thank you for the review. I've made proposed changes (along with
rebasing Issue23883_all patch; Issue23883_test_gettext.v3.patch still applies
cleanly).
--
Added file:
http://bugs.python.org/file41013/Issue23883_support_check__all__.v6.patch
Jacek Kołodziej added the comment:
Does anyone have strong preference towards one of the propositions above?
TestCase subclass looks reasonable IMHO, but I'd not add that to the scope of
this issue (I'd be happy to implement it later, though).
Any suggestions
Changes by Jacek Kołodziej kolodzi...@gmail.com:
Added file:
http://bugs.python.org/file39976/Issue23883_support_check__all__.v5.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23883
Jacek Kołodziej added the comment:
raiseExecptions typo: Might be best to get the typo fixed first (maybe open a
separate issue, since it should probably be fixed starting from the 3.4
branch).
Done in #24678 and commited in 83b45ea19d00 .
Regarding OpcodeInfo, it is probably up to your
New submission from Jacek Kołodziej:
The typo in test_logging was discovered while working on #23883: in two tests
the addCleanup call reverts the raiseEx*ec*ptions value (instead of
raiseExceptions) in logging module and apparently that didn't manifest itself
in any way.
Patch attached
Jacek Kołodziej added the comment:
s/swapattr/swap_attr/g :) Done.
--
Added file: http://bugs.python.org/file39968/test_logging_typo.v2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24678
Jacek Kołodziej added the comment:
I'm getting patches ready with amendments you've proposed. Two things, though
(and two on Rietveld):
That raiseExecptions thing looks like a typo to me. The code should probably
be monkey patching the module variable, and restoring it after the test
Jacek Kołodziej added the comment:
In any case it is too late for 3.5.
Ok, next round of patches is based on default branch.
Jacek: If we used the ModuleType check, and somebody adds a module-level
constant (like logging.CRITICAL = 50), the test will automatically detect if
they forget
Changes by Jacek Kołodziej kolodzi...@gmail.com:
Added file:
http://bugs.python.org/file39867/Issue23883_support_check__all__.v4.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23883
Changes by Jacek Kołodziej kolodzi...@gmail.com:
Added file: http://bugs.python.org/file39868/Issue23883_test_gettext.v3.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23883
Jacek Kołodziej added the comment:
Nice work with the check__all__() function.
Thank you! :)
I left some comments on Reitveld. Also, it currently ignores items satisfying
either of these checks:
* isinstance(module_object, types.ModuleType)
* getattr(module_object, '__module__', None
Changes by Jacek Kołodziej kolodzi...@gmail.com:
Added file:
http://bugs.python.org/file39807/Issue23883_support_check__all__.v3.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23883
Changes by Jacek Kołodziej kolodzi...@gmail.com:
Added file: http://bugs.python.org/file39808/Issue23883_test_gettext.v2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23883
Jacek Kołodziej added the comment:
I've added previously missing test and docs for test.support.check__all__ in
Issue23883_support_check__all__.v2.patch . Awaiting review. :)
--
Added file:
http://bugs.python.org/file39760/Issue23883_support_check__all__.v2.patch
Jacek Kołodziej added the comment:
ftplib and threading have more functions
I've meant function and exceptions, of course. Sorry for the noise.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23883
Changes by Jacek Kołodziej kolodzi...@gmail.com:
Added file: http://bugs.python.org/file39734/Issue23883_test_gettext.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23883
Jacek Kołodziej added the comment:
Thank you for feedback, Martin. I've amended the the patch.
Next, I've prepared some initial test.support.check__all__ helper, based on
generalization of all previous patches. Its name/params' descriptions may be a
bit rough - amendments/suggestions
Jacek Kołodziej added the comment:
Hi! This is my first attempt at contributing so as always, feedback will be
well appreciated. :)
I meant to start small so I took a shot with csv module. In test, initial
expected set contains QUOTE_* because they don't provide __module__ attribute
Changes by Jacek Kołodziej kolodzi...@gmail.com:
Removed file: http://bugs.python.org/file39716/Issue23883_csv_all.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23883
Changes by Jacek Kołodziej kolodzi...@gmail.com:
Added file: http://bugs.python.org/file39717/Issue23883_csv_all.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23883
45 matches
Mail list logo
