[issue25386] msvcrt_putch/msvcrt_putwch don't check the return value of _putch/_putwch

2016-04-17 Thread Josh Snider
Josh Snider added the comment: Here's a patch that raises an exception when _put[w]ch and _get[w]ch[e] are run without a console. Like Eryk Sun says, the get's work fine if you do unget before hand. -- keywords: +patch nosy: +Josh Snider Added file: http://bugs.python.org/file42501

[issue26554] PC\bdist_wininst\install.c: Missing call to fclose()

2016-04-16 Thread Josh Snider
Josh Snider added the comment: I suggested some changes to your patch. Your patch should also add your name to the Misc/ACKS file as I don't currently see an Aatish listed there. -- nosy: +Josh Snider ___ Python tracker <rep...@bugs.python.

[issue26574] replace_interleave can be optimized for single character byte strings

2016-03-19 Thread Josh Snider
New submission from Josh Snider: replace_interleave in Objects/bytesobject.c and Objects/bytearrayobject.c can be optimized for the special case where the interleaving byte string is a single character. Here's some quick results from timeit showing that it's about three times faster

[issue26574] replace_interleave can be optimized for single character byte strings

2016-03-19 Thread Josh Snider
Josh Snider added the comment: Addresses review comments. -- Added file: http://bugs.python.org/file42180/bytes-2.patch ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/i