Changes by Martin Panter <vadmium...@gmail.com>:
--
components: +Windows
stage: test needed -> needs patch
title: subprocess.Popen(cwd) documentation -> subprocess.Popen(cwd)
documentation: Posix vs Windows
___
Python tracker <rep...@
Martin Panter added the comment:
Perhaps this is a duplicate of Issue 8557
--
nosy: +martin.panter
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Martin Panter added the comment:
Marco: I agree “Python reports an error” would have been simpler. That is what
I meant to say. Anyway, perhaps we should put
Python raises :exc:`IndentationError` if mixed tabs and spaces are causing
problems in leading whitespace.
In general, the exception
Changes by Martin Panter <vadmium...@gmail.com>:
--
resolution: -> duplicate
stage: -> resolved
status: open -> closed
superseder: -> subprocess.Popen(cwd) documentation
___
Python tracker <rep...@bugs.python.org>
Martin Panter added the comment:
It is hard to make sense of this without decoding your URLs, downloading the
repository and finding the relevant commit. Anyway, what you have posted sounds
like a duplicate of Issue 8557.
--
nosy: +martin.panter
resolution: -> duplicate
st
Changes by Martin Panter <vadmium...@gmail.com>:
--
title: Subprocess picks the wrong executable on Windows -> Subprocess searches
special directories before PATH on Windows
___
Python tracker <rep...@bugs.python.org>
<http
Martin Panter added the comment:
Not a big deal, but the change produces compiler warnings with GCC 6.1.1:
/home/proj/python/cpython/Objects/bytesobject.c: In function ‘bytes_subscript’:
/home/proj/python/cpython/Objects/bytesobject.c:1701:13: warning: ‘slicelength’
may be used uninitialized
Martin Panter added the comment:
FYI Victor, you can make non-C-contiguous buffers by slicing memoryview:
>>> struct.unpack(">L", memoryview(b"1234")[::-1])
Traceback (most recent call last):
File "", line 1, in
BufferError: memoryview: underlyin
Martin Panter added the comment:
Shouldn’t the top-level unpack() parameter be called “buffer” like the other
functions and methods, not “inputstr”?
--
nosy: +martin.panter
___
Python tracker <rep...@bugs.python.org>
<http://bugs.p
Martin Panter added the comment:
Misc/NEWS (and the commit message) say 1.2.10. Perhaps you meant 1.2.11?
--
nosy: +martin.panter
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Martin Panter added the comment:
Can you explain your broken pipe situation? Are you talking about a real-world
EPIPE operating on a pseudoterminal, or just a result of using a Unix socket to
emulate a PTY in the tests? Usually a broken pipe is an asynchronous condition.
You cannot predict
Martin Panter added the comment:
While I don’t have much opinion either way, here is a patch to remove the
existing dead code should that be the eventual outcome.
If the default implementations in the base class deferred to math.isfinite()
etc, that may help with compatibility
Martin Panter added the comment:
I pushed the simpler 2.6-compatible option. Keeping this open to check the
buildbot is happy overnight.
--
stage: needs patch -> resolved
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.or
New submission from Martin Panter:
The Windows FAQ
<https://docs.python.org/release/3.5.2/faq/windows.html#how-do-i-keep-editors-from-inserting-tabs-into-my-python-source>
mentions the “python -t” command-line option, but in Python 3 this option is
undocumented (and I understand has no
Martin Panter added the comment:
According to <https://bugs.python.org/issue17861#msg217417>, Ned says 2.6+ is
already needed to build the Python 3.5 documentation, so maybe Sphinx uses that.
--
___
Python tracker <rep...@bugs.python.o
Martin Panter added the comment:
Thanks Ned. Do you know what version of Python Sphinx uses (which runs
patchlevel.py)?
According to Issue 28039, David set up Python 2.7 so that “make touch” would
work. But the log also uses a python2.5 command, and apparently Python 2.3 also
installed
Martin Panter added the comment:
Thanks Senthil
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker <rep...@bugs.python.org>
<http://bugs.pyt
Martin Panter added the comment:
Of course, somehow I missed that
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue18842>
___
___
Martin Panter added the comment:
I think the general rule is to clean up code if you are doing something else in
nearby code, but don’t go out of your way with unnecessary cleanups to
arbitrary code. Otherwise it adds too much noise to the repository history,
review process, risks adding bugs
Martin Panter added the comment:
longobject_v5 looks good to me
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue20185>
___
___
Martin Panter added the comment:
For str.format_map(mapping), yes the parsing happens in
Objects/stringlib/unicode_format.h, but I don’t see that as a big problem.
Moving this back to “needs patch”, assuming it is okay to convert format_map().
Other than from that, there are just tricky
Martin Panter added the comment:
FWIW, here is an attempt to add Argument Clinic to the Objects/floatobject.c
and Objects/longobject.c implementations:
https://bugs.python.org/file33943/issue20185_conglomerate_v4.diff
https://bugs.python.org/file33989/clinic_longobject_v3.patch
If the methods
Martin Panter added the comment:
The O! and O& units are in a similar situation. They just use a different font
and descriptive name, rather than a specific type:
``O!`` (object) [*typeobject*, PyObject \*]
``O&`` (object) [*converter*, *anything*]
Following this lead, you could writ
New submission from Martin Panter:
Modules/ld_so_beos and Modules/ar_beos are no longer used since Be OS support
was dropped from the configure script for Python 3:
https://hg.python.org/cpython/diff/a5e984eda45a/configure.in
I propose to also remove the scripts.
--
components: Build
Martin Panter added the comment:
I’m not really an expert on non-ASCII URLs / IRIs. Maybe it is obvious to other
people that this is a good general implementation, but for me to thoroughly
review it I would need time to research the relevant RFCs, other
implementations, suitability
Martin Panter added the comment:
There is an Open Indiana buildbot
<http://buildbot.python.org/all/buildslaves/cea-indiana-x86>, that was passing
test_ctypes (until the buildbot went offline a few weeks ago). Would it be
possible to include a regression test case?
Also, in
Martin Panter added the comment:
Do you have an opinion of the proposal Shawn?
Judging by John’s “[the constant] is what the system provides, though
users may customize as needed”, it sounds like the patch is more than a bug
fix. Will it also mean find_library() will no longer search
Martin Panter added the comment:
I presume this is the same as in Issue 18543 (and a few other duplicates). Let
me know if I got it wrong.
IMO there is no easy fix. The best solution may be to just document the
behaviour as a limitation of the API, and design a new/improved API
Martin Panter added the comment:
Nothing has been fixed; I don’t see any evidence that this is “out of date”.
Here is a more complete test:
import urllib.request
opener = urllib.request.build_opener(urllib.request.HTTPCookieProcessor())
urllib.request.install_opener(opener)
request = 'https
Martin Panter added the comment:
More closely related: Issue 23448, about the same thing with urllib, which adds
the Host value itself. Any solution should be shared between both modules.
--
nosy: +martin.panter
___
Python tracker <
Martin Panter added the comment:
This works for me on Linux:
>>> signal.pthread_sigmask(signal.SIG_BLOCK, {signal.SIGUSR1})
set()
>>> import threading
>>> t = threading.Thread(target=sigwait)
>>> t.start()
Send me a signal, my PID is 24197
>>> os.kil
Changes by Martin Panter <vadmium...@gmail.com>:
--
components: +Library (Lib)
stage: -> needs patch
versions: +Python 3.6, Python 3.7
___
Python tracker <rep...@bugs.python.org>
<http://bugs.pyt
Martin Panter added the comment:
Sorry I meant Issue 10656. I recently committed a fix regarding out-of-tree
builds and ld_so_aix, and it sounds like you were thinking of reverting that.
--
___
Python tracker <rep...@bugs.python.org>
Martin Panter added the comment:
I don’t run AIX, but my understanding is there are three distinct branches
(2.7, 3.5, and 3.6+). Some of the following is guessed, so please correct me if
I am wrong:
Python 2.7:
_sysconfigdata.py incorrectly created with LDSHARED = Modules/ld_so_aix.
Result
Changes by Martin Panter <vadmium...@gmail.com>:
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker <rep...@bugs.python.org>
<http://bu
Martin Panter added the comment:
Just a minor update with an extra get_payload() test I missed before
--
versions: +Python 3.7
Added file: http://bugs.python.org/file46400/policy-flag.v2.patch
___
Python tracker <rep...@bugs.python.org>
Martin Panter added the comment:
ERROR: test_annotation_usage_with_methods (test.test_typing.NamedTupleTests)
--
Traceback (most recent call last):
File "/home/proj/python/cpython/Lib/test/test_typing.py",
Martin Panter added the comment:
Is it okay to only fix this in 3.5+? 3.4 only gets security fixes now.
Either way, the “with” statement changes is not a bug fix and should only go
into 3.7.
--
nosy: +martin.panter
stage: -> commit rev
Changes by Martin Panter <vadmium...@gmail.com>:
Added file: http://bugs.python.org/file46399/expressions-py3.7_v17.diff
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
Martin Panter added the comment:
Updated patch for 2.7, which I plan to commit soon. Corresponding Py 3 patch
coming soon.
--
Added file: http://bugs.python.org/file46398/expressions-py2.7_v17.diff
___
Python tracker <rep...@bugs.python.org>
Changes by Martin Panter <vadmium...@gmail.com>:
--
versions: +Python 3.6 -Python 3.5
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
Martin Panter added the comment:
There is an inconsistency when parsing with headersonly=True. According to the
documentation, get_payload() with message/rfc822 should should return a list of
Message objects, not a string. But using headersonly=True produces a
non-multipart Message object
Martin Panter added the comment:
It is not obvious what the effect of not calling addFailure() is, but perhaps
this is related to Issue 25894? Failure and error statuses are not immediately
reported from subtests.
--
nosy: +martin.panter
___
Python
Martin Panter added the comment:
If the assignment is completely removed, won’t this break the test when run
from the source or build tree (as opposed to when installed)? Or at least make
the situation worse: the AIX buildbot is already failing test_distutils, but at
least it is looking
Martin Panter added the comment:
I added this behaviour in 3.6 on purpose via Issue 26685.
The change also impacted Yury (see the original bug thread), but if I
understood correctly, he eventually decided that it highlighted a problem in
asyncio or his code (though the resulting asyncio pull
Changes by Martin Panter <vadmium...@gmail.com>:
--
dependencies: +Clarify the behavior of __eq__() returning NotImplemented
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
Changes by Martin Panter <vadmium...@gmail.com>:
--
title: Clarify the behavior of NotImplemented -> Clarify the behavior of
__eq__() returning NotImplemented
___
Python tracker <rep...@bugs.python.org>
<http://bugs.pyt
Martin Panter added the comment:
Patch looks good to me.
BTW in Issue 27409 I proposed a patch listing more of these.
--
nosy: +martin.panter
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Changes by Martin Panter <vadmium...@gmail.com>:
--
dependencies: +Document socket.SOL_SOCKET
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.o
Martin Panter added the comment:
Patch looks good, apart from one little thing (see review)
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Martin Panter added the comment:
Will keep this in mind, but my time is rather limited, so I may not get to it
(and I wouldn’t want to discourage other people from working on it)
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.p
Martin Panter added the comment:
The warning for urllib2.urlopen() was removed in revision 1882157b298a.
However, a couple other warnings were converted to “Changed in version 2.7.9”
in revision fb83916c3ea1, which seems safer to me.
Removing documentation almost seems like a step backwards
Martin Panter added the comment:
Here is a port of the documentation to Python 2. Main differences:
* Default rules for order comparisons are different
* Not all kinds of objects inherit from object()
* str(), unicode() compatibility
* xrange() only seems to have default comparability
* NAN
Martin Panter added the comment:
Have you seen <https://docs.python.org/2.7/reference/datamodel.html#slots>?
There is also <https://docs.python.org/2.7/glossary.html#term-slots>.
--
assignee: -> docs@python
components: +Documentation
nosy: +docs@python
Martin Panter added the comment:
If you read the whole paragraph carefully, I don't think it is too misleading.
"In particular, tuples and lists . . ." suggests the author was just trying to
say that a tuple never compares equal to a list. Maybe we just need to make
that mo
Martin Panter added the comment:
D.get(key[, default]) -> D[key] if key in D, else default.
There is no big problem with that. D is defined at the start. The only thing I
would have suggested is avoid using square brackets to mean two things in the
one expression. Since it is no lon
Martin Panter added the comment:
The Python 3 version of this was rewritten in Issue 12067. It would be good to
port the new text to the Python 2 version, although that is not straightforward
because of various differences between Python 2 and 3.
That doesn’t rule out making smaller more
Changes by Martin Panter <vadmium...@gmail.com>:
--
dependencies: +Wrong documentation (Language Ref) for unicode and str comparison
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
Martin Panter added the comment:
Thanks for the feedback
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker <rep...@bugs.python.org>
<http://bugs.pyt
Martin Panter added the comment:
In general, HTTP URLs are supposed to be ASCII only. Newer protocols (e.g. RTSP
which is based on HTTP) specifically allow UTF-8 encoding. But it would be
wrong for Python’s HTTP library to assume UTF-8 is wanted everywhere.
Especially in a domain name (e.g
Martin Panter added the comment:
Issue 9679: Focusses on encoding just the DNS name
Issue 20559: Maybe a duplicate, or opportunity for better documentation or
error message as a bug fix?
Andreas’s patch just proposes a new function called quote_uri(). It would need
documentation. We already
Martin Panter added the comment:
See also Issue 3991 with proposals for handling non-ASCII as new features.
--
nosy: +martin.panter
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Martin Panter added the comment:
Maybe a duplicate of Issue 16623
--
nosy: +martin.panter
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Martin Panter added the comment:
I would say it is more important to fit in with the surrounding style than
mindlessly follow PEP 7. IMO the indentation in the configure script is a mess,
but if we fix it up, it should probably be done separately to adding this extra
flag
Martin Panter added the comment:
V3 of my patch skips the Readline tests in cases involving non-ASCII bytes when
the locale seen by Readline would be ASCII. Readline may translate the
non-ASCII bytes to escape sequences, and treat them as special Meta (Alt) key
combinations. This behaviour
Martin Panter added the comment:
So the problem seems to be that Python assumes Readline’s encoding is UTF-8,
but Readline actually uses ASCII (depending on locale variables). The code at
the start of the test is supposed to catch when add_history() calls
PyUnicode_EncodeLocale() and fails
New submission from Martin Panter:
The “unittest” documentation has “tests cases” written a few times. This
doesn’t seem right to me, but I thought I should get a second opinion in case I
missed something.
--
assignee: docs@python
components: Documentation
files: tests-cases.patch
New submission from Martin Panter:
On a Linux computer I have LANG=en_US.utf8 set. Python 3 initializes the locale
with this setting (see revision 43e32b2b4004):
>>> locale.setlocale(locale.LC_CTYPE) # Get setting initialized by Python
'en_US.utf8'
In Lib/test/test__
Martin Panter added the comment:
Looks like Doc/tools/susp-ignored.csv needs updating:
$ make -C Doc/ suspicious
[. . .]
writing output... [ 49%] library/hashlib
WARNING: [library/hashlib:502] ":vatrogasac" found in ">>> coo
Changes by Martin Panter <vadmium...@gmail.com>:
--
title: ld_so_aix not found -> config/ld_so_aix not found: old dir name
___
Python tracker <rep...@bugs.python.org>
<http://bugs.pyt
Martin Panter added the comment:
So are you saying you tried patching Python 2 and/or 3, but did not see any
relevant change at all?
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Changes by Martin Panter <vadmium...@gmail.com>:
--
title: AIX shared library extension modules installation broken -> AIX shared
library extension modules installation broken: wrong dir names
___
Python tracker <rep...@bugs.pytho
New submission from Martin Panter:
The __dict__ attribute of class objects is documented as being a (standard)
dictionary, but implemented with a proxy object. I propose to clarify the
documentation in “Custom classes” under
<https://docs.python.org/3.5/reference/datamodel.html#the-stand
Martin Panter added the comment:
The patch for Issue 26228 proposes an improvement to the situation, although it
is not perfect and does not include a test. I wonder if it is possible to
replace fork() and execlp() with a subprocess.Popen invokation, at least in a
new Python release
Martin Panter added the comment:
Thanks Jim
--
nosy: +martin.panter
resolution: -> fixed
stage: -> resolved
status: open -> closed
versions: +Python 3.7
___
Python tracker <rep...@bugs.python.org>
<http://bugs.pyt
Martin Panter added the comment:
Inada, I think you messed up the positioning of bits of the patch. E.g. there
are now test methods declared inside a helper function (rather than a test
class).
Since it seems other people are in favour of this API, I would like to expand
it a bit to cover
Martin Panter added the comment:
.
The documentation did not get merged properly into 3.6+. And even in 3.5, under
METH_KEYWORDS, I propose to change “The flag is typically combined with
METH_VARARGS” to “The flag must be combined . . .”.
The remaining issue15657_36.diff patch looks out
Martin Panter added the comment:
Both fixes (join and replace) look good to me. However I don’t think it is
necessary to change the exception message in 3.5 or 3.6.
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Martin Panter added the comment:
FTR I thought the consensus was not to backport these fixes unless there was a
demonstrated problem: <https://bugs.python.org/issue1621#msg144499>, though
personally, I would be in favour of backporting in many cases.
Regarding str.join() in unicode.
Changes by Martin Panter <vadmium...@gmail.com>:
--
dependencies: +failing overflow checks in replace_*
___
Python tracker <rep...@bugs.python.org>
<http://bugs.pytho
Martin Panter added the comment:
David you are right, thanks.
Dustin: the exact patch you want is revision 0a55e039d25f.
--
resolution: -> duplicate
status: open -> closed
superseder: -> Python 3.6 on Windows doesn't seed Random() we
Martin Panter added the comment:
It looks like the logic for handling an error seeding from urandom is reversed:
<https://hg.python.org/cpython/rev/45fc0c83ed42#l6.66>. Random_seed_urandom()
actually returns -1 if is an exception set, and 0 if it was successful.
The result would be a
Martin Panter added the comment:
Isn’t cElementTree useful and recommended in 2.7? It would be awkward to
deprecate it in Python 3. But I guess the other cases should be okay to
deprecate in 3.7.
--
nosy: +martin.panter
___
Python tracker <
Martin Panter added the comment:
.
Thanks for the explanation. It sounds like the Readline library assumes an
ASCII-only locale and sets its “convert-meta” variable to “on”. But Python
assumes UTF-8 and inputs b"\xC3\xAB" to the terminal. Readline converts the
input to two escape
Changes by Martin Panter <vadmium...@gmail.com>:
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker <rep...@bugs.python.org>
<http://bu
Martin Panter added the comment:
Other tests are skipped if libc_name is None, so your assertion is inconsistent.
FTR there are reports open about problems with bootstrap files like asdl_c.py,
e.g. Issue 28143 proposing to port that file to Python 3, and Issue 23404 about
the future of “make
Martin Panter added the comment:
It is still not clear what change you were proposing. Perhaps factor out the
common code for ADSLGEN and OPCODEHGEN? If so, that has been done as part of
Issue 26662 in 3.5+.
--
nosy: +martin.panter
superseder: -> configure/Makefile doesn't ch
Martin Panter added the comment:
I would prefer to commit Chris’s fix for BSDs (Issue 26228) with a regression
test. I can explain in the commit message who contributed to which part, or do
two separate commits if you prefer. But the point is to add the test with the
fix. I’m not going
Martin Panter added the comment:
The code in test.py is not realistic. It spawns children only to terminate them
straight away, and you could easily reap each child after calling terminate().
You might have more influence with a realistic use case.
Victor has committed a fix
Martin Panter added the comment:
The user can access pipes and close them directly, or keep their own reference.
I don’t think detach() should touch pipes, and __exit__() should probably
continue to close them. Maybe call the method detach_pid() if that makes it
clearer that pipes
Martin Panter added the comment:
The ResourceWarning was added by Issue 26741.
I agree that there are legitimate reasons why pre-3.6 code may avoid calling
Popen.wait() and equivalent. Victor opened Issue 27068 about adding a
Popen.detach() method, which such code could use to opt out
Martin Panter added the comment:
Regarding reopening Issue 10656, whatever you think is more appropriate. You
just have to judge whether it is the same use case, the same code affected, etc.
Issue 16189 and Issue 25825 were about updating to match recent changes to
directory names, and I
Martin Panter added the comment:
FWIW Issue 28290 was also opened about this pragma directive being not
recognized by a compiler called xlC on AIX.
--
nosy: +martin.panter
___
Python tracker <rep...@bugs.python.org>
<http://bugs.p
Martin Panter added the comment:
Ignore my comment about contrib agreement, that must have come through recently
:)
--
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/i
Martin Panter added the comment:
Hi Cornelius and thanks for the work. Since the patch adds a significant amount
of code, I think you might have to sign the contributor agreement:
<http://www.python.org/psf/contrib/contrib-form/>. You can do it in a web
browser.
I would like to revie
Martin Panter added the comment:
Behaviour change in Free BSD as I understand. Nothing changed in Python, but
perhaps older versions of Free BSD behaved like Linux and raised EIO (or
another errno; it is not clear).
--
___
Python tracker <
Martin Panter added the comment:
Thanks, I will try to look at that some time
--
stage: needs patch -> resolved
status: open -> closed
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
New submission from Martin Panter:
Normally there is a Python 3 compatibility warning emitted when a class is
based on object, implements __eq__(), but does not define __hash__():
$ python -3 -c 'class C(object): __eq__ = lambda self, other: True'
-c:1: DeprecationWarning: Overriding __eq__
Martin Panter added the comment:
David is right. The 120 code was added in Issue 5319, as a way of indicating a
problem in the final stages of the interpreter exiting. The two conditions that
trigger this are calling the flush() method on sys.stdout and sys.stderr. If
you add a dummy flush
Martin Panter added the comment:
Example where an implementation like Serhiy’s was not good enough:
<https://bugs.python.org/issue29130#msg284437>. In that case, the lack of
flush() method causes a subtle problem.
--
___
Python tracke
501 - 600 of 4209 matches
Mail list logo
