[issue44972] Add workflow_dispatch trigger for GitHub Actions jobs

2021-08-26 Thread Ryan Mast (nightlark)
Ryan Mast (nightlark) added the comment: > How is manually dispatched workflows different from just opening a PR to your > own fork? I do that from time to time in order to run the CI before opening a > PR against the CPython repo. Here are a few thoughts on how it is different: -

[issue44974] Warning about "Unknown child process pid" in test_asyncio

2021-08-26 Thread Ryan Mast (nightlark)
Ryan Mast (nightlark) added the comment: I haven't gotten a chance to narrow it down much yet, it might be that it is occurs more often on systems with a low core count/higher load -- a bit hard to tell with it being intermittent though

[issue44972] Add workflow_dispatch trigger for GitHub Actions jobs

2021-08-23 Thread Ryan Mast (nightlark)
Ryan Mast (nightlark) added the comment: > On the main request, provided the workflow_dispatch is only triggerable by > non-contributors in their own fork (without any of our tokens/etc.) then it's > fine by me. If it allows anyone to trigger CI builds against the main repo, >

[issue44972] Add workflow_dispatch trigger for GitHub Actions jobs

2021-08-23 Thread Ryan Mast (nightlark)
Ryan Mast (nightlark) added the comment: Another observation, first-time contributors need a maintainer to approve the workflows for their PRs -- from the looks of it that isn't an instant process and could take a few days, so this also gives first-time contributors a way to check

[issue44972] Add workflow_dispatch trigger for GitHub Actions jobs

2021-08-21 Thread Ryan Mast (nightlark)
Change by Ryan Mast (nightlark) : -- nosy: +brett.cannon ___ Python tracker <https://bugs.python.org/issue44972> ___ ___ Python-bugs-list mailing list Unsub

[issue44972] Add workflow_dispatch trigger for GitHub Actions jobs

2021-08-21 Thread Ryan Mast (nightlark)
Change by Ryan Mast (nightlark) : -- nosy: +steve.dower ___ Python tracker <https://bugs.python.org/issue44972> ___ ___ Python-bugs-list mailing list Unsub

[issue44972] Add workflow_dispatch trigger for GitHub Actions jobs

2021-08-21 Thread Ryan Mast (nightlark)
Change by Ryan Mast (nightlark) : -- keywords: +patch pull_requests: +26328 stage: -> patch review pull_request: https://github.com/python/cpython/pull/27873 ___ Python tracker <https://bugs.python.org/issu

[issue44972] Add workflow_dispatch trigger for GitHub Actions jobs

2021-08-21 Thread Ryan Mast (nightlark)
Change by Ryan Mast (nightlark) : -- nosy: +FFY00 ___ Python tracker <https://bugs.python.org/issue44972> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue44972] Add workflow_dispatch trigger for GitHub Actions jobs

2021-08-21 Thread Ryan Mast (nightlark)
Ryan Mast (nightlark) added the comment: * The main constraint is that the the `workflow_dispatch` trigger must be in the GHA workflow yaml files for the branch to be selectable as a target on the Actions tab when manually triggering a workflow. Having the change made to the main branch

[issue44972] Add workflow_dispatch trigger for GitHub Actions jobs

2021-08-21 Thread Ryan Mast (nightlark)
New submission from Ryan Mast (nightlark) : Adding a workflow_dispatch trigger for the GitHub Actions jobs makes it possible to run the GHA CI jobs for commits to branches in a fork without opening a "draft/WIP" PR to one of the main release branches. It also runs the SSL t

[issue41322] unittest: deprecate test methods returning non-None values

2021-08-20 Thread Ryan Mast (nightlark)
Ryan Mast (nightlark) added the comment: The new issue for the failing test is bpo-44968 -- ___ Python tracker <https://bugs.python.org/issue41322> ___ ___ Pytho

[issue44968] Fix/remove test_subprocess_wait_no_same_group from test_asyncio tests

2021-08-20 Thread Ryan Mast (nightlark)
New submission from Ryan Mast (nightlark) : A deprecation made in bpo-41322 uncovered issues with test_subprocess_wait_no_same_group in test_asyncio that seems to have been broken for some time. Reverting to a similar structure prior to the refactoring in https://github.com/python/cpython

[issue41322] unittest: deprecate test methods returning non-None values

2021-08-20 Thread Ryan Mast (nightlark)
Ryan Mast (nightlark) added the comment: Sure, I'll open a new issue. -- ___ Python tracker <https://bugs.python.org/issue41322> ___ ___ Python-bugs-list mailin

[issue41322] unittest: deprecate test methods returning non-None values

2021-08-20 Thread Ryan Mast (nightlark)
Ryan Mast (nightlark) added the comment: Would rewriting the test so that it doesn't yield be the right fix? ``` def test_subprocess_wait_no_same_group(self): # start the new process in a new session connect = self.loop.subprocess_shell

[issue41322] unittest: deprecate test methods returning non-None values

2021-08-20 Thread Ryan Mast (nightlark)
Ryan Mast (nightlark) added the comment: It looks like since GH-27748 got merged, `test_subprocess_wait_no_same_group` in `test_asyncio` has been failing for the Ubuntu SSL tests. -- nosy: +rmast ___ Python tracker <https://bugs.python.

[issue20041] TypeError when f_trace is None and tracing.

2021-08-18 Thread Ryan Mast (nightlark)
Change by Ryan Mast (nightlark) : -- nosy: +rmast ___ Python tracker <https://bugs.python.org/issue20041> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue26545] [doc] os.walk is limited by python's recursion limit

2021-08-18 Thread Ryan Mast (nightlark)
Change by Ryan Mast (nightlark) : -- nosy: +rmast ___ Python tracker <https://bugs.python.org/issue26545> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue15373] copy.copy() does not properly copy os.environment

2021-08-18 Thread Ryan Mast (nightlark)
Change by Ryan Mast (nightlark) : -- nosy: +rmast ___ Python tracker <https://bugs.python.org/issue15373> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue44942] Add number pad enter bind to TK's simpleDialog

2021-08-17 Thread Ryan Mast (nightlark)
Ryan Mast (nightlark) added the comment: I'm new to this system, if I'm understanding https://devguide.python.org/triaging/#nosy-list then it looks like the people listed for `tkinter` should be added to the Nosy List? -- nosy: +gpolo, serhiy.storchaka

[issue44942] Add number pad enter bind to TK's simpleDialog

2021-08-17 Thread Ryan Mast (nightlark)
New submission from Ryan Mast (nightlark) : Tk the number pad enter and main enter keys separately. The number pad enter button should be bound to `self.ok` in simpleDialog's `Dialog` class so that both enter buttons have the same behavior. A PR for this change has been submitted on GitHub

[issue24905] Allow incremental I/O to blobs in sqlite3

2021-08-17 Thread Ryan Mast (nightlark)
Ryan Mast (nightlark) added the comment: It looks like this has a PR that just needs rebasing, then it will be ready for another review. -- nosy: +rmast ___ Python tracker <https://bugs.python.org/issue24

[issue33140] shutil.chown should not be defined in Windows

2021-08-17 Thread Ryan Mast (nightlark)
Ryan Mast (nightlark) added the comment: If this function were to be implemented on Windows would the preferred approach be the one described in the initial message for this issue of creating a Windows `os.set_owner` function that uses the appropriate Windows API calls to change owner