Change by Sanyam Khurana :
--
nosy: +CuriousLearner
___
Python tracker
<https://bugs.python.org/issue40358>
___
___
Python-bugs-list mailing list
Unsubscribe:
Sanyam Khurana added the comment:
Closed Issue 37853 as a duplicate.
Adding Fatih's comment from there for urllib.parse.urlparse
-
No problem for these:
"http://localhost:9100;
"http://user:password@loca
Sanyam Khurana added the comment:
Duplicate of Issue 37854
Fatih,
Thank you for your report. I'm marking this one as a duplicate of another.
Request you to not create multiple issues at once for the same thing.
Thank you!
--
nosy: +CuriousLearner
resolution: -> duplicate
st
Sanyam Khurana added the comment:
I've checked and approved this PR.
This needs a core-review now.
Thanks, Hai for your contribution.
--
nosy: +CuriousLearner, Mariatta
___
Python tracker
<https://bugs.python.org/issue37
Sanyam Khurana added the comment:
Thanks for the bug report Alan & for the PR Ngalim!
I've checked the current docs and this is a valid bug.
I've also reviewed the Pull request and it looks good to me.
@Mariatta, @Senthil can you please have a look at this?
Many thanks!
--
Sanyam Khurana added the comment:
Hi Eric,
This is with reference to https://bugs.python.org/issue10528.
I've looked at the PR and it's ready for a core-review:
https://github.com/python/cpython/pull/15161
Can you please take a look at this?
Many thanks!
--
nosy: +bethard
Change by Sanyam Khurana :
--
pull_requests: +14935
pull_request: https://github.com/python/cpython/pull/15206
___
Python tracker
<https://bugs.python.org/issue26
Change by Sanyam Khurana :
--
nosy: +CuriousLearner
___
Python tracker
<https://bugs.python.org/issue37819>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Sanyam Khurana :
--
nosy: +CuriousLearner
versions: +Python 3.7, Python 3.8, Python 3.9 -Python 3.4
___
Python tracker
<https://bugs.python.org/issue19
Sanyam Khurana added the comment:
Adding 3.9 to this bug. I've reviewed the PR and it looks good to me.
--
nosy: +CuriousLearner
versions: +Python 3.9
___
Python tracker
<https://bugs.python.org/issue34
Change by Sanyam Khurana :
--
nosy: +CuriousLearner
___
Python tracker
<https://bugs.python.org/issue32912>
___
___
Python-bugs-list mailing list
Unsubscribe:
Sanyam Khurana added the comment:
Hey ankostis,
Please let us know if you've time to complete the PR.
Thank you :)
--
___
Python tracker
<https://bugs.python.org/issue26
Sanyam Khurana added the comment:
Removing 3.5 as it is in security fix mode. Also, the PR just contains the test
case that would trigger the condition and not the actual code.
--
nosy: +CuriousLearner
stage: -> patch review
versions: +Python 3.7, Python 3.8, Python 3.9 -Python
Sanyam Khurana added the comment:
Hi Jakub,
Welcome and thank you for contributing. I've added a suggestion on your pull
request.
Python 3.6 and Python 3.5 are in security fixes stage, so I've removed those
tags from this bug.
--
nosy: +CuriousLearner
type: -> behavior
versi
Sanyam Khurana added the comment:
I'm changing the versions to Python 3.8 and 3.9 for this bug.
--
versions: +Python 3.8, Python 3.9 -Python 3.4, Python 3.5
___
Python tracker
<https://bugs.python.org/issue16
Sanyam Khurana added the comment:
Hi Alexander,
Can you please address the reviews and turn this patch into a GitHub PR, please?
--
nosy: +CuriousLearner
___
Python tracker
<https://bugs.python.org/issue16
Sanyam Khurana added the comment:
I was trying to search the mailing list archives for the URL posted by Eric:
http://mail.python.org/pipermail/python-list/2011-May/1272604.html
But I couldn't find it. Also that URL shows 404.
Eric, is it possible for you to post the correct link
Sanyam Khurana added the comment:
Backport successfully completed. Marking this as fixed.
Congrats on your first patch, Krishna!
Thank you, everyone!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
_
Sanyam Khurana added the comment:
Mariatta, I see it also needs a backport to 3.8
We can close it once the backport is completed.
--
nosy: +CuriousLearner
___
Python tracker
<https://bugs.python.org/issue36
Change by Sanyam Khurana :
--
pull_requests: +13409
___
Python tracker
<https://bugs.python.org/issue21914>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Sanyam Khurana :
--
pull_requests: +13170
___
Python tracker
<https://bugs.python.org/issue36822>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Sanyam Khurana :
--
pull_requests: +13135
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue18387>
___
___
Python-bugs-lis
Sanyam Khurana added the comment:
The issue does not seem to be on 3.7 and master branch, so I'm closing the bug
as well as the pull request.
--
resolution: -> out of date
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.5, Python 3.6 -P
Change by Sanyam Khurana :
--
keywords: +patch
pull_requests: +13083
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue36836>
___
___
Py
Sanyam Khurana added the comment:
I had to clean-up my build a bit, and it seems like it's not really happening
on 3.6, but it is still an issue with 3.4, 3.5, etc.
I've added a PR for 3.5 to resolve the issue.
--
assignee: -> CuriousLearner
title: Test Suite not working on
Change by Sanyam Khurana :
--
title: Test Suite not working on 3.4 and 3.5 on MacOS Mojave -> Test Suite not
working on 3.4, 3.5, 3.6, 3.7 on MacOS Mojave
___
Python tracker
<https://bugs.python.org/issu
New submission from Sanyam Khurana :
I was testing this issue: https://bugs.python.org/issue10598
I checked both Python 3.4, 3.5, 3.6 and tagged commit v3.7.0 but I'm not able
to run the test suite on any of them. I'm currently working on MacOS Mojave
10.14.4
I landed on issue https
Sanyam Khurana added the comment:
Hey Ron,
Friendly ping :)
Can you please convert this into a pull request?
--
nosy: +CuriousLearner
versions: +Python 3.9
___
Python tracker
<https://bugs.python.org/issue18
Change by Sanyam Khurana :
--
keywords: +patch
pull_requests: +13058
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
New submission from Sanyam Khurana :
While working on translations, I saw a minor grammatical error in
`Doc/glossary.rst`:
```
* The default Python prompt of the interactive shell when entering
code for an indented code block ...
```
should be
```
* The default Python
Sanyam Khurana added the comment:
Hello Anjali,
This PR is still lurking for your updates from almost 11 months. Please let us
know if you're still working on this, else, we'll get this in.
Thanks for your work!
--
___
Python tracker
<ht
Sanyam Khurana added the comment:
Given that Python 2.x and async chat is deprecated in favor of new async io,
we're better in closing this issue, rather than trying to apply this cleanly on
the master branch.
--
nosy: +CuriousLearner
resolution: -> out of date
stage: patch rev
Sanyam Khurana added the comment:
I'm working on applying this patch cleanly and writing a test for this.
However, it seems I'm unable to import `readline` in compiled version of
Python. I'm trying to provide a path to the installation of readline in my
system using LDFLAGS
Change by Sanyam Khurana :
--
pull_requests: +11416, 11417, 11418
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Sanyam Khurana :
--
pull_requests: +11416, 11417
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issue31506>
___
_
Change by Sanyam Khurana :
--
pull_requests: +11416
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issue31506>
___
___
Python-
Sanyam Khurana added the comment:
Hi Victor,
Senthil reverted the backport commit on 2.7 branch.
Is there a way I can test reference leaks in CPython? Is it using valgrind or
some other tool? Can you please point me to that?
I can then see if I can fix this on 2.7
Thanks
Change by Sanyam Khurana :
--
pull_requests: +10999, 11000
___
Python tracker
<https://bugs.python.org/issue24746>
___
___
Python-bugs-list mailing list
Unsub
Change by Sanyam Khurana :
--
pull_requests: +10999
___
Python tracker
<https://bugs.python.org/issue24746>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Sanyam Khurana :
--
keywords: +patch, patch, patch
pull_requests: +10670, 10671, 10672
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Sanyam Khurana :
--
keywords: +patch
pull_requests: +10670
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue35614>
___
___
Py
Change by Sanyam Khurana :
--
keywords: +patch, patch
pull_requests: +10670, 10671
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issu
Sanyam Khurana added the comment:
Hey R. David Murray,
Where do you think the unit test for `doctest` should be placed?
Should it be in `test_doctest.py`?
--
assignee: -> CuriousLearner
versions: +Python 3.7, Python 3.8
___
Python trac
Change by Sanyam Khurana :
--
assignee: -> CuriousLearner
___
Python tracker
<https://bugs.python.org/issue24746>
___
___
Python-bugs-list mailing list
Un
Sanyam Khurana added the comment:
Thanks for your suggestion, Tim.
I've fixed the patch and it is ready for review at
https://github.com/python/cpython/pull/10639
--
___
Python tracker
<https://bugs.python.org/issue24
Sanyam Khurana added the comment:
> Unfortunately I was reminded a few days ago that there is a commit hook that
> prevents patches containing trailing whitespace from being committed to the
> repository.
Is this still the case?
I tried to figure out writing the test case, but I c
Change by Sanyam Khurana :
--
pull_requests: +9886
stage: test needed -> patch review
___
Python tracker
<https://bugs.python.org/issue24746>
___
___
Python-
Change by Sanyam Khurana :
--
pull_requests: +9886, 9887
stage: test needed -> patch review
___
Python tracker
<https://bugs.python.org/issue24746>
___
___
Py
Sanyam Khurana added the comment:
PR is up for a review: https://github.com/python/cpython/pull/10616
--
___
Python tracker
<https://bugs.python.org/issue25
Change by Sanyam Khurana :
--
pull_requests: +9862
___
Python tracker
<https://bugs.python.org/issue25439>
___
___
Python-bugs-list mailing list
Unsubscribe:
Sanyam Khurana added the comment:
I'm working on applying the patch cleanly to master branch for this.
Also adding 3.8 and 3.7 as candidates for the bug.
--
versions: +Python 3.7, Python 3.8
___
Python tracker
<https://bugs.python.org/issue25
Change by Sanyam Khurana :
--
assignee: -> CuriousLearner
nosy: +CuriousLearner
___
Python tracker
<https://bugs.python.org/issue25439>
___
___
Python-
Sanyam Khurana added the comment:
Patch added in PR: https://github.com/python/cpython/pull/10591
--
nosy: +CuriousLearner
___
Python tracker
<https://bugs.python.org/issue18
Change by Sanyam Khurana :
--
pull_requests: +9837
___
Python tracker
<https://bugs.python.org/issue18859>
___
___
Python-bugs-list mailing list
Unsubscribe:
Sanyam Khurana added the comment:
The change in current PR is very minor and looks good enough that aligns the
docs with the docstring and functionality of `ZipFile.writestr` as described.
Can a core-contributor, please look at this?
Also, I'm adding 3.8 for this change.
--
nosy
Sanyam Khurana added the comment:
Marking this fixed via
https://github.com/python/cpython/commit/ffc5a14d00db984c8e72c7b67da8a493e17e2c14
and
https://github.com/python/cpython/commit/fc8205cb4b87edd1c19e1bcc26deaa1570f87988
Thanks, everyone!
--
resolution: -> fixed
stage: pa
Sanyam Khurana added the comment:
Marking this bug as fixed via https://github.com/python/cpython/pull/8645
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Sanyam Khurana added the comment:
Hey Nick, Serhiy
The patch is up for your review. Any updates on this?
--
___
Python tracker
<https://bugs.python.org/issue15
Sanyam Khurana added the comment:
Hi,
I agree that it can break backward compatibility. But maybe we can add some
sort of warning message?
The entire motive of this is to get new folks to understand how a function is
ideally defined and called
New submission from Sanyam Khurana :
I noticed this while reviewing the code.
The print function works like:
```
print (5)
```
This works with user-defined function too.
Ideally, this is a function call and we should return an error stating that
there shouldn't be any spaces between
Sanyam Khurana added the comment:
Yeah, that is understandable. I've reverted major chunk of it. Just in the http
client file, I've added blank lines where ever necessary (which I think won't
change the blame information for any of the code :))
Would that be okay?
Also, I did a change
Sanyam Khurana added the comment:
Hey Conrad,
I've merged your fixes as well. They are in the PR now. Also added your name in
the NEWS entry :)
@Vinay, I noticed that there are linting errors in `test_logging.py`. Does it
make sense to issue a separate Pull Request to fix those? Currently
Sanyam Khurana added the comment:
+1 to Terry's suggestion.
I've reviewed xtreak's PR and it looks good to me.
--
nosy: +CuriousLearner
___
Python tracker
<https://bugs.python.org/issue34
Sanyam Khurana added the comment:
Hello Anjali,
As far as I remember, you started this in a PyDelhi Dev Sprint. So, just wanted
to check around, if you're looking for any help :)
--
nosy: +CuriousLearner
___
Python tracker
<ht
Sanyam Khurana added the comment:
Hey Rajalakshmi,
Are you still working on this issue? Is there anything we can help you with?
--
nosy: +CuriousLearner
___
Python tracker
<https://bugs.python.org/issue21
Sanyam Khurana added the comment:
Sure Conrad,
Yeah, indeed. The patch didn't apply cleanly, so I"ve done it manually.
I've raised the PR here: https://github.com/python/cpython/pull/8633
I'll check your patch and merge :)
Thanks for your help too!
I'm adding Python 3.7 and Pytho
Change by Sanyam Khurana :
--
pull_requests: +8138
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issue24255>
___
___
Python-
Sanyam Khurana added the comment:
That's okay Eryn. We really appreciate all your help.
I will take this patch forward :)
--
___
Python tracker
<https://bugs.python.org/issue24
Sanyam Khurana added the comment:
On, yes, I think I missed the first point, earlier. Thank You! I did the
changes.
--
___
Python tracker
<https://bugs.python.org/issue29
Sanyam Khurana added the comment:
Hey Tim,
> @CuriousLearner, does the PR also include Nick's first suggested change?
> Here:
"""
=
Bitwise operations only make sense for integers. The result of bitwise
operations is calculated as though carried ou
Sanyam Khurana added the comment:
Hi,
My perception with all the discussion and WIP patch is that we can ideally
limit the no. of subclasses shown only for object, and not for any other class.
>From that list, the only unhelpful ones with > 4 items, in my opinion, appear
>to b
Sanyam Khurana added the comment:
Seems good to me. I've made the changes in the PR.
--
___
Python tracker
<https://bugs.python.org/issue29710>
___
___
Pytho
Sanyam Khurana added the comment:
This is strange.
I cloned the repo again at some other location, and I can build it successfully.
In my older clone, however, it shows me this error, despite running a `make
clean`.
Any idea on what is the problem here?
--
nosy: +vstinner
priority
New submission from Sanyam Khurana :
The step for configuration works correctly and gives a makefile.
On running `./make` the following traceback is produced:
```
$ make
Sanyam Khurana <sanyam.khuran...@gmail.com> added the comment:
Hey Jurjen,
Do you mind converting your patch in a Pull request please?
--
nosy: +CuriousLearner
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python
Sanyam Khurana <sanyam.khuran...@gmail.com> added the comment:
Carol, Yes, I've raised a PR.
Currently, I've updated the docs for `str.isidentifier` clarifying the usage of
`keyword.iskeyword`
For updating the docstring of `keyword.iskeyword`, I saw that `Lib/Keyword.py`
defines this o
Change by Sanyam Khurana <sanyam.khuran...@gmail.com>:
--
keywords: +patch
pull_requests: +5850
stage: needs patch -> patch review
___
Python tracker <rep...@bugs.python.org>
<https://bugs.pyt
Change by Sanyam Khurana <sanyam.khuran...@gmail.com>:
--
keywords: +patch
pull_requests: +5849
stage: -> patch review
___
Python tracker <rep...@bugs.python.org>
<https://bugs.py
Sanyam Khurana <sanyam.khuran...@gmail.com> added the comment:
Hey David,
I'm working on this issue. Will submit a PR in a while :)
--
nosy: +CuriousLearner
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python
Sanyam Khurana <sanyam.khuran...@gmail.com> added the comment:
Hey Erin,
Can you please convert your patch to a PR on Github?
--
nosy: +CuriousLearner
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python
Change by Sanyam Khurana <sanyam.khuran...@gmail.com>:
--
assignee: -> CuriousLearner
versions: +Python 3.8 -Python 3.7
___
Python tracker <rep...@bugs.python.org>
<https://bugs.py
Change by Sanyam Khurana <sanyam.khuran...@gmail.com>:
--
pull_requests: +5217
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python
Sanyam Khurana <sanyam.khuran...@gmail.com> added the comment:
Thanks for the report Mayank!
As we discussed offline, it is indeed reproducible if someone uses `print` on
the same line (such as in this case, where a loop is used).
I will look into this
Sanyam Khurana <sanyam.khuran...@gmail.com> added the comment:
Victor, there is just one last thing to do in here.
All the links pointing to Github (that are build automatically) are permanently
redirected from https://github.com/python/cpython/tree/master/* to
https://github.com/
Sanyam Khurana <sanyam.khuran...@gmail.com> added the comment:
I've changed the version to 3.7. Not sure if this would need a backport since
this is a new feature. So, I'll defer this call to a core developer. I've
created a PR for the new feature.
--
versions: +Python 3.7 -Pyth
Change by Sanyam Khurana <sanyam.khuran...@gmail.com>:
--
pull_requests: +4940
stage: needs patch -> patch review
___
Python tracker <rep...@bugs.python.org>
<https://bugs.py
Change by Sanyam Khurana <sanyam.khuran...@gmail.com>:
--
pull_requests: +4932
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python
Change by Sanyam Khurana <sanyam.khuran...@gmail.com>:
--
keywords: +patch
pull_requests: +4931
stage: needs patch -> patch review
___
Python tracker <rep...@bugs.python.org>
<https://bugs.pyt
Change by Sanyam Khurana <sanyam.khuran...@gmail.com>:
--
pull_requests: +4708
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python
Sanyam Khurana <sanyam.khuran...@gmail.com> added the comment:
Serhiy, can you please elaborate on that a bit? I'll try to fix this.
--
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python
Sanyam Khurana <sanyam.khuran...@gmail.com> added the comment:
Leslie, would you like to work on a patch for this?
--
nosy: +CuriousLearner
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python
Sanyam Khurana <sanyam.khuran...@gmail.com> added the comment:
Ezra, can you please convert your patch to a Pull Request on Github?
--
nosy: +CuriousLearner
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python
Change by Sanyam Khurana <sanyam.khuran...@gmail.com>:
--
pull_requests: +4643
stage: needs patch -> patch review
___
Python tracker <rep...@bugs.python.org>
<https://bugs.pyt
Sanyam Khurana <sanyam.khuran...@gmail.com> added the comment:
Nick,
I think the error messages are incorrect. We expect error message to be `takes
no argument` rather than `takes exactly one argument`. Can you please confirm
that?
I think for the class without any method ove
Sanyam Khurana <sanyam.khuran...@gmail.com> added the comment:
I'll work on a fix for this and issue a PR.
--
nosy: +CuriousLearner
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python
Sanyam Khurana <sanyam.khuran...@gmail.com> added the comment:
Hey Victor, thanks for the update.
I was confused about how the macro was replaced in the previous version.
--
___
Python tracker <rep...@bugs.python.org>
<https://
Change by Sanyam Khurana <sanyam.khuran...@gmail.com>:
--
keywords: +patch
pull_requests: +4601
stage: test needed -> patch review
___
Python tracker <rep...@bugs.python.org>
<https://bugs.pyt
Sanyam Khurana <sanyam.khuran...@gmail.com> added the comment:
Even a simple use of ternary operator instead of using if-else inside do-while
to handle the macro like:
#define SET_DECODE_ERROR(NAME, LEN) \
pymain->err = ((LEN) == (size_t)-2) \
? _Py_INIT_USER_ERR("cannot
Sanyam Khurana <sanyam.khuran...@gmail.com> added the comment:
I tried to resolve the issue by trying to figure out the syntax for the
SET_DECODE_ERROR macro.
I tried to call a function from the macro, and eventually do the checking in
that function.
Second way I tried was to r
Sanyam Khurana <sanyam.khuran...@gmail.com> added the comment:
I used git bisect to track down the commit that broke the build.
Seems like this is the SHA: ebac19dad6263141d5db0a2c923efe049dba99d2
ebac19dad6263141d5db0a2c923efe049dba99d2 is the first bad commit
1 - 100 of 136 matches
Mail list logo
