[issue45278] RuntimeError on race on weakset concurrent iteration

2021-09-24 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- components: +Library (Lib) nosy: +fdrake, pitrou, serhiy.storchaka versions: +Python 3.10, Python 3.11, Python 3.9 ___ Python tracker <https://bugs.python.org/issue45

[issue45026] More compact range iterator

2021-09-24 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I do not see any difference in iterating small integers: $ ./python -m pyperf timeit -s 'r = range(1)' 'for i in r: pass' PR 27986: Mean +- std dev: 174 us +- 9 us PR 28176: Mean +- std dev: 172 us +- 10 us

[issue45274] Race condition in Thread._wait_for_tstate_lock()

2021-09-23 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I am not sure that it can be solved at Python level. Possible solutions: * Add a Lock method (or just a builtin function) which acquires and immediately releases the lock, without possibility to interrupt. if lock._blink(block, timeout

[issue40346] Add random.BaseRandom to ease implementation of subclasses

2021-09-23 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Matt, your example works in 3.11. In earlier versions you need to override the __new__ method. -- ___ Python tracker <https://bugs.python.org/issue40

[issue40116] Regression in memory use of shared key dictionaries for "compact dicts"

2021-09-23 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: There are several common idioms which do not work well with shared dictionaries. 1. Class attributes as defaults. If most instances of the class have the default value for some attribute, it can be set as the class attribute. It saves memory because most

[issue41203] Replace references to OS X in documentation with macOS

2021-09-23 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you Patrick. We had several PRs for fixing macOS references here and there, they were closed in favor of this larger PR. -- resolution: -> fixed stage: patch review -> resolved status: open -&g

[issue41203] Replace references to OS X in documentation with macOS

2021-09-23 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset f1d5cdef57fea961646c52db7a60d1f110e0eaa6 by Miss Islington (bot) in branch '3.9': bpo-41203: Replace Mac OS X and OS X with macOS (GH-28515) (GH-28524) https://github.com/python/cpython/commit/f1d5cdef57fea961646c52db7a60d1f110e0eaa6

[issue41203] Replace references to OS X in documentation with macOS

2021-09-23 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 1493e1a40d04a048cce9c5080ec47478a4941054 by Miss Islington (bot) in branch '3.10': bpo-41203: Replace Mac OS X and OS X with macOS (GH-28515) (GH-28523) https://github.com/python/cpython/commit/1493e1a40d04a048cce9c5080ec47478a4941054

[issue41203] Replace references to OS X in documentation with macOS

2021-09-22 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 36122e18148c5b6c78ebce1d36d514fd7cf250f5 by Serhiy Storchaka in branch 'main': bpo-41203: Replace Mac OS X and OS X with macOS (GH-28515) https://github.com/python/cpython/commit/36122e18148c5b6c78ebce1d36d514fd7cf250f5

[issue45256] Remove the usage of the cstack in Python to Python calls

2021-09-22 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: AFAIK Mark Shannon proposed this idea, but it was rejected. -- nosy: +gvanrossum, serhiy.storchaka ___ Python tracker <https://bugs.python.org/issue45

[issue41203] Replace references to OS X in documentation with macOS

2021-09-22 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: +26907 pull_request: https://github.com/python/cpython/pull/28515 ___ Python tracker <https://bugs.python.org/issue41

[issue45026] More compact range iterator

2021-09-21 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: length_hint(), not len(). Its cost is included in microbenchmark for list(), where it is followed by iterating 2000 items. Calling operator.length_hint() in Python: $ ./python -m pyperf timeit -s 'it = iter(range(1000)); from operator import length_hint

[issue24076] sum() several times slower on Python 3 64-bit

2021-09-21 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you again Stefan. Now no doubts are left. BTW, pyperf gives more stable results. I use it if have any doubts (either the results of timeit are not stable or the difference is less than say 10

[issue24076] sum() several times slower on Python 3 64-bit

2021-09-21 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you. Could you please test PGO builds? -- ___ Python tracker <https://bugs.python.org/issue24076> ___ ___ Python-bug

[issue45176] Many regtest failures on Windows with non-ASCII account name

2021-09-21 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Not only sys.executable. Sources of non-ASCII paths: * sys.executable * __file__ of the stdlib or test modules * the current working directory * the temporary directory The last one is the most common in these failures. Tests fail when a non-ASCII path

[issue24076] sum() several times slower on Python 3 64-bit

2021-09-21 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: What are microbenchmark results for PR 28469 in comparison with the baseline? -- ___ Python tracker <https://bugs.python.org/issue24

[issue35712] Make NotImplemented unusable in boolean context

2021-09-20 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Interesting, it is because object().__eq__(object()) returns NotImplemented instead of False. object.__eq__ could return False if arguments have same type (or in some other cases). I think it would not break anything, and it would fix your case. But I am

[issue45229] Always use unittest for collecting tests in regrtests

2021-09-20 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset e6ba992288fdbe71aa808cfb6955f6f99da7e349 by Serhiy Storchaka in branch 'main': bpo-45229: Make pickle tests discoverable (GH-28467) https://github.com/python/cpython/commit/e6ba992288fdbe71aa808cfb6955f6f99da7e349

[issue45229] Always use unittest for collecting tests in regrtests

2021-09-20 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset a856364cc920d8b16750fd1fadc902efb509754c by Serhiy Storchaka in branch 'main': bpo-45229: Use doctest.DocTestSuite instead of run_doctest (GH-28468) https://github.com/python/cpython/commit/a856364cc920d8b16750fd1fadc902efb509754c

[issue45229] Always use unittest for collecting tests in regrtests

2021-09-20 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: +26867 pull_request: https://github.com/python/cpython/pull/28468 ___ Python tracker <https://bugs.python.org/issue45

[issue45229] Always use unittest for collecting tests in regrtests

2021-09-20 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: +26866 pull_request: https://github.com/python/cpython/pull/28467 ___ Python tracker <https://bugs.python.org/issue45

[issue45229] Always use unittest for collecting tests in regrtests

2021-09-20 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 5822ab672a1d26ff1837103c1ed8e4c3c2a42b87 by Serhiy Storchaka in branch '3.9': [3.9] bpo-45229: Remove test_main in many tests (GH-28405) (GH-28456) https://github.com/python/cpython/commit/5822ab672a1d26ff1837103c1ed8e4c3c2a42b87

[issue45229] Always use unittest for collecting tests in regrtests

2021-09-19 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset bedce3538cca3469ac3efc614ef062367cbb2ff1 by Serhiy Storchaka in branch '3.10': [3.10] bpo-45229: Remove test_main in many tests (GH-28405) (GH-28455) https://github.com/python/cpython/commit/bedce3538cca3469ac3efc614ef062367cbb2ff1

[issue45229] Always use unittest for collecting tests in regrtests

2021-09-19 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: +26858 pull_request: https://github.com/python/cpython/pull/28456 ___ Python tracker <https://bugs.python.org/issue45

[issue45229] Always use unittest for collecting tests in regrtests

2021-09-19 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset a6241773869b80f2b1cac63f26ba646aa808a8db by Serhiy Storchaka in branch 'main': bpo-45229: Fix setUpModule in test_ssl (GH-28454) https://github.com/python/cpython/commit/a6241773869b80f2b1cac63f26ba646aa808a8db

[issue45229] Always use unittest for collecting tests in regrtests

2021-09-19 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: +26857 pull_request: https://github.com/python/cpython/pull/28455 ___ Python tracker <https://bugs.python.org/issue45

[issue45229] Always use unittest for collecting tests in regrtests

2021-09-19 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: +26856 pull_request: https://github.com/python/cpython/pull/28454 ___ Python tracker <https://bugs.python.org/issue45

[issue45229] Always use unittest for collecting tests in regrtests

2021-09-19 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 40348acc180580371d25f75f46b27048e35f2435 by Serhiy Storchaka in branch 'main': bpo-45229: Remove test_main in many tests (GH-28405) https://github.com/python/cpython/commit/40348acc180580371d25f75f46b27048e35f2435

[issue30856] unittest.TestResult.addSubTest should be called immediately after subtest finishes

2021-09-19 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue30856] unittest.TestResult.addSubTest should be called immediately after subtest finishes

2021-09-19 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 664448d81f41c5fa971d8523a71b0f19e76cc136 by Serhiy Storchaka in branch 'main': bpo-30856: Update TestResult early, without buffering in _Outcome (GH-28180) https://github.com/python/cpython/commit/664448d81f41c5fa971d8523a71b0f19e76cc136

[issue45238] Fix debug() in IsolatedAsyncioTestCase

2021-09-19 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: It turned out be more complicated than I expected. We need to keep the even loop after getting exception in debug() for having ability to run doCleanup() etc. The option is to close the even loop in __del__. But we should ensure that it is closed before

[issue45026] More compact range iterator

2021-09-18 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Iterating large integers: $ ./python -m pyperf timeit -s 'r = range(0, 10**20, 3**35)' 'for i in r: pass' baseline: Mean +- std dev: 223 us +- 10 us PR 27986: Mean +- std dev: 128 us +- 4 us PR 28176: Mean +- std dev: 99.0 us +- 3.7 us $ ./python -m

[issue45216] Remove redundant information from difflib docstrings

2021-09-18 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- title: Remove redundand information from difflib docstrings -> Remove redundant information from difflib docstrings ___ Python tracker <https://bugs.python.org/issu

[issue36674] "unittest.TestCase.debug" should honour "skip" (and other test controls)

2021-09-18 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: See issue45238 for debug() in IsolatedAsyncioTestCase. -- ___ Python tracker <https://bugs.python.org/issue36674> ___ ___

[issue45238] Fix debug() in IsolatedAsyncioTestCase

2021-09-18 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +26852 stage: -> patch review pull_request: https://github.com/python/cpython/pull/28449 ___ Python tracker <https://bugs.python.org/issu

[issue45238] Fix debug() in IsolatedAsyncioTestCase

2021-09-18 Thread Serhiy Storchaka
New submission from Serhiy Storchaka : Currently debug() does not work in IsolatedAsyncioTestCase subclasses. It runs synchronous code (setUp(), tearDown(), synchronous tests and cleanup functions), but does not run any asynchronous code (asyncSetUp(), asyncTearDown(), asynchronous tests

[issue36674] "unittest.TestCase.debug" should honour "skip" (and other test controls)

2021-09-18 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset dea59cf88adf5d20812edda330e085a4695baba4 by Serhiy Storchaka in branch 'main': bpo-36674: Honour the skipping decorators in TestCase.debug() (GH-28446) https://github.com/python/cpython/commit/dea59cf88adf5d20812edda330e085a4695baba4

[issue36674] "unittest.TestCase.debug" should honour "skip" (and other test controls)

2021-09-18 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Since the behavior of debug() was different for the following cases: @skip('skipping') def test1(self): pass @othedecorator @skip('skipping') def test2(self): pass def test3(self): self.skipTest('skipping') I

[issue36674] "unittest.TestCase.debug" should honour "skip" (and other test controls)

2021-09-18 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: PR 28446 makes TestCase.debug() honoring the skipping decorator. The difference with PR 13180: 1. It does not run setUp() and tearDown() for tests decorated with the skipping decorator, as TestCase.run(). 2. It has the same behavior for tests decorated

[issue36674] "unittest.TestCase.debug" should honour "skip" (and other test controls)

2021-09-18 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: +26849 pull_request: https://github.com/python/cpython/pull/28446 ___ Python tracker <https://bugs.python.org/issue36

[issue42389] test_multiprocessing: @requires_hashdigest() prevents test discovery

2021-09-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Fixed in issue45042. -- nosy: +serhiy.storchaka resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> Many multiprocessing tests are silently skipped since 3.9 ___ Py

[issue45187] Some tests in test_socket are not run

2021-09-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 6c50f23ae085ec66f320a26a3f0a6c60d7f2b29d by Miss Islington (bot) in branch '3.9': bpo-45187: Fix dangling threads in test_socket.CreateServerFunctionalTest (GH-28422) (GH-28424) https://github.com/python/cpython/commit

[issue14408] Support ./python -m unittest in test_socket

2021-09-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: It has been done in issue45187. The problem with reaping threads was solved by using setUpModule() and addModuleCleanup(). Matt's patch contains also replacing calls of concrete class __init__s with using super(). It can be applied. -- nosy

[issue16968] Fix test discovery for test_concurrent_futures.py

2021-09-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: test_concurrent_futures was made discoverable by Victor Stinner in issue37421. It used tearDownModule() to run threading_cleanup() and reap_children(). -- status: open -> pending ___ Python tracker <

[issue38063] Modify test_socket.py to use unittest test discovery

2021-09-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I has merged similar PR in issue45187. Although it required to fix some existing bugs first. -- nosy: +serhiy.storchaka ___ Python tracker <https://bugs.python.org/issue38

[issue45229] Always use unittest for collecting tests in regrtests

2021-09-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you Zachary, I almost forgot about that issue. The goal of this issue is to make regrtests using test discovery instead of manually composed lists of test classes. Of course it requires that tests should be discoverable. And most of them already

[issue45187] Some tests in test_socket are not run

2021-09-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 51ebb7f4f5e9bdcf8279a1d91be9569706f6bead by Serhiy Storchaka in branch 'main': bpo-45187: Fix dangling threads in test_socket.CreateServerFunctionalTest (GH-28422) https://github.com/python/cpython/commit

[issue45187] Some tests in test_socket are not run

2021-09-17 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: +26834 pull_request: https://github.com/python/cpython/pull/28422 ___ Python tracker <https://bugs.python.org/issue45

[issue45187] Some tests in test_socket are not run

2021-09-17 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue45212] Dangling threads in skipped tests in test_socket

2021-09-17 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue45212] Dangling threads in skipped tests in test_socket

2021-09-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 54a1760cde7bb01e5574734c389c0746762218fd by Serhiy Storchaka in branch 'main': bpo-45212: Add a comment for time.sleep() in tests (GH-28414) https://github.com/python/cpython/commit/54a1760cde7bb01e5574734c389c0746762218fd

[issue10611] sys.exit() in a test causes a test run to die

2021-09-17 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: -26829 ___ Python tracker <https://bugs.python.org/issue10611> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue10611] sys.exit() in a test causes a test run to die

2021-09-17 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- nosy: +serhiy.storchaka nosy_count: 4.0 -> 5.0 pull_requests: +26829 pull_request: https://github.com/python/cpython/pull/28180 ___ Python tracker <https://bugs.python.org/issu

[issue5846] Deprecate obsolete functions in unittest

2021-09-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: It is an internal function. We can remove it without deprecation. -- ___ Python tracker <https://bugs.python.org/issue5

[issue45228] Stack buffer overflow in parsing J1939 network address

2021-09-17 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue45187] Some tests in test_socket are not run

2021-09-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 0f4449ecb0d678984b1343d60c070dcb1bd62e56 by Łukasz Langa in branch '3.9': [3.9] bpo-45187: Collect test_socket tests using unittest (GH-28317) (GH-28413) https://github.com/python/cpython/commit/0f4449ecb0d678984b1343d60c070dcb1bd62e56

[issue44211] Duplicate '.bmp' key in mimetypes.py, maps to both 'image/bmp' and 'image/x-ms-bmp'

2021-09-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: It is not clear whether we want to backport this change. -- ___ Python tracker <https://bugs.python.org/issue44211> ___ ___

[issue45162] Remove old deprecated unittest features

2021-09-17 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue45162] Remove old deprecated unittest features

2021-09-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset b0a6ede3d0bd6fa4ffe413ab4dfc1059201df25b by Serhiy Storchaka in branch 'main': bpo-45162: Remove many old deprecated unittest features (GH-28268) https://github.com/python/cpython/commit/b0a6ede3d0bd6fa4ffe413ab4dfc1059201df25b

[issue45212] Dangling threads in skipped tests in test_socket

2021-09-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I have merged the backported PRs because they are blockers for my other PR which is a blocker for my other PR which is a blocker for my other PR and several future PRs. -- ___ Python tracker <ht

[issue45212] Dangling threads in skipped tests in test_socket

2021-09-17 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: +26826 pull_request: https://github.com/python/cpython/pull/28414 ___ Python tracker <https://bugs.python.org/issue45

[issue45212] Dangling threads in skipped tests in test_socket

2021-09-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 10c3cf78518f4b31e1527c2795694b1bcb092696 by Serhiy Storchaka in branch '3.9': [3.9] bpo-45212: Fix dangling threads in skipped tests in test_socket (GH-28361) (GH-28408) https://github.com/python/cpython/commit

[issue45212] Dangling threads in skipped tests in test_socket

2021-09-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset ce59ac93626004894c2b291ec599a36cfa9fb0be by Serhiy Storchaka in branch '3.10': [3.10] bpo-45212: Fix dangling threads in skipped tests in test_socket (GH-28361) (GH-28409) https://github.com/python/cpython/commit

[issue5846] Deprecate obsolete functions in unittest

2021-09-17 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.o

[issue5846] Deprecate obsolete functions in unittest

2021-09-17 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- versions: +Python 3.11 -Python 3.4 ___ Python tracker <https://bugs.python.org/issue5846> ___ ___ Python-bugs-list mailin

[issue5846] Deprecate obsolete functions in unittest

2021-09-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset b2b035a949eff1dc54b5bafe2bc9ce72b4d24438 by Serhiy Storchaka in branch 'main': bpo-5846: Fix deprecations for obsolete unittest functions and add tests. (GH-28382) https://github.com/python/cpython/commit

[issue45230] Something wrong when Calculate "3==3 is not True"

2021-09-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: No, it is a feature. Python allows you to chain comparison operations, so you can write 0 < x <= 10 which is equivalent to (0 < x) and (x <= 10). And "is" is a comparison operation. So `3==3 is not True` is equivalent to `(3=

[issue45212] Dangling threads in skipped tests in test_socket

2021-09-17 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: +26821 pull_request: https://github.com/python/cpython/pull/28409 ___ Python tracker <https://bugs.python.org/issue45

[issue45212] Dangling threads in skipped tests in test_socket

2021-09-17 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: +26820 pull_request: https://github.com/python/cpython/pull/28408 ___ Python tracker <https://bugs.python.org/issue45

[issue45228] Stack buffer overflow in parsing J1939 network address

2021-09-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 773319545ba60577bc140aa46eac83b360240b7a by Serhiy Storchaka in branch 'main': bpo-45228: Fix stack buffer overflow in parsing J1939 address (GH-28404) https://github.com/python/cpython/commit/773319545ba60577bc140aa46eac83b360240b7a

[issue45229] Always use unittest for collecting tests in regrtests

2021-09-17 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- dependencies: +Some tests in test_socket are not run, test.test_ssl.TestEnumerations is not run ___ Python tracker <https://bugs.python.org/issue45

[issue45229] Always use unittest for collecting tests in regrtests

2021-09-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: PR 28405 contains simple changes for 60 test files. It does not cover files which use complex code for generating list of test classes and running doctests (because there are subtle differences between running doctests with run_doctest() and via

[issue45229] Always use unittest for collecting tests in regrtests

2021-09-17 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +26817 stage: -> patch review pull_request: https://github.com/python/cpython/pull/28405 ___ Python tracker <https://bugs.python.org/issu

[issue45229] Always use unittest for collecting tests in regrtests

2021-09-17 Thread Serhiy Storchaka
New submission from Serhiy Storchaka : Currently regrtest supports two ways of collecting and running tests in module. 1. If the module contains the "test_main" function, regrtest just calls it. This function usually calls run_unittest() with a list of test classes, composed manual

[issue45228] Stack buffer overflow in parsing J1939 network address

2021-09-17 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +26816 stage: -> patch review pull_request: https://github.com/python/cpython/pull/28404 ___ Python tracker <https://bugs.python.org/issu

[issue45228] Stack buffer overflow in parsing J1939 network address

2021-09-17 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- versions: +Python 3.10, Python 3.9 ___ Python tracker <https://bugs.python.org/issue45228> ___ ___ Python-bugs-list mailin

[issue45187] Some tests in test_socket are not run

2021-09-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Running omitted tests exposed some real bugs. See issue45212, issue45228. -- ___ Python tracker <https://bugs.python.org/issue45

[issue45187] Some tests in test_socket are not run

2021-09-17 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- dependencies: +Stack buffer overflow in parsing J1939 network address ___ Python tracker <https://bugs.python.org/issue45

[issue45228] Stack buffer overflow in parsing J1939 network address

2021-09-17 Thread Serhiy Storchaka
New submission from Serhiy Storchaka : It can be reproduced when run test.test_socket.J1939Test (omitted in regrtests now, see issue45187) with Address Sanitizer. See for example https://github.com/python/cpython/pull/28317/checks?check_run_id=3625390397. It can be reproduced when run

[issue43413] tuple subclasses allow arbitrary kwargs

2021-09-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I do not have any particular use case. It was a side effect of unification code that uses _PyArg_NoKeywords(). -- ___ Python tracker <https://bugs.python.org/issue43

[issue43413] tuple subclasses allow arbitrary kwargs

2021-09-17 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: +26815 pull_request: https://github.com/python/cpython/pull/28403 ___ Python tracker <https://bugs.python.org/issue43

[issue45227] Control reaches end of non-void function in specialize.c

2021-09-16 Thread Serhiy Storchaka
New submission from Serhiy Storchaka : Python/specialize.c: In function ‘load_method_fail_kind’: Python/specialize.c:878:1: warning: control reaches end of non-void function [-Wreturn-type] 878 | } | ^ -- components: Interpreter Core messages: 402001 nosy: serhiy.storchaka

[issue45220] Windows builds sometimes fail on Azure and GitHub Action: fatal error RC1116: RC terminating after preprocessor errors

2021-09-16 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset f798cef87faeb428bdb9ebf73df1a6146304 by Miss Islington (bot) in branch '3.10': bpo-45220: Avoid automatically selecting the Windows 11 SDK preview when building (GH-28393) (GH-28394) https://github.com/python/cpython/commit

[issue45212] Dangling threads in skipped tests in test_socket

2021-09-16 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Yes, it is a deliberate choice. It is difficult to explain why it was passed without it -- dues to a specific order of calling tearDown() and callbacks registered with addCleanup() in different base classes. Using an event object would fix it too

[issue45212] Dangling threads in skipped tests in test_socket

2021-09-16 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 7dacb70485a0910eb298c24b4d051720ca56fb91 by Serhiy Storchaka in branch 'main': bpo-45212: Fix dangling threads in skipped tests in test_socket (GH-28361) https://github.com/python/cpython/commit/7dacb70485a0910eb298c24b4d051720ca56fb91

[issue5846] Deprecate obsolete functions in unittest

2021-09-16 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: +26797 pull_request: https://github.com/python/cpython/pull/28382 ___ Python tracker <https://bugs.python.org/issue5

[issue45216] Remove redundand information from difflib docstrings

2021-09-16 Thread Serhiy Storchaka
New submission from Serhiy Storchaka : Difflib docstrings contain short descriptions of functions and methods defined in the module and classes. It is redundant because pydoc shows descriptions for every function and method just few lines below. For example: | Methods

[issue5846] Deprecate obsolete functions in unittest

2021-09-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I do not think that PR 28299 is correct. We want to deprecate these functions which are implemented in the unittest.loader module, not just names exported to the unittest module. -- ___ Python tracker <ht

[issue45187] Some tests in test_socket are not run

2021-09-15 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- dependencies: +Dangling threads in skipped tests in test_socket ___ Python tracker <https://bugs.python.org/issue45187> ___ ___

[issue45212] Dangling threads in skipped tests in test_socket

2021-09-15 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: +26789 pull_request: https://github.com/python/cpython/pull/28317 ___ Python tracker <https://bugs.python.org/issue45

[issue45083] Need to use the exception class qualname when rendering exception (in C code)

2021-09-15 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> fixed status: open -> closed ___ Python tracker <https://bugs.python.org/issue45083> ___ ___ Python-bugs-

[issue45212] Dangling threads in skipped tests in test_socket

2021-09-15 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +26775 stage: -> patch review pull_request: https://github.com/python/cpython/pull/28361 ___ Python tracker <https://bugs.python.org/issu

[issue45212] Dangling threads in skipped tests in test_socket

2021-09-15 Thread Serhiy Storchaka
New submission from Serhiy Storchaka : Dangling threads are reported when run test_socket tests which raise SkipTest in setUp() in refleak mode. $ ./python -m test -R 3:3 test_socket -m testBCM 0:00:00 load avg: 2.53 Run tests sequentially 0:00:00 load avg: 2.53 [1/1] test_socket beginning 6

[issue45185] test.test_ssl.TestEnumerations is not run

2021-09-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you Nikita! The test was added in issue38659 and was not backported, so it is 3.11 only issue. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: -Python 3.10, P

[issue45185] test.test_ssl.TestEnumerations is not run

2021-09-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset d897579a80da3f4572d96501c41bec6cacb10d84 by Nikita Sobolev in branch 'main': bpo-45185: enables `TestEnumerations` in `test_ssl` (GH-28330) https://github.com/python/cpython/commit/d897579a80da3f4572d96501c41bec6cacb10d84

[issue44786] test_check_c_globals "crashed" and then "FutureWarning: Possible nested set at position 12"

2021-09-15 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed type: -> behavior versions: +Python 3.10 ___ Python tracker <https://bugs.python

[issue44786] test_check_c_globals "crashed" and then "FutureWarning: Possible nested set at position 12"

2021-09-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 89966f59c2e1d0558f8126458acc7d7ae2a8fef5 by Miss Islington (bot) in branch '3.10': bpo-44786: Fix a warning in RE in c-analyzer (GH-28351) (GH-28353) https://github.com/python/cpython/commit/89966f59c2e1d0558f8126458acc7d7ae2a8fef5

[issue44786] test_check_c_globals "crashed" and then "FutureWarning: Possible nested set at position 12"

2021-09-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 1a9ef5798525bbb39a16c8af5c435b97352ee027 by Serhiy Storchaka in branch 'main': bpo-44786: Fix a warning in RE in c-analyzer (GH-28351) https://github.com/python/cpython/commit/1a9ef5798525bbb39a16c8af5c435b97352ee027

[issue44786] test_check_c_globals "crashed" and then "FutureWarning: Possible nested set at position 12"

2021-09-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Yes, [[] looks as the start of a character set containing nested sets (e.g. "[[a-z]--[p-q]]"). This feature is supported by regex and can be added in future versions of re, breaking the code which contain such co

[issue45202] Add 'remove_barry_from_BDFL' future to revert effects of 'from __future__ import barry_as_FLUFL'

2021-09-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: But why do you need to execute 'from __future__ import barry_as_FLUFL' in your interpreter at first place? Don't do this and you would not need to revert its effect. -- ___ Python tracker <ht

<    4   5   6   7   8   9   10   11   12   13   >