Change by Serhiy Storchaka :
--
keywords: +patch
nosy: +serhiy.storchaka
nosy_count: 1.0 -> 2.0
pull_requests: +26765
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/28351
___
Python tracker
<https://bugs.p
Change by Serhiy Storchaka :
--
pull_requests: +26734
pull_request: https://github.com/python/cpython/pull/28324
___
Python tracker
<https://bugs.python.org/issue45
Change by Serhiy Storchaka :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Serhiy Storchaka added the comment:
I meant that the current __getattr__ breaks deepcopy(). It can break also other
protocols. It already has a list of exceptions, we need to add "__copy__" and
"__deepcopy__" in this list. Or maybe exclude all dunder names by default a
Serhiy Storchaka added the comment:
PR 28317 makes test classes in test_socket be autocollected instead of
explicitly enumerated. This will save as from similar errors in future.
--
___
Python tracker
<https://bugs.python.org/issue45
Change by Serhiy Storchaka :
--
keywords: +patch
pull_requests: +26727
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/28317
___
Python tracker
<https://bugs.python.org/issu
New submission from Serhiy Storchaka :
Test classes ISOTPTest, J1939Test, BasicUDPLITETest, UDPLITETimeoutTest in
test_socket are not included in the list of test classes and are not run by
regrtest.
--
components: Tests
messages: 401725
nosy: serhiy.storchaka
priority: normal
New submission from Serhiy Storchaka :
test.test_ssl.TestEnumerations is not run when run ssl tests. If add it to the
list of test classes it fails:
==
ERROR: test_options (test.test_ssl.TestEnumerations
Serhiy Storchaka added the comment:
If you can remove context managers in arbitrary order it is no longer a stack.
I think that it is just a wrong tool for your problem. Just maintain a
collection of opened connections. Set or dict can be better that list or deque.
--
nosy
Change by Serhiy Storchaka :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Serhiy Storchaka added the comment:
New changeset 3e19409d6443c66a6a7d62f58b2bb4e8330e56c4 by Serhiy Storchaka in
branch 'main':
bpo-45181: Simplify loading sqlite3 tests (GH-28304)
https://github.com/python/cpython/commit/3e19409d6443c66a6a7d62f58b2bb4e8330e56c4
Serhiy Storchaka added the comment:
New changeset 9260e6739865c966c3ec6c5c289e0b96f848403e by Serhiy Storchaka in
branch 'main':
bpo-45182: Fix incorrect use of requires_zlib in test_bdist_rpm (GH-28305)
https://github.com/python/cpython/commit/9260e6739865c966c3ec6c5c289e0b96f848403e
Serhiy Storchaka added the comment:
I think it is better to narrow the __getattr__. It can break protocols using
other special methods.
--
nosy: +gvanrossum, serhiy.storchaka
___
Python tracker
<https://bugs.python.org/issue45
Serhiy Storchaka added the comment:
New changeset 851811f5772c43f72f445e2ce1ac3ea9da951ae3 by Serhiy Storchaka in
branch 'main':
bpo-5846: Do not use obsolete unittest functions. (GH-28303)
https://github.com/python/cpython/commit/851811f5772c43f72f445e2ce1ac3ea9da951ae3
Change by Serhiy Storchaka :
--
keywords: +patch
pull_requests: +26719
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/28305
___
Python tracker
<https://bugs.python.org/issu
New submission from Serhiy Storchaka :
requires_zlib is a decorator factory which returns a decorator, not a
decorator. It should always be followed by parenthesis. In
Lib/distutils/tests/test_bdist_rpm.py it is used improperly, so the
corresponding tests were never ran
Serhiy Storchaka added the comment:
See issue45181. Most of this code is gone.
Also, TestLoader has mutable attribute "errors". I am not sure that it is good
idea to share it between unrelated tests.
--
___
Python track
Change by Serhiy Storchaka :
--
keywords: +patch
pull_requests: +26718
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/28304
___
Python tracker
<https://bugs.python.org/issu
New submission from Serhiy Storchaka :
The proposed PR rewrites the loading of sqlite3 tests. Instead of explicitly
enumerating test modules and test classes in every module, and manually
creating test suites, it uses unittest discover ability. Every new test files
and test classes
Change by Serhiy Storchaka :
--
nosy: +serhiy.storchaka
nosy_count: 4.0 -> 5.0
pull_requests: +26717
pull_request: https://github.com/python/cpython/pull/28303
___
Python tracker
<https://bugs.python.org/iss
Serhiy Storchaka added the comment:
Perhaps it is because "little" is checked first. One call of
_PyUnicode_EqualToASCIIId() for "little" and two for "big".
--
___
Python tracker
<h
Change by Serhiy Storchaka :
--
assignee: -> serhiy.storchaka
___
Python tracker
<https://bugs.python.org/issue45176>
___
___
Python-bugs-list mailing list
Un
Change by Serhiy Storchaka :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Serhiy Storchaka added the comment:
New changeset 92bf8691fb78f3484bf2daba836c416efedb1d8d by Serhiy Storchaka in
branch 'main':
bpo-43413: Fix handling keyword arguments in subclasses of some buitin classes
(GH-26456)
https://github.com/python/cpython/commit
Change by Serhiy Storchaka :
--
components: +Unicode
nosy: +ezio.melotti, serhiy.storchaka, vstinner
type: -> behavior
versions: +Python 3.11 -Python 3.8
___
Python tracker
<https://bugs.python.org/issu
Serhiy Storchaka added the comment:
We recently discussed the RTLO attack on Python sources (sorry, I don't
remember on what resource) and decided that we should do something with this. I
think this is a related issue.
--
___
Python tracker
Serhiy Storchaka added the comment:
In the stdlib, there is only one use of to_bytes() with sys.byteorder (2 in
tests), 16 uses of to_bytes()/from_bytes() with 'little' (22 in tests) and 22
uses with 'big' (33 in tests). So making sys.byteorder the default will help
almost nobody
Serhiy Storchaka added the comment:
The struct module has 4 different modes. By default it uses not only native
byte order, but native sizes and alignments which depend on OS and compiler.
You need to know all these details just to understand the format codes. I think
that the struct module
New submission from Serhiy Storchaka :
The main difference between platforms is that the first argument of the foreach
function is int on some platforms and unsigned long on others.
PR 28295 fixes code not only on DragonflyBSD, but on FreeBSD and OpenBSD, where
it is unsigned long
Serhiy Storchaka added the comment:
This warning is produced by the compiler when it compiles the source code. If
it is already compiled, no compiler is involved.
--
nosy: +serhiy.storchaka
resolution: -> not a bug
stage: -> resolved
status: open -&g
Change by Serhiy Storchaka :
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue45163>
___
___
Change by Serhiy Storchaka :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Serhiy Storchaka added the comment:
New changeset 9abd07e5963f966c4d6df8f4e4bf390ed8191066 by Dong-hee Na in branch
'main':
bpo-44987: Speed up unicode normalization of ASCII strings (GH-28283)
https://github.com/python/cpython/commit/9abd07e5963f966c4d6df8f4e4bf390ed8191066
Serhiy Storchaka added the comment:
New changeset 97ea18ecede8bfd33d5ab2dd0e7e2aada205 by Serhiy Storchaka in
branch 'main':
bpo-35474: Fix mimetypes.guess_all_extensions() potentially mutating list
(GH-28286)
https://github.com/python/cpython/commit
New submission from Serhiy Storchaka :
New changeset 5f5b7d0c654488206ac13e27d9a5dcffbd2cc0af by David CARLIER in
branch 'main':
bpo-45163: Haiku build fix. (GH-28269)
https://github.com/python/cpython/commit/5f5b7d0c654488206ac13e27d9a5dcffbd2cc0af
--
nosy: +serhiy.storchaka
Serhiy Storchaka added the comment:
Also, mutating the result of guess_all_extensions() mutated the internal state
of the MimeTypes object and affected the following calls of
guess_all_extensions().
--
stage: patch review ->
versions: +Python 3.10, Python 3.11, Python
Change by Serhiy Storchaka :
--
keywords: +patch
nosy: +serhiy.storchaka
nosy_count: 1.0 -> 2.0
pull_requests: +26702
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/28286
___
Python tracker
<https://bugs.p
Serhiy Storchaka added the comment:
Since this change has a user-visible effect a NEWS entry is required. Just copy
it from issue22589.
--
nosy: +serhiy.storchaka
___
Python tracker
<https://bugs.python.org/issue44
Serhiy Storchaka added the comment:
New changeset 17a1b3e63a5db4e581c0ef52751df2314f7249fa by Serhiy Storchaka in
branch 'main':
bpo-45132: Fix the reStructuredText markup error. (GH-28270)
https://github.com/python/cpython/commit/17a1b3e63a5db4e581c0ef52751df2314f7249fa
Serhiy Storchaka added the comment:
Thank you for your contribution, Hakan, Henry-Joseph.
Sorry, David, there was already a PR, and it was not dead, it just waited for a
coredev review.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -&g
Serhiy Storchaka added the comment:
New changeset 707137b8637feef37b2e06a851fdca9d1b945861 by Henry-Joseph Audéoud
in branch 'main':
bpo-40563: Support pathlike objects on dbm/shelve (GH-21849)
https://github.com/python/cpython/commit/707137b8637feef37b2e06a851fdca9d1b945861
--
nosy
Change by Serhiy Storchaka :
--
pull_requests: +26690
pull_request: https://github.com/python/cpython/pull/28270
___
Python tracker
<https://bugs.python.org/issue45
Serhiy Storchaka added the comment:
b'\x1964' is a 3-bytes bytes object.
>>> b = b'\x1964'
>>> len(b)
3
>>> b[0], b[1], b[2]
(25, 54, 52)
What you what to get is b'\x19\x64'. And it is a different writing of b'\x19d',
because b'\x64' is the same as b'd
Change by Serhiy Storchaka :
--
keywords: +patch
pull_requests: +26688
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/28268
___
Python tracker
<https://bugs.python.org/issu
Change by Serhiy Storchaka :
--
nosy: +ezio.melotti, michael.foord, rbcollins
___
Python tracker
<https://bugs.python.org/issue45162>
___
___
Python-bugs-list m
New submission from Serhiy Storchaka :
The proposed PR removes the following unittest features:
* "fail*" and "assert*" aliases of TestCase methods.
* Broken from start TestCase method assertDictContainsSubset().
* Ignored TestLoader.loadTestsFromModule() parameter use_loa
Serhiy Storchaka added the comment:
>From my experience, the largest cost in importing module (after I/O) is for
>creating classes, especially classes with complex creation code: enums and
>dataclasses (and namedtuples in past, but they were significanly optimized
>since).
Fo
Serhiy Storchaka added the comment:
Ah, signed=False by default, so (128).to_bytes() will work. But I still worry
that it can provoke writing more errorprone code.
--
___
Python tracker
<https://bugs.python.org/issue45
Serhiy Storchaka added the comment:
So (128).to_bytes() will raise an error, right?
I afraid also that it will lead to some programs working correctly only on
platforms with the most common byte order, just because authors are not aware
of byte ordering. Currently the interface forces
Serhiy Storchaka added the comment:
I am currently working on a feature which can be better in these cases that
subTest(). It will allow to reduce the indentation level instead of increasing
it.
--
nosy: +serhiy.storchaka
___
Python tracker
Serhiy Storchaka added the comment:
Expression `A or B` gets you A if A is true.
If you want to catch several types of exception by one "except", use except
with a tuple:
except (ConnectionResetError, ConnectionAbortedError):
--
nosy: +serhiy.storchaka
resolution: -&
Change by Serhiy Storchaka :
--
nosy: +christian.heimes, gregory.p.smith
type: -> enhancement
versions: +Python 3.11
___
Python tracker
<https://bugs.python.org/issu
Serhiy Storchaka added the comment:
"{__module__}.{__name__}" is just incorrect reference if __name__ !=
__qualname__. Error messages should always use "{__module__}.{__qualname__}" or
just "{__name__}". I see this as a bug. Fortunately very few code
Serhiy Storchaka added the comment:
What is wrong with this? Is such logic used in the dis module or any other
module outside modulefinder?
--
nosy: +serhiy.storchaka
___
Python tracker
<https://bugs.python.org/issue45
Serhiy Storchaka added the comment:
New changeset f235dd0784b92824565c4a4e72adc70fa3eab68f by Erlend Egeberg
Aasland in branch 'main':
bpo-38371: Remove deprecated `tkinter` split() method (GH-28237)
https://github.com/python/cpython/commit/f235dd0784b92824565c4a4e72adc70fa3eab68f
Serhiy Storchaka added the comment:
I have not benchmarked PR 28176 yet and do not know whether it have advantages
over PR 27986 and how large. Slower __lenght_hint__ can make list(range(...))
slower for small ranges, but I do not know how small
Change by Serhiy Storchaka :
--
pull_requests: +26656
pull_request: https://github.com/python/cpython/pull/28236
___
Python tracker
<https://bugs.python.org/issue45
Serhiy Storchaka added the comment:
Thank you for your contribution Hugo.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Serhiy Storchaka added the comment:
New changeset d003a5bd2505a7fa04f50504b68ba8fca67349cd by Hugo van Kemenade in
branch 'main':
bpo-45132 Remove deprecated __getitem__ methods (GH-28225)
https://github.com/python/cpython/commit/d003a5bd2505a7fa04f50504b68ba8fca67349cd
--
nosy
Serhiy Storchaka added the comment:
Go ahead. Fix also other issues in tests:
* All pickling tests should test with all supported protocols, not just with
the default one.
* self.assertTrue(
isinstance(deserialized_sl, shared_memory.ShareableList)
)
assertIsinstance
Serhiy Storchaka added the comment:
I concur with Raymond. Originally it was "instance of cls". It was changed in
issue15542 (6b16d938d6d1ccb443815e20e8812deed274dc09).
--
nosy: +serhiy.storchaka
___
Python tracker
<https://bu
Serhiy Storchaka added the comment:
By default configparser does not support inline comments. "# percentage sign
'%'" is a part of value. If you want to support inline comments you should pass
the inline_comment_prefixes argument.
But note that it can break parsing existing va
Serhiy Storchaka added the comment:
There are too many issues with TestResult.debug(). It does not call tearDown()
and doCleanups() if the test is skipped, failed or raises other exception
(including errors in cleanup). It does not support skipping decorators. It does
not support
Serhiy Storchaka added the comment:
_STRUCT_TM_ITEMS was always set to 11 since issue25283.
On what platform test_localtime_timezone fails now?
--
nosy: +serhiy.storchaka
___
Python tracker
<https://bugs.python.org/issue35
Serhiy Storchaka added the comment:
Before b3468f79efa45c8adaf86c0b9b797b9b3d4c12a2 the TestResult methods
(addFailure, addError, addSkip, addExpectedFailure, addUnexpectedSuccess) were
called immediately after running the test method. After that change all skips,
failures and errors were
Change by Serhiy Storchaka :
--
keywords: +patch
nosy: +serhiy.storchaka
nosy_count: 4.0 -> 5.0
pull_requests: +26606
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/28180
___
Python tracker
<https://bugs.p
Serhiy Storchaka added the comment:
Any suggestions for the format of output? Currently PR 28082 formats lines for
subtest skipping, failure or error with a 2-space identation. Lines for
skipping, failure or error in tearDown() or functions registered with
addCallback() do not differ from
Serhiy Storchaka added the comment:
What to do with comprehensions and classes? Corresponding code objects are not
easily accessible and they do not have corresponding function. It would be
difficult to use the locals of the frame with comprehensions.
Maybe use per-module registries
Serhiy Storchaka added the comment:
New changeset 9e31b3952f6101ef71ec029481b972169ab0e0f1 by Irit Katriel in
branch 'main':
bpo-41031: Match C and Python code formatting of unprintable exceptions and
exceptions in the __main__ module. (GH-28139)
https://github.com/python/cpython/commit
Change by Serhiy Storchaka :
--
status: open -> pending
___
Python tracker
<https://bugs.python.org/issue45105>
___
___
Python-bugs-list mailing list
Un
Serhiy Storchaka added the comment:
PR 28176 implements idea proposed by Dennis in msg400396. It keeps the current
and stop values instead of the initial start, index and initial length. I do
not have data yet, but it is expected that it's iteration may be faster (for
large integers
Change by Serhiy Storchaka :
--
pull_requests: +26603
pull_request: https://github.com/python/cpython/pull/28176
___
Python tracker
<https://bugs.python.org/issue45
Change by Serhiy Storchaka :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Serhiy Storchaka added the comment:
New changeset 28264269de9ff88d9ee7110fc56ac2d2db275bec by Serhiy Storchaka in
branch 'main':
bpo-45102: unittest: add tests for skipping and errors in cleanup (GH-28166)
https://github.com/python/cpython/commit/28264269de9ff88d9ee7110fc56ac2d2db275bec
Change by Serhiy Storchaka :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Serhiy Storchaka added the comment:
New changeset ab58269ab3b784bef33a613cd0a68914065a9134 by Serhiy Storchaka in
branch '3.9':
[3.9] bpo-45042: Now test classes decorated with `requires_hashdigest` are not
skipped (GH-28060) (GH-28169)
https://github.com/python/cpython/commit
Change by Serhiy Storchaka :
--
pull_requests: +26598
pull_request: https://github.com/python/cpython/pull/28169
___
Python tracker
<https://bugs.python.org/issue45
Serhiy Storchaka added the comment:
New changeset dd7b816ac87e468e2fa65ce83c2a03fe1da8503e by Nikita Sobolev in
branch 'main':
bpo-45042: Now test classes decorated with `requires_hashdigest` are not
skipped (GH-28060)
https://github.com/python/cpython/commit
Change by Serhiy Storchaka :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Serhiy Storchaka :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Serhiy Storchaka added the comment:
New changeset 2ad114ddffbeeef1d20f26571b85a66974295667 by Miss Islington (bot)
in branch '3.10':
[3.10] bpo-45097: Add more tests for shutdown_asyncgens() (GH-28154) (GH-28159)
https://github.com/python/cpython/commit
Change by Serhiy Storchaka :
--
keywords: +patch
pull_requests: +26595
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/28166
___
Python tracker
<https://bugs.python.org/issu
New submission from Serhiy Storchaka :
The proposed PR adds tests for skipping and errors in cleanup: after success,
after failure, and in combination with the expectedFailure decorator.
--
components: Library (Lib)
messages: 401056
nosy: ezio.melotti, michael.foord, rbcollins
Serhiy Storchaka added the comment:
New changeset 936f6a16b9ef85bd56b18a247b962801e954c30e by Serhiy Storchaka in
branch 'main':
bpo-45030: Fix integer overflow in __reduce__ of the range iterator (GH-28000)
https://github.com/python/cpython/commit/936f6a16b9ef85bd56b18a247b962801e954c30e
Serhiy Storchaka added the comment:
New changeset c2970fdec52788b6d9ff419ab7e31f255d87433d by Serhiy Storchaka in
branch 'main':
bpo-45097: Add more tests for shutdown_asyncgens() (GH-28154)
https://github.com/python/cpython/commit/c2970fdec52788b6d9ff419ab7e31f255d87433d
Serhiy Storchaka added the comment:
New changeset c967bd523caabb05bf5988449487d7c1717f3ac6 by Serhiy Storchaka in
branch '3.9':
[3.9] bpo-45097: Remove incorrect deprecation warnings in asyncio. (GH-28153)
https://github.com/python/cpython/commit/c967bd523caabb05bf5988449487d7c1717f3ac6
Change by Serhiy Storchaka :
--
pull_requests: +26590
pull_request: https://github.com/python/cpython/pull/28154
___
Python tracker
<https://bugs.python.org/issue45
Serhiy Storchaka added the comment:
There are several calls of gather() and sleep() with the loop argument from the
asyncio library. Since all deprecation warnings were silenced in tests it was
unnoticed.
PR 28153 fixes the asyncio library, enables deprecation warnings in tests,
fixes
Change by Serhiy Storchaka :
--
keywords: +patch
pull_requests: +26589
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/28153
___
Python tracker
<https://bugs.python.org/issu
Change by Serhiy Storchaka :
--
assignee: -> serhiy.storchaka
___
Python tracker
<https://bugs.python.org/issue45097>
___
___
Python-bugs-list mailing list
Un
Change by Serhiy Storchaka :
--
nosy: +serhiy.storchaka
___
Python tracker
<https://bugs.python.org/issue45097>
___
___
Python-bugs-list mailing list
Unsub
Serhiy Storchaka added the comment:
It will not work in all cases. For example if the stdio encoding is UTF-8 and
the filesystem encoding is Latin1. Or the stdio encoding is CP1251 and the
filesystem encoding is UTF-8. I am not also sure that it gives us the result
which we want
Serhiy Storchaka added the comment:
> For the very specific case of os.environ.clear(), the C function clearenv()
> could be used if available.
It is bad in any way. The supposed example of using clear():
old_environ = dict(os.environ)
os.environ.clear()
os.environ.
Change by Serhiy Storchaka :
--
nosy: +rhettinger
stage: -> needs patch
___
Python tracker
<https://bugs.python.org/issue45090>
___
___
Python-bugs-list mai
Serhiy Storchaka added the comment:
Because the zipimport module is now implemented in Python.
--
___
Python tracker
<https://bugs.python.org/issue37
Serhiy Storchaka added the comment:
For tests it can be more convenient to use
list(d1.items()) == list(d2.items())
because it can produce better report on failure.
You can add a simple helper function if you use it multiple times in tests.
--
nosy: +serhiy.storchaka
Change by Serhiy Storchaka :
--
resolution: -> duplicate
stage: -> resolved
status: open -> closed
superseder: -> Make set ordered
___
Python tracker
<https://bugs.python
Serhiy Storchaka added the comment:
1. self.hashvalue == other.hashvalue is not enough. Different tuples can have
the same hash value, so you steel need to compare their context.
2. _HashedSeq is only used as a key in a dictionary. When you look up a key in
dictionary, it compares hashes
Serhiy Storchaka added the comment:
_compat_pickle is only used with protocol < 3.
--
___
Python tracker
<https://bugs.python.org/issue27175>
___
___
Python-
Serhiy Storchaka added the comment:
It would be nice to have simple general mechanism for everloading names of
modules, classes and functions, similar to _compat_pickle. Currently you can do
this with creating a subclass of Unpickler and overloading find_class(), but it
is not so convenient
901 - 1000 of 25750 matches
Mail list logo
