Change by Skip Montanaro :
--
nosy: -skip.montanaro
___
Python tracker
<https://bugs.python.org/issue27546>
___
___
Python-bugs-list mailing list
Unsubscribe:
Skip Montanaro added the comment:
See also (perhaps)
https://bugs.python.org/issue47190
--
nosy: +skip.montanaro
___
Python tracker
<https://bugs.python.org/issue27
Skip Montanaro added the comment:
That's fine. My brief search didn't turn up
https://bugs.python.org/issue27546
I'm happy to close this.
--
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.p
Change by Skip Montanaro :
--
keywords: +patch
pull_requests: +30355
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/32293
___
Python tracker
<https://bugs.python.org/issu
New submission from Skip Montanaro :
After looking around and asking, it appears there is no built-in integration of
the tkinter and asyncio event loops. That would seem to be a good thing, at
least as an example. I wrote a simple hello world which creates an AsyncTk
class and uses asyncio
Skip Montanaro added the comment:
Further question... All the discussion has been on the writer side of the csv
module. Is there any reason that using QUOTE_STRINGS or QUOTE_NOTNULL should
have an effect when reading? For example, should this line on input
"",,1,'a'
produce
Skip Montanaro added the comment:
Note to @samwyse and @krypten: I updated the patches and created a pull request
on GitHub, but I have no way of knowing if at least krypten has signed a CLA
for Python. Since you're the author of the original patches, we need to verify
that you have
Change by Skip Montanaro :
--
pull_requests: +27722
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/29469
___
Python tracker
<https://bugs.python.org/issu
Skip Montanaro added the comment:
Thanks, I get that. My issue is with the apparent mismatch between the English
meaning of "find leaks" and "fail env changed." It seems to me that the help
message(s) for one or both of those options is probably incorrect and
New submission from Skip Montanaro :
Just preparing to make a refleaks test run, so I ran:
./python -m test --help
The output related to refleaks seemed suspicious:
...
Special runs:
-l, --findleaks deprecated alias to --fail-env-changed
...
--fail-env-changedif a test file
Skip Montanaro added the comment:
Took me a while to notice the -i flag to regrtest.py. I think that solves my
particular problem, so I will close this. Is there a place to see how 'make
test' is run on the buildbots?
--
stage: -> resolved
status: open ->
New submission from Skip Montanaro :
I find that test_multiprocessing_spawn frequently hangs. Hitting Ctl-C then
rerunning "make test" generally works. Still, this behavior makes it
problematic to run testing unattended. I don't think I have an unusual
environment (XUbuntu 20.04,
Skip Montanaro added the comment:
CCbench was mentioned recently in the discussion about Sam Gross's nogil branch:
https://mail.python.org/archives/list/python-...@python.org/message/WRT7F2RHHCQ3N2TYEDC6JSIJ4T2ZM6F7/
I'm not convinced that deleting it is a no-brainer. Maybe if it landed
Skip Montanaro added the comment:
I'll be the wet blanket here and say -1. This doesn't seem at all necessary. 81
occurrences in ~3.5k PyPI packages? That's a hardly overwhelming endorsement.
To top it off, since this can't be backported to 3.10 and earlier, it creates a
needless (trivial
New submission from Skip Montanaro :
At the top of Tools/ccbench/ccbench.py is this comment dating from 2010
(probably in the initial version):
# This file should be kept compatible with both Python 2.6 and Python >= 3.0.
Is there still a need for 2.6 compatibility in what is essentia
Skip Montanaro added the comment:
Update version - too late for anything older than 3.11.
--
versions: -Python 3.10, Python 3.6, Python 3.7, Python 3.8, Python 3.9
___
Python tracker
<https://bugs.python.org/issue23
Skip Montanaro added the comment:
Unfortunately, I'm currently not able to build Python 3.8, 3.9 or 3.10 and get
a non-failing test_gdb. I'll mess around a bit more, but I'm skeptical I'll
find something simple. (I wonder if something changed in GDB which is causing
the failure
Skip Montanaro added the comment:
I routinely build with -O0 and have been getting test_gdb failures building the
3.10 branch. I tried adding -g3 to my configure flags:
nice ./configure OPT="-O0 -g3 -Wall" --with-pydebug --with-trace-refs
but test_gdb still fails. Output atta
Skip Montanaro added the comment:
Here's a NEWS entry.
--
Added file:
https://bugs.python.org/file50132/2021-06-29-07-27-08.bpo-43625.ZlAxhp.rst
___
Python tracker
<https://bugs.python.org/issue43
Skip Montanaro added the comment:
Here is a change to the has_header documentation and an extra test case
documenting the behavior when the sample contains strings. I'm not sure about
the wording of the doc change, perhaps you can tweak it? Seems kind of clumsy
to me. If it seems okay
Skip Montanaro added the comment:
I retract my comment about fixed length strings in the non-numeric case. There
are clearly test cases (which I probably wrote, considering the values) where
the sample as a header but the values are of varying length. Misread of the
code on my part. I have
Skip Montanaro added the comment:
Thanks @andrei.avk. You are right, only the complex test is required.
I suppose it's okay to commit this, but reviewing the full code of the
has_header method leaves me thinking this is just putting lipstick on a pig. If
I read the code correctly
Skip Montanaro added the comment:
Ugh... s/QUOTE_NONNULL/QUOTE_NOTNULL/
Not, Non, None... Perl would treat them all the same, right?
--
___
Python tracker
<https://bugs.python.org/issue23
Skip Montanaro added the comment:
Missed tweaking a couple settings.
--
resolution: rejected ->
stage: resolved -> needs patch
versions: +Python 3.11 -Python 3.8
___
Python tracker
<https://bugs.python.org/i
Skip Montanaro added the comment:
Okay, I'll reopen this, at least for the discussion of QUOTE_NONNULL.
@erdnaxeli please given an example of how PostgreSQL distinguishes between the
empty string and None cases. Is it a quoted empty string vs an empty field? If
so, modifying @samwyse's
Skip Montanaro added the comment:
Perhaps I should point out that this doesn't matter to me. I just noticed the
old name. I can't claim anything is broken that I need.
--
___
Python tracker
<https://bugs.python.org/issue44
Change by Skip Montanaro :
--
keywords: +patch
pull_requests: +24612
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/25949
___
Python tracker
<https://bugs.python.org/issu
New submission from Skip Montanaro :
When the interpreter is compiled with computed goto support, the TARGET macro
is defined like this:
#define TARGET(op) op: TARGET_##op
If computed gotos are disabled, the implementation is simpler:
#define TARGET(op) op
I'm finding it useful to use those
New submission from Skip Montanaro :
Should these references to "master" be changed to "main"?
% git co 3.10
Switched to branch '3.10'
Your branch is up to date with 'origin/3.10'.
% egrep master .azure-pipelines/*
.azure-pipelines/ci.yml:trigger: ['master', '3.10', '3.9',
Skip Montanaro added the comment:
>
> Skip: By the way, I'm curious, why do you use --with-trace-refs?
>
I'm still horsing around with register opcodes and got in the habit of
building with pydebug and trace refs enabled.
--
___
Pytho
Skip Montanaro added the comment:
I should revise that comment. The xxlimited and xxlimited_35 modules fail to
build. That seems suboptimal, but perhaps is to be expected. Perhaps it would
be better that compiling them not be attempted with configuring
--with-trace-refs
Skip Montanaro added the comment:
The latest commit seems to break the build if configured --with-trace-refs.
--
nosy: +skip.montanaro
___
Python tracker
<https://bugs.python.org/issue41
Change by Skip Montanaro :
--
title: What are the requirements for a test_sunry-testable script in
Tools/scripts? -> What are the requirements for a test_sundry-testable script
in Tools/scripts?
___
Python tracker
<https://bugs.pyth
Skip Montanaro added the comment:
I assume the OP is referring to this sort of usage:
>>> sniffer = csv.Sniffer()
>>> raw = open("mixed.csv").read()
>>> sniffer.has_header(raw)
False
*sigh*
I really wish the Sniffer class had never been added to the
New submission from Skip Montanaro :
In my fork of python/cpython I recently created a simple script to help me with
my work (I am messing around in the internals and sometimes get blindsided by
opcode changes). I stuck the script in Tools/script which caused
test_tools.test_sundry to hang
Skip Montanaro added the comment:
Closing, per Terry's comment.
--
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/i
Skip Montanaro added the comment:
When I submitted the PR one check failed with this error:
No news entry in Misc/NEWS.d/next/ or "skip news" label found
I'd be surprised if this was important enough for a news entry, and I'm pretty
sure I can't add a "s
Change by Skip Montanaro :
--
keywords: +patch
pull_requests: +23621
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/24861
___
Python tracker
<https://bugs.python.org/issu
New submission from Skip Montanaro :
For the VM work I'm doing I need to adapt to Mark's new line number table
format. (I stalled for several months, hence this rather late report.) As I was
reading Objects/lnotab_notes.txt I noticed a couple typos, fixed those and
threw in a couple other
New submission from Skip Montanaro :
I recently replaced Ubuntu 20.04 with Manjaro 20.2. In the process my Python
builds broke in the sharedmods target of the Makefile. The tail end of the
traceback is:
File "/home/skip/src/python/cpython/./setup.py", line 246, in grep_h
Skip Montanaro added the comment:
I created a PR from my patch, but it includes all the merges to my
smontanaro/cpython master branch from python/cpython. I thought I was following
the instructions properly
(https://devguide.python.org/gitbootcamp/#creating-a-pull-request), but I guess
I'm
Change by Skip Montanaro :
--
pull_requests: +21450
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/22412
___
Python tracker
<https://bugs.python.org/issu
Skip Montanaro added the comment:
Possible patch. All this does is add some C casts. @pablogsal suggested there
was more to be done, but my glance at the reference he gave suggested that's
already been done. My apologies if I misinterpreted his reference.
--
keywords: +patch
Added
Skip Montanaro added the comment:
> This is because the types of the grammars in
Lib/test/test_peg_generator/test_c_parser.py needs to be updated to use the
new sequences
I'm sorry, that doesn't mean much to me. Is it simply a matter of applying
suitable casts to the various paramet
New submission from Skip Montanaro :
I don't see anything like this while building Python proper, but when
test_peg_generator is run, it spews a few compiler warnings. Platform is Ubuntu
20.04. Seems low-ish priority, but I saw no mention of it in a quick bpo
search, so thought I would toss
Skip Montanaro added the comment:
> Could you please modify the test case to check for TLS 1.0 and run it Ubuntu?
>
> @requires_minimum_version
> @requires_tls_version('TLSv1_2')
> @requires_tls_version('TLSv1')
> def test_min_max_version_mismatch
Skip Montanaro added the comment:
>
> I confirm that Tal Einat's workaround also works.
>
Should workarounds be required to successfully run the test suite? I
routinely unset PYTHONSTARTUP, but that's because I can and sometimes do
weird things to support interactive use. It concerns
Skip Montanaro added the comment:
@Vladyslav.Bondar I can't tell where you are suggesting MinProtocol should be
set. I don't see that particular string in any .c, .h or .py file in the Python
source.
--
___
Python tracker
<ht
Skip Montanaro added the comment:
This skips the breaking tests (but doesn't actually fix anything).
--
keywords: +patch
versions: +Python 3.10 -Python 3.8
Added file: https://bugs.python.org/file49450/test_ssl_ubuntu.diff
___
Python tracker
Skip Montanaro added the comment:
Has any progress been made on the Ubuntu 20.04 test_ssl failures? Is there any
consensus about it being a Python or Ubuntu problem?
--
nosy: +skip.montanaro
___
Python tracker
<https://bugs.python.org/issue41
Skip Montanaro added the comment:
> > I don't know how to get rid of all those commit messages.
>
> I suggest you to create a local branch per change, rather than using "master".
>
> I consider that "origin" is g...@github.com:python/cpython.git. Che
Skip Montanaro added the comment:
> they all look to be of the form "Merge remote-tracking branch
> 'upstream/master'".
Aside from one where I erroneously committed a change to the wrong
branch, then backed it out immediately.
--
__
Skip Montanaro added the comment:
I see what @vstinner is talking about. If you look at those commit messages,
they all look to be of the form "Merge remote-tracking branch
'upstream/master'". That is, they are me syncing python/cpython/master to
python/smontanaro/master. There i
Skip Montanaro added the comment:
> Your PR has 124 commits, that looks strange.
Funny, it told me just one file had changed (Makefile.pre.in). I was attempting
to make a PR against that one change from my fork of master to the main repo.
Let me take another cr
Skip Montanaro added the comment:
Created a pull request. Hopefully I didn't muff the protocol too badly.
--
stage: patch review ->
___
Python tracker
<https://bugs.python.org/issu
Change by Skip Montanaro :
--
keywords: +patch
pull_requests: +20877
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/21732
___
Python tracker
<https://bugs.python.org/issu
New submission from Skip Montanaro :
When Include/cpython/frameobject.h was created, there was no dependency added
to Makefile.pre.in.
--
components: Build
messages: 374809
nosy: skip.montanaro
priority: normal
severity: normal
status: open
title: Missing dependency on Include/cpython
Skip Montanaro added the comment:
Looks like my comment removed Remi from the nosy list. Restoring that...
--
nosy: +remi.lapeyre
___
Python tracker
<https://bugs.python.org/issue27
Skip Montanaro added the comment:
I'm sorry, but why is this issue coming up again after nearly four years?
Especially without a patch? (I apologize. I've gotten a bit more grumpy as I've
aged.) Let me summarize a bit of history.
Back in the early 2000s, Dave Cole at Object Craft
Skip Montanaro added the comment:
I would also that tweaking Python to make this work with no change in Pandas
would be a case of the tail wagging the dog. A big tail, but a tail nonetheless.
--
___
Python tracker
<https://bugs.python.
Skip Montanaro added the comment:
This likely worked in the past because bytes == str in Python 2.x. This is just
a corner case people porting from 2 to 3 need to address in their code.
Papering over it so people using Pandas don't have to do the right thing is no
reason to make changes
Skip Montanaro added the comment:
Thanks, Serhiy.
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
New submission from Skip Montanaro :
Consider this trivial function:
>>> def f():
... while True:
... pass
...
and its disassembly:
>>> dis.dis(f)
3 >> 0 JUMP_ABSOLUTE 0
2 LOAD_CONST 0 (None)
4 R
Change by Skip Montanaro :
--
nosy: +ncoghlan, vstinner
___
Python tracker
<https://bugs.python.org/issue39583>
___
___
Python-bugs-list mailing list
Unsub
Change by Skip Montanaro :
--
keywords: +patch
pull_requests: +17787
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/18413
___
Python tracker
<https://bugs.python.org/issu
New submission from Skip Montanaro :
I noticed that the files in Include/cpython also have extern C declarations,
despite the fact that the only files which #include them do as well. Seems like
a small bit of cleanup. PR incoming...
--
components: C API
messages: 361628
nosy
Skip Montanaro added the comment:
I think to avoid compiler warnings about 'save' perhaps being used
uninitialized, it should be initialized to NULL when declared on line 21 of
Objects/stringlib/join.h.
--
nosy: +skip.montanaro
status: closed -> open
Added file: ht
Change by Skip Montanaro :
Added file: https://bugs.python.org/file48522/lfmapper.py
___
Python tracker
<https://bugs.python.org/issue37709>
___
___
Python-bugs-list m
Skip Montanaro added the comment:
Looking at your sample file, it seems stranger than you first indicated. Your
line terminator actually appears to be '\x07\r\n', not just '\x07'. Opening
your file in text mode will leave you with '\x07' as the last character of the
last cell in each row
Skip Montanaro added the comment:
I imagine this is a corner case which will continue to cause problems. At the
time the csv module was originally written, I believe the authors' intent was
to read and write CSV files which were compatible with Excel. In Python 3, you
have to open input
Skip Montanaro added the comment:
I think this is ready to go. I added a comment to PR12306. As I am no longer a
committer, I'm not sure what the next step is.
--
___
Python tracker
<https://bugs.python.org/issue27
Change by Skip Montanaro :
--
nosy: -skip.montanaro
___
Python tracker
<https://bugs.python.org/issue17267>
___
___
Python-bugs-list mailing list
Unsubscribe:
Skip Montanaro added the comment:
A couple comments.
1. Terry Reedy wrote:
> The csv expert listed in https://devguide.python.org/experts/ is marked as
> inactive
That would be me. I am indeed inactive w.r.t. fixing broken stuff, and
don't want to feel obligated to jump in with bot
Change by Skip Montanaro :
Added file: https://bugs.python.org/file47697/netrc-blank-comment
___
Python tracker
<https://bugs.python.org/issue34132>
___
___
Python-bug
New submission from Skip Montanaro :
Not sure I can really call this a bug, however there is a behavioral change
between 2.7 and at least 3.6 and 3.7 (probably earlier versions of the 3.x
series as well). There is no spec for .netrc files that I can find, certainly
nothing which mentions
Change by Skip Montanaro <skip.montan...@gmail.com>:
--
keywords: +patch
pull_requests: +6622
stage: needs patch -> patch review
___
Python tracker <rep...@bugs.python.org>
<https://bugs.pyt
New submission from Skip Montanaro <skip.montan...@gmail.com>:
There is a leftover reference to "thread.get_ident" in the docstring for
threading.ident. I believe it needs a leading underscore.
Hopefully a PR isn't required for this. I'm not equipped to generate on
Skip Montanaro <skip.montan...@gmail.com> added the comment:
@christian.heimes I figured you probably didn't need it, but I did that work
before I discovered this ticket. And as a nice bonus, I got to learn git
bisect. :-)
--
___
Python t
Skip Montanaro <skip.montan...@gmail.com> added the comment:
Just in case this would be useful to others, git bisect led me to this commit
as the source of the problem:
61d478c71c5341cdc54e6bfb4ace4252852fd972 is the first bad commit
commit 61d478c71c5341cdc54e6bfb4ace4252852fd972
Skip Montanaro <skip.montan...@gmail.com> added the comment:
I was bitten by this porting a system from Python 2.7 to 3.6. "/dev/stderr" is
a very nice default for logfiles. Users will frequently override the default,
so you really want to open the logfile in append mode
Change by Skip Montanaro <skip.montan...@gmail.com>:
--
versions: +Python 3.7 -Python 3.4
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python
Skip Montanaro <skip.montan...@gmail.com> added the comment:
This looks good to me. I added a pull request with a couple minor tweaks.
Unfortunately, I can't tell how to add a "skip news" label. This doesn't seem
"big" enough to warrant it.
--
Change by Skip Montanaro <skip.montan...@gmail.com>:
--
pull_requests: +6094
stage: -> patch review
___
Python tracker <rep...@bugs.python.org>
<https://bugs.pyt
Skip Montanaro <skip.montan...@gmail.com> added the comment:
I would prefer if these macros remain standalone (and thus fragile). Despite
Python support in gdb, not everyone (more than five years after the bug report)
don't use a gdb which was built --with-python. There is better s
Change by Skip Montanaro <skip.montan...@gmail.com>:
--
nosy: -skip.montanaro
___
Python tracker <rep...@bugs.python.org>
<https://bugs.python
Skip Montanaro <skip.montan...@gmail.com> added the comment:
FWIW, I relinquished my check-in privileges quite awhile ago. This should
almost certainly no longer be assigned to me.
S
--
___
Python tracker <rep...@bugs.python.or
Skip Montanaro <skip.montan...@gmail.com> added the comment:
I'm not terribly concerned with the end result, only that we wind up with a
more consistent system. As I see it, there are two main problems:
1. The type of the name attribute varies
2. The name attribute appears to be undocu
Skip Montanaro <skip.montan...@gmail.com> added the comment:
Apologies for the incomplete report. In 2.7 this anomaly exists in the
io.open() function. You are correct, builtin open() in 2.x doesn't support
opening by file descriptor.
--
___
New submission from Skip Montanaro <skip.montan...@gmail.com>:
I stumbled on what I think is an inconsistency in the "name" attribute of file
objects. When a file is opened with an existing file descriptor, the "name"
attribute is of type int (this from a 3.6.4 s
Skip Montanaro added the comment:
Again, my apologies for the crappy initial bug report. Hopefully this comment
and the two files I just attached demonstrate what I am getting at.
I just uploaded a stupid little example, partial3.py. Stupid, but still, it
demonstrates part of how I think
Changes by Skip Montanaro <skip.montan...@gmail.com>:
--
keywords: +patch
Added file: http://bugs.python.org/file46824/ft.diff
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
Changes by Skip Montanaro <skip.montan...@gmail.com>:
Added file: http://bugs.python.org/file46823/partial3.py
___
Python tracker <rep...@bugs.python.org>
<http://bugs.python
Skip Montanaro added the comment:
Yeah, sorry about that. I work in an environment where I can't "eject" any
code from my work computer. I've come up with a simple Python3 example, but
it will have to wait until I can recreate it from scratch on my hom
New submission from Skip Montanaro:
I needed to create a partial method in Python 2.7, so I grabbed
functools.partialmethod from a Python 3.5.2 install. For various reasons, one
of the reasons I wanted this was to suck in some methods from a delegated class
so they appeared in dir() and help
Skip Montanaro added the comment:
Vinay> I would like to close this issue now...
Go for it.
As I indicated in a previous comment, the exercise was as much to try and
come to grips with the process as to actually make the change. There
certainly appear to be good reasons to leave well eno
Skip Montanaro added the comment:
One example demonstrating that the datetime module at least prefers a decimal
point:
>>> import dateutil.parser
>>> t = '1993-04-21 08:03:00,123'
>>> dateutil.parser.parse(t)
datetime.datetime(1993, 4, 21, 8, 3, 0, 123000)
Skip Montanaro added the comment:
It's Vinay's code, so what he wants should carry the most weight. I did this as
much as an exercise in figuring out the whole pull request/bug report process
as anything.
--
___
Python tracker <
New submission from Skip Montanaro:
The logging module hard codes the decimal point for timestamps to be ",". It
should use locale.localeconv()["decimal_point"] instead.
--
components: Library (Lib)
messages: 290927
nosy: skip.montanaro
priority: normal
severity:
Skip Montanaro added the comment:
Note that these macros were always expected to be fragile. They depend to a
great extent on the layout of the functions in Python/ceval.c. I've had to
tweak them a couple times over the years.
I'm pretty sure the gdb instance I have available to me at work
Skip Montanaro added the comment:
The problem is solved. It seems there were changes in my 2.7 checkout which hg
update wouldn't overwrite. I vaguely remember applying somebody's patch for a
bug quite awhile ago. Apparently, I failed to revert that change before moving
on.
I obviously wasn't
1 - 100 of 805 matches
Mail list logo
