[issue34319] Clarify pathlib.Path("filepath").read_text()

2018-08-03 Thread Thomas Nyberg
Thomas Nyberg added the comment: For what it's worth as the original opener of the bug report, I think Terry's recommendation clarifies things quite well. -- ___ Python tracker <https://bugs.python.org/issue34

[issue34319] Clarify pathlib.Path("filepath").read_text()

2018-08-02 Thread Thomas Nyberg
New submission from Thomas Nyberg : This came out of the following posts: https://mail.python.org/pipermail/python-ideas/2018-August/052549.html https://mail.python.org/pipermail/python-ideas/2018-August/052553.html Basically my request would be to change the documentation here: https

[issue32980] Remove functions that do nothing in _Py_InitializeCore()

2018-03-03 Thread Thomas Nyberg
Thomas Nyberg <tomnyb...@gmail.com> added the comment: ince I originated this issue and I think I understand the concerns, I figured I could speed up the back and forth in this thread by opening this new PR which removes the `_PyFrame_Init()` function. I couldn't find any `_PyFram

[issue32980] Remove functions that do nothing in _Py_InitializeCore()

2018-03-03 Thread Thomas Nyberg
Change by Thomas Nyberg <tomnyb...@gmail.com>: -- pull_requests: +5732 ___ Python tracker <rep...@bugs.python.org> <https://bugs.python.org/issue32980> ___

[issue32980] Remove functions that do nothing in _Py_InitializeCore()

2018-03-01 Thread Thomas Nyberg
Change by Thomas Nyberg <tomnyb...@gmail.com>: -- keywords: +patch pull_requests: +5719 stage: -> patch review ___ Python tracker <rep...@bugs.python.org> <https://bugs.pyt

[issue32980] Remove functions that do nothing in _Py_InitializeCore()

2018-03-01 Thread Thomas Nyberg
New submission from Thomas Nyberg <tomnyb...@gmail.com>: The `_PyFrame_Init()` and `PyByteArray_Init()` functions are called in these two locations in the `_Py_InitializeCore()` function: https://github.com/python/cpython/blob/master/Python/pylifecycle.c#L693-L694

[issue24875] pyvenv doesn´t install PIP inside a new venv with --system-site-package

2017-01-13 Thread Thomas Nyberg
Thomas Nyberg added the comment: Hi Vinay, You should probably upload a patch with the changes you made (however trivial) if you want that version considered. Makes it easier to comment and can then point to it for others to consider. Cheers, Thomas

[issue24875] pyvenv doesn´t install PIP inside a new venv with --system-site-package

2017-01-12 Thread Thomas Nyberg
Thomas Nyberg added the comment: Hi Vinay, I just checked and yes that code works fine on my end (debian 8 box). Personally, I think either this or Mark's second patch would be fine. Cheers, Thomas -- ___ Python tracker <rep...@bugs.python.

[issue24875] pyvenv doesn´t install PIP inside a new venv with --system-site-package

2017-01-12 Thread Thomas Nyberg
Changes by Thomas Nyberg <tomnyb...@gmail.com>: Removed file: http://bugs.python.org/file46250/venv_site_packages.patch ___ Python tracker <rep...@bugs.python.org> <http://bugs.python

[issue24875] pyvenv doesn´t install PIP inside a new venv with --system-site-package

2017-01-11 Thread Thomas Nyberg
Thomas Nyberg added the comment: Hi Mark Haase, I've gone through both of your patches and they both work for me as they should. I'm not sure why the first one isn't working for you, since it works for me. That one seems like it's solving the problem the "right" way. In any case,

[issue24875] pyvenv doesn´t install PIP inside a new venv with --system-site-package

2017-01-10 Thread Thomas Nyberg
Thomas Nyberg added the comment: Now that I look over this thread again, I realize that my patch ended up basically evolving to being extremely similar to Mark Haase's. The only thing that I don't understand though is that he says that his shebangs are somehow messed up. For me the shebangs

[issue24875] pyvenv doesn´t install PIP inside a new venv with --system-site-package

2017-01-10 Thread Thomas Nyberg
Thomas Nyberg added the comment: I'm attaching a small patch (against the current hg master branch) that I believe solves the problem, however, I think it was quite hacky. Here is a walk-through of the logic. 1) If '--system-site-packages' is requested, then it is overrided initially

[issue23076] list(pathlib.Path().glob("")) fails with IndexError

2016-01-23 Thread Thomas Nyberg
Thomas Nyberg added the comment: I added a patch which causes glob to raise a ValueError exception if it is called with an empty string. I also added a test verifying the change and have run all the tests and they pass. Though I've been reading the developer guide, I'm a bit unfamiliar