[issue10071] Should not release GIL while running RegEnumValue

2021-10-18 Thread Zachary Ware
Zachary Ware added the comment: With Steve's opposition and the fact that we've gotten along for 11 years since this issue was opened without it (and also without further reports of issues), I'm going to go ahead and close the issue. -- resolution: -> rejected stage: patch review

[issue10071] Should not release GIL while running RegEnumValue

2019-04-27 Thread Mark Lawrence
Change by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue10071] Should not release GIL while running RegEnumValue

2014-08-04 Thread Steve Dower
Steve Dower added the comment: I don't think this is an appropriate fix, since in most cases there is no need to prevent other Python threads running while inside RegSetValue. There are also other ways that a context switch may occur during the enumeration which will put the program in

[issue10071] Should not release GIL while running RegEnumValue

2014-08-02 Thread Mark Lawrence
Mark Lawrence added the comment: Apart from the request for a comment made in msg192649 it looks as if this can be commited. -- nosy: +BreamoreBoy, steve.dower, tim.golden, zach.ware -brian.curtin versions: +Python 3.5 -Python 3.3 ___ Python

[issue10071] Should not release GIL while running RegEnumValue

2013-07-08 Thread Christian Heimes
Christian Heimes added the comment: LGTM I suggest that you add a comment with a link to this issue. People may wonder why some places don't release the GIL. -- nosy: +christian.heimes versions: +Python 3.3, Python 3.4 -Python 3.1, Python 3.2 ___

[issue10071] Should not release GIL while running RegEnumValue

2010-10-13 Thread Hirokazu Yamamoto
Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp added the comment: Well, I couldn't reproduce it on WinXP. Probably Win2K's bug. One thread is exactly on RegEnumValue or RegQueryValue, and another thread is a bit after RegSetValue (the place varies case by case). Type is SEGV. --

[issue10071] Should not release GIL while running RegEnumValue

2010-10-13 Thread Hirokazu Yamamoto
Changes by Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp: -- Removed message: http://bugs.python.org/msg118507 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10071 ___

[issue10071] Should not release GIL while running RegEnumValue

2010-10-13 Thread Hirokazu Yamamoto
Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp added the comment: One thread is exactly on RegEnumValue or RegQueryValue, and another thread is a bit after RegSetValue (the place varies case by case). Type is SEGV. -- ___ Python tracker

[issue10071] Should not release GIL while running RegEnumValue

2010-10-12 Thread Hirokazu Yamamoto
New submission from Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp: Currently, PC/winreg.c releases GIL while calling registry API, but I found this in Remarks section of RegEnumValue. http://msdn.microsoft.com/en-us/library/ms724865%28VS.85%29.aspx While using RegEnumValue, an application

[issue10071] Should not release GIL while running RegEnumValue

2010-10-12 Thread Hirokazu Yamamoto
Changes by Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp: -- Removed message: http://bugs.python.org/msg118413 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10071 ___

[issue10071] Should not release GIL while running RegEnumValue

2010-10-12 Thread Hirokazu Yamamoto
New submission from Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp: Currently, PC/winreg.c releases GIL while calling registry API, but I found this in Remarks section of RegEnumValue. http://msdn.microsoft.com/en-us/library/ms724865%28VS.85%29.aspx While using RegEnumValue, an application

[issue10071] Should not release GIL while running RegEnumValue

2010-10-12 Thread Hirokazu Yamamoto
Changes by Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp: Removed file: http://bugs.python.org/file19198/py27_test_winreg_crash_stack_trace.txt ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10071

[issue10071] Should not release GIL while running RegEnumValue

2010-10-12 Thread Hirokazu Yamamoto
Changes by Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp: -- Removed message: http://bugs.python.org/msg118414 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10071 ___

[issue10071] Should not release GIL while running RegEnumValue

2010-10-12 Thread Hirokazu Yamamoto
Changes by Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp: -- status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10071 ___ ___

[issue10071] Should not release GIL while running RegEnumValue

2010-10-12 Thread Hirokazu Yamamoto
New submission from Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp: Currently, PC/winreg.c releases GIL while calling registry API, but I found this in Remarks section of RegEnumValue. http://msdn.microsoft.com/en-us/library/ms724865%28VS.85%29.aspx While using RegEnumValue, an application

[issue10071] Should not release GIL while running RegEnumValue

2010-10-12 Thread Brian Curtin
Brian Curtin cur...@acm.org added the comment: Some of your submission appears to have gotten lost (I saw it via email). Below is the patch you proposed. I haven't experienced this crash on my machines, but the solution seems fine to me. # I sometimes experienced crash of

[issue10071] Should not release GIL while running RegEnumValue

2010-10-12 Thread Daniel Stutzbach
Daniel Stutzbach dan...@stutzbachenterprises.com added the comment: Hirokazu, could you run Python in a debugger and figure out exactly which line crashes and what the error is? I'm curious. If we make this change, the same change should be applied to RegEnumKey, etc., since the RegEnumKey