[issue10381] Add timezone support to datetime C API

STINNER Victor added the comment: I tested manually "./python -m test test_datetime test_datetime" in 3.6, 3.7 and master branches: I confirm that the test no longer crash. It has been fixed by the commit 58dc03c737a71de93edef7723c9f6186116288ef. Moreover, I don't recall a recent crash on

[issue10381] Add timezone support to datetime C API

Paul Ganssle added the comment: This can be closed now, I think. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue10381] Add timezone support to datetime C API

Alexander Belopolsky added the comment: New changeset fff596f792a0752b0e571fa57809e5752aba6353 by Alexander Belopolsky (Miss Islington (bot)) in branch '3.7': bpo-10381, bpo-32403: What's new entries for changes to datetime (gh-5814) (gh-5929)

[issue10381] Add timezone support to datetime C API

Alexander Belopolsky added the comment: New changeset 5bd04f964b4f1bcdbd0fa36de04f087c2db07cfe by Alexander Belopolsky (Paul Ganssle) in branch 'master': bpo-10381, bpo-32403: What's new entries for changes to datetime (gh-5814)

[issue10381] Add timezone support to datetime C API

Change by miss-islington : -- pull_requests: +5700 ___ Python tracker ___

[issue10381] Add timezone support to datetime C API

Change by miss-islington : -- pull_requests: +5596 ___ Python tracker ___

[issue10381] Add timezone support to datetime C API

Change by Paul Ganssle : -- pull_requests: +5588 ___ Python tracker ___ ___

[issue10381] Add timezone support to datetime C API

STINNER Victor added the comment: Oh, PR 5317 title mentionned this bpo number, but the merged change omits the bpo number and so wasn't mentioned on this issue. PR 5317 added: commit 58dc03c737a71de93edef7723c9f6186116288ef (upstream/master, master) Author: Paul

[issue10381] Add timezone support to datetime C API

Change by Paul Ganssle : -- pull_requests: +5164 ___ Python tracker ___ ___

[issue10381] Add timezone support to datetime C API

STINNER Victor added the comment: Ok, this time it should be fixed for real ;-) -- ___ Python tracker ___

[issue10381] Add timezone support to datetime C API

Change by Paul Ganssle : -- pull_requests: +5163 stage: resolved -> patch review ___ Python tracker ___

[issue10381] Add timezone support to datetime C API

STINNER Victor added the comment: Hunting reference leaks with "./python -m test -R 3:3 test_datetime" crashs since the commit 04af5b1ba9eb546a29735fac6cb5298159069b53. *** vstinner@apu$ ./python -m test -R 3:3 test_datetime Run tests sequentially 0:00:00 load avg:

[issue10381] Add timezone support to datetime C API

Change by Alexander Belopolsky : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue10381] Add timezone support to datetime C API

Alexander Belopolsky added the comment: New changeset 04af5b1ba9eb546a29735fac6cb5298159069b53 by Alexander Belopolsky (Paul Ganssle) in branch 'master': bpo-10381: Add timezone to datetime C API (#5032)

[issue10381] Add timezone support to datetime C API

Nick Coghlan added the comment: https://bugs.python.org/issue32459 covers defining a module-reloading-friendly way of using capsules. For this issue, I now think it makes sense to just ignore that problem, and add whatever you need to the existing API. --

[issue10381] Add timezone support to datetime C API

Nick Coghlan added the comment: On 31 December 2017 at 01:34, Paul Ganssle wrote: > That said, I think it would be really good if we could get a fast path for > timezone creation and access to the UTC singleton into the Python 3.7 > release. I

[issue10381] Add timezone support to datetime C API

Paul Ganssle added the comment: @Nick I'm certainly fine with re-configuring my PR to center around a new capsule module with deprecation of the old C API (though if you have any examples of what you have in mind that would be helpful to me). Certainly the "C global

[issue10381] Add timezone support to datetime C API

Nick Coghlan added the comment: Would it be possible to deprecate (or at least stop enhancing) the current datetime C API and add a new capsule based one instead? We're trying to get extension module authors to *stop* relying on C level globals, since it causes problems

[issue10381] Add timezone support to datetime C API

Change by Paul Ganssle : -- keywords: +patch pull_requests: +4919 stage: needs patch -> patch review ___ Python tracker ___

[issue10381] Add timezone support to datetime C API

Change by Paul Ganssle : -- nosy: +p-ganssle ___ Python tracker ___ ___

[issue10381] Add timezone support to datetime C API

Alexander Belopolsky added the comment: Since issue 24773 (PEP 495 implementation) will touch on CAPI, maybe it is time to implement this as well. -- nosy: +tim.peters versions: +Python 3.6 -Python 3.5 ___ Python tracker

[issue10381] Add timezone support to datetime C API

Changes by Mark Lawrence breamore...@yahoo.co.uk: -- versions: +Python 3.5 -Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10381 ___ ___

[issue10381] Add timezone support to datetime C API

New submission from Alexander Belopolsky belopol...@users.sourceforge.net: With timezone class added to datetime module, C API should be extended to at the minimum support efficient creation of timezone instances and access to the singleton UTC instance. I am not sure whether