Éric Araujo added the comment:
Thanks bitdancer for applying this.
FTR I just stumbled on code extracted from chishop that shows Django had issues
with the non-CRLF requests sent by distutils:
https://github.com/disqus/djangopypi/blob/master/djangopypi/http.py#L19
--
Roundup Robot added the comment:
New changeset 6375bf34fff6 by R David Murray in branch '3.4':
#10510: Fix bug in forward port of 2.7 distutils patch.
https://hg.python.org/cpython/rev/6375bf34fff6
New changeset 90b07d422bd9 by R David Murray in branch 'default':
#10510: Fix bug in forward port
Roundup Robot added the comment:
New changeset 5e3f8bd33cf2 by R David Murray in branch '3.4':
#10510: make distuitls upload/register use HTML standards compliant CRLF.
https://hg.python.org/cpython/rev/5e3f8bd33cf2
New changeset ea665bae2ea0 by R David Murray in branch 'default':
Merge:
Changes by R. David Murray rdmur...@bitdance.com:
--
resolution: - fixed
stage: commit review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10510
___
Ian Cordasco added the comment:
Bumping this once more.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10510
___
___
Python-bugs-list mailing
Ian Cordasco added the comment:
Per discussion on twitter
(https://twitter.com/merwok_/status/468518605135835136) I'm bumping this to
make sure it's merged.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10510
Éric Araujo added the comment:
Patch looks good, will apply. Thanks.
--
stage: needs patch - commit review
versions: +Python 3.5 -Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10510
Ian Cordasco added the comment:
I've attached a patch that should fix this issue. Please review and let me know
if changes are necessary.
--
keywords: +patch
Added file: http://bugs.python.org/file35067/compliant_distutils.patch
___
Python tracker
Changes by Ian Cordasco graffatcolmin...@gmail.com:
--
nosy: +icordasc
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10510
___
___
Changes by Éric Araujo mer...@netwok.org:
--
components: +Distutils -Distutils2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10510
___
___
Matthew Iversen added the comment:
Sorry, I referenced http://bugs.python.org/issue12169 before.
distutils multipart/form-data encoding still breaks the spec for MIME, which
demands CRLF line endings.
Especially since it is now sending HTTP 1.1 requests which should conform.
The patch /
Éric Araujo added the comment:
Some clarifications:
* distutils2/packaging is now abandoned.
* distutils can get bug fixes, unless they break e.g. work-arounds that have
been working in setuptools or setup.py scripts for years.
* distutils can get new features in 3.5.
For this issue, I think
Changes by Éric Araujo mer...@netwok.org:
--
resolution: duplicate -
stage: committed/rejected -
superseder: Factor out common code for d2 commands register, upload and
upload_docs -
title: packaging upload/register should use CRLF in HTTP requests - distutils
upload/register
Stephen Thorne step...@thorne.id.au added the comment:
I'm having a look at this ticket now. It looks like this can be rewritten to
use common code, and it would probably be good to use the 'email' module for
creating the MIME segements properly.
--
nosy: +jerub
Stephen Thorne step...@thorne.id.au added the comment:
Okay, I looked at this, then I ran into str/byte type problems with the email
module. Will wait until 'email' is sorted out before I consider a ticket like
this one again.
--
___
Python tracker
Changes by Éric Araujo mer...@netwok.org:
--
keywords: +easy
versions: +Python 3.3 -3rd party
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10510
___
Éric Araujo mer...@netwok.org added the comment:
Updated guidelines: http://wiki.python.org/moin/Distutils/FixingBugs
is it currently impossible to test the current svn version of
distutils in the current svn version of Python?
It is. Branches that get bugfixes are 3.2, 3.1 and 2.7; each one
Brian Jones bkjo...@gmail.com added the comment:
Sure. I'll create a patch in the next few days and submit it. Thanks for the
link to the guidelines. :)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10510
Brian Jones bkjo...@gmail.com added the comment:
So... have I missed a memo, or is it currently impossible to test the current
svn version of distutils in the current svn version of Python?
The tests for (at least) register and upload are written using Python 2.x
syntax and modules. How are
Tarek Ziadé ziade.ta...@gmail.com added the comment:
If you can make your server work with the current implementation, I'd rather
not change this in distutils but in distutils2.
Distutils is frozen and we make only bug fixes. By bug fix I mean anything that
is a bug. A non-strict
Brian Jones bkjo...@gmail.com added the comment:
If it's not a bug in distutils1, I imagine it will not be a bug in distutils2,
since that will also presumably work with PyPI, and PyPI will be the single
solitary supported implementation of the service?
I also don't see distutils2 in this
Tarek Ziadé ziade.ta...@gmail.com added the comment:
If it's not a bug in distutils1, I imagine it will not be a bug in distutils2
Yes that would be a feature request. we would be happy to add. e.g. make the
commands works with server X ou server Y.
I also don't see distutils2 in this list
Éric Araujo mer...@netwok.org added the comment:
I am convinced. Do you want to work on a patch? Guidelines are found at
http://www.python.org/dev/patches/
--
stage: - needs patch
title: distutils.command.upload/register HTTP message headers: bad line
termination - distutils
23 matches
Mail list logo
