[issue10572] Move test sub-packages to Lib/test

Erlend E. Aasland added the comment: > Do we need Lib/test/test_sqlite3/__init__.py? Would not tests in package be > loaded automatically? If I remove it, the test suite is not run. Maybe another change is needed for autodetection to work better. --

[issue10572] Move test sub-packages to Lib/test

Serhiy Storchaka added the comment: Do we need Lib/test/test_sqlite3/__init__.py? Would not tests in package be loaded automatically? -- nosy: +serhiy.storchaka ___ Python tracker

[issue10572] Move test sub-packages to Lib/test

Pablo Galindo Salgado added the comment: New changeset 762a4dc9361f9563e158e373ba8d767b4449f23d by Erlend Egeberg Aasland in branch 'main': bpo-10572: Fixup Lib/test/libregrtest/pgo.py (GH-29327) https://github.com/python/cpython/commit/762a4dc9361f9563e158e373ba8d767b4449f23d --

[issue10572] Move test sub-packages to Lib/test

Change by Erlend E. Aasland : -- pull_requests: +27596 pull_request: https://github.com/python/cpython/pull/29327 ___ Python tracker ___

[issue10572] Move test sub-packages to Lib/test

miss-islington added the comment: New changeset 62bf263a775fd8b5d5841cc09be3bd53e933 by Erlend Egeberg Aasland in branch 'main': bpo-10572: Move `sqlite3` tests to `Lib/test` (GH-29304) https://github.com/python/cpython/commit/62bf263a775fd8b5d5841cc09be3bd53e933 -- nosy:

[issue10572] Move test sub-packages to Lib/test

Change by Erlend E. Aasland : -- pull_requests: +27573 pull_request: https://github.com/python/cpython/pull/29304 ___ Python tracker ___

[issue10572] Move test sub-packages to Lib/test

Erlend E. Aasland added the comment: A side-effect of keeping tests inside the package, is that they appear in the package contents module docstring, which may be slightly confusing to new users. >>> import sqlite3 >>> help(sqlite3) Help on package sqlite3: NAME sqlite3 DESCRIPTION

[issue10572] Move test sub-packages to Lib/test

Brett Cannon added the comment: > After so long a reason came up that prevents the movement of tests of ctypes, > lib2to3, and idlelib (which even continues in the same folder, only the > nomenclature was changed)? Time and energy. -- ___ Python

[issue10572] Move test sub-packages to Lib/test

Leonardo Freua added the comment: After so long a reason came up that prevents the movement of tests of ctypes, lib2to3, and idlelib (which even continues in the same folder, only the nomenclature was changed)? -- nosy: +Leonardofreua ___ Python

[issue10572] Move test sub-packages to Lib/test

Terry J. Reedy added the comment: I added idlelib.idletest in May 2013 with the concurrence of Nick Coughlin, who also suggested 'idle_test' rather than just 'test'. It currently has 72 files (66 test_xyz files for idlelib modules). Foord's opening justification for moving package tests

[issue10572] Move test sub-packages to Lib/test

Change by Erlend Egeberg Aasland : -- pull_requests: +22976 pull_request: https://github.com/python/cpython/pull/24148 ___ Python tracker ___

[issue10572] Move test sub-packages to Lib/test

Change by Ido Michael : -- nosy: -Ido Michael ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue10572] Move test sub-packages to Lib/test

Change by Erlend Egeberg Aasland : -- nosy: +erlendaasland ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue10572] Move test sub-packages to Lib/test

Ido Michael added the comment: GH-18727 Only tkinter module for start. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue10572] Move test sub-packages to Lib/test

Brett Cannon added the comment: I'm also still in favour of the change. While people may have worked around this that doesn't mean we need to keep forcing them to do so. People worked around our lack of booleans but we chose to still fix that. ;) --

[issue10572] Move test sub-packages to Lib/test

Ned Deily added the comment: > some vendors like to leave out the tests and not having them all under 'test' > prevents that from working cleanly Yeah, but presumably all the major distributors have long ago figured out how to do this (it's not *that* hard) and, by moving the tests now,

[issue10572] Move test sub-packages to Lib/test

Zachary Ware added the comment: I'm personally still in favor of the change. This wouldn't be the first big movement of files in our repo and likely not the last, and I don't think git/GitHub's support (or lack thereof) for file moves is a good enough reason to not organize things better.

[issue10572] Move test sub-packages to Lib/test

Éric Araujo added the comment: Yes, I recommend against this change. Sorry for the time already spent :( (I only named Mercurial because python-dev used it before, so I was comparing the behaviour of the two tools) -- ___ Python tracker

[issue10572] Move test sub-packages to Lib/test

Ido Michael added the comment: Hey Eric, I'm not sure what you mean, you don't recommend the change in general? Or you just don't recommend Git for this and saying I should use Mercurial instead? -- ___ Python tracker

[issue10572] Move test sub-packages to Lib/test

Éric Araujo added the comment: I would advise against this for two reasons: - git does not track renames, contrart to Mercurial, so every log/diff command needs to analyse files to determine if something was moved rather than deleted + created; the matching can change depending on a

[issue10572] Move test sub-packages to Lib/test

Ido Michael added the comment: + Distutils is last priority -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue10572] Move test sub-packages to Lib/test

Ido Michael added the comment: Before I put more time into that, here's the strategy here: 1. Module by module migration. 2. By this order tkinter/test distutils/tests ctypes/tests lib2to3/tests unittest/test * sqlite3/test - excluded because needs more work. Please let me know if

[issue10572] Move test sub-packages to Lib/test

Ido Michael added the comment: I've created a clean PR - will do it in 2 rounds: This PR GH-18727, contains the modified test of ctypes, sqlite3 and tkinter modules. Once that's approved I'll deal with the other remaining 3. -- ___ Python tracker

[issue10572] Move test sub-packages to Lib/test

Change by Ido Michael : -- pull_requests: +18084 pull_request: https://github.com/python/cpython/pull/18727 ___ Python tracker ___

[issue10572] Move test sub-packages to Lib/test

Brett Cannon added the comment: @ned.deily the motivation is covered in Michael's initial comment; some vendors like to leave out the tests and not having them all under 'test' prevents that from working cleanly. Plus it makes the tests more discoverable. As for any of the projects being

[issue10572] Move test sub-packages to Lib/test

Ned Deily added the comment: As noted in the review of the PR, keep in mind that tests are included in an installed Python instance; there is a list of test directories in the main Makefile (Makefile.pre.in) that is used by "make install". Any movement of test directories thus needs to

[issue10572] Move test sub-packages to Lib/test

Ido Michael added the comment: Moved all 6 modules tests under Lib/test/MODULE_NAME_test Created this PR: GH-18524 -- ___ Python tracker ___

[issue10572] Move test sub-packages to Lib/test

Change by Ido Michael : -- pull_requests: +17901 pull_request: https://github.com/python/cpython/pull/18524 ___ Python tracker ___

[issue10572] Move test sub-packages to Lib/test

Brett Cannon added the comment: distutils might get pulled out at some point to it's at the bottom of the priority list for now. Basically move the tests for a package to under Lib/test under the proper subpackage name and make sure the tests didn't break due to the move. That's pretty

[issue10572] Move test sub-packages to Lib/test

Ido Michael added the comment: Thanks Brett, I'll check this out over the week. Let's take this module for instance: Lib/distutils. I looked on this one test file by now, it looks decoupled (test_bdist.py), 1.What to look for 2.Once decided it's not the right path, just migrate to

[issue10572] Move test sub-packages to Lib/test

Change by Andrew Svetlov : -- nosy: -asvetlov ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue10572] Move test sub-packages to Lib/test

Brett Cannon added the comment: Someone probably needs to go through the stdlib to find which modules have tests outside of Lib/test/, and then figure out if there is still any justification for that. If there isn't then they should be moved to Lib/test. --

[issue10572] Move test sub-packages to Lib/test

Ido Michael added the comment: Are there any conclusions? what needs to be done? -- nosy: +Ido Michael ___ Python tracker ___ ___

[issue10572] Move test sub-packages to Lib/test

Change by Brett Cannon : -- versions: +Python 3.9 -Python 3.6 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue10572] Move test sub-packages to Lib/test

Brett Cannon added the comment: In case anyone cares, this is still a thing. -- ___ Python tracker ___ ___ Python-bugs-list

[issue10572] Move test sub-packages to Lib/test

Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___

[issue10572] Move test sub-packages to Lib/test

Changes by Christian Heimes : -- versions: +Python 3.6 -Python 3.5 ___ Python tracker ___

[issue10572] Move test sub-packages to Lib/test

Zachary Ware added the comment: Here's an updated patch to move the sqlite3 tests. It's a large patch because it simplifies things by renaming all of the test methods from Checkxxx to testxxx. The test files are also renamed to fit the usual pattern. -- Added file:

[issue10572] Move test sub-packages to Lib/test

Zachary Ware added the comment: Here's a patch that moves the ctypes tests. On this one, I remembered to patch Makefile.pre.in; my sqlite3 patch will need the equivalent change as well. -- Added file: http://bugs.python.org/file36317/issue10572-ctypes.diff

[issue10572] Move test sub-packages to Lib/test

Changes by Berker Peksag berker.pek...@gmail.com: -- nosy: +berker.peksag stage: needs patch - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10572 ___

[issue10572] Move test sub-packages to Lib/test

Michael Foord added the comment: I still dislike moving tests around. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10572 ___ ___

[issue10572] Move test sub-packages to Lib/test

Zachary Ware added the comment: I'm in favor of a move, especially for ctypes, sqlite3, unittest, and tkinter, and don't really see a reason not to move distutils and lib2to3. The IDLE tests make a certain amount of sense to stay in the idlelib folder, just because IDLE is a special case.

[issue10572] Move test sub-packages to Lib/test

Mark Lawrence added the comment: Can we get this into 3.5 for the reasons given in msg179596 ? -- nosy: +BreamoreBoy versions: +Python 3.5 -Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10572

[issue10572] Move test sub-packages to Lib/test

Changes by Zachary Ware zachary.w...@gmail.com: -- nosy: +zach.ware ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10572 ___ ___ Python-bugs-list

[issue10572] Move test sub-packages to Lib/test

Geoff Wilson added the comment: Thanks Ned! Attached is an update for sqlite tests with the right patch format (issue10572-sqlite3-2.patch). May make sense to mention the hg diff --git format in: http://docs.python.org/devguide/patch.html -- Added file:

[issue10572] Move test sub-packages to Lib/test

Geoff Wilson added the comment: Attach updated patch for lib2to3 (issue10572-lib2to3-2.patch) -- Added file: http://bugs.python.org/file29250/issue10572-lib2to3-2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10572

[issue10572] Move test sub-packages to Lib/test

Ned Deily added the comment: Geoff, thanks, it is documented elsewhere in the devguide but it should be mentioned there as well. I've added a note to Issue16931. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10572

[issue10572] Move test sub-packages to Lib/test

Éric Araujo added the comment: Mercurial’s diff formats are actually able to represent file creation, deletion and rename. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10572 ___

[issue10572] Move test sub-packages to Lib/test

Geoff Wilson added the comment: Odd. I must be doing something wrong. My test workflow was: 1. hg mv a b 1a. modify files to resolve issues from the move 2. hg diff issue.patch # attached 3. hg revert --all 4. patch -p1 issue.patch Reading the hg docs more, I should have used 'hg

[issue10572] Move test sub-packages to Lib/test

Ned Deily added the comment: Geoff, you need to use hg's optional git format diff to preserve rename info. See hg help diffs. -- nosy: +ned.deily ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10572

[issue10572] Move test sub-packages to Lib/test

Ezio Melotti added the comment: Naming of files has been kept the same in the move from Lib/sqlite/test, to allow for easier merging of future patches. This should be done with hg mv -- this will also allow to change the name while preserving the history if that's desirable. --

[issue10572] Move test sub-packages to Lib/test

Geoff Wilson added the comment: The move will need to be done by someone with commit access. These patches came from using hg mv. After doing the move, there is some cleanup needed in each. These changes are included in the attached patches. --

[issue10572] Move test sub-packages to Lib/test

Geoff Wilson added the comment: Patch attached to move sqlite3 tests under Lib/test, and remove Lib/test/test_sqlite.py. Naming of files has been kept the same in the move from Lib/sqlite/test, to allow for easier merging of future patches. -- keywords: +patch nosy: +gmwils Added

[issue10572] Move test sub-packages to Lib/test

Geoff Wilson added the comment: Patch attached to move Lib/lib2to3/tests to Lib/test/test_lib2to3. -- Added file: http://bugs.python.org/file29209/issue10572-lib2to3.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10572

[issue10572] Move test sub-packages to Lib/test

R. David Murray added the comment: I believe that the complete list of test files still located outside of Lib/test are: tkinter/test distutils/tests ctypes/tests lib2to3/tests sqlite3/test unittest/test That last is somewhat ironic since Michael opened the issue :). I'm

[issue10572] Move test sub-packages to Lib/test

R. David Murray added the comment: Talked to Michael in IRC. He isn't particularly in favor of the move of the unittest tests, but doesn't object if someone else wants to do it. So, unassigning the issue from him. -- assignee: michael.foord -

[issue10572] Move test sub-packages to Lib/test

Alexander Belopolsky added the comment: ctypes/tests is within my area of interests and may prove to be one of the harder pieces. I'll try to move it and report the results. I have not worked with the rest, so unless it is truly trivial this will have to wait for another volunteer.

[issue10572] Move test sub-packages to Lib/test

Benjamin Peterson added the comment: I honestly don't see the point of moving tests around. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10572 ___

[issue10572] Move test sub-packages to Lib/test

Brett Cannon added the comment: Two reasons for collecting all of the tests in a single location: 1) Facilitates test discovery 2) It makes packaging of CPython easier for Linux distros that prefer to leave the tests out of the core package -- ___

[issue10572] Move test sub-packages to Lib/test

Alexander Belopolsky belopol...@users.sourceforge.net added the comment: Changing the title to reflect broader scope of this issue. Json tests were moved to Lib/test/json_tests in r86875. -- title: Move unittest test package to Lib/test - Move test sub-packages to Lib/test