Changes by Nir Soffer nir...@gmail.com:
--
nosy: +nirs
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1068268
___
___
Python-bugs-list mailing list
David Oxley pyt...@psi.epsilon.org.uk added the comment:
Another instance of a blocking function within subprocess not being protected
against EINTR
Python 2.6.4, subprocess.py, Popen function, line 1115:
data = os.read(errpipe_read, 1048576) # Exceptions limited to 1 MB
If a signal arrives
Changes by Dave Malcolm dmalc...@redhat.com:
--
nosy: +dmalcolm
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1068268
___
___
Python-bugs-list
Changes by Reid Kleckner r...@mit.edu:
--
nosy: +rnk
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1068268
___
___
Python-bugs-list mailing list
Changes by R. David Murray rdmur...@bitdance.com:
--
nosy: +r.david.murray
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1068268
___
___
Chad Miller pyt...@chad.org added the comment:
File
/home/cmiller/work/cabzr/desktopcouch/getport-at-call-time/desktopcouch/start_local_couchdb.py,
line 93, in run_couchdb
retcode = subprocess.call(local_exec)
File /usr/lib/python2.6/subprocess.py, line 444, in call
return
Changes by STINNER Victor victor.stin...@haypocalc.com:
--
nosy: -haypo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1068268
___
___
STINNER Victor victor.stin...@haypocalc.com added the comment:
Since Python 2.5 only accept security fixes, you should update your
patch to Python trunk.
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1068268
Changes by Matteo Bertini matt...@naufraghi.net:
Removed file:
http://bugs.python.org/file11818/subprocess-retry-on-EINTR-std-in-out-err.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1068268
Changes by Matteo Bertini matt...@naufraghi.net:
Removed file:
http://bugs.python.org/file11511/subprocess-eintr-safety-25maint-r65475.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1068268
Matteo Bertini matt...@naufraghi.net added the comment:
no EINTR patch upgraded to 25-maint r65475 that protects:
*) all direct calls
*) all returned fd
I hope :P
Added file:
http://bugs.python.org/file12438/no-EINTR-subprocess.py-25-maint-r65475.patch
Matteo Bertini matt...@naufraghi.net added the comment:
Please have a look at the proposed patch:
http://bugs.python.org/file11511/subprocess-eintr-safety-25maint-
r65475.patch
the list is more or less the patch itself.
___
Python tracker
STINNER Victor victor.stin...@haypocalc.com added the comment:
Instead of define a method for each syscall, you can write a generic
function that retry at OSError(EINTR):
def no_intr(self, func, *args, **kw):
while True:
try:
return func(*args, **kw)
except OSError, e:
if
STINNER Victor victor.stin...@haypocalc.com added the comment:
Oh, the new patch (subprocess-retry-on-EINTR-std-in-out-err.diff) has
already a generic function (_no_intr) which is a little bit different
than mine (looks like a decorator). Can you delete your old patch?
STINNER Victor victor.stin...@haypocalc.com added the comment:
naufraghi there are a lot of other places where EINTR
naufraghi can cause and error.
Can you write a list of these places?
___
Python tracker rep...@bugs.python.org
Changes by Martin v. Löwis mar...@v.loewis.de:
--
versions: -Python 2.4, Python 2.5, Python 2.5.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1068268
___
Changes by STINNER Victor victor.stin...@haypocalc.com:
--
nosy: +haypo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1068268
___
___
Matteo Bertini [EMAIL PROTECTED] added the comment:
Factorized try-except code, merged r65475 from 25-maint.
Protetect std[in|out|err] read and write too.
Added file:
http://bugs.python.org/file11818/subprocess-retry-on-EINTR-std-in-out-err.diff
___
Python
Matteo Bertini [EMAIL PROTECTED] added the comment:
Ups, forgot a _no_intr around select.select
Index: subprocess.py
===
--- subprocess.py (revisione 19645)
+++ subprocess.py (copia locale)
@@ -1178,7 +1178,7 @@
Matteo Bertini [EMAIL PROTECTED] added the comment:
Upgrade subprocess.py patch to 25-maint r65475
(apply cleanly with http://bugs.python.org/issue2113 fixed)
--
keywords: +patch
Added file:
http://bugs.python.org/file11511/subprocess-eintr-safety-25maint-r65475.patch
Gregory P. Smith [EMAIL PROTECTED] added the comment:
its too late in the release process for subprocess internals being EINTR
safe to make it into 2.6 but it is reasonable for 2.6.1.
--
priority: low - normal
type: - behavior
versions: +Python 2.5, Python 2.6
Matteo Bertini [EMAIL PROTECTED] added the comment:
I'd like to suggest to rise the priority of this bug.
Till this bus is around, no way using any module using subprocess.Popen
form a PyQt app (and I suppose PyGtk and wxPython too).
--
nosy: +naufraghi
Amaury Forgeot d'Arc [EMAIL PROTECTED] added the comment:
Two remarks:
1 - The part of the patch around the call to select.select() is already
in trunk since r64756, almost in the same form. good.
2 - the patch seems to replace all calls to os.write, os.read and
os.waipid. But it is based on a
Jesse Noller [EMAIL PROTECTED] added the comment:
I think this should be resolved in 2.6/3.0 if possible. Especially if
distributions like Ubuntu are self-patching the fix into place. For
reference, see: http://mg.pov.lt/blog/subprocess-in-2.4
--
nosy: +jnoller
Gregory P. Smith [EMAIL PROTECTED] added the comment:
fyi - To fix issue #2113 I added handling of a select.error errno.EINTR
being raised during the select.select call in r64756.
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1068268
Ralf Schmitt [EMAIL PROTECTED] added the comment:
Of course the signal handler may raise an exception, so my last argument
isn't that good.
_
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1068268
_
Changes by Gregory P. Smith [EMAIL PROTECTED]:
--
nosy: +gregory.p.smith
_
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1068268
_
___
Python-bugs-list mailing
Jeffrey Yasskin [EMAIL PROTECTED] added the comment:
I think the proper behavior on EINTR may depend on which subprocess call
we're in. For example, the user can easily loop on .wait() herself if
she wants to ignore EINTR. But it's a lot harder to loop on Popen() if
the read() in _execute_child
28 matches
Mail list logo
