[issue11105] Compiling evil ast crashes interpreter

miss-islington added the comment: New changeset 976598d36bd180024c5f0edf1f7ec0f0b436380f by Miss Islington (bot) in branch '3.10': bpo-11105: Do not crash when compiling recursive ASTs (GH-20594) https://github.com/python/cpython/commit/976598d36bd180024c5f0edf1f7ec0f0b436380f --

[issue11105] Compiling evil ast crashes interpreter

Pablo Galindo Salgado added the comment: New changeset f3491242e41933aa9529add7102edb68b80a25e9 by Batuhan Taskaya in branch 'main': bpo-11105: Do not crash when compiling recursive ASTs (GH-20594) https://github.com/python/cpython/commit/f3491242e41933aa9529add7102edb68b80a25e9 --

[issue11105] Compiling evil ast crashes interpreter

Change by miss-islington : -- nosy: +miss-islington nosy_count: 9.0 -> 10.0 pull_requests: +25115 pull_request: https://github.com/python/cpython/pull/26521 ___ Python tracker

[issue11105] Compiling evil ast crashes interpreter

Change by Georg Brandl : -- nosy: -georg.brandl ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue11105] Compiling evil ast crashes interpreter

Batuhan Taskaya added the comment: > With 3.9 on Windows, using Benjamin's example, I do not get the Windows > equivalent of a seg fault. However, execution stops at compile with no > exception, including SystemExit. I can still reproduce on Linux, $ python Python 3.10.0a0

[issue11105] Compiling evil ast crashes interpreter

Terry J. Reedy added the comment: With 3.9 on Windows, using Benjamin's example, I do not get the Windows equivalent of a seg fault. However, execution stops at compile with no exception, including SystemExit. These examples amount to limited fuzz testing of compile(). I think it should

[issue11105] Compiling evil ast crashes interpreter

Change by Batuhan Taskaya : -- keywords: +patch pull_requests: +19824 stage: test needed -> patch review pull_request: https://github.com/python/cpython/pull/20594 ___ Python tracker

[issue11105] Compiling evil ast crashes interpreter

ppperry added the comment: What about indirect cycles like below: >>> e = ast.UnaryOp(op=ast.Not(), lineno=0, col_offset=0) >>> f = ast.UnaryOp(op=ast.Not(), lineno=0, col_offset=0) >>> e.operand = f >>> f.operand = e >>> compile(ast.Expression(e), "", "eval") (I tested, this also crashes)

[issue11105] Compiling evil ast crashes interpreter

Batuhan added the comment: We can probably implement something like this to prevent this happening diff --git a/Parser/asdl_c.py b/Parser/asdl_c.py index daac0966f5..f9da52da7f 100755 --- a/Parser/asdl_c.py +++ b/Parser/asdl_c.py @@ -559,6 +559,11 @@ class Obj2ModVisitor(PickleVisitor):

[issue11105] Compiling evil ast crashes interpreter

Change by Batuhan : -- versions: +Python 3.9 -Python 3.2, Python 3.3 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue11105] Compiling evil ast crashes interpreter

Gregory P. Smith g...@krypto.org added the comment: i haven't confirmed if it is this exact bug but I believe a coworker just ran into something similar. he wrote code to use the ast to remove docstrings from code before passing it to compile() (as that saves a noticable amount of memory).

[issue11105] Compiling evil ast crashes interpreter

Benjamin Peterson benja...@python.org added the comment: Have him try on 3.3. This should be less of an issue there where there is an AST validator. It doesn't fix this bug, but it does fix most accidental AST construction bugs. -- ___ Python

[issue11105] Compiling evil ast crashes interpreter

Changes by Eric Snow ericsnowcurren...@gmail.com: -- nosy: +eric.snow ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11105 ___ ___ Python-bugs-list

[issue11105] Compiling evil ast crashes interpreter

Changes by Ezio Melotti ezio.melo...@gmail.com: -- components: +None stage: - test needed versions: -Python 3.1 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11105 ___

[issue11105] Compiling evil ast crashes interpreter

Changes by Meador Inge mead...@gmail.com: -- nosy: +meador.inge ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11105 ___ ___ Python-bugs-list

[issue11105] Compiling evil ast crashes interpreter

Alexander Belopolsky belopol...@users.sourceforge.net added the comment: Looks like a stack overflow caused by an infinite recursion. I am not sure if it is possible to add cycle detection code without sacrificing performance or setting some arbitrary limits. I wonder: Why ast nodes need to

[issue11105] Compiling evil ast crashes interpreter

Benjamin Peterson benja...@python.org added the comment: 2011/2/3 Alexander Belopolsky rep...@bugs.python.org: Alexander Belopolsky belopol...@users.sourceforge.net added the comment: Looks like a stack overflow caused by an infinite recursion.  I am not sure if it is possible to add cycle

[issue11105] Compiling evil ast crashes interpreter

Alexander Belopolsky belopol...@users.sourceforge.net added the comment: On Thu, Feb 3, 2011 at 12:08 PM, Benjamin Peterson rep...@bugs.python.org wrote: .. I wonder: Why ast nodes need to be mutable? So people can change them. Well, they are hashable, so this needs to be done carefully. Is

[issue11105] Compiling evil ast crashes interpreter

Benjamin Peterson benja...@python.org added the comment: 2011/2/3 Alexander Belopolsky rep...@bugs.python.org: Alexander Belopolsky belopol...@users.sourceforge.net added the comment: On Thu, Feb 3, 2011 at 12:08 PM, Benjamin Peterson rep...@bugs.python.org wrote: .. I wonder: Why ast

[issue11105] Compiling evil ast crashes interpreter

Georg Brandl ge...@python.org added the comment: Alex: If the node attributes were not mutable, it would be extremely awkward, not to say inefficient, to mutate an already existing AST as returned by ast.parse(). The AST objects in the _ast module aren't what Python works with internally,

[issue11105] Compiling evil ast crashes interpreter

New submission from Benjamin Peterson benja...@python.org: You don't want to know why I was thinking about this... $ ./python Python 3.2rc2+ (py3k:88302, Feb 1 2011, 19:02:10) [GCC 4.4.4] on linux2 Type help, copyright, credits or license for more information. import ast e =