Roundup Robot added the comment:
New changeset 3a1ac42435f9 by Serhiy Storchaka in branch '3.2':
Issue #12004: Fix an internal error in PyZipFile when writing an invalid
http://hg.python.org/cpython/rev/3a1ac42435f9
New changeset 678320c7f63d by Serhiy Storchaka in branch '3.3':
Issue #12004:
Serhiy Storchaka added the comment:
Thank you for the patch.
--
resolution: - fixed
stage: commit review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12004
Serhiy Storchaka added the comment:
Ben, can you please resend your agreement?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12004
___
___
Ben Morgan added the comment:
I've sent it again.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12004
___
___
Python-bugs-list mailing list
Ben Morgan added the comment:
Okay, I've emailed a contributor agreement.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12004
___
___
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12004
___
___
Serhiy Storchaka added the comment:
Ben Morgan, can you please submit a contributor form?
http://python.org/psf/contrib/contrib-form/
http://python.org/psf/contrib/
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12004
Serhiy Storchaka added the comment:
The patches look good to me, except that `self.assertIn('mod1.py', names)` can
be used instead `self.assertTrue('mod1.py' in names)`.
--
nosy: +alanmcintyre, serhiy.storchaka
stage: - commit review
versions: +Python 3.2, Python 3.3, Python 3.4
Eric V. Smith e...@trueblade.com added the comment:
Could you incorporate the test into Lib/test/test_zipfile?
Thanks!
--
components: +Library (Lib)
nosy: +eric.smith
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12004
Ben Morgan benpmor...@gmail.com added the comment:
I've attached a patch to test_zipfile.py. I noticed that it writes out the
error to stdout not stderr; I don't know if this is the desired behaviour.
--
Added file: http://bugs.python.org/file21903/test-zipfile.patch
New submission from Ben Morgan benpmor...@gmail.com:
PyZipFile.writepy gives internal error on syntax errors in files it processes.
For example, in the attached test case:
Traceback (most recent call last):
File C:\tfs\SDKS\python\Python32\lib\py_compile.py, line 119, in compile
Changes by Ben Morgan benpmor...@gmail.com:
--
keywords: +patch
Added file: http://bugs.python.org/file21889/pyzipfile-error.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12004
___
12 matches
Mail list logo