[issue12144] cookielib.CookieJar.make_cookies fails for cookies with 'expires' set

Change by Andrew Svetlov : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue12144] cookielib.CookieJar.make_cookies fails for cookies with 'expires' set

Andrew Svetlov added the comment: New changeset e7b7edf5ebaed14dc68c841a8a98260f1330ef9a by Andrew Svetlov (Xtreak) in branch '3.7': [3.7] bpo-12144: Handle cookies with expires attribute in CookieJar.make_cookies (GH-13921) (GH-16092)

[issue12144] cookielib.CookieJar.make_cookies fails for cookies with 'expires' set

Change by Karthikeyan Singaravelan : -- pull_requests: +15713 pull_request: https://github.com/python/cpython/pull/16092 ___ Python tracker ___

[issue12144] cookielib.CookieJar.make_cookies fails for cookies with 'expires' set

Change by Andrew Svetlov : -- versions: +Python 3.9 -Python 2.7 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue12144] cookielib.CookieJar.make_cookies fails for cookies with 'expires' set

miss-islington added the comment: New changeset 44cb89a78a308b7a613bdd01539ec84be914d693 by Miss Islington (bot) in branch '3.8': bpo-12144: Handle cookies with expires attribute in CookieJar.make_cookies (GH-13921)

[issue12144] cookielib.CookieJar.make_cookies fails for cookies with 'expires' set

miss-islington added the comment: New changeset bb41147eab15a2958f4ad38261e5bf608f6ace1b by Miss Islington (bot) (Xtreak) in branch 'master': bpo-12144: Handle cookies with expires attribute in CookieJar.make_cookies (GH-13921)

[issue12144] cookielib.CookieJar.make_cookies fails for cookies with 'expires' set

Change by miss-islington : -- pull_requests: +15709 pull_request: https://github.com/python/cpython/pull/16088 ___ Python tracker ___

[issue12144] cookielib.CookieJar.make_cookies fails for cookies with 'expires' set

Change by miss-islington : -- pull_requests: +15710 pull_request: https://github.com/python/cpython/pull/16089 ___ Python tracker ___

[issue12144] cookielib.CookieJar.make_cookies fails for cookies with 'expires' set

Change by Karthikeyan Singaravelan : -- pull_requests: +13794 stage: test needed -> patch review pull_request: https://github.com/python/cpython/pull/13921 ___ Python tracker

[issue12144] cookielib.CookieJar.make_cookies fails for cookies with 'expires' set

Karthikeyan Singaravelan added the comment: > Karthikeyan, it looks like your test will pass even when the bug is not > fixed. A test calling code that writes error message does not necessarily > mean the test itself will fail, I don’t think. You are right. Sorry, I got mislead by the

[issue12144] cookielib.CookieJar.make_cookies fails for cookies with 'expires' set

Martin Panter added the comment: Karthikeyan, it looks like your test will pass even when the bug is not fixed. A test calling code that writes error message does not necessarily mean the test itself will fail, I don’t think. I suggest you look at raising an exception when the UserWarning is

[issue12144] cookielib.CookieJar.make_cookies fails for cookies with 'expires' set

Demian Brecht added the comment: @xtreak sure, can do. May not have time to do so today but should be able to do so over the next couple days. -- ___ Python tracker ___

[issue12144] cookielib.CookieJar.make_cookies fails for cookies with 'expires' set

Karthikeyan Singaravelan added the comment: This issue is still reproducible on master and below is a unittest. The patch looks reasonable to me and fixes the issue. @demian.brecht, would you like to convert the patch to a PR ? diff --git a/Lib/test/test_http_cookiejar.py

[issue12144] cookielib.CookieJar.make_cookies fails for cookies with 'expires' set

Change by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue12144] cookielib.CookieJar.make_cookies fails for cookies with 'expires' set

Mark Lawrence added the comment: Can someone review the patch please. -- nosy: +BreamoreBoy versions: +Python 3.4, Python 3.5 -Python 3.2, Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12144

[issue12144] cookielib.CookieJar.make_cookies fails for cookies with 'expires' set

Terry J. Reedy added the comment: As I marked in the Stage setting 3 yrs ago, the patch needs a test, in particular a acceptible unittest. I doubt that cnn.com qualifies. Senthil? David? Perhaps we should have a test.python.org for use by tests, with oscure urls that return just what is

[issue12144] cookielib.CookieJar.make_cookies fails for cookies with 'expires' set

Changes by Demian Brecht demianbre...@gmail.com: -- nosy: +dbrecht ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12144 ___ ___ Python-bugs-list

[issue12144] cookielib.CookieJar.make_cookies fails for cookies with 'expires' set

Demian Brecht added the comment: I was able to repro this with Terry's steps on latest hg update. I've taken Scott's patch and updated it to diff from source root (his was pointing to /usr/lib) against the latest. The patch fixes the issue and I also can't see any negative knock-ons that may

[issue12144] cookielib.CookieJar.make_cookies fails for cookies with 'expires' set

Terry J. Reedy tjre...@udel.edu added the comment: Exceptions with traceback are ordinary behavior issues. 'Crash' means segfault or equivalent on Windows. And Jesus is correct. In general, include system with reports. With 3.2.0 IDLE on Winxp, adjusted 3.x code import urllib.request as ur,

[issue12144] cookielib.CookieJar.make_cookies fails for cookies with 'expires' set

Changes by Jesús Cea Avión j...@jcea.es: -- nosy: +jcea ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12144 ___ ___ Python-bugs-list mailing list

[issue12144] cookielib.CookieJar.make_cookies fails for cookies with 'expires' set

Jesús Cea Avión j...@jcea.es added the comment: Could you possibly test the bug in Python 2.7, 3.1, 3.2 and current 3.3 branch?. Python 2.6 is open for security fixes only, I think. -- ___ Python tracker rep...@bugs.python.org

[issue12144] cookielib.CookieJar.make_cookies fails for cookies with 'expires' set

New submission from Scott Wimer scott.wi...@gmail.com: When cookielib.CookieJar().make_cookies is used to extract cookies from a urllib2 response, it crashes when it encounters a 'Set-Cookie' header entry that has an 'expires' attribute. This crash occurs because the expires time is evaluated

[issue12144] cookielib.CookieJar.make_cookies fails for cookies with 'expires' set

Scott Wimer scott.wi...@gmail.com added the comment: The actual error is triggered by line 1507 in '_cookie_from_cookie_tuple()'. An easy fix is to move the setting of '_now' on line 1636 into the 'make_cookies()' method. That addresses this problem and doesn't look like it would introduce

[issue12144] cookielib.CookieJar.make_cookies fails for cookies with 'expires' set

Scott Wimer scott.wi...@gmail.com added the comment: Forgot to include the patch. Oops. -- keywords: +patch Added file: http://bugs.python.org/file22055/cookielib-crash.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12144