[issue12169] Factor out common code for d2 commands register, upload and upload_docs

Change by Martijn Pieters : -- pull_requests: +12168 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue12169] Factor out common code for d2 commands register, upload and upload_docs

Change by Martijn Pieters : -- pull_requests: -12166 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue12169] Factor out common code for d2 commands register, upload and upload_docs

Change by Martijn Pieters : -- pull_requests: +12166 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue12169] Factor out common code for d2 commands register, upload and upload_docs

Matthew Iversen added the comment: Hi, I'm wondering why this branch was never merged in? AFIAK, it's roundabout here - http://hg.python.org/cpython/log/28e4cd8fd864/Lib/packaging/command/upload.py It'd be great to have distutils submit forms that are compliant with the MIME spec (in my use

[issue12169] Factor out common code for d2 commands register, upload and upload_docs

Éric Araujo added the comment: Hi, I'm wondering why this branch was never merged in? It was, see the comment before with the changeset link. AFIAK, it's roundabout here - http://hg.python.org/cpython/log/28e4cd8fd864/Lib/packaging/command/upload.py I don’t understand what you mean.

[issue12169] Factor out common code for d2 commands register, upload and upload_docs

Roundup Robot devnull@devnull added the comment: New changeset c2785ed52ed4 by Éric Araujo in branch 'default': Factor out code used by packaging commands for HTTP requests (#12169). http://hg.python.org/cpython/rev/c2785ed52ed4 -- nosy: +python-dev

[issue12169] Factor out common code for d2 commands register, upload and upload_docs

Éric Araujo mer...@netwok.org added the comment: I added a few blank lines, changed the error message when boundary is not bytes, moved test_encode_multipart to test_util.py and committed. Thanks again! -- resolution: - fixed stage: needs patch - committed/rejected status: open -

[issue12169] Factor out common code for d2 commands register, upload and upload_docs

Changes by Éric Araujo mer...@netwok.org: Removed file: http://bugs.python.org/file22309/patch.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12169 ___

[issue12169] Factor out common code for d2 commands register, upload and upload_docs

Changes by Éric Araujo mer...@netwok.org: Removed file: http://bugs.python.org/file22330/patch.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12169 ___

[issue12169] Factor out common code for d2 commands register, upload and upload_docs

Éric Araujo mer...@netwok.org added the comment: Great patch, thanks! It’s on the top of my commit list. -- priority: normal - high ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12169 ___

[issue12169] Factor out common code for d2 commands register, upload and upload_docs

Éric Araujo mer...@netwok.org added the comment: I made some comments on the code review site; maybe you didn’t get the email, there is a known bug about that. You can follow the “review” link on the right of the patch file to see it. I have closed #10510, which asked that HTTP request use

[issue12169] Factor out common code for d2 commands register, upload and upload_docs

John Edmonds pocketcooki...@gmail.com added the comment: Thanks for reviewing the patch. I don't believe I received an email for the review. I think I have addressed your comment about the usage of str(body) by removing the call to str() and changing the tests to use byte literals. As for

[issue12169] Factor out common code for d2 commands register, upload and upload_docs

John Edmonds pocketcooki...@gmail.com added the comment: Here is the patch, re-written for the packaging module. -- Added file: http://bugs.python.org/file22330/patch.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12169

[issue12169] Factor out common code for d2 commands register, upload and upload_docs

Éric Araujo mer...@netwok.org added the comment: Thanks for your contribution. Unfortunately, I used “distutils2” as a familiar name for what is now known as the packaging module, in the 3.3 standard library. This document should help you find the right codebase to work from:

[issue12169] Factor out common code for d2 commands register, upload and upload_docs

John Edmonds pocketcooki...@gmail.com added the comment: I'd like to try tackling this issue. I've made a patch that moves encode_multipart from upload_docs to the distutils2.command module and changed the register and upload commands to use this function. -- keywords: +patch nosy:

[issue12169] Factor out common code for d2 commands register, upload and upload_docs

Changes by Éric Araujo mer...@netwok.org: -- assignee: tarek - eric.araujo keywords: +easy stage: patch review - needs patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12169 ___

[issue12169] Factor out common code for d2 commands register, upload and upload_docs

New submission from Éric Araujo mer...@netwok.org: These three commands have different code to do POST requests, using rllib or httplib. This already made us do more work to fix bugs and to port the code. upload_docs has a top-level function for multipart encoding; this should be moved to a

[issue12169] Factor out common code for d2 commands register, upload and upload_docs

Tarek Ziadé ziade.ta...@gmail.com added the comment: good idea! want to tackle this ? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12169 ___