[issue12424] distutils2: extension section uses bad environment marker separator

2014-03-12 Thread Éric Araujo
Changes by Éric Araujo mer...@netwok.org: -- resolution: - out of date stage: - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12424 ___

[issue12424] distutils2: extension section uses bad environment marker separator

2011-11-26 Thread Éric Araujo
Éric Araujo mer...@netwok.org added the comment: if a line ends with ;;, _pop_values() will call interpret() with an empty string. [...] it just means interpret() would return False, causing the line to be ignored, which is probably fine for that border case Hm, I’d rather call that a

[issue12424] distutils2: extension section uses bad environment marker separator

2011-11-26 Thread Éric Araujo
Éric Araujo mer...@netwok.org added the comment: Latest patch looks good. Looking at the examples with ';;' or even '--', I think that their role is non-obvious. Even though the PEP and docs explained them, there is value in using intuitive (“guessable”) markup. So if the constraints are

[issue12424] distutils2: extension section uses bad environment marker separator

2011-11-25 Thread Eli Collins
Eli Collins e...@assurancetechnologies.com added the comment: The second patchset (9170231ebf14.diff) should implement all the changes you suggested in your second review (dated 2011-09-05). --- The only non-addressed item in your second review was a request for clarification on a potential

[issue12424] distutils2: extension section uses bad environment marker separator

2011-11-22 Thread Éric Araujo
Éric Araujo mer...@netwok.org added the comment: Does your latest patch address my second review? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12424 ___

[issue12424] distutils2: extension section uses bad environment marker separator

2011-09-27 Thread Eli Collins
Changes by Eli Collins e...@assurancetechnologies.com: Added file: http://bugs.python.org/file23247/9170231ebf14.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12424 ___

[issue12424] distutils2: extension section uses bad environment marker separator

2011-09-27 Thread Eli Collins
Changes by Eli Collins e...@assurancetechnologies.com: -- hgrepos: +70 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12424 ___ ___

[issue12424] distutils2: extension section uses bad environment marker separator

2011-09-27 Thread Eli Collins
Eli Collins e...@assurancetechnologies.com added the comment: I've attached a second revision of my patch to fix this issue (9170231ebf14.diff). Per Eric Araujo's advice, this patch changes _pop_values() to use ;; as the environment marker separator for all fields in setupcfg's extension

[issue12424] distutils2: extension section uses bad environment marker separator

2011-06-27 Thread Eli Collins
New submission from Eli Collins e...@assurancetechnologies.com: The _pop_values() function in packaging.config uses -- as the environment marker separator when parsing extension sections. This doesn't match PEP 345, or how the metadata section is currently parsed, both of which use ; instead.

[issue12424] distutils2: extension section uses bad environment marker separator

2011-06-27 Thread Eli Collins
Changes by Eli Collins e...@assurancetechnologies.com: -- keywords: +patch Added file: http://bugs.python.org/file22503/cpython_issue12424.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12424