[issue13312] test_time fails: strftime('%Y', y) for negative year

STINNER Victor added the comment: Note for myself: Python 2.7 is not affected by this bug because it doesn't accept year < 1900. -- ___ Python tracker ___

[issue13312] test_time fails: strftime('%Y', y) for negative year

Gregory P. Smith added the comment: OverflowError is now raised for negative values that would trigger a problem and the unittest has been updated to test this. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___

[issue13312] test_time fails: strftime('%Y', y) for negative year

miss-islington added the comment: New changeset d5f017bbd65f37ac53fd3c6c439a53155eef2475 by Miss Islington (bot) in branch '3.7': bpo-13312: Avoid int underflow in time year. (GH-8912) https://github.com/python/cpython/commit/d5f017bbd65f37ac53fd3c6c439a53155eef2475 -- nosy:

[issue13312] test_time fails: strftime('%Y', y) for negative year

miss-islington added the comment: New changeset c47acc2bb1d0a3fb6dda14ced958d272fb2821a6 by Miss Islington (bot) in branch '3.6': bpo-13312: Avoid int underflow in time year. (GH-8912) https://github.com/python/cpython/commit/c47acc2bb1d0a3fb6dda14ced958d272fb2821a6 --

[issue13312] test_time fails: strftime('%Y', y) for negative year

Change by miss-islington : -- pull_requests: +8386 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue13312] test_time fails: strftime('%Y', y) for negative year

Change by miss-islington : -- pull_requests: +8385 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue13312] test_time fails: strftime('%Y', y) for negative year

Gregory P. Smith added the comment: New changeset 76be0f8b7dbe649ad4821144461800ffb0d0 by Gregory P. Smith in branch 'master': bpo-13312: Avoid int underflow in time year. (GH-8912) https://github.com/python/cpython/commit/76be0f8b7dbe649ad4821144461800ffb0d0 --

[issue13312] test_time fails: strftime('%Y', y) for negative year

Change by Gregory P. Smith : -- pull_requests: +8384 stage: needs patch -> patch review ___ Python tracker ___ ___ Python-bugs-list

[issue13312] test_time fails: strftime('%Y', y) for negative year

Change by Gregory P. Smith : -- assignee: -> gregory.p.smith nosy: +gregory.p.smith versions: +Python 3.6, Python 3.7, Python 3.8 -Python 3.5 ___ Python tracker ___

[issue13312] test_time fails: strftime('%Y', y) for negative year

Changes by Jakub Wilk : -- nosy: +jwilk ___ Python tracker ___ ___ Python-bugs-list mailing

[issue13312] test_time fails: strftime('%Y', y) for negative year

Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___

[issue13312] test_time fails: strftime('%Y', y) for negative year

Martin Panter added the comment: If you enable GCC’s -ftrapv option, the subtraction overflow triggers an abort. Alexander’s patch works around the problem for asctime(), but the problem still exists in other cases, such as: >>> time.mktime((-2**31 + 1899, *(0,) * 8)) Aborted (core dumped)

[issue13312] test_time fails: strftime('%Y', y) for negative year

Alexander Belopolsky added the comment: As far as I can tell, the original report was about a test failing due to a system-dependent behavior of time.asctime(). However, since changeset 1e62a0cee092 (see issue #8013), we no longer call system asctime. I believe the test disabled in

[issue13312] test_time fails: strftime('%Y', y) for negative year

Alexander Belopolsky added the comment: Attached patch eliminates undefined behavior, but I am not sure fixing this is worth the trouble. -- keywords: +patch nosy: +haypo Added file: http://bugs.python.org/file38290/issue13312.patch ___ Python

[issue13312] test_time fails: strftime('%Y', y) for negative year

Alexander Belopolsky added the comment: We still have the following in Lib/test/test_time.py: # Issue #13312: it may return wrong value for year TIME_MINYEAR + 1900 # Skip the value test, but check that no error is raised self.yearstr(TIME_MINYEAR) I reviewed the

[issue13312] test_time fails: strftime('%Y', y) for negative year

Mark Lawrence added the comment: Sorry should have been #17690. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13312 ___ ___ Python-bugs-list

[issue13312] test_time fails: strftime('%Y', y) for negative year

Mark Lawrence added the comment: I believe that this can be closed as the test code was changed completely in #17960. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13312 ___

[issue13312] test_time fails: strftime('%Y', y) for negative year

Alexander Belopolsky added the comment: Mark, Issue #17960 (Clarify the required behaviour of locals()) does not seem to be relevant here. I think you meant to refer to a changeset, not issue number. If so please use hash number such as d877d7f3b679. --

[issue13312] test_time fails: strftime('%Y', y) for negative year

Mark Lawrence added the comment: The failing negative years test is still being skipped. I'm assuming this was not originally intended. -- nosy: +BreamoreBoy ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13312

[issue13312] test_time fails: strftime('%Y', y) for negative year

Florent Xicluna florent.xicl...@gmail.com added the comment: It fails for very low negative years: -2147481749 = year = -2147483648 (-131) + 1900 = year = (-131) Every other value behaves correctly on this FreeBSD buildbot: - (-131) + 1900 year (+131) : correctly formatted with '%Z'

[issue13312] test_time fails: strftime('%Y', y) for negative year

Florent Xicluna florent.xicl...@gmail.com added the comment: It fails for very low negative years: -2147483648 = year -2147481748 (-131)= year (-131) + 1900 Every other value behaves correctly on this FreeBSD buildbot: - (-131) + 1900 = year (+131) : correctly formatted with '%Z'

[issue13312] test_time fails: strftime('%Y', y) for negative year

Changes by Florent Xicluna florent.xicl...@gmail.com: -- Removed message: http://bugs.python.org/msg146827 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13312 ___

[issue13312] test_time fails: strftime('%Y', y) for negative year

Florent Xicluna florent.xicl...@gmail.com added the comment: I mean formatted with '%Y', of course. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13312 ___

[issue13312] test_time fails: strftime('%Y', y) for negative year

Roundup Robot devn...@psf.upfronthosting.co.za added the comment: New changeset 1a0bfc26af57 by Florent Xicluna in branch 'default': Issue #13312: skip the failing negative years for now. http://hg.python.org/cpython/rev/1a0bfc26af57 -- ___ Python

[issue13312] test_time fails: strftime('%Y', y) for negative year

New submission from Florent Xicluna florent.xicl...@gmail.com: On builder AMD64 FreeBSD 8.2 3.x for the TIME_MINYEAR: == FAIL: test_negative (test.test_time.TestStrftime4dyear)

[issue13312] test_time fails: strftime('%Y', y) for negative year

Roundup Robot devn...@psf.upfronthosting.co.za added the comment: New changeset 9cb1b85237a9 by Florent Xicluna in branch 'default': Issue #13312: skip the single failing value for now. http://hg.python.org/cpython/rev/9cb1b85237a9 -- nosy: +python-dev

[issue13312] test_time fails: strftime('%Y', y) for negative year

Roundup Robot devn...@psf.upfronthosting.co.za added the comment: New changeset d877d7f3b679 by Florent Xicluna in branch 'default': Actually, there's more than one failing value. (changeset 9cb1b85237a9, issue #13312). http://hg.python.org/cpython/rev/d877d7f3b679 --