[issue13559] Use sendfile where possible in httplib

Christian Heimes added the comment: sendfile() only works for plain HTTP. For technical reasons it does not work for HTTPS (*). These days majority of services use HTTPS. Therefore the usefulness of sendfile() patch is minimal. (*) It is possible to use sendfile() for TLS connections, but

[issue13559] Use sendfile where possible in httplib

Change by STINNER Victor : -- nosy: -vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue13559] Use sendfile where possible in httplib

Senthil Kumaran added the comment: Yes, the point number 5. We will have to evaluate if sendfile side-steps and avoids the issues noted in issue23740 -- ___ Python tracker

[issue13559] Use sendfile where possible in httplib

Alex Willmer added the comment: To check my understanding Is the motivation for the closer to 1. using sendfile() will break $X, and we know X 2. there's high probability sendfile() will break something 3. there's unknown probability sendfile() will break something 4. there's low probability

[issue13559] Use sendfile where possible in httplib

Senthil Kumaran added the comment: Alex, https://bugs.python.org/issue23740 is identified as a dependency on this issue. We will have to resolve that first, and come back to this. And yes, if you contribute on other's patch, both the contributions will be included and appropriately

[issue13559] Use sendfile where possible in httplib

Alex Willmer added the comment: I would like to take a stab at this. Giampaolo, would it be okay if I made a pull request updated from your patch? With the appropriate "Co-authored-by: Author Name " line. -- nosy: +Alex.Willmer ___ Python tracker

[issue13559] Use sendfile where possible in httplib

STINNER Victor added the comment: This issue is no newcomer friendly, I remove the "easy" keyword. -- keywords: -easy nosy: +vstinner ___ Python tracker ___

[issue13559] Use sendfile where possible in httplib

Martin Panter added the comment: The multiple personalities of HTTPConnection.send() and friends is a bit of a can of worms. I suggest working on Issue 23740 to get an idea of what kinds of file objects are meant to be supported, and what things may work by accident and be used in the real

[issue13559] Use sendfile where possible in httplib

Giampaolo Rodola' added the comment: Patch in attachment uses the newly added socket.sendfile() method (issue 17552). -- keywords: +patch type: enhancement - performance Added file: http://bugs.python.org/file35569/httplib-sendfile.patch ___ Python

[issue13559] Use sendfile where possible in httplib

Changes by Giampaolo Rodola' g.rod...@gmail.com: -- dependencies: +Add a new socket.sendfile() method versions: +Python 3.5 -Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13559

[issue13559] Use sendfile where possible in httplib

Changes by Kasun Herath kasun...@gmail.com: -- nosy: +kasun ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13559 ___ ___ Python-bugs-list mailing

[issue13559] Use sendfile where possible in httplib

Changes by Ross Lagerwall rosslagerw...@gmail.com: -- nosy: +rosslagerwall ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13559 ___ ___

[issue13559] Use sendfile where possible in httplib

Changes by Éric Araujo mer...@netwok.org: -- nosy: +eric.araujo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13559 ___ ___ Python-bugs-list

[issue13559] Use sendfile where possible in httplib

New submission from Benjamin Peterson benja...@python.org: HTTPConnection.send() should use os.sendfile when possible to avoid copying data into userspace and back. -- components: Library (Lib) keywords: easy messages: 149052 nosy: benjamin.peterson priority: normal severity: normal

[issue13559] Use sendfile where possible in httplib

Changes by Antoine Pitrou pit...@free.fr: -- nosy: +giampaolo.rodola, orsenthil ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13559 ___ ___

[issue13559] Use sendfile where possible in httplib

Giampaolo Rodola' g.rod...@gmail.com added the comment: This is not possible for two reasons: - on most POSIX systems, sendfile() works with mmap-like (regular) files only, while HTTPConnection.send() accepts any file-like object as long as it provides a read() method - after read()ing a

[issue13559] Use sendfile where possible in httplib

Benjamin Peterson benja...@python.org added the comment: 2011/12/8 Giampaolo Rodola' rep...@bugs.python.org: Giampaolo Rodola' g.rod...@gmail.com added the comment: This is not possible for two reasons: - on most POSIX systems, sendfile() works with mmap-like (regular) files only, while

[issue13559] Use sendfile where possible in httplib

Giampaolo Rodola' g.rod...@gmail.com added the comment: ftplib's sendfile support is not tracked as issue13559. Considerations I made there should apply here as well. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13559

[issue13559] Use sendfile where possible in httplib

Giampaolo Rodola' g.rod...@gmail.com added the comment: Ops! I meant issue13564. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13559 ___ ___