Roundup Robot added the comment:
New changeset 24b449a77e88 by R David Murray in branch '3.2':
#13579: teach string.Formatter about 'a'.
http://hg.python.org/cpython/rev/24b449a77e88
New changeset 4feb10457c13 by R David Murray in branch 'default':
Merge #13579: teach string.Formatter about
R. David Murray added the comment:
I've reviewed the patch and applied it.
2.7 doesn't support !a or 'ascii()', but I did backport the doc changes and the
reordering of the clauses in order to minimize code base drift.
Thanks, Francisco.
--
resolution: - fixed
stage: commit review -
Francisco Martín Brugué franci...@email.de added the comment:
The patch is updated. Please let me know.
And as Éric noticed the NEWS entry could be:
Issue #13579: string.Formatter now understands the a conversion specifier.
Thanks!
--
Added file:
Éric Araujo mer...@netwok.org added the comment:
To be exact, the specifier is a, without ! which is a delimiter. :)
--
nosy: +eric.araujo
title: string.Formatter doesn't understand the !a conversion specifier -
string.Formatter doesn't understand the a conversion specifier
Francisco Martín Brugué franci...@email.de added the comment:
However, I have not actually applied and run test_string.py.
I've applied the issue13579_4720cc9e.patch to the changeset 0554183066b5
and applies without errors for me.
--
___
Python
R. David Murray rdmur...@bitdance.com added the comment:
To answer your question about wrapping, it is best not to introduce noise into
the patch. The person who commits it can rewrap (although even then it is nice
to do the rewrapping in a separate changeset).
--
nosy:
Francisco Martín Brugué franci...@email.de added the comment:
Ok, I've updated the patch.
The NEWS entry could be:
Issue #13579: string.Formatter now understands the !a conversion specifier.
(not in the patch because AFAIN it makes the merge easier)
Let me know if that's in the line you want.
Francisco Martín Brugué franci...@email.de added the comment:
Well, it's done:
http://bugs.python.org/issue14053
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13579
___
Francisco Martín Brugué franci...@email.de added the comment:
Updated. The NEWS line is now at the top of the section.
As near as I can tell, the two change block beginning with
+In less formal terms,
[...]
are strictly re-wrapping and no text changes. Correct?
Yes. Just a pydev question
Nick Coghlan ncogh...@gmail.com added the comment:
On Sat, Feb 18, 2012 at 10:10 PM, Francisco Martín Brugué
rep...@bugs.python.org wrote:
./python ./Tools/scripts/patchcheck.py
Getting the list of files that have been added/changed ... 0 files
Fixing whitespace ... 0 files
Fixing C file
Francisco Martín Brugué franci...@email.de added the comment:
I suspect mq will confuse make patchcheck (since it looks for
differences between the working copy and the hg branch tip, and there
are no such differences for an applied mq patch).
Does it makes sense to open a feature request
Nick Coghlan ncogh...@gmail.com added the comment:
Agreed that this is a bug in string.Formatter rather than a new feature.
There's already a separate bug for the autonumbering problem:
http://bugs.python.org/issue13598
And I created a new issue about unifying some of the tests:
Francisco Martín Brugué franci...@email.de added the comment:
I have updated the patch with the documentation changes proposed and also added
a news entry (does a new entry has to be added in some order?).
Thank for the review in advance.
--
Added file:
Terry J. Reedy tjre...@udel.edu added the comment:
I just noticed two more minor errors that were and remain in It takes a format
string, and an arbitrary set of positional and keyword argument. Remove the
comma and make 'argument' plural.
As near as I can tell, the two change block beginning
Terry J. Reedy tjre...@udel.edu added the comment:
However, I have not actually applied and run test_string.py.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13579
___
Terry J. Reedy tjre...@udel.edu added the comment:
Doc/library/string.rst string.Formatter().format(fmt, 10)needs a couple of
changes also.
1. format(format_string, *args, **kwargs)
format() is the primary API method. It takes a format template string,
I think 'template' should be removed as
Changes by Terry J. Reedy tjre...@udel.edu:
--
stage: needs patch - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13579
___
___
Francisco Martín Brugué franci...@email.de added the comment:
Hi,
here's a patch with the changes proposed by Terry
Cheers,
francis
--
keywords: +patch
nosy: +francismb
Added file: http://bugs.python.org/file24512/issue13579_80a50b7ad88f.patch
___
Terry J. Reedy tjre...@udel.edu added the comment:
At line 237 of string.py:
def convert_field(self, value, conversion):
# do any conversion on the resulting object
if conversion == 'r':
return repr(value)
elif conversion == 's':
return
Changes by Terry J. Reedy tjre...@udel.edu:
--
stage: - needs patch
type: - behavior
versions: +Python 2.7, Python 3.2, Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13579
___
Changes by Eric V. Smith e...@trueblade.com:
--
assignee: - eric.smith
nosy: +eric.smith
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13579
___
New submission from Nick Coghlan ncogh...@gmail.com:
As the subject line says:
fmt = {0!a}
fmt.format(10)
'10'
import string
string.Formatter().format(fmt, 10)
Traceback (most recent call last):
File stdin, line 1, in module
File /usr/lib/python3.2/string.py, line 180, in format
22 matches
Mail list logo
