Stefan Krah stefan-use...@bytereef.org added the comment:
STINNER Victor rep...@bugs.python.org wrote:
Your comment is incorrect, it was already failing before my commit ;-)
Example at changeset 548a023c8230:
Ah, sorry about that. I was lazy and tested against 585d3664da89 (which is a
couple
STINNER Victor victor.stin...@gmail.com added the comment:
By the way, Python 3.2 fails also to handle
non-ASCII thousands separator or non-ASCII
decimal point: (...)
Hum, it is not trivial to redo the work on Python 3.2. I prefer to leave the
code unchanged to not introduce a regression,
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset f89e2f4cda88 by Victor Stinner in branch 'default':
Issue #13706: Fix format(int, n) for locale with non-ASCII thousands separator
http://hg.python.org/cpython/rev/f89e2f4cda88
--
Stefan Krah stefan-use...@bytereef.org added the comment:
The ps_AF locale fails with an assert after the latest commit:
Python 3.3.0a0 (default:f89e2f4cda88+, Feb 24 2012, 01:14:50)
[GCC 4.4.3] on linux
Type help, copyright, credits or license for more information.
import locale
[67103
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset a29d20fa85b4 by Victor Stinner in branch 'default':
Issue #13706: Fix format(float, n) for locale with non-ASCII decimal point
(e.g. ps_aF)
http://hg.python.org/cpython/rev/a29d20fa85b4
--
STINNER Victor victor.stin...@gmail.com added the comment:
The ps_AF locale fails with an assert after the latest commit:
...
format(13232434234.23423, n)
python: Python/formatter_unicode.c:606: fill_number:
Assertion `r == spec-n_grouped_digits' failed.
Aborted
Oh, you found a locale
Stefan Krah stefan-use...@bytereef.org added the comment:
I'm using ps_AF for testing:
$ ./localeconv_wchar ps_AF
size of wchar_t: 32 bits
decimal_point byte string: \xd9\xab (2 bytes)
decimal_point wide string: L\u066b (1 characters)
thousands_sep byte string: \xd9\xac (2 bytes)
thousands_sep
STINNER Victor victor.stin...@gmail.com added the comment:
thousands_separator.patch:
- Remove the unused _PyUnicode_InsertThousandsGroupingLocale() function
- Add a test for non-ASCII thousands separator (depend on the locale)
- _PyUnicode_InsertThousandsGrouping() expects thousands
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 056f5cc8885d by Victor Stinner in branch 'default':
Issue #13706: Add assertions to detect bugs earlier
http://hg.python.org/cpython/rev/056f5cc8885d
--
___
Python
STINNER Victor victor.stin...@haypocalc.com added the comment:
With the changeset 056f5cc8885d, format(1234, 'n') fails in a locale using a
non-ASCII thousands separator. Patch showing the problem:
diff --git a/Lib/test/test_format.py b/Lib/test/test_format.py
--- a/Lib/test/test_format.py
+++
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 231c6042c40c by Victor Stinner in branch 'default':
Issue #13706: Support non-ASCII fill characters
http://hg.python.org/cpython/rev/231c6042c40c
--
nosy: +python-dev
___
STINNER Victor victor.stin...@haypocalc.com added the comment:
I fixed the original report, but there is still an issue with non-ASCII
thousands separator.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13706
Eric V. Smith e...@trueblade.com added the comment:
Sorry for the off-the-cuff diagnosis. I had assumed this was the unintended
result of the conversion, but of course I'm wrong.
I'd like to fix this.
--
nosy: +Jim.Jewett
___
Python tracker
Stefan Krah stefan-use...@bytereef.org added the comment:
Actually the issue is not restricted to numeric formatting. It's not
possible to pad a Unicode string with a non-ascii whitespace:
format(abcd, \u20077)
Traceback (most recent call last):
File stdin, line 1, in module
ValueError: fill
14 matches
Mail list logo
