[issue13706] non-ascii fill characters no longer work in numeric formatting

2012-01-03 Thread Stefan Krah
Changes by Stefan Krah stefan-use...@bytereef.org: -- title: Unicode fill characters no longer work in numeric formatting - non-ascii fill characters no longer work in numeric formatting ___ Python tracker rep...@bugs.python.org

[issue13706] non-ascii fill characters no longer work in numeric formatting

2012-01-03 Thread Eric V. Smith
Eric V. Smith e...@trueblade.com added the comment: I assume this is left over from the PEP 393 changes. I think the right thing to do is delete this code from line 277 of formatter_unicode.c: if (format-fill_char 127 || format-align 127 || format-sign 127) {

[issue13706] non-ascii fill characters no longer work in numeric formatting

2012-01-03 Thread STINNER Victor
STINNER Victor victor.stin...@haypocalc.com added the comment: I assume this is left over from the PEP 393 changes. Correct. I'm not sure such a restriction needs to exist any more. The restriction was introduced to simplify the implementation. maxchar has to be computed exactly in

[issue13706] non-ascii fill characters no longer work in numeric formatting

2012-01-03 Thread Martin v . Löwis
Martin v. Löwis mar...@v.loewis.de added the comment: Removing the if condition would be incorrect. The maximum char is computed at the beginning of the formatting. If, during formatting, need for a padding character is determined, the padding character must not be larger than the maximum