[issue13849] Add tests for NUL checking in certain strs

Martin Panter added the comment: Buildbots seem happier now -- status: open -> closed ___ Python tracker ___

[issue13849] Add tests for NUL checking in certain strs

Roundup Robot added the comment: New changeset 9e997c8f4876 by Berker Peksag in branch '3.5': Issue #13849: Fix test_null_bytes under Windows https://hg.python.org/cpython/rev/9e997c8f4876 New changeset a28abe83cf5c by Berker Peksag in branch 'default': Issue #13849: Merge from 3.5

[issue13849] Add tests for NUL checking in certain strs

Martin Panter added the comment: http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%203.5/builds/1072/steps/test/logs/stdio == FAIL: test_null_bytes (test.test_genericpath.TestGenericTest) (attr='getsize')

[issue13849] Add tests for NUL checking in certain strs

Berker Peksag added the comment: Thanks for your review, Victor. I don't care about 2.7 at this point so I went with 3.5+ :) -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue13849] Add tests for NUL checking in certain strs

Roundup Robot added the comment: New changeset 899f06eb390c by Berker Peksag in branch '3.5': Issue #13849: Add tests for null byte checking in test_genericpath https://hg.python.org/cpython/rev/899f06eb390c New changeset 9498736fbd8f by Berker Peksag in branch 'default': Issue #13849: Merge

[issue13849] Add tests for NUL checking in certain strs

Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___

[issue13849] Add tests for NUL checking in certain strs

STINNER Victor added the comment: issue13849.diff: LGTM. If the tests pass on Python 2.7 and 3.5, I think that it's worth to add the tests to these versions as well. -- ___ Python tracker

[issue13849] Add tests for NUL checking in certain strs

Berker Peksag added the comment: Attached patch adds tests for common members of Lib/genericpath.py. -- keywords: +patch nosy: +berker.peksag stage: needs patch -> patch review versions: +Python 3.6 -Python 3.4 Added file: http://bugs.python.org/file43821/issue13849.diff

[issue13849] Add tests for NUL checking in certain strs

Mark Lawrence added the comment: The type and versions fields have been set to what I think they ought to be, as I couldn't find any reference to this issue on python-dev. Note that #13848 is closed as fixed and I've asked Victor if he can pick up #13617. -- nosy: +BreamoreBoy type:

[issue13849] Add tests for NUL checking in certain strs

Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com: -- nosy: +Arfrever ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13849 ___

[issue13849] Add tests for NUL checking in certain strs

Hynek Schlawack h...@ox.cx added the comment: It appears that os.stat did not check for embedded nulls but just passed the string to Windows. JFTR, we have fixed it for open() because it's a potential security problem. I have implemented a helper function for checking for NUL chars:

[issue13849] Add tests for NUL checking in certain strs

Hynek Schlawack h...@ox.cx added the comment: Why is this one still open? I'm afraid the questions raised aren't fit to be discussed in a ticket (weren't the outsourcing of of stdlib an item at the language summit?). I tend to close it as rejected (although I rather disagree) unless someone

[issue13849] Add tests for NUL checking in certain strs

Antoine Pitrou pit...@free.fr added the comment: Why is this one still open? I'm afraid the questions raised aren't fit to be discussed in a ticket The original request (add tests for NUL character checking) is still relevant AFAIK. All it needs is a patch - by Alex or anybody else :-)

[issue13849] Add tests for NUL checking in certain strs

Changes by R. David Murray rdmur...@bitdance.com: -- stage: - needs patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13849 ___ ___

[issue13849] Add tests for NUL checking in certain strs

Alex Gaynor alex.gay...@gmail.com added the comment: I'm perfectly happy to write a patch for this, the only reason I didn't was Martin and others expressed opposition to committing it. If there's a philosophicaly opposition to the patch I won't write it :) --

[issue13849] Add tests for NUL checking in certain strs

Terry J. Reedy tjre...@udel.edu added the comment: There are two issues. 1) what is the requested changed and is it technically correct; 2) if correct, should it be made from a policy viewpoint. 1) Alex, do I understand correctly that you see the behavior of disallowing nulls in paths as

[issue13849] Add tests for NUL checking in certain strs

STINNER Victor victor.stin...@gmail.com added the comment: See also issue #13617. -- nosy: +haypo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13849 ___

[issue13849] Add tests for NUL checking in certain strs

Terry J. Reedy tjre...@udel.edu added the comment: This is a bit related to #13848 files 2 seconds earlier. -- nosy: +terry.reedy ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13849 ___

[issue13849] Add tests for NUL checking in certain strs

Antoine Pitrou pit...@free.fr added the comment: Well, adding tests is certainly useful to avoid regressions in CPython (not only PyPy or Jython). It seems to me that the only reasonable discussion is whether they should be committed to 2.7 and 3.2, or only the default branch. (I personally

[issue13849] Add tests for NUL checking in certain strs

Martin v. Löwis mar...@v.loewis.de added the comment: If other VMs need this test for some reason, they can easily add a test case themselves. I'm -1 on adding test cases to bug fix releases just for completeness. A lacking test is not a bug, and hence must not be added to a bug fix release.

[issue13849] Add tests for NUL checking in certain strs

R. David Murray rdmur...@bitdance.com added the comment: My understanding (and recollection, but I don't have notes I can point at to hand) is that one goal that arose from recent VM and language summits was for the CPython test suite to be used as the validating test suite, with

[issue13849] Add tests for NUL checking in certain strs

R. David Murray rdmur...@bitdance.com added the comment: Oh, and in case it isn't clear, this request is *coming* from one of the other VMs (pypy), so if my summit recollection is correct, they are in fact adding a test that they need by submitting this issue :) (Or at least they will have

[issue13849] Add tests for NUL checking in certain strs

Changes by Hynek Schlawack h...@ox.cx: -- nosy: +hynek ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13849 ___ ___ Python-bugs-list mailing list

[issue13849] Add tests for NUL checking in certain strs

Martin v. Löwis mar...@v.loewis.de added the comment: If so, I think this change should not checked into the 2.7 branch. Instead, a separate branch should be made for changes not intended for CPython, but for Python implementations in general. Making the Python test suite usable for other

[issue13849] Add tests for NUL checking in certain strs

Martin v. Löwis mar...@v.loewis.de added the comment: Reconsidering: I think it shouldn't be checked into the cpython *repository*. Instead, if PyPy developers want to contribute changes to the test suite and standard library to improve the standard library, there should be a separate

[issue13849] Add tests for NUL checking in certain strs

New submission from Alex Gaynor alex.gay...@gmail.com: ATM there's no tests (at least in 2.x, I haven't checked 3.x yet) for this behavior: os.path.exists(/tmp\x00abcds) Traceback (most recent call last): File stdin, line 1, in module File /usr/lib/python3.2/genericpath.py, line 18, in

[issue13849] Add tests for NUL checking in certain strs

Martin v. Löwis mar...@v.loewis.de added the comment: Why is that a bug? There is no feature in Python saying that the test suite covers the code fully (by some kind of measurement). New tests should only be added to 3.3, unless they test for a newly-fixed bug (and even then the test may not

[issue13849] Add tests for NUL checking in certain strs

R. David Murray rdmur...@bitdance.com added the comment: Adding tests helps the other VMs, which generally are trailing behind the CPython releases. -- nosy: +r.david.murray ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13849