[issue13886] readline-related test_builtin failure

STINNER Victor added the comment: Since nobody managed to fix this issue in 10 years and the test still fails if the readline module is loaded, I wrote GH-30631 to skip the test if the readline module is loaded. -- ___ Python tracker

[issue13886] readline-related test_builtin failure

Change by STINNER Victor : -- pull_requests: +28834 pull_request: https://github.com/python/cpython/pull/30631 ___ Python tracker ___

[issue13886] readline-related test_builtin failure

STINNER Victor added the comment: Oh, the test_builtin.test_input_tty_non_ascii() fails just if test_readline is loaded previously: $ ./python -E -m test -m test.test_builtin.PtyTests.test_input_tty_non_ascii -v test_readline test_builtin == CPython 3.11.0a4+ (heads/main:7f4b69b9076, Jan 17

[issue13886] readline-related test_builtin failure

STINNER Victor added the comment: On Fedora 35, I still reproduce the initial issue on the main branch of Python: $ ./python -E -m test -v test_readline test_builtin (...) == FAIL: test_input_tty_non_ascii

[issue13886] readline-related test_builtin failure

Irit Katriel added the comment: See also Issue44887. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue13886] readline-related test_builtin failure

Irit Katriel added the comment: On 3.11 I don't see a problem on windows, but on mac test_input_tty from test_builtin hangs when test_readline runs first, while test_builtin passes on its own. -- nosy: +iritkatriel versions: +Python 3.10, Python 3.11, Python 3.9 -Python 3.5, Python

[issue13886] readline-related test_builtin failure

Change by Brett Cannon : -- nosy: -brett.cannon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue13886] readline-related test_builtin failure

Change by Xavier de Gaye : -- nosy: -xdegaye ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue13886] readline-related test_builtin failure

Xavier de Gaye added the comment: All checks have passed on PR 7133, even on macOs, and the PR is ready to be reviewed :-) -- ___ Python tracker ___

[issue13886] readline-related test_builtin failure

Xavier de Gaye added the comment: As stated in msg285810, issue 28180 removed the need for an Android workaround. After checking this point on the Android API 24 emulator with the current master branch, I have opened PR 7133 which is Martin's input-readline.v3.patch with

[issue13886] readline-related test_builtin failure

Change by Xavier de Gaye : -- pull_requests: +6767 ___ Python tracker ___ ___

[issue13886] readline-related test_builtin failure

Serhiy Storchaka added the comment: This old issue still is not fixed. Martin, Xavier, could you open a PR please? -- ___ Python tracker

[issue13886] readline-related test_builtin failure

Serhiy Storchaka added the comment: As well as other 5 bugs. -- ___ Python tracker ___

[issue13886] readline-related test_builtin failure

STINNER Victor added the comment: bpo-31703 has been marked as a duplicate of this bug. -- ___ Python tracker ___

[issue13886] readline-related test_builtin failure

Xavier de Gaye added the comment: With input-readline.v3.patch, test_builtin runs with success on Android api 21. With pep538_coerce_legacy_c_locale_v4.diff that implements PEP 538 in issue 28180, and with input-readline.v3.patch modified to have 'readline_encoding =

[issue13886] readline-related test_builtin failure

Martin Panter added the comment: V3 of my patch skips the Readline tests in cases involving non-ASCII bytes when the locale seen by Readline would be ASCII. Readline may translate the non-ASCII bytes to escape sequences, and treat them as special Meta (Alt) key combinations. This behaviour

[issue13886] readline-related test_builtin failure

Xavier de Gaye added the comment: Thanks for waiting for a run of the patch on Android. Indeed, test_input_tty_non_ascii fails with this patch on Android when LANG is not set and is ok when LANG=en_US.UTF-8. As you are suggesting, the test is ok when skipping the Readline half of the test.

[issue13886] readline-related test_builtin failure

Martin Panter added the comment: Hi Xavier, I was about to push input-readline.v2.patch, but I thought it might be good to check with you first if this causes problems with Android, based on my experience with Issue 28997. With the patch applied,

[issue13886] readline-related test_builtin failure

Martin Panter added the comment: input-readline.v2.patch sets stderr=DEVNULL so that the prompt does not come out in the test log. A disadvantage of this is that if there is a failure, any error messages, stack trace, etc is also lost. To fix this properly, we would probably have to capture

[issue13886] readline-related test_builtin failure

Martin Panter added the comment: Since people keep coming upon this bug, perhaps we should inhibit push my fix without fixing that other prompt bug (now a feature change I think). Probably have to capture stderr to avoid it coming out in the test output. -- versions: +Python 3.7

[issue13886] readline-related test_builtin failure

Martin Panter added the comment: Here is a possible patch which: * Runs the three test_input_tty() tests in a fresh child Python interpreter, for control over whether Readline is loaded. A pseudoterminal is used for stdin and stdout, and stderr is left untouched to easily see error messages.

[issue13886] readline-related test_builtin failure

Changes by Martin Panter : Added file: http://bugs.python.org/file41653/input-readline.patch ___ Python tracker ___

[issue13886] readline-related test_builtin failure

Changes by Ned Deily n...@acm.org: -- nosy: +doko ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13886 ___ ___ Python-bugs-list mailing list

[issue13886] readline-related test_builtin failure

Serhiy Storchaka added the comment: This happens even when run test_builtin twice. ./python -E -m test -v test_builtin test_builtin or ./python -E -m test -Fv test_builtin -- nosy: +serhiy.storchaka ___ Python tracker

[issue13886] readline-related test_builtin failure

Brett Cannon added the comment: Issue #18230 is another test_builtin failure related to tty tests. -- nosy: +brett.cannon ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13886 ___

[issue13886] readline-related test_builtin failure

Nadeem Vawda added the comment: You're right; it breaks backspacing over multibyte characters. I should have tested it more carefully before committing. I'll revert the changes. -- resolution: fixed - stage: committed/rejected - needs patch status: closed - open

[issue13886] readline-related test_builtin failure

Roundup Robot added the comment: New changeset e6952acd5a55 by Nadeem Vawda in branch '3.2': Back out fix for issue #13886; it introduced a new bug in interactive readline use. http://hg.python.org/cpython/rev/e6952acd5a55 -- ___ Python tracker

[issue13886] readline-related test_builtin failure

Roundup Robot added the comment: New changeset 5c7e884b205a by Nadeem Vawda in branch '3.3': Back out fix for issue #13886; it introduced a new bug in interactive readline use. http://hg.python.org/cpython/rev/5c7e884b205a -- ___ Python tracker

[issue13886] readline-related test_builtin failure

Roundup Robot added the comment: New changeset 8b8c6abda7e8 by Nadeem Vawda in branch 'default': Back out fix for issue #13886; it introduced a new bug in interactive readline use. http://hg.python.org/cpython/rev/8b8c6abda7e8 -- ___ Python tracker

[issue13886] readline-related test_builtin failure

Roundup Robot added the comment: New changeset 5bf91dfb1e34 by Nadeem Vawda in branch '2.7': Back out fix for issue #13886; it introduced a new bug in interactive readline use. http://hg.python.org/cpython/rev/5bf91dfb1e34 -- ___ Python tracker

[issue13886] readline-related test_builtin failure

Roundup Robot added the comment: New changeset cf0f450b3299 by Nadeem Vawda in branch '3.2': Issue #13886: Fix input() to not strip out supposedly-invalid input bytes. http://hg.python.org/cpython/rev/cf0f450b3299 -- nosy: +python-dev ___ Python

[issue13886] readline-related test_builtin failure

Roundup Robot added the comment: New changeset 5c8732049dd5 by Nadeem Vawda in branch '3.3': Issue #13886: Fix input() to not strip out supposedly-invalid input bytes. http://hg.python.org/cpython/rev/5c8732049dd5 -- ___ Python tracker

[issue13886] readline-related test_builtin failure

Roundup Robot added the comment: New changeset 9774721bfc32 by Nadeem Vawda in branch 'default': Issue #13886: Fix input() to not strip out supposedly-invalid input bytes. http://hg.python.org/cpython/rev/9774721bfc32 -- ___ Python tracker

[issue13886] readline-related test_builtin failure

Roundup Robot added the comment: New changeset 12223782031f by Nadeem Vawda in branch '2.7': Issue #13886: Fix input() to not strip out supposedly-invalid input bytes. http://hg.python.org/cpython/rev/12223782031f -- ___ Python tracker

[issue13886] readline-related test_builtin failure

Changes by Nadeem Vawda nadeem.va...@gmail.com: -- assignee: - nadeem.vawda resolution: - fixed stage: patch review - committed/rejected status: open - closed versions: +Python 2.7 ___ Python tracker rep...@bugs.python.org

[issue13886] readline-related test_builtin failure

Petri Lehtinen added the comment: -setlocale(LC_CTYPE, ); +setlocale(LC_CTYPE, C); This looks dangerous to me. Are you sure readline's behavior doesn't change because of this? -- ___ Python tracker rep...@bugs.python.org

[issue13886] readline-related test_builtin failure

Ezio Melotti added the comment: This problem still exists on 3.4. The attached patch seems to solve it. -- nosy: +ezio.melotti versions: +Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13886

[issue13886] readline-related test_builtin failure

Changes by Petri Lehtinen pe...@digip.org: -- nosy: +haypo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13886 ___ ___ Python-bugs-list mailing

[issue13886] readline-related test_builtin failure

Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com: -- nosy: +Arfrever ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13886 ___

[issue13886] readline-related test_builtin failure

Petri Lehtinen pe...@digip.org added the comment: I had exactly the same error on 3.3b1 when running the test suite with randomized order. -- nosy: +petri.lehtinen ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13886

[issue13886] readline-related test_builtin failure

New submission from Nadeem Vawda nadeem.va...@gmail.com: I've recently come across a strange failure in the tests for the input() built-in function: $ ./python -E -m test -v test_readline test_builtin [... snip ...]

[issue13886] readline-related test_builtin failure

Nadeem Vawda nadeem.va...@gmail.com added the comment: Here's another patch that ensures the test always exercises the GNU readline code path (rather than the stdio fallback). This will cause the failure to occur when running just test_builtin (no need to also run test_readline before it).