[issue14905] zipimport.c needs to support namespace packages when no 'directory' entry exists

Serhiy Storchaka added the comment: Issue34738 fixes distutils. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue14905] zipimport.c needs to support namespace packages when no 'directory' entry exists

Change by Serhiy Storchaka : -- components: +Library (Lib) -Extension Modules stage: patch review -> needs patch type: behavior -> enhancement versions: +Python 3.8 -Python 3.6 ___ Python tracker

[issue14905] zipimport.c needs to support namespace packages when no 'directory' entry exists

Serhiy Storchaka added the comment: zipimport have been rewritten in pure Python (issue25711). -- ___ Python tracker ___ ___

[issue14905] zipimport.c needs to support namespace packages when no 'directory' entry exists

Changes by Eric Snow ericsnowcurren...@gmail.com: -- nosy: +superluser versions: +Python 3.6 -Python 3.3, Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14905 ___

[issue14905] zipimport.c needs to support namespace packages when no 'directory' entry exists

Changes by Eric Snow ericsnowcurren...@gmail.com: -- nosy: +gregory.p.smith ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14905 ___ ___

[issue14905] zipimport.c needs to support namespace packages when no 'directory' entry exists

Phil Connell added the comment: I've raised issue17633 to track the issue in my last message. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14905 ___

[issue14905] zipimport.c needs to support namespace packages when no 'directory' entry exists

Changes by Phil Connell pconn...@gmail.com: -- nosy: +pconnell ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14905 ___ ___ Python-bugs-list

[issue14905] zipimport.c needs to support namespace packages when no 'directory' entry exists

Changes by Martin Morrison m...@ensoft.co.uk: -- nosy: +isoschiz ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14905 ___ ___ Python-bugs-list

[issue14905] zipimport.c needs to support namespace packages when no 'directory' entry exists

Phil Connell added the comment: The problem appears to be more general. zipimport fails for deeper hierarchies, even with directory entries. With the supplied patch (zipimport-issue14905-2.patch) I see the following: $ unzip -l foo.zip Archive: foo.zip Length DateTimeName

[issue14905] zipimport.c needs to support namespace packages when no 'directory' entry exists

Phillip J. Eby added the comment: Just a note: the zip files produced by the distutils and friends (sdist, bdist_dumb, eggs) do not include entries for plain directories. I would guess that this is also true for wheels at the moment, unless something was specifically done to work around this

[issue14905] zipimport.c needs to support namespace packages when no 'directory' entry exists

Ronald Oussoren added the comment: Why are zipfiles without entries for directories broken? When you don't care about directory permissions (such as when the zipfile won't be extracted at all) the entries for directories are not necessary. Also, AFAIK the zipfile specification

[issue14905] zipimport.c needs to support namespace packages when no 'directory' entry exists

Changes by Brett Cannon br...@python.org: -- nosy: -brett.cannon ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14905 ___ ___ Python-bugs-list

[issue14905] zipimport.c needs to support namespace packages when no 'directory' entry exists

Eric V. Smith added the comment: I don't think such files are common: I've never seen such a file in the wild. I created one, by accident, while testing PEP 420. OTOH, it was surprisingly easy to create the malformed file with zipfile. -- ___

[issue14905] zipimport.c needs to support namespace packages when no 'directory' entry exists

Changes by Antoine Pitrou pit...@free.fr: -- nosy: +brett.cannon, ncoghlan versions: +Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14905 ___

[issue14905] zipimport.c needs to support namespace packages when no 'directory' entry exists

Serhiy Storchaka added the comment: This can significant slowdown zipimport. I think we shouldn't support such broken zip files in zipimport. -- nosy: +serhiy.storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14905

[issue14905] zipimport.c needs to support namespace packages when no 'directory' entry exists

Nick Coghlan added the comment: How common are such broken zip files? Like Serhiy, I'm concerned about the possible negative impact on the interpreter startup time as we try to second guess the contents of the zip file manifest. It seems better to be explicit that we consider such zipfiles

[issue14905] zipimport.c needs to support namespace packages when no 'directory' entry exists

Nick Coghlan added the comment: OTOH, the scan time should be short relative to the time needed to read the manifest in the first place - an appropriate microbenchmark may also be adequate to address my concerns. -- ___ Python tracker

[issue14905] zipimport.c needs to support namespace packages when no 'directory' entry exists

Stephen Thorne added the comment: Please see attached new patch, based on review comments. -- Added file: http://bugs.python.org/file26894/zipimport-issue14905-2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14905

[issue14905] zipimport.c needs to support namespace packages when no 'directory' entry exists

Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com: -- nosy: +Arfrever ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14905 ___

[issue14905] zipimport.c needs to support namespace packages when no 'directory' entry exists

Changes by Eric Snow ericsnowcurren...@gmail.com: -- stage: needs patch - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14905 ___ ___

[issue14905] zipimport.c needs to support namespace packages when no 'directory' entry exists

Changes by Eric Snow ericsnowcurren...@gmail.com: -- nosy: +eric.snow ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14905 ___ ___ Python-bugs-list

[issue14905] zipimport.c needs to support namespace packages when no 'directory' entry exists

Changes by Jonathan Paugh jpa...@gmx.us: -- nosy: +jpaugh ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14905 ___ ___ Python-bugs-list mailing

[issue14905] zipimport.c needs to support namespace packages when no 'directory' entry exists

Stephen Thorne step...@thorne.id.au added the comment: Here is a patch that synthesises the directory names at the point where file names are read in. The unit test now passes, and has had the expected failure removed. Patch collaboration with Diarmuid Bourke diarmuidbou...@gmail.com at the

[issue14905] zipimport.c needs to support namespace packages when no 'directory' entry exists

Eric V. Smith e...@trueblade.com added the comment: See also test_namespace_pkgs.py ZipWithMissingDirectory.test_missing_directory which is currently marked as expectedFailure. -- ___ Python tracker rep...@bugs.python.org

[issue14905] zipimport.c needs to support namespace packages when no 'directory' entry exists

New submission from Eric V. Smith e...@trueblade.com: If a zip file contains pkg/foo.py but no pkg/ entry, it will not be possible for pkg to be a namespace package portion. -- components: Extension Modules messages: 161543 nosy: eric.smith priority: normal severity: normal stage:

[issue14905] zipimport.c needs to support namespace packages when no 'directory' entry exists

Eric V. Smith e...@trueblade.com added the comment: For a (very) brief discussion on the strategy to implement this, see: http://mail.python.org/pipermail/import-sig/2012-May/000528.html -- ___ Python tracker rep...@bugs.python.org