[issue15088] PyGen_NeedsFinalizing is public, but undocumented

STINNER Victor added the comment: New changeset 74b662cf202753d224d82d5503974cce881f7436 by Victor Stinner (Joannah Nanjekye) in branch 'master': bpo-15088 : Remove PyGen_NeedsFinalizing() (GH-15702) https://github.com/python/cpython/commit/74b662cf202753d224d82d5503974cce881f7436

[issue15088] PyGen_NeedsFinalizing is public, but undocumented

STINNER Victor added the comment: The function is not documented nor tested. I searched for usage of PyGen_NeedsFinalizing() in C code in GitHub: https://github.com/search?l=C=1=PyGen_NeedsFinalizing=Code I only found copies of the CPython code source: PyGen_NeedsFinalizing() definition in

[issue15088] PyGen_NeedsFinalizing is public, but undocumented

STINNER Victor added the comment: PyGen_NeedsFinalizing() was added by: commit 49fd7fa4431da299196d74087df4a04f99f9c46f Author: Thomas Wouters Date: Fri Apr 21 10:40:58 2006 + Merge p3yk branch with the trunk up to revision 45595. This breaks a fair number of tests, all

[issue15088] PyGen_NeedsFinalizing is public, but undocumented

Joannah Nanjekye added the comment: My searches show references to this function in CPython cloned repositories. From @pitrous's views, I think it is better to deprecate it with a removal notice for a later release. I have deprecated the Function instead and will be removed in the next

[issue15088] PyGen_NeedsFinalizing is public, but undocumented

Change by Joannah Nanjekye : -- pull_requests: +15356 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15702 ___ Python tracker ___

[issue15088] PyGen_NeedsFinalizing is public, but undocumented

Cheryl Sabella added the comment: Thanks again, Antoine. I'll see what I can come up with. :-) -- ___ Python tracker ___

[issue15088] PyGen_NeedsFinalizing is public, but undocumented

Antoine Pitrou added the comment: I think https://searchcode.com/ may have a larger indexing base than GitHub alone. And, yes, you'll see many duplicates of the CPython source code... Visual inspection may be needed :-/ -- ___

[issue15088] PyGen_NeedsFinalizing is public, but undocumented

Cheryl Sabella added the comment: Thanks Antoine. Do you have a good way for searching third party projects? I searched on Github and I'm getting a lot of references to the CPython filenames. I don't know how to check if anyone is making calls to the function. But,

[issue15088] PyGen_NeedsFinalizing is public, but undocumented

Antoine Pitrou added the comment: Cheryl: it may be useful to do a code search to find out whether any third-party projects are relying on PyGen_NeedsFinalizing. -- ___ Python tracker

[issue15088] PyGen_NeedsFinalizing is public, but undocumented

Cheryl Sabella added the comment: What should be done for the PyGen_NeedsFinalizing API? Does it need to be documented or should it be removed since it's no longer used in the code base? Thanks! -- nosy: +csabella versions: +Python 3.7, Python 3.8 -Python 3.2,

[issue15088] PyGen_NeedsFinalizing is public, but undocumented

Antoine Pitrou added the comment: For the record, PyGen_NeedsFinalizing still exists but it isn't used anymore in the code base (following PEP 442). -- nosy: +pitrou ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15088

[issue15088] PyGen_NeedsFinalizing is public, but undocumented

Nathan Housel added the comment: Please correct me if I'm wrong, but I think PyGen_NeedsFinalizing should not be an API function because it is only used, nor _PyGen_FetchStopIterationValue. In the attached patch I've removed PyGen_NeedsFinalizing and _PyGen_FetchStopIterationValue fom the

[issue15088] PyGen_NeedsFinalizing is public, but undocumented

New submission from Nick Coghlan ncogh...@gmail.com: Currently undocumented: http://docs.python.org/py3k/c-api/gen.html Public API in a released version of Python: http://hg.python.org/cpython/file/3.2/Include/genobject.h -- messages: 163012 nosy: ncoghlan priority: normal severity:

[issue15088] PyGen_NeedsFinalizing is public, but undocumented

Changes by Nick Coghlan ncogh...@gmail.com: -- assignee: - docs@python components: +Documentation nosy: +docs@python versions: +Python 3.2, Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15088