Guido van Rossum added the comment:
looks good to me. Crys, can you do the honors?
--
nosy: +gvanrossum
resolution: - accepted
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1537
__
Guido van Rossum added the comment:
Oops, some tests fail. ctypes and hotshot at least.
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1537
__
___
Python-bugs-list mailing list
Christian Heimes added the comment:
Applied in r59300 to the trunk. (This time for real. At first I
committed it together with some junk to py3k branch. :/)
--
resolution: accepted - fixed
status: open - closed
__
Tracker [EMAIL PROTECTED]
Chad Austin added the comment:
Fantastic, thank you!
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1537
__
___
Python-bugs-list mailing list
Unsubscribe:
Christian Heimes added the comment:
Can you also add a comment to ./Doc/reference/expressions.rst and update
Misc/NEWS please? The rest of the patch is looking good.
--
assignee: - tiran
keywords: +patch
nosy: +tiran
priority: - normal
__
Tracker
Antoine Pitrou added the comment:
I'm not sure this change is necessary. Why don't you catch StandardError
instead of Exception? StandardError catches all Exception subtypes
except GeneratorExit, StopIteration and the various Warnings.
--
nosy: +pitrou
Christian Heimes added the comment:
You make a good point. Can you take it to the mailing list, please?
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1537
__
___
Chad Austin added the comment:
The mailing list discussion continues... in the meantime, I will
update the patch with your suggestions.
Can you describe to me what should change in Doc/reference/
expressions.rst? It makes sense to remove the section in the example
that says you should never
Chad Austin added the comment:
New patch...
Added file: http://bugs.python.org/file8855/GeneratorExit-BaseException-2.patch
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1537
__
GeneratorExit-BaseException-2.patch
New submission from Chad Austin:
Per discussion at http://mail.python.org/pipermail/python-dev/2007-
December/075498.html, this patch changes GeneratorExit's base class
from Exception to BaseException.
I updated the tests and documentation, but I may have missed any other
discussion of
10 matches
Mail list logo