[issue15852] typos in curses argument error messages

2017-12-20 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: It was worth to honor Chris as the author of the patch in the commit message. -- ___ Python tracker

[issue15852] typos in curses argument error messages

2017-12-20 Thread Andrew Svetlov
Change by Andrew Svetlov : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue15852] typos in curses argument error messages

2017-12-20 Thread Roundup Robot
Change by Roundup Robot : -- pull_requests: +4847 ___ Python tracker ___

[issue15852] typos in curses argument error messages

2017-12-20 Thread Roundup Robot
Change by Roundup Robot : -- pull_requests: +4846 ___ Python tracker ___

[issue15852] typos in curses argument error messages

2017-12-20 Thread Srinivas Reddy T
Change by Srinivas Reddy T : -- pull_requests: +4843 ___ Python tracker ___

[issue15852] typos in curses argument error messages

2017-11-01 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Do you mind to create a pull request on GitHub Chris? In general the patch LGTM, but I don't think this minor typo fix needs tests for exact error messages. Adding new tests is good, but I think it is enough to test that

[issue15852] typos in curses argument error messages

2015-01-25 Thread Berker Peksag
Changes by Berker Peksag berker.pek...@gmail.com: -- nosy: +berker.peksag versions: +Python 3.4, Python 3.5 -Python 3.2, Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15852 ___

[issue15852] typos in curses argument error messages

2013-04-18 Thread Phil Connell
Phil Connell added the comment: The patch looks correct and complete, and still patches and passes the tests. So, as far as I can see, this can be committed. -- nosy: +pconnell ___ Python tracker rep...@bugs.python.org

[issue15852] typos in curses argument error messages

2012-09-21 Thread Ezio Melotti
Ezio Melotti added the comment: Can't you use assertRaisesRegex? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15852 ___ ___ Python-bugs-list

[issue15852] typos in curses argument error messages

2012-09-21 Thread Chris Jerdonek
Chris Jerdonek added the comment: Thanks for taking a look at this, and good question. Without restructuring how the tests are done, I believe the short answer is no. The funny thing about this test module is that it does not actually have any unittest test cases. It just calls some

[issue15852] typos in curses argument error messages

2012-09-21 Thread Chris Jerdonek
Chris Jerdonek added the comment: FYI, I created issue 16000 :) to switch test_curses to using unittest.TestCase. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15852 ___

[issue15852] typos in curses argument error messages

2012-09-08 Thread Ezio Melotti
Changes by Ezio Melotti ezio.melo...@gmail.com: -- nosy: +ezio.melotti ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15852 ___ ___

[issue15852] typos in curses argument error messages

2012-09-02 Thread Chris Jerdonek
New submission from Chris Jerdonek: It seems like a couple error messages in the curses module need correcting: PyErr_SetString(PyExc_TypeError, insch requires 1 or 4 arguments); http://hg.python.org/cpython/file/8ff2f4634ed8/Modules/_cursesmodule.c#l1322 PyErr_SetString(PyExc_TypeError,

[issue15852] typos in curses argument error messages

2012-09-02 Thread R. David Murray
R. David Murray added the comment: Given their signatures in the docs, I suspect it is more complicated than that. Perhaps the error messages are even correct. What does the code implement? -- nosy: +r.david.murray ___ Python tracker

[issue15852] typos in curses argument error messages

2012-09-02 Thread Chris Jerdonek
Chris Jerdonek added the comment: I just completed a patch to improve the documentation of these signatures (along with many others) in issue 15831. The correction here is consistent with my findings and revised documentation there. As for the code, they are straightforward switch statements

[issue15852] typos in curses argument error messages

2012-09-02 Thread Chris Jerdonek
Chris Jerdonek added the comment: The situation is the same in 2.7 (and probably 3.2). -- versions: +Python 2.7, Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15852 ___

[issue15852] typos in curses argument error messages

2012-09-02 Thread Chris Jerdonek
Chris Jerdonek added the comment: Attaching a patch with tests and fix for the default branch. -- keywords: +patch Added file: http://bugs.python.org/file27105/issue-15831-1.patch ___ Python tracker rep...@bugs.python.org

[issue15852] typos in curses argument error messages

2012-09-02 Thread Chris Jerdonek
Changes by Chris Jerdonek chris.jerdo...@gmail.com: -- keywords: +needs review stage: test needed - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15852 ___

[issue15852] typos in curses argument error messages

2012-09-02 Thread Chris Jerdonek
Chris Jerdonek added the comment: Uploading correct file. -- Added file: http://bugs.python.org/file27106/issue-15852-1.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15852 ___

[issue15852] typos in curses argument error messages

2012-09-02 Thread Chris Jerdonek
Changes by Chris Jerdonek chris.jerdo...@gmail.com: Removed file: http://bugs.python.org/file27105/issue-15831-1.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15852 ___