[issue16328] win_add2path.py sets wrong user path

Irit Katriel added the comment: I've refreshed the version as neither the patch was applied nor was the bug mentioned in msg239074 fixed so far. -- nosy: +iritkatriel ___ Python tracker

[issue16328] win_add2path.py sets wrong user path

Change by Irit Katriel : -- versions: +Python 3.11 -Python 2.7 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue16328] win_add2path.py sets wrong user path

Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___

[issue16328] win_add2path.py sets wrong user path

Cheryl Sabella added the comment: Any interest in making a PR for this patch? -- nosy: +csabella ___ Python tracker ___

[issue16328] win_add2path.py sets wrong user path

Paul Moore added the comment: One further thought. This is a change in behaviour (albeit to a script in Tools), so I'm inclined to say it's a new feature for 3.5, rather than a bugfix to be backported to 2.7 and 3.4. For users of 2.7/3.4, the workaround is simply to rerun the script - it

[issue16328] win_add2path.py sets wrong user path

Paul Moore added the comment: There's actually a bug in the pre-3.5 script beyond the does the directory exist check. The code is if hasattr(site, USER_SITE): userpath = site.USER_SITE.replace(appdata, %APPDATA%) userscripts = os.path.join(userpath, Scripts) which sets

[issue16328] win_add2path.py sets wrong user path

Steve Dower added the comment: This script adds them to PATH. As I said, the original issue is not a bug, but it has drawn attention to something we apparently missed a while ago. -- ___ Python tracker rep...@bugs.python.org

[issue16328] win_add2path.py sets wrong user path

Paul Moore added the comment: ... because I think it does do that (see http://bugs.python.org/file38085/userscripts.patch which updates this file) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16328

[issue16328] win_add2path.py sets wrong user path

Paul Moore added the comment: One further thought - the installer can't create the user scripts directory if you're doing an all-users install, that's sort of the point of all users. It could do so for a per-user install, but then there would be an inconsistency that I don't think is a good

[issue16328] win_add2path.py sets wrong user path

Steve Dower added the comment: Ah, you're right, it was fixed. Guess I misread my local copy (or I was looking at 3.4). That patch looks good to me. It'll help cover the case where someone does something to create the directory. -- ___ Python

[issue16328] win_add2path.py sets wrong user path

Paul Moore added the comment: Pip and/or setuptools will add the Scripts directory when needed, so it's not a big deal that the installer doesn't create it. In 2.7.9 and later, and 3.4 onwards, the Scripts directory is created as part of the ensurepip step of the install, so it's pretty much

[issue16328] win_add2path.py sets wrong user path

Paul Moore added the comment: I think the problem here is that as the OP mentioned, win_add2path.py doesn't add the directory if it doesn't exist, so if you run it immediately after install, it won't add the directories that don't exist yet. And because it's setting the registry entries to

[issue16328] win_add2path.py sets wrong user path

Paul Moore added the comment: Here is a patch to fix the issue. -- keywords: +patch Added file: http://bugs.python.org/file38659/addpath.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16328

[issue16328] win_add2path.py sets wrong user path

Paul Moore added the comment: Cool. I'll try to set up a test (it's not covered by the testsuite AFAICT) on a VM or something, just to confirm I haven't broken anything. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16328

[issue16328] win_add2path.py sets wrong user path

Paul Moore added the comment: Steve - is it the fact that it's not using the versioned user-site directory that you're referring to? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16328

[issue16328] win_add2path.py sets wrong user path

Steve Dower added the comment: It looks like the script hasn't been updated for the moved user scripts directory (under %APPDATA%), but otherwise this is not a bug and can be closed. -- nosy: +paul.moore ___ Python tracker rep...@bugs.python.org

[issue16328] win_add2path.py sets wrong user path

Mark Lawrence added the comment: Presumably we can look at this after the discussions about the installer scheduled for PyCon 2015? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16328

[issue16328] win_add2path.py sets wrong user path

Mark Lawrence added the comment: Should we create the scripts dir during install? Is it that big a deal? -- nosy: +BreamoreBoy, steve.dower, zach.ware ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16328

[issue16328] win_add2path.py sets wrong user path

New submission from Emil Styrke: OS: Windows 7 Ultimate x64 Python version: 2.7.3 x64 win_add2path.py in the scripts directory is supposed to add the Scripts directory according to its source. However, it tries to add $PYTHONPATH/Scripts, when in fact the Scripts directory is at

[issue16328] win_add2path.py sets wrong user path

Changes by Tim Golden m...@timgolden.me.uk: -- nosy: +christian.heimes ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16328 ___ ___

[issue16328] win_add2path.py sets wrong user path

Tim Golden added the comment: [this response appears to have got lost in an email black hole somewhere] I assume that $PYTHONPATH is actually referring to sys.exec_prefix (and not the PYTHONPATH env var which has nothing to do with this). In any case c:\python27\scripts is still the place for

Re: [issue16328] win_add2path.py sets wrong user path

I assume that $PYTHONPATH is actually referring to sys.exec_prefix (and not the PYTHONPATH env var which has nothing to do with this). In any case c:\python27\scripts is still the place for scripts. There is a c:\python27\tools\scripts (which you're welcome to add to your %PATH% if you find the

[issue16328] win_add2path.py sets wrong user path

Emil Styrke added the comment: Ok, thanks for clearing that up. And yes, I meant the pythonpath variable in the script, which seems to be derived from sys.executable. But in that case, it's unfortunate that the c:\python27\scripts dir is not created during install. I did win_add2path right