[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules

Changes by Martin Panter : -- status: open -> closed ___ Python tracker ___ ___

[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules

Roundup Robot added the comment: New changeset ede10138327e by Martin Panter in branch '2.7': #16484: Change PYTHONDOCS to "https:", and fix links to use lowercase https://hg.python.org/cpython/rev/ede10138327e -- ___ Python tracker

[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules

Martin Panter added the comment: Thanks Kaushik. I also changed the https:// detection to also detect http://, to maintain backwards compatibility. I am porting these changes to 2.7. -- versions: +Python 2.7 ___ Python tracker

[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules

Changes by Berker Peksag : -- type: compile error -> behavior ___ Python tracker ___

[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules

Roundup Robot added the comment: New changeset c60d2e4f4f96 by Martin Panter in branch '2.7': Issue #16484: PYTHONDOCS still uses “http:” in Python 2 https://hg.python.org/cpython/rev/c60d2e4f4f96 -- ___ Python tracker

[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules

Roundup Robot added the comment: New changeset d84268ed62ac by Martin Panter in branch '3.5': Issue #16484: Fix pydoc link and test on Windows, by Kaushik Nadikuditi https://hg.python.org/cpython/rev/d84268ed62ac New changeset 84d1e5a4b1c5 by Martin Panter in branch 'default': Issue #16484:

[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules

Kaushik Nadikuditi added the comment: - fixed broken test - test_mixed_case_module_names_are_lower_cased - tested on Windows, Mac, Ubuntu - thank you Martin Panter for suggestions. -- components: +Tests -Documentation type: -> compile error Added file:

[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules

Martin Panter added the comment: My guess is the file.startswith(basedir) in the getdocloc() method is getting tricked by non-canonical paths (e.g. lowercase vs uppercase C: drive?). Would it help to use something like os.path.normcase(), or maybe os.path.commonpath(), pathlib.PurePath.parts

[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules

Terry J. Reedy added the comment: Those are the only failures on 2 of the 4 buildbots running gui tests. -- nosy: +terry.reedy ___ Python tracker ___

[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules

Martin Panter added the comment: Kaushik or David (or anyone else), does you have an idea of how to fix the Windows tests? It would be good to make the buildbots healthy again, then it is easier to see new failures in Windows. -- priority: normal -> high

[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules

Martin Panter added the comment: It seems the test is broken on Windows: http://buildbot.python.org/all/builders/x86%20Windows7%203.5/builds/915/steps/test/logs/stdio == ERROR: test_mixed_case_module_names_are_lower_cased

[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules

R. David Murray added the comment: Thanks Sean and Kaushik. The final patch didn't apply to 2.7. If someone wants to port the patch I'll apply it, but I'm going to close the issue. -- resolution: -> fixed stage: test needed -> resolved status: open -> closed type: behavior ->

[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules

Roundup Robot added the comment: New changeset 64e7c8531131 by R David Murray in branch '3.5': #16484: Fix pydoc doc links to modules whose names are mixed case. https://hg.python.org/cpython/rev/64e7c8531131 New changeset 912b9aad0b45 by R David Murray in branch 'default': Merge: #16484: Fix

[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules

R. David Murray added the comment: This patch looks good to me. Note that the reason for the basedir change is that the test would fail if run from a build directory which hadn't been installed. An implication of this is that 'doc_loc' is None most of the time when the other tests are run,

[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules

Kaushik N added the comment: Applied patch from sean.rodman. Created a tests. Incorporated comments from rdmurray -- Added file: http://bugs.python.org/file43160/Issue16484_rev_python3.6.patch ___ Python tracker

[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules

Changes by Kaushik N : Removed file: http://bugs.python.org/file43121/Issue16484_python3.6.patch ___ Python tracker ___

[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules

Kaushik N added the comment: Applied patch from sean.rodman. Created a test. -- nosy: +Kaushik N Added file: http://bugs.python.org/file43121/Issue16484_python3.6.patch ___ Python tracker

[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules

Martin Panter added the comment: I don’t think these ones could be so easily fixed, but on my computer “pydoc” references: * library/importlib.machinery.html (ideally should be library/importlib.html#module-importlib.machinery) * library/tkinter.font.html (not in Python documentation at all

[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules

Éric Araujo added the comment: Brett, any opposition to moving the doc about importlib submodules to separate files? -- nosy: +brett.cannon versions: +Python 3.5 -Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16484

[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules

Brett Cannon added the comment: No, I have no objections. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16484 ___ ___ Python-bugs-list mailing

[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules

Changes by Eric Snow ericsnowcurren...@gmail.com: -- nosy: +eric.snow ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16484 ___ ___ Python-bugs-list

[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules

Éric Araujo added the comment: It would be nice to have unit tests for this change. Did you get an email from the review system? If not, follow the “review” link on the right of the list of files on this page. -- ___ Python tracker

[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules

Sean Rodman added the comment: Is there anything else I can do for this? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16484 ___ ___

[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules

Changes by Éric Araujo mer...@netwok.org: -- stage: needs patch - test needed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16484 ___ ___

[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules

Changes by Berker Peksag berker.pek...@gmail.com: -- versions: +Python 3.4 -Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16484 ___ ___

[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules

Sean Rodman added the comment: Here is a working patch for python 2.7. all it does is lowercase the module name, but once I did that and clicked the link it worked correctly. -- keywords: +patch Added file: http://bugs.python.org/file34233/issue16484.patch

[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules

Sean Rodman added the comment: Note: It doesn't change the actual module name. Just how it is represented in the link. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16484 ___

[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules

Sean Rodman added the comment: Here is the patch for python 3.2. It implements the same fix that the 2.7 patch does. -- Added file: http://bugs.python.org/file34234/issue16484_python3.2.patch ___ Python tracker rep...@bugs.python.org

[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules

Changes by Sean Rodman srodman7...@gmail.com: Removed file: http://bugs.python.org/file34234/issue16484_python3.2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16484 ___

[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules

Changes by Sean Rodman srodman7...@gmail.com: Removed file: http://bugs.python.org/file34233/issue16484.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16484 ___

[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules

Sean Rodman added the comment: Sorry guys, I missed a place I needed to add the lower() fuction to the module.__name__. Here is a fixed patch for python2.7. -- Added file: http://bugs.python.org/file34236/issue16484_python2.7.patch ___ Python

[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules

Changes by Sean Rodman srodman7...@gmail.com: Added file: http://bugs.python.org/file34238/issue16484_python3.3.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16484 ___

[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules

Sean Rodman added the comment: Here are the python3.2 and python3.3 patches. Please let me know if there is anything I need to change on these. -- Added file: http://bugs.python.org/file34237/issue16484_python3.2.patch ___ Python tracker

[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules

Marius Gedminas added the comment: Near the top: Help on module xml.etree.ElementTree in xml.etree: NAME xml.etree.ElementTree FILE /usr/lib/python2.7/xml/etree/ElementTree.py MODULE DOCS http://docs.python.org/library/xml.etree.ElementTree DESCRIPTION ... --

[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules

Sean Rodman added the comment: I could try to create the patch for pydoc if you would like for me to. -- nosy: +sean.rodman ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16484 ___

[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules

Sean Rodman added the comment: To display my ignorance, I have run the pydoc command listed in the original message but I can't actually see where it lists the url. Or even where it has a link. -- ___ Python tracker rep...@bugs.python.org

[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules

Georg Brandl added the comment: Adding a redirect should be easy, yes. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16484 ___ ___

[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules

Marius Gedminas added the comment: Considering many existing Python installations out there would it be possible to fix this on the server side? I.e. lowercase the URL while redirecting? -- ___ Python tracker rep...@bugs.python.org

[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules

Éric Araujo added the comment: A patch and test making sure that pydoc generates the right URIs for upper-case modules would help. -- assignee: docs@python - nosy: +eric.araujo -docs@python stage: - needs patch title: Missing/broken documentation redirect for