[issue16958] The sqlite3 context manager does not work with isolation_level=None

Change by Dong-hee Na : -- nosy: +corona10, erlendaasland ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue16958] The sqlite3 context manager does not work with isolation_level=None

Change by STINNER Victor : -- nosy: -vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue16958] The sqlite3 context manager does not work with isolation_level=None

Kodiologist added the comment: This bit me real bad. On Python 3.8, I wrote a program with `isolation_level = None` and `with db: …` and spent a long time figuring out why writes were so slow. Turns out that `with db` doesn't actually start a transaction in this case, as the documentation

[issue16958] The sqlite3 context manager does not work with isolation_level=None

Change by STINNER Victor : -- keywords: -easy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue16958] The sqlite3 context manager does not work with isolation_level=None

Charles added the comment: > With isolation_level set to None, the sqlite3 library is in autocommit mode, > so changes will get committed immediately inside the with, which is simply > broken. Not necessarily. When sqlite is in autocommit mode, you can still open transactions by executing

[issue16958] The sqlite3 context manager does not work with isolation_level=None

STINNER Victor added the comment: This issue is no newcomer friendly, I remove the "easy" keyword. -- nosy: +vstinner ___ Python tracker ___

[issue16958] The sqlite3 context manager does not work with isolation_level=None

Gerhard Häring added the comment: I'm +1 on deprecating the connection manager -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16958 ___ ___

[issue16958] The sqlite3 context manager does not work with isolation_level=None

Changes by Gerhard Häring g...@ghaering.de: -- assignee: - ghaering ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16958 ___ ___ Python-bugs-list

[issue16958] The sqlite3 context manager does not work with isolation_level=None

aaugustin added the comment: * Thesis * I belive that using the connection as a context manager is an inadequate API for controlling transactions because it's very likely to result in subtly broken code. As a consequence, my recommendation would be to deprecate this API. * Argumentation *

[issue16958] The sqlite3 context manager does not work with isolation_level=None

New submission from R. David Murray: Its operation is also not particularly intuitive if isolation_level is not None, so its documentation needs some clarification. Currently the transaction manager does nothing on enter, and does a commit or rollback on exit, depending on whether or not

[issue16958] The sqlite3 context manager does not work with isolation_level=None

Changes by R. David Murray rdmur...@bitdance.com: -- nosy: +nagylzs ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16958 ___ ___ Python-bugs-list

[issue16958] The sqlite3 context manager does not work with isolation_level=None

Martin v. Löwis added the comment: changes will get committed immediately inside the with, which is simply broken What do you mean by that? A. Changes ought to be committed immediately, but are not; it is broken, and changes must be committed immediately. - or - B. What actually happens is

[issue16958] The sqlite3 context manager does not work with isolation_level=None

R. David Murray added the comment: B, yes. So you would view the connection context manager acting as an actual transaction manager as a new feature? Would you be OK with adding that feature to the existing context manager in 3.4 (since currently the context manager is a noop in autocommit