[issue18299] Change script_helper to use universal_newlines=True in _assert_python

Change by hai shi : -- nosy: -shihai1991 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18299] Change script_helper to use universal_newlines=True in _assert_python

Change by STINNER Victor : -- nosy: -vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18299] Change script_helper to use universal_newlines=True in _assert_python

hai shi added the comment: spawn_python in script_helper is good enough, so this bug looks like cloud be closed. -- ___ Python tracker ___

[issue18299] Change script_helper to use universal_newlines=True in _assert_python

Change by hai shi : -- pull_requests: +13781 pull_request: https://github.com/python/cpython/pull/13908 ___ Python tracker ___ ___

[issue18299] Change script_helper to use universal_newlines=True in _assert_python

STINNER Victor added the comment: I dislike script_helper API. I doesn't allow to pass arbitrary keyword parameters to subprocess.Popen. IMHO a new API should be added, but I didn't check if script_helper already contains such API or not. -- ___

[issue18299] Change script_helper to use universal_newlines=True in _assert_python

Change by hai shi : -- keywords: +patch pull_requests: +13724 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/13847 ___ Python tracker

[issue18299] Change script_helper to use universal_newlines=True in _assert_python

hai shi added the comment: >it's a pain to extend the API (I don't want to use yet another __xxx custom >keyword) Adding __xxx in run_python_until_end function would increase the complexity but it looks like a unified function. -- nosy: +shihai1991

[issue18299] Change script_helper to use universal_newlines=True in _assert_python

Change by Manuel Cerón : -- nosy: +ceronman ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18299] Change script_helper to use universal_newlines=True in _assert_python

Pranav Deshpande added the comment: I am afraid I didn't make myself clear. I am a beginner when it comes to open source contribution and have decided to take up this issue. I did some basic research about the issue and found this file: cpython/Lib/test/support/script_helper.py The function

[issue18299] Change script_helper to use universal_newlines=True in _assert_python

Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___

[issue18299] Change script_helper to use universal_newlines=True in _assert_python

STINNER Victor added the comment: > Even if there turn out to be a few uses where having bytes is required, it > would probably be worth catering to the common case and making those > exceptional cases use Popen directly. (Or alternatively provide > assert_python_xxx_binary helpers.) I

[issue18299] Change script_helper to use universal_newlines=True in _assert_python

STINNER Victor added the comment: I really hate script_helper API: keyword arguments are only used to pass environment variables, so the function uses hackish parameteres like __cleanenv=True... I would prefer to pass keywords unchanged to Popen() to be able to use universal_newlines=True

[issue18299] Change script_helper to use universal_newlines=True in _assert_python

Pranav Deshpande added the comment: Hello, I would like to work on this issue. Could you guide me on so as how to proceed with this? -- nosy: +Pranav Deshpande ___ Python tracker

[issue18299] Change script_helper to use universal_newlines=True in _assert_python

Mark Lawrence added the comment: Just a gentle reminder guys. -- nosy: +BreamoreBoy versions: +Python 3.5 -Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18299 ___

[issue18299] Change script_helper to use universal_newlines=True in _assert_python

New submission from R. David Murray: A look at a random selection of tests that use script_helper indicates that using universal_newlines=True would either simplify or make no difference to the usage of the script_helper assert_python functions in the majority of the tests that use it. Even

[issue18299] Change script_helper to use universal_newlines=True in _assert_python

Changes by Barry A. Warsaw ba...@python.org: -- nosy: +barry ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18299 ___ ___ Python-bugs-list mailing