[issue18307] Relative path in co_filename for zipped modules

Change by Brett Cannon : -- nosy: -brett.cannon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18307] Relative path in co_filename for zipped modules

Serhiy Storchaka added the comment: zipimport has been rewritten in pure Python (issue25711). -- ___ Python tracker ___ ___

[issue18307] Relative path in co_filename for zipped modules

Brett Cannon added the comment: So it sounds like that maybe we need to decide if we are going to replace zipimport with Serhiy's Python version. And if we do decide to go with the Python code then it should get updated to use _imp._fix_co_filename(). Regardless of the decision, obviously

[issue18307] Relative path in co_filename for zipped modules

Nick Coghlan added the comment: Serhiy's analysis sounds right to me - for precompiled bytecode files, we really want co_filename to reflect the import time filename *not* the compile time filename. While zipimport is one way to get the compile time and import time paths to differ, there

[issue18307] Relative path in co_filename for zipped modules

Serhiy Storchaka added the comment: The patch for the Python implementation of zipimport (see issue25711) is much simpler (see the attached sample patch). But it requires adding a way of modifying co_filename. Currently code objects are immutable. This issue looks as a part of the larger

[issue18307] Relative path in co_filename for zipped modules

Brett Cannon added the comment: This will be a semantic change to the value of co_filename so I don't think this can safely be backported. -- versions: -Python 2.7, Python 3.7 ___ Python tracker

[issue18307] Relative path in co_filename for zipped modules

Change by Brett Cannon : -- nosy: +twouters ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18307] Relative path in co_filename for zipped modules

Vitaly Murashev added the comment: > Only a PR for master is needed. Serhiy Storchaka, thanks for advice, I cancelled unnecessary PRs. -- ___ Python tracker

[issue18307] Relative path in co_filename for zipped modules

Serhiy Storchaka added the comment: Only a PR for master is needed. Changes to other branches will be ported after reviewing and merging the PR for master. -- ___ Python tracker

[issue18307] Relative path in co_filename for zipped modules

Vitaly Murashev added the comment: Pull-requests for 2.7, 3.7 and master submitted on github, all tests look passed, so Python dev-team, please, take a look. -- ___ Python tracker

[issue18307] Relative path in co_filename for zipped modules

Change by Vitaly Murashev : -- versions: +Python 2.7, Python 3.7, Python 3.8 -Python 3.3, Python 3.4 ___ Python tracker ___

[issue18307] Relative path in co_filename for zipped modules

Vitaly Murashev added the comment: > Vitaly, in the future please use gender-neutral words Mariatta, OK, got it, I am sorry for that. I am not a native speaker. -- ___ Python tracker

[issue18307] Relative path in co_filename for zipped modules

Change by Roundup Robot : -- pull_requests: +6774 ___ Python tracker ___

[issue18307] Relative path in co_filename for zipped modules

Change by Roundup Robot : -- pull_requests: +6773 ___ Python tracker ___

[issue18307] Relative path in co_filename for zipped modules

Change by Roundup Robot : -- pull_requests: +6772 stage: test needed -> patch review ___ Python tracker ___

[issue18307] Relative path in co_filename for zipped modules

Mariatta Wijaya added the comment: Vitaly, in the future please use gender-neutral words such as "folks" and "y'all" instead of "guys". Thanks. -- nosy: +Mariatta ___ Python tracker

[issue18307] Relative path in co_filename for zipped modules

Serhiy Storchaka added the comment: In year 2018 you have to create a pull request on GitHub. See https://devguide.python.org/. -- nosy: +serhiy.storchaka ___ Python tracker

[issue18307] Relative path in co_filename for zipped modules

Vitaly Murashev added the comment: Guys, a couple questions ... I want to suggest new patches for python3.7 and python2.7 with regression tests included What is proper way to do it now, in year 2018 ? May I do it on github.com ? Should I submit new issue for that there

[issue18307] Relative path in co_filename for zipped modules

Vitaly Murashev added the comment: patch suggested (over 3.3.0 code base). Without patch test fails, with patch - passed -- components: -Library (Lib) keywords: +patch Added file: http://bugs.python.org/file31781/zipimport.diff ___ Python tracker

[issue18307] Relative path in co_filename for zipped modules

Changes by Nick Coghlan ncogh...@gmail.com: -- nosy: +ncoghlan ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18307 ___ ___ Python-bugs-list

[issue18307] Relative path in co_filename for zipped modules

Vitaly Murashev added the comment: unit-test attached. There are 3 tests inside it: 2 failed, 1 succeeded. According to this test results it becomes clear that specified issue is reproduced only with zip modules which contain precompiled bytecode inside (pyc-files) -- Added file:

[issue18307] Relative path in co_filename for zipped modules

New submission from Vitaly Murashev: Recently I found out that it not possible to debug python code if it is a part of zip-module. Python version being used is 3.3.0 Well known GUI debuggers like Eclipse+PyDev or PyCharm are unable to start debugging and give the following warning: --- pydev

[issue18307] Relative path in co_filename for zipped modules

Changes by Christian Heimes li...@cheimes.de: -- nosy: +brett.cannon, christian.heimes stage: - test needed versions: +Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18307 ___