[issue18576] Document test.support.script_helper

Julien Palard added the comment: All those functions has already been documented. -- dependencies: -Make test.script_helper more comprehensive, and use it in the test suite nosy: +mdk resolution: -> out of date stage: patch review -> resolved status: open -> closed

[issue18576] Document test.support.script_helper

Louie Lu added the comment: The PR on GitHub is based on bobcatfist's patch, addressed on Martin request and some minor change. -- nosy: +louielu ___ Python tracker

[issue18576] Document test.support.script_helper

Changes by Louie Lu : -- pull_requests: +1367 ___ Python tracker ___ ___ Python-bugs-list

[issue18576] Document test.support.script_helper

Martin Panter added the comment: I left some more comments on Reitveld. The main one is I think stderr gets stripped with assert_python_ok(), but I don’t think stdout is touched. Correct me if I’m wrong though. -- ___ Python tracker

[issue18576] Document test.support.script_helper

Changes by Nick Coghlan ncogh...@gmail.com: -- assignee: ncoghlan - ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18576 ___ ___ Python-bugs-list

[issue18576] Document test.support.script_helper

Christie added the comment: Hey @vadmium! I've finally responded to your review feedback. I've attached a new patch, hopefully this time actually review-able. I've removed the docs for methods I added in @24033 so that this could be merged without it. Let me know if you have any more

[issue18576] Document test.support.script_helper

Christie added the comment: If you diffed your patch from a public revision in the main repository, there should be a nice “Review” link. Ah, thanks @vadmium!!! I've been confused about why some patches get review links and others do not . I'll have a new patch up shortly which is diffed

[issue18576] Document test.support.script_helper

Christie added the comment: @ncoghlan I've taken the test.rst changes from the previous diff and reviewed them against the latest script_helper (including updates from issue24033). Nothing had fallen behind, but I've added what was missing. * I've realized that spawn_python and the helper

[issue18576] Document test.support.script_helper

Martin Panter added the comment: If you diffed your patch from a public revision in the main repository, there should be a nice “Review” link. Anyway, here are some comments on issue18576.patch: +.. function:: assert_python_ok(*args, **env_vars) + + Runs the interpreter with *args* and

[issue18576] Document test.support.script_helper

Nick Coghlan added the comment: As far as using docstrings for the online docs goes, there are some useful Sphinx add-ons that we've never enabled for the main Python docs (like autodoc, blockdiag, seqdiag) that could be good options to have available. For autodoc in particular, we prefer to

[issue18576] Document test.support.script_helper

Christie added the comment: I'm going to take a look at bringing these docs up to date and including the changes from issue24033. -- nosy: +bobcatfish ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18576

[issue18576] Document test.support.script_helper

Nick Coghlan added the comment: script_helper was moved to the test.support package in issue 9517, so this issue is just about adding the docs now. -- dependencies: +Make test.script_helper more comprehensive, and use it in the test suite -Refactor the test_runpy walk_package support

[issue18576] Document test.support.script_helper

Nick Coghlan added the comment: Also noting that my draft docs are over a year old now, so they need to be reviewed against the current state of the helper module. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18576