Changes by Jakub Wilk jw...@jwilk.net:
--
nosy: +jwilk
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18603
___
___
Python-bugs-list mailing list
Georg Brandl added the comment:
Well, if the functions are part of the stable ABI (which it seems they are, as
they don't fall under some exclusion defined by PEP 384) they shouldn't be
removed if we take PEP 384 seriously.
--
nosy: +loewis
___
Martin v. Löwis added the comment:
The patch looks good to me. The stable ABI was originally intended for Windows
only, where the functions are guaranteed to be included in python3.dll (as the
.def file references them); they are included in python3X.dll as link.exe
doesn't do the same object
Roundup Robot added the comment:
New changeset 4c4f31a1b706 by Christian Heimes in branch '3.3':
Issue #18603: Ensure that PyOS_mystricmp and PyOS_mystrnicmp are in the
http://hg.python.org/cpython/rev/4c4f31a1b706
New changeset b5cc822d5bf0 by Christian Heimes in branch 'default':
Issue
Christian Heimes added the comment:
Thanks for your input. I have applied the patch to 2.7, 3.3 and 3.4. A couple
of 3rd party were bitten by the missing symbols. A Google search reveals a
couple of them https://www.google.de/search?q=PyOS_mystricmp+missing
--
resolution: - fixed
Changes by Christian Heimes li...@cheimes.de:
--
stage: patch review - committed/rejected
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18603
___
Benjamin Peterson added the comment:
Someone would have to be trying fairly hard to use those functions on Windows
because this is in the header:
#ifdef MS_WINDOWS
#define PyOS_strnicmp strnicmp
#define PyOS_stricmp stricmp
#else
#define PyOS_strnicmp PyOS_mystrnicmp
#define PyOS_stricmp
Christian Heimes added the comment:
ping RMs
--
nosy: +benjamin.peterson, georg.brandl, larry
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18603
___
Benjamin Peterson added the comment:
Uggg, can we just kill them if we've already released versions without them?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18603
___
STINNER Victor added the comment:
The function doesn't hurt, please don't touch stable versions: only remove it
from 3.4. I don't understand the tag keywords: 3.3regression. Is this issue a
bug, or even a compile error??
--
nosy: +haypo
___
Python
Christian Heimes added the comment:
Fine with me, however ...
Technically all our source releases still contain the code. AFAIK all shared
library builds, too. Just standard builds of Python are lacking the object file.
--
___
Python tracker
Christian Heimes added the comment:
Here is a simple patch based on the approach in Objects/object.c
--
components: +Interpreter Core
keywords: +patch
stage: - patch review
Added file: http://bugs.python.org/file31357/18603.patch
___
Python tracker
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18603
___
New submission from Christian Heimes:
The two functions PyOS_strnicmp() and PyOS_stricmp() from Python/pystrcmp.c are
no longer used by any function in the core. Because no module references any
object from Python/pystrcmp.c the object file is not included in the Python
binary:
$ nm -P
14 matches
Mail list logo
