[issue18792] test_ftplib timeouts

2017-02-23 Thread Gregory P. Smith
Gregory P. Smith added the comment: https://bugs.python.org/issue29639 opened to track undoing this when appropriate. -- ___ Python tracker ___

[issue18792] test_ftplib timeouts

2017-02-23 Thread Gregory P. Smith
Gregory P. Smith added the comment: FYI - hardcoding these addresses is now causing me problems as I try to get our test suite passing on IPv6 only hosts. "localhost" is correct. IMNSHO if for some reason a system cannot resolve "localhost" into a correct address, it should be banned from

[issue18792] test_ftplib timeouts

2013-08-21 Thread Charles-François Natali
Charles-François Natali added the comment: Some ftplib tests sometimes time out. Seem they seem to try to connect to localhost (rather than 127.0.0.1), I was wondering if this could be a DNS issue and if we should resolve localhost in advance like Charles-François did for some other tests

[issue18792] test_ftplib timeouts

2013-08-21 Thread Antoine Pitrou
Antoine Pitrou added the comment: Hard-cording 127.0.0.1 for this test should be OK, because the server setup explicitly binds an AF_INET socket. We'll probably have to check the rest of the test suite for similar issues. Ok, let's do it! -- keywords: +easy

[issue18792] test_ftplib timeouts

2013-08-21 Thread Antoine Pitrou
Antoine Pitrou added the comment: Here is a patch for default. -- keywords: +patch Added file: http://bugs.python.org/file31395/support_host.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18792

[issue18792] test_ftplib timeouts

2013-08-21 Thread Charles-François Natali
Charles-François Natali added the comment: Changing support.HOST from 'localhost' to '127.0.0.1' means that on dual-stack hosts (I don't think the test suite would run on IPv6-only hosts anyway), the tests will now always use IPv4, whereas they are currently using either IPv6 or IPv4 addresses

[issue18792] test_ftplib timeouts

2013-08-21 Thread Antoine Pitrou
Antoine Pitrou added the comment: Changing support.HOST from 'localhost' to '127.0.0.1' means that on dual-stack hosts (I don't think the test suite would run on IPv6-only hosts anyway), the tests will now always use IPv4, whereas they are currently using either IPv6 or IPv4 addresses

[issue18792] test_ftplib timeouts

2013-08-21 Thread Charles-François Natali
Charles-François Natali added the comment: That would only be true if the server we are contacting happens to listen on both IPv6 and IPv4, right? I don't think we have such a situation in the test suite. Ah, I thought some code was using getaddrinfo() to select an arbitrary bind() address

[issue18792] test_ftplib timeouts

2013-08-21 Thread Charles-François Natali
Charles-François Natali added the comment: LGTM -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18792 ___ ___ Python-bugs-list mailing list

[issue18792] test_ftplib timeouts

2013-08-21 Thread Roundup Robot
Roundup Robot added the comment: New changeset 085ba7d85eb2 by Antoine Pitrou in branch 'default': Issue #18792: Use 127.0.0.1 or ::1 instead of localhost as much as possible, since localhost goes through a DNS lookup under recent Windows versions. http://hg.python.org/cpython/rev/085ba7d85eb2

[issue18792] test_ftplib timeouts

2013-08-21 Thread Roundup Robot
Roundup Robot added the comment: New changeset 7728b073c77c by Antoine Pitrou in branch '3.3': Issue #18792: Use 127.0.0.1 or ::1 instead of localhost as much as possible, since localhost goes through a DNS lookup under recent Windows versions. http://hg.python.org/cpython/rev/7728b073c77c

[issue18792] test_ftplib timeouts

2013-08-21 Thread Roundup Robot
Roundup Robot added the comment: New changeset 48de8df194d9 by Antoine Pitrou in branch '2.7': Issue #18792: Use 127.0.0.1 or ::1 instead of localhost as much as possible, since localhost goes through a DNS lookup under recent Windows versions. http://hg.python.org/cpython/rev/48de8df194d9

[issue18792] test_ftplib timeouts

2013-08-21 Thread Antoine Pitrou
Antoine Pitrou added the comment: Done, thanks :) -- resolution: - fixed stage: needs patch - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18792

[issue18792] test_ftplib timeouts

2013-08-20 Thread Antoine Pitrou
New submission from Antoine Pitrou: Some ftplib tests sometimes time out. Seem they seem to try to connect to localhost (rather than 127.0.0.1), I was wondering if this could be a DNS issue and if we should resolve localhost in advance like Charles-François did for some other tests (or simply